[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a reviewer: ychen. ChuanqiXu added a comment. @jyknight @nikic @rjmccall @efriedma @nhaehnle gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 ___ cfe-commits mailing list

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650412 , @3405691582 wrote: > Tested change on OpenBSD resolves downstream issues. What issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } shchenz wrote: > Can we use `path::parent_path(P)` directly in `addSystemInclude()`? > `remove_fil

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

3405691582 added a comment. In D129654#3650534 , @brad wrote: > In D129654#3650412 , @3405691582 > wrote: > >> Tested change on OpenBSD resolves downstream issues. > > What issues? As mentioned, this replicates

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

NoQ added a comment. In D129498#3647348 , @ASDenysPetrov wrote: > In D129498#3644222 , @NoQ wrote: > >> Maybe `clang_analyzer_range()` instead? > > This was its first name. I refused. First, because it emits conc

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

glandium added a comment. From the commit message: > This patch adds deprecation warnings for the usage of those builtins, except > for __has_trivial_destructor which doesn't have a GCC alternative. This doesn't seem to be true, FWIW. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Why was this reverted? Please make extensive tests especially for something dealing with the build system. When reverting a commit, briefly describe what happened. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson added a comment. In D129170#3650618 , @glandium wrote: > From the commit message: > >> This patch adds deprecation warnings for the usage of those builtins, except >> for __has_trivial_destructor which doesn't have a GCC alternative. > > The

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. @iains @rsmith @MaskRay gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

sameerds added a comment. The current set of reviewers is mostly loaded with HIP engineers who are familiar with the issue and the proposed solution. But this solution affects all languages with convergent functions, which is visible from the affected tests. It will be good to seek comments fro

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. FWIW, this change also broke this check in Firefox's clang plugin: https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Wasn't there a discussion about this before, or some other patch? If so, could we please link such things (e.g., in the commit message) so people don't have to remember and fin

[clang] 6882ca9 - [Clang] Adjust extension warnings for delimited sequences

Author: Corentin Jabot Date: 2022-07-14T07:50:58+02:00 New Revision: 6882ca9aff076738bbffd68f73892187519554f8 URL: https://github.com/llvm/llvm-project/commit/6882ca9aff076738bbffd68f73892187519554f8 DIFF: https://github.com/llvm/llvm-project/commit/6882ca9aff076738bbffd68f73892187519554f8.diff

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

This revision was automatically updated to reflect the committed changes. Closed by commit rG6882ca9aff07: [Clang] Adjust extension warnings for delimited sequences (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ ht

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud updated this revision to Diff 444527. t-rasmud added a reviewer: ziqingluo-90. t-rasmud added a comment. Addresses review comments from the previously uploaded diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 Files: clang-tools

[clang] cb2c8f6 - [clang] Use value instead of getValue (NFC)

Author: Kazu Hirata Date: 2022-07-13T23:39:33-07:00 New Revision: cb2c8f694db15c488f46de6db5a7db444a189fc4 URL: https://github.com/llvm/llvm-project/commit/cb2c8f694db15c488f46de6db5a7db444a189fc4 DIFF: https://github.com/llvm/llvm-project/commit/cb2c8f694db15c488f46de6db5a7db444a189fc4.diff L

[PATCH] D127812: [AArch64] Function multiversioning support added.

echristo added a comment. In D127812#3616603 , @danielkiss wrote: > In D127812#3602688 , @aaron.ballman > wrote: > >> In D127812#3602645 , @erichkeane >> wrote: >> >>>

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

iains added a comment. Hi @ChuanqiXu, I have no comment on the technical content of the patch (it looks reasonable to me). However, I wonder if we should be supplying this option at all because in: https://eel.is/c++draft/module#reach-2 note2 says "[Note 2: It is advisable to avoid depending on

<    1   2   3