[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdc6974f9230: [clang] Implement ElaboratedType sugaring for types

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim updated this revision to Diff 444115. hctim added a comment. Update ASan and HWASan tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/ https://reviews.llvm.org/D129492 Files: clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. In D128059#3646695 , @JDevlieghere wrote: > I had to revert this because it breaks a bunch of LLDB tests: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45288/#showFailuresLink. > It looks like this causes an erro

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 444118. cor3ntin added a comment. This turned out to be an interesting bug. The SSE code tried to be clever and skip over valid ascii code units when finding invalid UTF-8. In doing so, it could run over the end of a comment entirely if - there was a short

[PATCH] D129607: [clang][deps] Fix handling of -MT in module command-line

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a subscriber: mgorny. Herald added a project: All. benlangmuir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Follow-up to 6626f6fec3d3

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() cassanova wrote: > mib

[clang] fcbb4e1 - [NFCI] Fix unused variable warning with asserts off in clang/lib/Sema/TypeLocBuilder.cpp

Author: Jorge Gorbe Moya Date: 2022-07-12T17:40:41-07:00 New Revision: fcbb4e1fa42793edc9531d59d047e6bd0909d3d3 URL: https://github.com/llvm/llvm-project/commit/fcbb4e1fa42793edc9531d59d047e6bd0909d3d3 DIFF: https://github.com/llvm/llvm-project/commit/fcbb4e1fa42793edc9531d59d047e6bd0909d3d3.di

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

shafik added a comment. Herald added a reviewer: NoQ. Thank you for this work. This looks mostly good to me but I am not confident on all the code. I feel like there are some assumptions that maybe could use comments e.g. places where we know it can only be a `VarDecl` e.g. b/c it is an init ca

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

JDevlieghere added a comment. In D128059#3646953 , @cor3ntin wrote: > In D128059#3646695 , @JDevlieghere > wrote: > >> I had to revert this because it breaks a bunch of LLDB tests: >> https://green.lab.llvm.org/

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626 // Compute the hash of the method as if it has no body. -auto ComputeCXXMethodODRHash = [&Hash](const CXXMethodDecl *D) { - Hash.clear(); - Hash.AddFunc

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. I think even with the readnone -> readonly change this patch should be fine, but let me run some internal benchmarks on this patch the func-attrs change can come later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/n

[PATCH] D119296: KCFI sanitizer

MaskRay added a comment. Mostly looks good. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2296 + // functions, which means it's safe to skip unusual names. Subset of + // MCAsmInfo::isAcceptableChar() and MCAsmInfoXCOFF::isAcceptableChar(). + for (const char &C : Name) { -

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:42 +// CHECK: @double_keep_thunk2() [[EXTERN]] +[[gnu::function_return("thunk-keep")]][[gnu::function_return("thunk-extern")]] +void double_keep_thunk2(void) {} I just no

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 444147. daiyousei-qz added a comment. fix line end to LF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 444150. daiyousei-qz added a comment. Herald added subscribers: Sanitizers, Enna1. Herald added a project: Sanitizers. fix patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://re

[clang-tools-extra] 53daa17 - [clang, clang-tools-extra] Use has_value instead of hasValue (NFC)

Author: Kazu Hirata Date: 2022-07-12T22:47:41-07:00 New Revision: 53daa177f86b3abbc21222d8093fc2ac0aa62035 URL: https://github.com/llvm/llvm-project/commit/53daa177f86b3abbc21222d8093fc2ac0aa62035 DIFF: https://github.com/llvm/llvm-project/commit/53daa177f86b3abbc21222d8093fc2ac0aa62035.diff L

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 444151. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/u

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov added a comment. In D129498#3644222 , @NoQ wrote: > Looks great! > > Maybe `clang_analyzer_range()` instead? This was its first name. I refused. First, because it emits concrete integers as well and moreover we can extend it for arrays or

<    1   2   3