[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443337. serge-sans-paille added a comment. ++review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/t

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Confirm that #56445 is fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129383/new/ https://reviews.llvm.org/D129383 ___

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this is now diagnosed as an error. +- Clang now correctly emit symbols for implicitly instanciated constexpr + template function. Fixes `Issue 55560

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3213 +static bool EquivalentArrayTypes(QualType Old, QualType New, + ASTContext const &Ctx) { + aaron.ballman wrote: > East const? MONSTEROUS! ;-) (We

[PATCH] D128449: [clang] Introduce -Warray-parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc5b77273af3: [clang] Introduce -Warray-parameter (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D128449?vs=44

[clang] cc5b772 - [clang] Introduce -Warray-parameter

Author: serge-sans-paille Date: 2022-07-08T22:36:05+02:00 New Revision: cc5b77273af3705b6f5cf574567b49d5158bb3a9 URL: https://github.com/llvm/llvm-project/commit/cc5b77273af3705b6f5cf574567b49d5158bb3a9 DIFF: https://github.com/llvm/llvm-project/commit/cc5b77273af3705b6f5cf574567b49d5158bb3a9.d

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443342. ldionne added a comment. Rebase onto main and remove references to -funstable since the design is still changing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128

[clang-tools-extra] 474c873 - Revert "[llvm] cmake config groundwork to have ZSTD in LLVM"

Author: Leonard Chan Date: 2022-07-08T13:48:05-07:00 New Revision: 474c873148b1441f1dd7a2b269441a1b20e30aa2 URL: https://github.com/llvm/llvm-project/commit/474c873148b1441f1dd7a2b269441a1b20e30aa2 DIFF: https://github.com/llvm/llvm-project/commit/474c873148b1441f1dd7a2b269441a1b20e30aa2.diff

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ldionne added inline comments. Comment at: llvm/CMakeLists.txt:441 +set(LLVM_ENABLE_ZSTD "ON" CACHE STRING "Use zstd for compression/decompression if available. Can be ON, OFF, or FORCE_ON") + This broke builds that do not specify `LLVM_ENABLE_ZSTD=OFF` explic

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

shafik accepted this revision. shafik added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] bb93993 - [libc++] Always build c++experimental.a

Author: Louis Dionne Date: 2022-07-08T16:58:22-04:00 New Revision: bb939931a1adb9a47a2de13c359d6a72aeb277c8 URL: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8 DIFF: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8.diff

[PATCH] D128927: [libc++] Always build c++experimental.a

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb939931a1ad: [libc++] Always build c++experimental.a (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] b069801 - [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

Author: Martin Storsjö Date: 2022-07-09T00:11:45+03:00 New Revision: b069801ffb6d11143c2b611a220827120113c7a1 URL: https://github.com/llvm/llvm-project/commit/b069801ffb6d11143c2b611a220827120113c7a1 DIFF: https://github.com/llvm/llvm-project/commit/b069801ffb6d11143c2b611a220827120113c7a1.diff

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb069801ffb6d: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D129398: Adding a new ASTMatcher for callee declarations of Obj-C message expressions

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, njames93, aaron.ballman, klimek, t-rasmud, usama54321, LegalizeAdulthood. ziqingluo-90 added a project: clang. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129393/new/ https://reviews.llvm.org/D129393 ___

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3635861 , @njames93 wrote: > Sorry to do this again, but could this be split up again, one patch for the > new matcher and the tests associated with it, then another for the actual bug > fix. > Also cc @klimek as

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36b96afb224: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] d36b96a - [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

Author: Joseph Huber Date: 2022-07-08T17:22:35-04:00 New Revision: d36b96afb2245d791eaf9d9b1b1adfa52df1e498 URL: https://github.com/llvm/llvm-project/commit/d36b96afb2245d791eaf9d9b1b1adfa52df1e498 DIFF: https://github.com/llvm/llvm-project/commit/d36b96afb2245d791eaf9d9b1b1adfa52df1e498.diff

[clang] 24849c9 - [Clang] Fix the wrong features being derivec in the offload packager

Author: Joseph Huber Date: 2022-07-08T17:26:20-04:00 New Revision: 24849c9eb504cad5b17f16ed23a88dab92882d5d URL: https://github.com/llvm/llvm-project/commit/24849c9eb504cad5b17f16ed23a88dab92882d5d DIFF: https://github.com/llvm/llvm-project/commit/24849c9eb504cad5b17f16ed23a88dab92882d5d.diff

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

This revision was automatically updated to reflect the committed changes. Closed by commit rG24849c9eb504: [Clang] Fix the wrong features being derivec in the offload packager (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12939

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443362. cassanova edited the summary of this revision. cassanova added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building the expression evaluator fuzzer is now conditional on the CLANG_ENABLE_PROTO_FUZZER CMake varia

[clang] df90d22 - [CMake] Option to select C++ library for runtimes that use it

Author: Petr Hosek Date: 2022-07-08T22:10:24Z New Revision: df90d22704d8743746fa00bc6d67e2789ca9ee9e URL: https://github.com/llvm/llvm-project/commit/df90d22704d8743746fa00bc6d67e2789ca9ee9e DIFF: https://github.com/llvm/llvm-project/commit/df90d22704d8743746fa00bc6d67e2789ca9ee9e.diff LOG: [C

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90d22704d8: [CMake] Option to select C++ library for runtimes that use it (authored by phosek). Changed prior to commit: https://reviews.llvm.or

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ This needs a change in lld/test/CMakeLists.txt Looks like you haven't

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > This needs a change in lld/test/CMakeLists.txt > > L

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: probinson, wristow. Herald added a project: All. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

shafik added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:894 bool useObjCFPRetForRealType(FloatModeKind T) const { -return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T); +return (int)((FloatModeKind)RealTypeUsesObjCFPRetMask

[clang] bd8b55e - [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

Author: Hubert Tong Date: 2022-07-08T18:33:16-04:00 New Revision: bd8b55e609c825f1063a28ef94502a6bfed7a0fd URL: https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd DIFF: https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd.diff L

[PATCH] D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8b55e609c8: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12916

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions. Otherwise the change just introduces some CMake var

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir updated this revision to Diff 443379. benlangmuir added a comment. Updates: - Made lookup of module outputs fallible. Not currently used by clang-scan-deps, but since the expectation is for a build system to provide these settings account for possibility of errors. - Attempt to fix

[PATCH] D128950: Add 'sanitize_memtag' Global IR attribute

hctim updated this revision to Diff 443390. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. After talking with Evgenii offline, and testing, clearly we don't need an exclude mask. Update the patch to remove the exclude mask, and repl

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3639735 , @jdoerfert wrote: > F23722893: ast_dump_2_check.py >>! In > D102107#3639615 , @dhruvachak wrote: > >> In D102107#3639556

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test fail

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

jdoerfert added a comment. In D129008#3640194 , @tianshilei1992 wrote: > `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Don't we generate copies of things elsewhere already? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test failur

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 443399. dhruvachak added a comment. Herald added a subscriber: hiraditya. Fixed opaque pointer miscompile. Added alloc_aggregate_arg entry point to OpenMPOpt SPMD list. Fixed nocapture attribute of __kmpc_alloc_aggregate_arg, Added align attribute for call

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3640232 , @jdoerfert wrote: > In D102107#3640198 , @dhruvachak > wrote: > >> Thanks. I followed the above steps and regenerated a couple of the AST tests >> but they still

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:4263 case OMPRTL___kmpc_nvptx_end_reduce_nowait: +case OMPRTL___kmpc_alloc_aggregate_arg: break; @jdoerfert Is this enough to enable SPMDization or is further hand

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:4263 case OMPRTL___kmpc_nvptx_end_reduce_nowait: +case OMPRTL___kmpc_alloc_aggregate_arg: break; dhruvachak wrote: > @jdoerfert Is this enough to enable SPMDizatio

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

vsapsai added a comment. Thanks for the changes, they look good! While I was looking how we handle "requires" constraints in other cases, I've noticed that they are suspiciously similar. That's why I offer the following change to unify comparison of the constraint expressions diff --git a/cl

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 443403. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files: clang/lib/Serialization/ASTReader.cpp Index: clang/lib/Serializatio

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Results from "make check-clang": Failed Tests (14): Clang :: AST/ast-dump-openmp-distribute-parallel-for-simd.c Clang :: AST/ast-dump-openmp-distribute-parallel-for.c Clang :: AST/ast-dump-openmp-target-teams-distribute-parallel-for-simd.c Clang :: AST/ast-dum

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. make check-openmp passes on amdgpu. Need to check on nvptx. Testing Time: 39.95s Unsupported : 143 Passed : 563 Expectedly Failed: 14 [100%] Built target check-openmp [100%] Built target check-openmp Repository: rG LLVM Github Monorepo CHAN

[clang-tools-extra] b1fbc05 - [clangd] Support "usedAsMutableReference" in member initializations

Author: Christian Kandeler Date: 2022-07-08T23:16:20-04:00 New Revision: b1fbc0519c5224de44b2711f8a813b24d767dd3e URL: https://github.com/llvm/llvm-project/commit/b1fbc0519c5224de44b2711f8a813b24d767dd3e DIFF: https://github.com/llvm/llvm-project/commit/b1fbc0519c5224de44b2711f8a813b24d767dd3e.

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fbc0519c52: [clangd] Support "usedAsMutableReference" in member initializations (authored by ckandeler, committed by nridge). Repository: rG LL

[clang] 615f838 - [clang-format] Fix an assertion failure on -lines=0:n

Author: owenca Date: 2022-07-08T23:41:16-07:00 New Revision: 615f838f7380e6a4f3df8e16f04dea3c8eed656c URL: https://github.com/llvm/llvm-project/commit/615f838f7380e6a4f3df8e16f04dea3c8eed656c DIFF: https://github.com/llvm/llvm-project/commit/615f838f7380e6a4f3df8e16f04dea3c8eed656c.diff LOG: [

[PATCH] D129348: [clang-format] Fix an assertion failure on -lines=0:n

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG615f838f7380: [clang-format] Fix an assertion failure on -lines=0:n (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 updated this revision to Diff 443417. njames93 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129202/new/ https://reviews.llvm.org/D129202 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/D

<    1   2