[PATCH] D129258: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functionalities of the clang-offload-bundler into a user-facing li

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. I feel obliged to point out that the sheer number of updates is too large. Every update triggers an email to all reviewers and subscribers, so please be mindful. Personally I don't mind how many updates I receive, but others may do. It's usually not too bad to have too m

[clang] 14c30c7 - [clang-format] Avoid crash in LevelIndentTracker.

Author: Marek Kurdej Date: 2022-07-07T10:15:45+02:00 New Revision: 14c30c70c4595d8f410c74a72357a5a31fdd5507 URL: https://github.com/llvm/llvm-project/commit/14c30c70c4595d8f410c74a72357a5a31fdd5507 DIFF: https://github.com/llvm/llvm-project/commit/14c30c70c4595d8f410c74a72357a5a31fdd5507.diff

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c30c70c459: [clang-format] Avoid crash in LevelIndentTracker. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129064/new/ https://re

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442824. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + erichkea

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442825. wyt marked 3 inline comments as done. wyt added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis/FlowSen

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#3634073 , @jdoerfert wrote: > cleanup/destructor test missing. > > @ABataev WDYT? Looks good in general, extra tests would be good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. First of all, I am really sorry about the noise and the misbehavior here. I have to admit that some of the changes here are because I am still in the way of getting familiar with the patch system. I apologize for being careless in the progress. > I don't know ho

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442828. wyt added a comment. Make scope resolution consistent (Solver:: instead of WatchedLiteralsSolver::). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clan

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:266 + /// - `Unsatisfiable`: A satisfying assignment does not exist. + /// - `

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:78 +Status Status; +std::optional> Solution; }; `#include "llvm/ADT/DenseMap.h"` Comment at: clang/lib/Analy

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442840. wyt marked 3 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers created this revision. vabridgers added reviewers: martong, steakhal. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. va

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442845. wyt added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 442844. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take review into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/Releas

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:67 +/// boolean formula if available. Otherwise, an empty optional is returned. +std::optional> +getSolution() const { Please use llvm::Optional, we can'

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442848. wyt added a comment. Replace std::optional with llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis/FlowSensitive

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 442849. iains marked 25 inline comments as done. iains added a comment. rebased, addressed review comments, added another test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https://reviews.llvm.org/D

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned out to be much more involved than I imagined from the standard's text. In D126694#3629254 , @ChuanqiXu wrote: > In D126694#3629251

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

steakhal added a comment. Actually, there is one more bug there. If the string has an embedded null-terminator; a wrong length will be returned. Please add tests to demonstrate the wrong behavior. Try different target triples for having irregular char sizes and pin that. Repository: rG LLVM

[clang] 2db2a4e - [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

Author: Peter Waller Date: 2022-07-07T10:55:40Z New Revision: 2db2a4e112406e97bad82b8e78492a472c13588e URL: https://github.com/llvm/llvm-project/commit/2db2a4e112406e97bad82b8e78492a472c13588e DIFF: https://github.com/llvm/llvm-project/commit/2db2a4e112406e97bad82b8e78492a472c13588e.diff LOG:

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2db2a4e11240: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209 (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo CH

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1897 + QualType Ty = SubReg->getValueType(); + if (BaseTy->isScalarType() && Ty->isScalarType()) { +if (Ctx.getTypeSizeInChars(BaseTy) >= Ctx.getTypeSizeInChars(Ty)) {

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

steakhal added a comment. In D127874#3628112 , @martong wrote: >> I don't think any of the issues mentioned in this patch relates to strongly >> connected components, thus I don't think I can answer to this question. > > In your example above, repeated h

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rnk, shafik. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. The two first parameters of checkPreprocessorOptions are "PPOpts, ExistingPPOpts". All other callers of the

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

steakhal added a comment. Sorry about my delayed response. I was busy. I've left a couple comments inline. Nothing serious. Thanks for the patch! Comment at: clang/docs/ReleaseNotes.rst:593 + +- clang-extdef-mapping now accepts .ast files as input. This is faster than to + rec

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:42 + : Ctx(Context), SM(Context.getSourceManager()) { +CurrentFileName = astFilePath.str(); + } steakhal wrote: > Why is this not initialized in the //initi

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

yurai007 created this revision. yurai007 added reviewers: nikic, ChuanqiXu, lxfind, GorNishanov. Herald added a project: All. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Recently C++ snippet included in this patch popped up at

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong created this revision. martong added reviewers: isuckatcs, NoQ, bruntib, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Her

[clang-tools-extra] cd3aa33 - [pseudo] NFC, fix the header guard for Language.h

Author: Haojian Wu Date: 2022-07-07T14:42:26+02:00 New Revision: cd3aa338c720b9ee296348e3670c284cfead969d URL: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d DIFF: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d.diff LO

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442874. wyt added a comment. Remove decomposing declarations which are not available in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + royjacobson wrote: > erichkeane wrote: > > royjacobson

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442879. junaire added a comment. Correct copy paster error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files: clang/test/Interpreter/execute-weak.cpp clang/te

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

clementval added a comment. @pengfei We are also hitting the following assertion with this patch. Do you have any idea why? /llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4333: void {anonymous}::SelectionDAGLegalize::ConvertNodeToLibcall(llvm::SDNode*): Assertion `cast(Node->get

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:60 + +std::string symbolName(clang::pseudo::SymbolID SID, + const clang::pseudo::Grammar &G) { This code is copied right? Comment at: clang

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442902. junaire added a comment. extern printf so we can use, another copy paster mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files: clang/test/Inter

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

steakhal added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:149 + if (!CI) +CI = new CompilerInstance(); + thieta wrote: > steakhal wrote: > > What takes the ownership of `CI`? When is it deleted? > I don't think anyone

[clang] 2d01a85 - [Driver] Improve linking options for target AVR

Author: KOLANICH Date: 2022-07-07T22:45:21+08:00 New Revision: 2d01a8572076a93fa40c4af934e78a859f3096ee URL: https://github.com/llvm/llvm-project/commit/2d01a8572076a93fa40c4af934e78a859f3096ee DIFF: https://github.com/llvm/llvm-project/commit/2d01a8572076a93fa40c4af934e78a859f3096ee.diff LOG:

[PATCH] D127501: [AVR] Fixed broken linking using `avr-gcc`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01a8572076: [Driver] Improve linking options for target AVR (authored by KOLANICH, committed by benshi001). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jdoerfert added a comment. Generally makes sense, some notes though Comment at: clang/test/Frontend/embed-object.ll:17 + +; CHECK: !llvm.embedded.object = !{![[METADATA_1:[0-9]+]], ![[METADATA_2:[0-9]+]]} +; CHECK: ![[METADATA_1]] = !{ptr @[[OBJECT_1]], !".llvm.offloading"} --

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

njames93 added a subscriber: klimek. njames93 added a comment. Sorry to do this again, but could this be split up again, one patch for the new matcher and the tests associated with it, then another for the actual bug fix. Also cc @klimek as he is the code owner of ASTMatchers Repository: rG L

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jhuber6 updated this revision to Diff 442926. jhuber6 added a comment. Updating to use `objects` and adding documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129033/new/ https://reviews.llvm.org/D129033 Files: clang/test/Frontend/embe

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Thanks @clementval for reporting it and the reproducer. Put a patch D129294 to address it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Note that the build failure seems unrelated, as it's due to a failing clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 _

[PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM), per

[PATCH] D129298: Add denormal-fp-math attribute for f16

dcandler created this revision. dcandler added reviewers: arsenm, spatel, echristo, andrew.w.kaylor, cameron.mcinally. Herald added subscribers: jsji, kosarev, jdoerfert, pengfei, hiraditya, kristof.beyls, tpr. Herald added a project: All. dcandler requested review of this revision. Herald added

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

jhuber6 updated this revision to Diff 442941. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addressing comments. Metadata is now empty and must be empty for the flag to be emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129033/new/ https://reviews.llvm.org/D129033 ___

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129151/new/ https://reviews.llvm.org/D129151 ___

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains updated this revision to Diff 442942. iains marked 3 inline comments as done. iains added a comment. rebased, reworked - to follow the changes proposed by core - to make the diagnostics follow that and a compromise for the proposed revision before the core amendment. Repository: rG LLV

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. the revised diagnostics look like this: ` error: {un-}exported inline function not defined before the private module fragment` with ` note: private module fragment begins here` pointing to the start of the PMF If there is no PMF then we just say: ` error: {un-}exported

[clang-tools-extra] eb64dbd - [clangd] Fix flaky throttler test

Author: Sam McCall Date: 2022-07-07T18:09:54+02:00 New Revision: eb64dbd6e0e617298579d32372fb92e595816d45 URL: https://github.com/llvm/llvm-project/commit/eb64dbd6e0e617298579d32372fb92e595816d45 DIFF: https://github.com/llvm/llvm-project/commit/eb64dbd6e0e617298579d32372fb92e595816d45.diff LO

[PATCH] D129300: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functional

[PATCH] D129298: Add denormal-fp-math attribute for f16

arsenm added a comment. Missing ARM changes that demonstrate the use of the control? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129298/new/ https://reviews.llvm.org/D129298 ___ cfe-commits mailing lis

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added a comment. In D129100#3634548 , @vitalybuka wrote: > This looks flaky https://lab.llvm.org/buildbot/#/builders/5/builds/25929 Sorry about that, I believe this is fixed in eb64dbd6e0e617298579d32372fb92e595816d45

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j updated this revision to Diff 442945. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 Files: clang/tools/clang-offload-bundler/CMakeLists.txt clang/t

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core func

[clang] ed801ad - [Clang] Use metadata to make identifying embedded objects easier

Author: Joseph Huber Date: 2022-07-07T12:20:25-04:00 New Revision: ed801ad5e5fef76c4303d04fd8de21662b428bee URL: https://github.com/llvm/llvm-project/commit/ed801ad5e5fef76c4303d04fd8de21662b428bee DIFF: https://github.com/llvm/llvm-project/commit/ed801ad5e5fef76c4303d04fd8de21662b428bee.diff

[clang] 41fba3c - [Metadata] Add 'exclude' metadata to add the exclude flags on globals

Author: Joseph Huber Date: 2022-07-07T12:20:40-04:00 New Revision: 41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98 URL: https://github.com/llvm/llvm-project/commit/41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98 DIFF: https://github.com/llvm/llvm-project/commit/41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98.diff

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed801ad5e5fe: [Clang] Use metadata to make identifying embedded objects easier (authored by jhuber6). Changed prior to commit: https://reviews.llv

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41fba3c107a5: [Metadata] Add 'exclude' metadata to add the exclude flags on globals (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core func

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functional

[clang] 6c3990a - [OpenMP][NFC] Claim order clause modifiers (reproducible and unconstrained)

Author: Chi Chun Chen Date: 2022-07-07T11:30:03-05:00 New Revision: 6c3990acfbb933a61e2c74332bb252121c06bd14 URL: https://github.com/llvm/llvm-project/commit/6c3990acfbb933a61e2c74332bb252121c06bd14 DIFF: https://github.com/llvm/llvm-project/commit/6c3990acfbb933a61e2c74332bb252121c06bd14.diff

[clang] 42e1035 - [LinkerWrapper] Identify offloading sections using ELF type

Author: Joseph Huber Date: 2022-07-07T12:38:00-04:00 New Revision: 42e10354d4553cdce131add80a4bf135f01d40db URL: https://github.com/llvm/llvm-project/commit/42e10354d4553cdce131add80a4bf135f01d40db DIFF: https://github.com/llvm/llvm-project/commit/42e10354d4553cdce131add80a4bf135f01d40db.diff

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. I feel it is better to do the refactoring in one patch, since it is difficult to maintain the integrity of 4 patches. It would be easier to revert or cherry-pick the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

steven_wu accepted this revision. steven_wu added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129220/new/ https://reviews.llvm.org/D129220 ___ cfe-commits mailing list cfe-comm

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3633705 , @jdoerfert wrote: > Also, make sure to remove all deviceRTL files and probably reset the > autogenerated tests to upstream (and re-generate) before you merge (or > reupload). > > In D102107#3633678

[clang-tools-extra] b15127d - [clangd] Disable flaky test

Author: Sam McCall Date: 2022-07-07T19:17:09+02:00 New Revision: b15127d0562cd6e1fc65abc1e967c56fa18391a7 URL: https://github.com/llvm/llvm-project/commit/b15127d0562cd6e1fc65abc1e967c56fa18391a7 DIFF: https://github.com/llvm/llvm-project/commit/b15127d0562cd6e1fc65abc1e967c56fa18391a7.diff LO

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1499 + +S.remove(Filenames.back()); +// Now shut down the TU Scheduler. kadircet wrote: > sequencing is hard here but it'd be nice to ensure release is ac

[clang] 67a84ec - [clang] Cleanup ASTContext before output files in crash recovery for modules

Author: Ben Langmuir Date: 2022-07-07T10:23:57-07:00 New Revision: 67a84ec8105e590159b6303a1f0e3cb77c02b5fe URL: https://github.com/llvm/llvm-project/commit/67a84ec8105e590159b6303a1f0e3cb77c02b5fe DIFF: https://github.com/llvm/llvm-project/commit/67a84ec8105e590159b6303a1f0e3cb77c02b5fe.diff

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a84ec8105e: [clang] Cleanup ASTContext before output files in crash recovery for modules (authored by benlangmuir). Repository: rG LLVM Github M

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule &R = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; so the dollar signs are a pr

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/Support/CompressionTest.cpp:21 using namespace llvm; +using namespace llvm::compression; Delete blank line between two `using` CHANGES SINCE LAST ACTION https://revie

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:27 +static constexpr std::string AlgorithmName = "zlib"; static constexpr int NoCompression = 0; Is it still used? Prefer StringRef if the string is backed from some storage.

[PATCH] D129308: [mlir] Remove VectorToROCDL

krzysz00 created this revision. Herald added subscribers: bzcheeseman, kosarev, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_am

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur accepted this revision. Meinersbur added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. Thanks for catching this! Is it really an NFC change though (it seems like it would change some of the diagnostic behavior and the list of suggested predefines)? Can you add test coverage for the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath created this revision. sridhar_gopinath added reviewers: curdeius, owenpan. Herald added a project: All. sridhar_gopinath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In diff and diffstat modes, the return code is != 0 e

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:27 +static constexpr std::string AlgorithmName = "zlib"; static constexpr int NoCompression = 0; MaskRay wrote: > Is it still used? > > Prefer StringRef if the string is backe

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636567 , @aaron.ballman wrote: > Thanks for catching this! Is it really an NFC change though (it seems like it > would change some of the diagnostic behavior and the list of suggested > predefines)? Can you add tes

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay added a comment. I think this can be pushed now. You need to remove the variable > In file included from > /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/MC/ELFObjectWriter.cpp:41: > /var/lib/buildkite-agent/builds/llvm-project/llvm/include/llvm/Support/Compression.h:27:30: > err

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443005. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 - compression refactor: undo

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443006. ckissane added a comment. - chore: delete an excess blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files: clang-tools-extra/clangd/index/Serial

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane marked 5 inline comments as done. ckissane added a comment. mark some handled comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-com

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane updated this revision to Diff 443009. ckissane edited the summary of this revision. ckissane added a comment. - remove crc32 from zlib compression namespace - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 - Merge branch 'ckissane.refactor-c

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane marked 4 inline comments as done. ckissane added a comment. mark handled comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___ cfe-commi

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 443011. jhuber6 added a comment. Moving version field to struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 updated this revision to Diff 443013. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128816/new/ https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPR

[clang] 19e2188 - [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

Author: Wei Yi Tee Date: 2022-07-07T20:53:47+02:00 New Revision: 19e21887eb18aa019000c2384ea7f2c91d937489 URL: https://github.com/llvm/llvm-project/commit/19e21887eb18aa019000c2384ea7f2c91d937489 DIFF: https://github.com/llvm/llvm-project/commit/19e21887eb18aa019000c2384ea7f2c91d937489.diff LO

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19e21887eb18: [clang][dataflow] Return a solution from the solver when `Constraints` are… (authored by wyt, committed by gribozavr). Changed prior t

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443017. abrahamcd edited the summary of this revision. abrahamcd added a comment. Adds functionality for only warning on the case of unused return value of the call to `empty()` and removes using-directive. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:146 +CXXRecordDecl *ArgRecordDecl = Arg->getType()->getAsCXXRecordDecl(); +if (ArgRecordDecl == NULL) + return; `nullptr`. Repository:

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. In D129277#3636596 , @mstorsjo wrote: > In D129277#3636567 , @aaron.ballman > wrote: > >> Thanks for catching this! Is it really an NFC change though (it seems like >> it would cha

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:128 + << FixItHint::CreateReplacement(ReplacementRange, "clear"); +} else { + diag(MemberLoc, "ignoring the result of 'empty()'"); Let's elimi

[PATCH] D119296: KCFI sanitizer

MaskRay added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:63 SanitizerKind::Unreachable | SanitizerKind::Return; -static const SanitizerMask AlwaysRecoverable = -SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress; +static const SanitizerMas

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. SO I've been playing with this for a while and all the libcxx issues. I THINK we really need to just bit the bullet and figure out how to correctly re-add things to the instantiation scope (after making the CheckFunctionConstraints LocalInstantiationScope 'false' for

  1   2   >