[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane marked 9 inline comments as done. erichkeane added a comment. In D126907#3617713 , @ChuanqiXu wrote: > In D126907#3615807 , @erichkeane > wrote: > >> All tests pass now, I was able to get the template-

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

alexfh added a comment. @pengfei could you fix the Darwin tests as well? And a general comment regarding the ongoing `_Float16` effort: I think that this change should have been a part of https://reviews.llvm.org/D107082 to make it possible to build a consistently working toolchain. Thus, if th

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane updated this revision to Diff 441020. erichkeane marked 2 inline comments as done. erichkeane added a comment. All but the 1 comment from @ChuanqiXu fixed, not sure what to do about the 'info'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.or

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/confusable-identifiers.cpp:43 + return q0 < q1; +} aaron.ballman wrote: > It looks like there's quite a bit of missing test coverage for all the > various situ

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

LegalizeAdulthood added a comment. This whole check seems weird to me. I mean, almost every use of a standard container could throw `std::bad_alloc` but we don't insist on a local `catch` for `bad_alloc` at every possible throwing call site. Why would we assume that every call site of `stoi` o

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Please add a summary of the fix to the release notes for this check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-tidy tests and docs have been moved to subdirectories by module, please rebase to `main:HEAD` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added a comment. In D128826#3619167 , @sammccall wrote: > Thanks! I just have a question if this behavior should be even "stronger": > > In most editors, if you return one result you go straight there, if you > return two results you get a men

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. Thanks @benlangmuir for the revert. The problem seems Darwin supports the `_Float16` type already but with a different ABI. I have no idea how to solve the problem ATM. Post a question on discourse: https://discourse.llvm.org/t/compiler-rt-tests-fail-on-darwin-stage1-bu

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125693/new/ https://reviews.llvm.org/D125693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

rjmccall added inline comments. Comment at: clang/lib/AST/Stmt.cpp:370-371 setStmts(Stmts); + if (hasStoredFPFeatures()) +setStoredFPFeatures(FPFeatures); } aaron.ballman wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > There's a part of me that w

[PATCH] D128833: [clang][dataflow] Handle `for` statements without conditions

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Handle `for` statements without conditions. Repositor

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619265 , @alexfh wrote: > @pengfei could you fix the Darwin tests as well? And a general comment > regarding the ongoing `_Float16` effort: I think that this change should have > been a part of https://reviews.llvm.o

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 441039. jyu2 added a comment. Thanks Alexey for the review. Add change in TreeTransform.h to rebuilt member expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 F

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 441048. jhuber6 added a comment. Update with new version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 updated this revision to Diff 441049. jhuber6 added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128816/new/ https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[clang] a9a60f2 - [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

Author: Corentin Jabot Date: 2022-06-29T18:28:51+02:00 New Revision: a9a60f20e6cc80855864b8f559073bc31f34554b URL: https://github.com/llvm/llvm-project/commit/a9a60f20e6cc80855864b8f559073bc31f34554b DIFF: https://github.com/llvm/llvm-project/commit/a9a60f20e6cc80855864b8f559073bc31f34554b.diff

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9a60f20e6cc: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC] (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128762/new/

[PATCH] D128604: [RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 441052. sunshaoce added a comment. Add alias instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def cla

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall added a comment. TL;DR: I'm convinced that this patch (return multiple locations) is a good choice. Also talked to Kadir offline. In D128826#3619339 , @tom-anders wrote: > I'm using this with neovim's builtin LSP, where when there are multipl

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch! This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128814/new/ https://reviews.llvm.org/D128814 ___

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix, the changes LGTM! From our off-review discussion, I understand you need me to commit this on your behalf. What name and email address would you like me to

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

zahiraam added a comment. Took the time to test the change on a few "crooked" tests I had used for the original patch. It works! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128814/new/ https://reviews.llvm.org/D128814

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille added a comment. @aaron.ballman : I agree with most of your suggestion except the one below that I annotated accordingly struct Base { virtual void O0(); private: void II(); }; struct Derived : Base { void OO(); // We should warn about this void I

[clang] a9bef07 - [clang-format] Fix incorrect isspace input (NFC)

Author: Kevin Cadieux Date: 2022-06-29T10:20:46-07:00 New Revision: a9bef0707db101bb72d000a1f09686d97fb2d35d URL: https://github.com/llvm/llvm-project/commit/a9bef0707db101bb72d000a1f09686d97fb2d35d DIFF: https://github.com/llvm/llvm-project/commit/a9bef0707db101bb72d000a1f09686d97fb2d35d.diff

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9bef0707db1: [clang-format] Fix incorrect isspace input (NFC) (authored by kevcadieux, committed by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 added a comment. Name : Prathit Aswar github username : appmonster007 email : snaswar0...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

aaron.ballman added a comment. In D128715#3619650 , @serge-sans-paille wrote: > @aaron.ballman : I agree with most of your suggestion except the one below > that I annotated accordingly > > struct Base { > virtual void O0(); > > private: >

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 441075. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recur

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 441079. Purva-Chaudhari added a comment. Updating CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp Index: cla

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3618040 , @abidmalikwaterloo wrote: > In D105584#3617666 , @clementval > wrote: > >> In D105584#3617456 , >> @abidmalikwat

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep marked 9 inline comments as done. samestep added a comment. Fixed all the minor nits and responded to some comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:401 + const TypeErasedDataflowAnalysisState &State

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 441084. samestep added a comment. - Merge branch 'main' into diagnose-api - Fix minor nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/include/cl

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 441089. Purva-Chaudhari added a comment. add preamble to test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. Thanks, I think this is heading in the right direction! Comment at: clang/include/clang/Basic/Sarif.h:167 + + ThreadFlow setRange(const CharSourceRange &ItemRange) { +Range = ItemRange; Should we assert this source range is n

[PATCH] D128841: [Driver] Always use --as-needed with libunwind

phosek created this revision. phosek added reviewers: mcgrathr, saugustine. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. With libgcc, we follow the behavior of GCC for backwards compatibility,

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441101. ckissane added a comment. add AlgorithmName to compression namespaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441102. ckissane added a comment. add AlgorithmName to compression namespaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/te

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added a comment. > In D128826#3619339 , @tom-anders > wrote: > >> I'm using this with neovim's builtin LSP, where when there are multiple >> results it takes me to the first one, and also opens the quickfix window >> that shows all results. B

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 441105. abidmalikwaterloo added a comment. Update the patch for assembly format. Change the WSLoopControl to LoopControl. Added DistributeOp to parent of Yield OP. Added one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3612956 , @MaskRay wrote: > The lld/ change should be separate. And it needs tests. We should have > several tests such as mixed zlib and zstd input, malformed zstd input, > compressed level, etc. `OutputSections` sh

[clang] 5f2cf3a - [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

Author: Egor Zhdan Date: 2022-06-29T19:36:22+01:00 New Revision: 5f2cf3a21f3aabff85d178a110602ce150914ff7 URL: https://github.com/llvm/llvm-project/commit/5f2cf3a21f3aabff85d178a110602ce150914ff7 DIFF: https://github.com/llvm/llvm-project/commit/5f2cf3a21f3aabff85d178a110602ce150914ff7.diff LO

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f2cf3a21f3a: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:75 + // could look up the name appearing on the RHS. + const Type *getPointeeType(const Type *T) const; + sammccall wrote: > tom-anders wrote: > > Not sure if it's the ri

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added a comment. Marked name of algorithm comments as done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___ cfe-commits mailing list cfe-commits

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441107. ckissane added a comment. - feat: refactor llvm compression namespaces - chore: update rel notes to note zlib::crc32 remove - feat: add AlgorithmName to compression namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin created this revision. Herald added a subscriber: wenlei. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Display 'static_assert failed: m

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1913 // to target. -static QualType unwrapFindType(QualType T) { +static llvm::SmallVector unwrapFindType( +QualType T, const HeuristicResolver* H) { tom-anders wrote: > sammcca

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:167 + + ThreadFlow setRange(const CharSourceRange &ItemRange) { +Range = ItemRange; aaron.ballman wrote: > Should we assert this source range is not a token range? I don't have a

[clang] 34fc1db - [LinkerWrapper] Change wrapping to include jumps for other variables

Author: Joseph Huber Date: 2022-06-29T14:48:39-04:00 New Revision: 34fc1db9a8b22300a90e71fe7285501e7bcdc90e URL: https://github.com/llvm/llvm-project/commit/34fc1db9a8b22300a90e71fe7285501e7bcdc90e DIFF: https://github.com/llvm/llvm-project/commit/34fc1db9a8b22300a90e71fe7285501e7bcdc90e.diff

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3615372 , @zahiraam wrote: > In D113107#3606106 , @rjmccall > wrote: > >> In D113107#3606094 , @zahiraam >> wrote: >> >>> In D113107

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 441112. samestep added a comment. - Tidy AnalysisData struct and PostVisitStmt param Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/include/clang/An

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added inline comments. Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:215 +LogicalResult DistributeOp::verify(){ + if (this->lowerBound().empty()) { +return emitOpError() << "empty lowerbound for distribute loop operation"; No brace - h

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, just nits you know of outstanding and I think no extra tests needed. In D128826#3619956 , @tom-anders wrote: >>> So here's what I thought:

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:199 UsesAllocatorsDecls; +struct ImplicitDefaultFDInfoTy { + const FieldDecl *FD = nullptr; Add comments for the structure and all fields, please. Commen

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441113. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.refactor-compression-namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D

[clang] f892ddb - [OpenMP] Add variant extension that applies to declarations

Author: Joseph Huber Date: 2022-06-29T15:04:26-04:00 New Revision: f892ddb3be640f477fc9acef55e7bd613fc27acf URL: https://github.com/llvm/llvm-project/commit/f892ddb3be640f477fc9acef55e7bd613fc27acf DIFF: https://github.com/llvm/llvm-project/commit/f892ddb3be640f477fc9acef55e7bd613fc27acf.diff

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441114. ckissane edited the summary of this revision. ckissane added a comment. - feat: add zstd compression - Merge branch 'ckissane.refactor-compression-namespace' into ckissane.add-zstd-compression - Merge branch 'ckissane.refactor-compression-namespace'

[PATCH] D124624: [OpenMP] Add variant extension that applies to declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf892ddb3be64: [OpenMP] Add variant extension that applies to declarations (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep marked an inline comment as done. samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129 +auto *Lattice = +llvm::any_cast(&State.Lattice.Value); +PostVisitStmt(Stmt, DataflowAnalysisS

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep updated this revision to Diff 441117. samestep added a comment. - Merge branch 'diagnose-api' into optional-check-diagnose - Update using review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128352/new/ https://reviews.llvm.org/D1

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 441118. samestep added a comment. - Merge branch 'optional-check-diagnose' into optional-model-noop-lattice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128356/new/ https://reviews.llvm.org/D128356 Files:

[clang] 58fe7f9 - [clang][dataflow] Add API to separate analysis from diagnosis

Author: Sam Estep Date: 2022-06-29T19:18:39Z New Revision: 58fe7f9683a020a880426a4d8d61b067b83a9380 URL: https://github.com/llvm/llvm-project/commit/58fe7f9683a020a880426a4d8d61b067b83a9380 DIFF: https://github.com/llvm/llvm-project/commit/58fe7f9683a020a880426a4d8d61b067b83a9380.diff LOG: [cl

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58fe7f9683a0: [clang][dataflow] Add API to separate analysis from diagnosis (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] cafb8b4 - [clang][dataflow] Use diagnosis API in optional checker

Author: Sam Estep Date: 2022-06-29T19:20:09Z New Revision: cafb8b4ff2c38f81e65f97193eb1d8d16c581522 URL: https://github.com/llvm/llvm-project/commit/cafb8b4ff2c38f81e65f97193eb1d8d16c581522 DIFF: https://github.com/llvm/llvm-project/commit/cafb8b4ff2c38f81e65f97193eb1d8d16c581522.diff LOG: [cl

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcafb8b4ff2c3: [clang][dataflow] Use diagnosis API in optional checker (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 58fe7f9 - [clang][dataflow] Add API to separate analysis from diagnosis

Author: Sam Estep Date: 2022-06-29T19:18:39Z New Revision: 58fe7f9683a020a880426a4d8d61b067b83a9380 URL: https://github.com/llvm/llvm-project/commit/58fe7f9683a020a880426a4d8d61b067b83a9380 DIFF: https://github.com/llvm/llvm-project/commit/58fe7f9683a020a880426a4d8d61b067b83a9380.diff LOG: [cl

[clang] 335c05f - [clang][dataflow] Use NoopLattice in optional model

Author: Sam Estep Date: 2022-06-29T19:20:58Z New Revision: 335c05f5d19fecd5c0972ac801e58248d772a78e URL: https://github.com/llvm/llvm-project/commit/335c05f5d19fecd5c0972ac801e58248d772a78e DIFF: https://github.com/llvm/llvm-project/commit/335c05f5d19fecd5c0972ac801e58248d772a78e.diff LOG: [cl

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG335c05f5d19f: [clang][dataflow] Use NoopLattice in optional model (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 441125. sammccall marked 14 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files: clang-tool

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added 1 blocking reviewer(s): aaron.ballman. philnik added a comment. LGTM from the libc++ side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 _

[clang] 8361877 - Revert "[clang][dataflow] Use NoopLattice in optional model"

Author: Sam Estep Date: 2022-06-29T19:34:30Z New Revision: 8361877b10b8180ab12300b289da54a403ce7554 URL: https://github.com/llvm/llvm-project/commit/8361877b10b8180ab12300b289da54a403ce7554 DIFF: https://github.com/llvm/llvm-project/commit/8361877b10b8180ab12300b289da54a403ce7554.diff LOG: Rev

[clang-tools-extra] 2a33d12 - Revert "[clang][dataflow] Use diagnosis API in optional checker"

Author: Sam Estep Date: 2022-06-29T19:34:44Z New Revision: 2a33d12642d862a8aa307e4a8b8a94d2d0c5ad1d URL: https://github.com/llvm/llvm-project/commit/2a33d12642d862a8aa307e4a8b8a94d2d0c5ad1d DIFF: https://github.com/llvm/llvm-project/commit/2a33d12642d862a8aa307e4a8b8a94d2d0c5ad1d.diff LOG: Rev

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3620014 , @zahiraam wrote: > In D113107#3615372 , @zahiraam > wrote: > >> In D113107#3606106 , @rjmccall >> wrote: >> >>> In D113107

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 441130. vaibhav.y added a comment. Assert that `CharSourceRange`s passed to `Threadflow`, `SarifResult` are character Ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3968 + !Right.isOneOf(tok::r_paren, tok::semi)) || +(Right.is(TT_VerilogTableItem) && !Left.is(tok::l_paren))) { + const FormatToken *Next = Right.g

[PATCH] D128848: Fix assertion when analyzing a for-loop with no condition expression

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For loops are allowed to have an empty conditional expression; we should not ass

[clang-tools-extra] 2adaca5 - [clang][dataflow] Use diagnosis API in optional checker

Author: Sam Estep Date: 2022-06-29T19:50:36Z New Revision: 2adaca532df4d3d7ae4cd3b724b2099ffefe235c URL: https://github.com/llvm/llvm-project/commit/2adaca532df4d3d7ae4cd3b724b2099ffefe235c DIFF: https://github.com/llvm/llvm-project/commit/2adaca532df4d3d7ae4cd3b724b2099ffefe235c.diff LOG: [cl

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the small change required to outp

[PATCH] D128848: Fix assertion when analyzing a for-loop with no condition expression

ymandel added a comment. Looks like you and Stanislav had the same idea? https://reviews.llvm.org/D128833 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128848/new/ https://reviews.llvm.org/D128848 ___ cf

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866 case CodeCompletionResult::RK_Pattern: - return Result.Pattern->getTypedText(); + CCS = Result.Pattern; + break; sammccall wrote: > weirdly, codeCompleti

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:366 + // so may differ from declaration order. In particular, Itanium ABI will + // allocate a primary base first. + llvm::sort(Fields, Maybe add a comment explaining why

[PATCH] D128848: Fix assertion when analyzing a for-loop with no condition expression

li.zhe.hua abandoned this revision. li.zhe.hua added a comment. In D128848#3620185 , @ymandel wrote: > Looks like you and Stanislav had the same idea? > https://reviews.llvm.org/D128833 Seems like it. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D128851: [clang][dataflow] Use NoopLattice in optional model

samestep created this revision. Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Reland of D128356

[clang] 5086e05 - Repair tautological condition.

Author: Richard Smith Date: 2022-06-29T13:08:40-07:00 New Revision: 5086e05bb0cdeef68b110336dba2fe229be95110 URL: https://github.com/llvm/llvm-project/commit/5086e05bb0cdeef68b110336dba2fe229be95110 DIFF: https://github.com/llvm/llvm-project/commit/5086e05bb0cdeef68b110336dba2fe229be95110.diff

[clang] dcea10c - Fix miscompile with [[no_unique_address]] struct fields.

Author: Richard Smith Date: 2022-06-29T13:08:40-07:00 New Revision: dcea10c3c6ac963387e53f918c3616b64cb82e8d URL: https://github.com/llvm/llvm-project/commit/dcea10c3c6ac963387e53f918c3616b64cb82e8d DIFF: https://github.com/llvm/llvm-project/commit/dcea10c3c6ac963387e53f918c3616b64cb82e8d.diff

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 441142. samestep added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Update UncheckedOptionalAccessCheck.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12835

[clang] cf1f978 - [clang][dataflow] Use NoopLattice in optional model

Author: Sam Estep Date: 2022-06-29T20:10:42Z New Revision: cf1f978d319b91464370d71289e1c7c30baa4243 URL: https://github.com/llvm/llvm-project/commit/cf1f978d319b91464370d71289e1c7c30baa4243 DIFF: https://github.com/llvm/llvm-project/commit/cf1f978d319b91464370d71289e1c7c30baa4243.diff LOG: [cl

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1f978d319b: [clang][dataflow] Use NoopLattice in optional model (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

samestep updated this revision to Diff 441144. samestep added a comment. Update from main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128448/new/ https://reviews.llvm.org/D128448 Files: clang/docs/tools/clang-formatted-files.txt clang/includ

[clang] 6a97be2 - [clang][dataflow] Delete SourceLocationsLattice

Author: Sam Estep Date: 2022-06-29T20:14:07Z New Revision: 6a97be27a1de652b8f09f43178d09fc100b05990 URL: https://github.com/llvm/llvm-project/commit/6a97be27a1de652b8f09f43178d09fc100b05990 DIFF: https://github.com/llvm/llvm-project/commit/6a97be27a1de652b8f09f43178d09fc100b05990.diff LOG: [cl

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a97be27a1de: [clang][dataflow] Delete SourceLocationsLattice (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders marked 6 inline comments as done. tom-anders added a comment. > In D128826#3619956 , @tom-anders > wrote: > So here's what I thought: Say you have a variable that's a smart pointer and trigger textDocument/typeDefinition on it and th

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders updated this revision to Diff 441147. tom-anders marked an inline comment as done. tom-anders added a comment. - Remove obsolete comment - Return empty vector when type isNull() - Add comment about why we don't deduplicate results - Use out-parameter in unwrapFindType to make structure

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added a comment. > and run the test case, the first added line prints `1` and the second one > `0`. `Result` is being mutated when doing the in-place evaluation. I did not catch that. That is unfortunate, I am wondering now if we need a `Result.isArray() && ` before the `EvaluateInPlace`

[clang] 3d2629d - [Clang] Mark consteval as supported in Clang 15 [NFC]

Author: Corentin Jabot Date: 2022-06-29T22:23:17+02:00 New Revision: 3d2629dd3aab17098813c68b5b76bb864bc5e285 URL: https://github.com/llvm/llvm-project/commit/3d2629dd3aab17098813c68b5b76bb864bc5e285 DIFF: https://github.com/llvm/llvm-project/commit/3d2629dd3aab17098813c68b5b76bb864bc5e285.diff

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added inline comments. Comment at: clang/include/clang/AST/APValue.h:511-512 bool hasArrayFiller() const { +if (!isArray()) + return false; return getArrayInitializedElts() != getArraySize(); aaron.ballman wrote: > I think this makes the i

[clang] 017c068 - [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

Author: Volodymyr Sapsai Date: 2022-06-29T13:24:55-07:00 New Revision: 017c068f7899b895e654c8efc1c4d02d940dbf8a URL: https://github.com/llvm/llvm-project/commit/017c068f7899b895e654c8efc1c4d02d940dbf8a DIFF: https://github.com/llvm/llvm-project/commit/017c068f7899b895e654c8efc1c4d02d940dbf8a.di

<    1   2   3   >