[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:624 bool isModulePrivate() const { return getModuleOwnershipKind() == ModuleOwnershipKind::ModulePrivate; } According to the opinion from @rsmith, the discarded declaration

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @rsmith @iains gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440856. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recursion.cpp Index: clang/test/S

[PATCH] D128709: [clang-format] Handle Verilog attributes

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1466-1471 + } else if (FormatTok->is(tok::l_paren)) { +const FormatToken *Next = Tokens->peekNextToken(); +if (Next && Next->is(tok::star)) + parseParens(); +

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440859. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/typeinfo clang/test/SemaCXX/warn-infinite-recur

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added a comment. In D105584#3617456 , @abidmalikwaterloo wrote: > // CHECK-LABEL: omp_DistributeOp > func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, > %data_var : memref, %chunk_var : i32) -> () { > // CHECK: omp

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail updated this revision to Diff 440860. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 Files: clang/include/clang/Basic/LangOptions.def clang/include/clan

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new field called EmittedDeferredDecls in CodeGenModule that keeps

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3615807 , @erichkeane wrote: > All tests pass now, I was able to get the template-template checks working > correctly, and it passes all the tests I have available. @ChuanqiXu if you > could review/run what tests

[PATCH] D128783: Check for more -fsanitize=array-bounds regressions

sberg created this revision. sberg added a reviewer: MaskRay. sberg added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. sberg requested review of this revision. ...that had been introduced with (since reverted) https://github.com/llvm/llvm-project/commit/88

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:401 + const TypeErasedDataflowAnalysisState &State) { +PostVisitStmt(Stmt.getStmt(), State); + }

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129 +auto *Lattice = +llvm::any_cast(&State.Lattice.Value); +PostVisitStmt(Stmt, DataflowAnalysisState{ +

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu updated this revision to Diff 440872. ChuanqiXu added a reviewer: MaskRay. ChuanqiXu added a comment. Herald added a subscriber: StephenFan. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 Files: clang/include/clang/Basic

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

kevcadieux created this revision. Herald added a project: All. kevcadieux requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a clang-format unit test failure introduced by D124748 . The `cou

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3614297 , @MaskRay wrote: > Oh, I did not see this when pushing a test > efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 > . > Consider adding additional t

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

mboehme added a comment. In D128706#3615623 , @aaron.ballman wrote: > The changes here LGTM and I think this is the correct way to go. However, > since you discovered that it was perhaps intentional that we did some style > checking on tests, do you th

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

ChuanqiXu added a comment. In D128487#3617422 , @vsapsai wrote: > Thanks for the review! > > In D128487#3614251 , @ChuanqiXu > wrote: > >> Is it possible to combine the several `DiagNote` into `DiagError`? So tha

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440874. awarzynski added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 Files: clang/lib/Driver/ToolChains/Linux.cpp flang/test/Dri

<    1   2   3