[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#3589347 , @sdesmalen wrote: > Thanks @aaron.ballman for your elaborate review, that was very helpful! I'm > still working through some of your suggestions (although some of them weren't > entirely clear to me),

[clang] 7b7166f - Fix an unused-variable warning in release build, NFC.

Author: Haojian Wu Date: 2022-06-21T20:52:07+02:00 New Revision: 7b7166f1a20fe64a9c04a30f6e9335ef0a556d70 URL: https://github.com/llvm/llvm-project/commit/7b7166f1a20fe64a9c04a30f6e9335ef0a556d70 DIFF: https://github.com/llvm/llvm-project/commit/7b7166f1a20fe64a9c04a30f6e9335ef0a556d70.diff LO

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

reames added a comment. Ok, with the revised description, let me start anew in my response. I don't have any particular problem with this change. I do think it would be good to explicitly update the docs to indicate whether the param can be null or not, but given a) gcc has allowed it, and b)

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. In D127246#3599826 , @JonChesterfield wrote: > I've read it but can't promise it's correct - the diff is large and has some > spurious noise in it which distracts significantly from the functional > changes. > > Would you be w

[PATCH] D128297: [pseudo] Track heads as GSS nodes, rather than as "pending actions".

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. IMO this model is simpler to understand (borrowed from the

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this is probably OK. Smaller patches usually get reviewed faster so minimising the line noise in the browser is worthwhile. Comment at: clang/tools

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438697. mizvekov added a comment. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . Fixes PR28087. Signed-off-by: Matheus Izvek

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

aaron.ballman accepted this revision. aaron.ballman added a comment. I remain concerned about the utility of this check. As I understand it, the more complete Unicode guidance is still under active discussion and hasn't been finalized (please correct me if I'm wrong @tahonermann and @cor3ntin) s

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9835-9839 + if (D.isFunctionDefinition()) { +NewFD->setWillHaveBody(); +ProcessDeclAttributes(S, NewFD, D); +NewFD->setWillHaveBody(false); + } else This seems like a hack

[PATCH] D128299: [pseudo] Add a fast-path to GLR reduce when both pop and push are trivial

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. In general we split a reduce into pop/push, so concurrently

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequiresInExpression(false)

[PATCH] D128301: [pseudo] Turn glrReduce into a class, reuse storage across calls.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This is a ~5% speedup, we no longer have to allocate the pr

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 438813. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSON

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

njames93 added a comment. I had another idea about offering the export pragma when in a header file but I don't know if that's going too far In D128204#3599286 , @kadircet wrote: > Hence i'd like to hear a little bit more about what kind of false positi

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added a comment. Hmm, a StaticAnalyzer unit test is failing. It looks it is expecting `"test.CXXDeallocator: NumArgs: 1\n"`, but getting `"test.CXXDeallocator: NumArgs: 2\n". I'm assuming it is because sized deallocation is enabled on default for MSVC now Repository: rG LLVM Github

[clang] 0d300da - [Clang] Fix compile time regression caused by D126061.

Author: Martin Boehme Date: 2022-06-21T23:15:43+02:00 New Revision: 0d300da799b06931eb6b974198d683548a8c8392 URL: https://github.com/llvm/llvm-project/commit/0d300da799b06931eb6b974198d683548a8c8392 DIFF: https://github.com/llvm/llvm-project/commit/0d300da799b06931eb6b974198d683548a8c8392.diff

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d300da799b0: [Clang] Fix compile time regression caused by D126061. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples

KazNX marked 17 inline comments as done. KazNX added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:2750-2752 +where an individual identifier can fall into several classifications. Below +is a list of the classifications s

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

tlively accepted this revision. tlively added a comment. I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/ https://reviews.llvm

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Copying sequences around as the heap resized is significant

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 438852. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt clang-tools-extra/unittests/clang-tidy/ObjCStr

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao added a comment. In D127923#3599451 , @aaron.ballman wrote: > Is there a reason the remarks can't use individual diagnostic emissions to > simulate newlines? Or is this perhaps a demonstration that the remarks should > not be using the diagnos

[PATCH] D128314: [Clang-tidy] Fixing bugs in clang-tidy infinite-loop checker

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, usama54321, rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, dcoughlin, aaron.ballman, alexfh, gribozavr, njames93, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, x

[PATCH] D127803: Generate the capture for field when the field is used with implicit default.

jyu2 updated this revision to Diff 438877. jyu2 edited the summary of this revision. jyu2 added a comment. Thanks Alexey's comment. Address his comment. Instead save info into DSA, add new field in ImplicitDefaultFirstprivateFDs in SharingMapTy. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128318: [pseudo] prototype: faster data structures for LRTable

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. For shift and goto, use

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

samestep updated this revision to Diff 438891. samestep added a comment. Only add the new API, don't change the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/docs/tools/clang-format

[PATCH] D128318: [pseudo] prototype: faster data structures for LRTable

sammccall added a comment. I'm happy with the data structures at this point, so if you have feedback on those that'd be great. Otherwise I still need to clean up the interfaces, fix the broken tests, add some more comments etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 438892. junaire added a comment. - Add unittest - Fix a crash when previous input failed to parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/inclu

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2319-2320 + // enable_if<>{} && ... + if (MatchingLBrace && MatchingLBrace->getPreviousNonComment() && + MatchingLBrace->getPreviousNonComment()->is

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { rjmccall wrote: > pengfei wrote: > > rjmccall wrote: > > > za

[PATCH] D128319: Survive #pragma once from virtual file.

tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Add check before marking file as a once-only file.

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added a comment. Magically deciding a default value for --unwindlib or --rtlib is not nice. You may emit a warning if the selected default happens to be incompatible with HIP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127142/new/ https://reviews.llvm.org/D127142 __

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder added a comment. Failing tests are just because the test file is not formatted it seems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. Great progress! In D126907#3599835 , @erichkeane wrote: > Note that the failure comes down to: > > template concept C = T::f(); > template class P> struct S1{}; > template struct X{}; > S1 s11; > > and requires the -fr

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a comment. @jyknight How do you think about the status now? I want to fix the thread local problem for coroutines in clang15 since the problem have been found for years... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 438926. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. - Address style comments - Improve commit message - Enable the warning in -pedantic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2399 + getSourceLocation(CurPtr)); + bool UnicodeDecodeFailed = false; + aaron.ballman wrote: > It looks like this can move into the `while` loop and we can

<    1   2