[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. Thanks for this patch. This is one big progress to use `flang-new` for real workloads. Mostly looks good to me. I have several minor comments. If supporing `-Ofast` requires more changes, I prefer to push forward with the current patch. summary: fronted -> frontend Conf

[PATCH] D128246: [ADT][NFC] Remove unuse code

Pretty-box created this revision. Pretty-box added reviewers: benshi001, kazu. Pretty-box added projects: LLVM, All. Pretty-box requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438576. philnik added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Papers.csv

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 438577. dongjunduo added a comment. [Clang] update help text of "ftime-trace-path" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Dri

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When calling `hasArrayFiller()` on a `APValue` that's not an array, the two

[PATCH] D128249: Adding clone_attrs attribute.

plotfi created this revision. plotfi added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. plotfi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just experimental for the time being. Posti

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. This is pretty incomplete. Please ignore for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128249/new/ https://reviews.llvm.org/D128249 ___ cfe-commits mailing list cfe-commi

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 438592. serge-sans-paille added a comment. Address most reviewers comment: - formatting style - reduced memory consumption - be clear about TR39 divergence - class and option renaming - getName() usage CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

asb added a comment. > This is still some sort of very early draft and I'm not sure what the rules > are in LLVM land for merging that sort of code. It's a fast track extension > so it should be done soon The policy we ended up with is that support for not-yet-ratified extensions can be merged

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

sberg added a comment. In D127593#3598020 , @royjacobson wrote: > Is it possible to check how often PDFium uses `__has_trivial_assign`? > Depending on how large this breakage is we might need to revert and proceed > more carefully.. The setup is a bit

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438597. tapaswenipathak added a comment. git clang-format HEAD~1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntry.

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. @kees does the new version looks good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the Screenshot, please remember to mark your comments as "Done" once you've addressed them. From what I can tell this looks good. Comment at: clan

[clang-tools-extra] d9afb8c - [clang-tidy] cppcoreguidelines-virtual-class-destructor should ignore final classes

Author: Balazs Benics Date: 2022-06-21T11:02:18+02:00 New Revision: d9afb8c3e8fd01a3c89ab2ddebcd44602a30a975 URL: https://github.com/llvm/llvm-project/commit/d9afb8c3e8fd01a3c89ab2ddebcd44602a30a975 DIFF: https://github.com/llvm/llvm-project/commit/d9afb8c3e8fd01a3c89ab2ddebcd44602a30a975.diff

[PATCH] D126891: [clang-tidy] The check should ignore final classes

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rGd9afb8c3e8fd: [clang-tidy] cppcoreguidelines-virtual-class-destructor should ignore final… (authored by steakhal). Changed prior to commit: https://reviews.ll

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3595461 , @nikic wrote: > In D127579#3588626 , @Anastasia > wrote: > >> In D127579#3586092 , @nikic wrote: >> >>> @Anastasia Thanks,

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

Anastasia added a comment. In D128012#3592126 , @beanz wrote: > In D128012#3592098 , @Anastasia > wrote: > >> aha, are you having a lot of these types then? Ok that sounds similar >> problem to OpenCL builtin fu

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

nikic added a comment. In D127579#3598306 , @Anastasia wrote: > In D127579#3595461 , @nikic wrote: > >> In D127579#3588626 , @Anastasia >> wrote: >> >>> In D127579#358609

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127961/new/ https://reviews.llvm.org/D127961 _

[clang-tools-extra] ae76b2f - [clang-tidy][docs] Fix wrong sphinx link after d9afb8c3e8fd01a3c89ab2ddebcd44602a30a975

Author: Balazs Benics Date: 2022-06-21T11:42:09+02:00 New Revision: ae76b2f455016efb8cac5519d382be575b2d2edc URL: https://github.com/llvm/llvm-project/commit/ae76b2f455016efb8cac5519d382be575b2d2edc DIFF: https://github.com/llvm/llvm-project/commit/ae76b2f455016efb8cac5519d382be575b2d2edc.diff

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder updated this revision to Diff 438612. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 Files: clang/include/clang/AST/APValue.h clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constexpr-array-init.cpp =

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 438622. pmatos added a comment. Incorporate @asb semantic restrictions patch. Generate test CHECK using update_cc_* script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D12

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 438624. sdesmalen added a comment. - Increased test-coverage by adding positive tests for: - template instantiations - function overloading - lambda function with attribute - (indirect) pointer to pointer to an attributed function type. - Also added

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. @ChuanqiXu - have you tried the test example from 10.6 ex1 - I did the impl as below, but the behaviour does not seem to be quite correct? any thoughts? As for review, I can try to pick up the "nits" but not sure that I know the instantiation sub=system too well, so it w

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

sdesmalen created this revision. sdesmalen added reviewers: aaron.ballman, sunfish. Herald added subscribers: pmatos, asb, jdoerfert, kristof.beyls, sbc100. Herald added a project: All. sdesmalen requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a proje

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

hans added a comment. In D127641#3597360 , @steplong wrote: > It looks like misc-new-delete-overloads.cpp is failing on line 20: > .. > On Line 16, it says sized deallocations are not enabled by default, but this > patch turns it on by default for MSVC.

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. as suspected, we also have a missing diagnostic in 10.7 ex1 // RUN: rm -rf %t // RUN: split-file %s %t // RUN: cd %t // RUN: %clang_cc1 -std=c++20 -emit-module-interface std-10-7-ex1-M-A.cpp \ // RUN: -o M-A.pcm // RUN: %clang_cc1 -std=c++20 -emit-module-i

[PATCH] D128257: invalidateCache in addModule and removeModules

tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Ref: https://github.com/vgvassilev/clang/commit/758

[PATCH] D128249: Adding clone_attrs attribute.

aaron.ballman added a comment. Can you add some details to the patch summary as to what problem you're trying to solve with these changes? The idea itself has some interesting edge cases to think about: [[some_attr]] void decl(); [[clone_attrs_from(decl)]] void other(); [[some_new_attr]]

[PATCH] D125669: Adding support for target in_reduction

RitanyaB updated this revision to Diff 438554. RitanyaB added a comment. The if condition in the method EmitOMPTargetTaskBasedDirective in CGStmtOpenMP.cpp file was removed since it was unnecessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

urnathan added a comment. please sed /initialiser/initializer/, I noticed a few had crept in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 ___ cfe-commits ma

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This sounds like a sensible direction to me. I spot-checked the changes and they all seem reasonable. Giving my LG, but please wait a bit before landing in case someone else has

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438657. omarahmed added a comment. Change the default to APO_Leave Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/include/clang/Format/Format.h:3559 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequiresInExpression(false), BeforeN

[PATCH] D128202: [clangd] Include "final" when printing class declaration

sammccall added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1010 + if (D->isEffectivelyFinal()) { + Out << " final"; tom-anders wrote: > sammccall wrote: > > isEffectivelyFinal returns true for > > `struct X { ~X() final; }` > > > > I don'

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. @gribozavr2 , have I successfully addressed the points you brought up? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 updated this revision to Diff 438669. jackhong12 added a comment. Thanks for your reply! I added comments for each clause. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittest

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

hans added a comment. > Ignoring the `pragma alloc_text`, it looks like GCC compiles the following > `foo` with C linkage vs LLVM which compiles with C++ linkage (foo's name is > mangled): The mangled name shouldn't matter since it has internal linkage. I tried dropping the `static`, and the

[PATCH] D127856: [clangd] Support multiline semantic tokens

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:947 +Out->tokenModifiers = Tok.Modifiers; +Last = Tok; this copy feels gratuitous, can we just use Tokens.back(), or do the

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov updated this revision to Diff 438680. mizvekov edited the summary of this revision. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/S

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. In D126559#3598885 , @hans wrote: >> Ignoring the `pragma alloc_text`, it looks like GCC compiles the following >> `foo` with C linkage vs LLVM which compiles with C++ linkage (foo's name is >> mangled): > > The mangled name sh

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 438682. steplong added a comment. Herald added a project: clang-tools-extra. - Add `-target x86_64-unknown-linux` to `misc-new-delete-overloads.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ ht

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

hans added a comment. > Oh I see, that makes sense. We aren't accepting > https://godbolt.org/z/9Yej9vhYd. Do you know of a way to get the `NamedDecl` > with `extern "C"` instead of the second declaration? I'm not sure I understand the question, but it seems the current code is checking `isExt

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

sammccall added a comment. This is a bit tricky - we'd like to offer more fixes in several scenarios (e.g. replace a header with the transitive includes you're relying on), but some of those require more complex implementation. On one hand, presenting only one automated fix will bias users towa

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:116-117 "source file is not valid UTF-8">; +def warn_invalid_utf8_in_comment : Warning< + "invalid UTF-8 in comment">, InGroup>, DefaultIgnore; def err_character_not_allowed : E

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

sammccall added a comment. FWIW, I think validating the names makes sense but I don't think typo correction pays for itself here. @kadircet? Comment at: clang-tools-extra/clangd/TidyProvider.cpp:291 + static void *call() { +return new tidy::NamesAndOptions(tidy::getAllChe

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438693. sammccall added a comment. Deeper version of LR0, still prototype-quality - use hashtables instead of binary search where appropriate - simplify GLR accordingly - add fast-path reduce to reclaim some of the performance (though "reclaim" is maybe wr

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall added a comment. In D127357#3569386 , @hokein wrote: > Thanks for experimenting this! > >> the size of the LR table is much smaller (In this patch we go from 340kB => >> 120kB, and the encoding isn't efficient) > > This is interesting. I'd expe

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. In D126559#3598950 , @hans wrote: >> Oh I see, that makes sense. We aren't accepting >> https://godbolt.org/z/9Yej9vhYd. Do you know of a way to get the `NamedDecl` >> with `extern "C"` instead of the second declaration? > > I'

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

pmatos created this revision. pmatos added reviewers: asb, tlively. Herald added subscribers: StephenFan, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald adde

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

reames added a comment. In D126461#3597862 , @craig.topper wrote: > `dst` in the patch description is not the pointer being loaded, it's the > pointer of where to store the new_vl. That is only thing being checked for > null in this patch. I agree thi

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. In D128012#3598307 , @Anastasia wrote: > PCH have large in-memory size compared to the sources, but if it's not an > issue then it should be reasonable. Yea... I think we may have some flexibility on memory size. Our current on-d

[PATCH] D125669: Adding support for target in_reduction

ABataev added a comment. What about the description? Shall we still emit ` if(0)`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438701. sammccall added a comment. Herald added a subscriber: mgrang. update tests, trim dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127357/new/ https://reviews.llvm.org/D127357 Files: clang-to

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov updated this revision to Diff 438702. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128112/new/ https://reviews.llvm.org/D128112 Files: clang/test/AST/ast-dump-template-decls.cpp Index: clang/test/AST/ast-d

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438703. sammccall added a comment. remove first/follow, also dead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127357/new/ https://reviews.llvm.org/D127357 Files: clang-tools-extra/pseudo/benchmarks/Bench

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D128072#3598634 , @aaron.ballman wrote: > This sounds like a sensible direction to me. I spot-checked the changes and > they all seem reasonable. Giving my LG, but please wait a bit before landing > in case someone

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl updated this revision to Diff 438709. yaxunl added a comment. add -unwindlib=libgcc by default for --hip-link since -rtlib=compiler-rt needs it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127142/new/ https://reviews.llvm.org/D127142 Files: clang/lib/Driver/ToolChain.cpp c

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet updated this revision to Diff 438711. kadircet marked 4 inline comments as done. kadircet added a comment. Get rid of the copy in common case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127856/new/ https://reviews.llvm.org/D127856 Files

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:947 +Out->tokenModifiers = Tok.Modifiers; +Last = Tok; sammccall wrote: > this copy feels gratuitous, can we just use Tokens.back(), or do the copy in > the r

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith updated this revision to Diff 438718. bsmith added a comment. - Clarify LangRef slightly to make it clearer that fixed types can be used - Rebase on top of recent test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https:/

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

kadircet added a comment. as discussed offline I agree that we should have this, as no matter how hard we try there are going to be cases that we can't get right due to ADL/template instantiations or depending on 3rd party code that cannot be edited and also doesn't have relevant pragmas inside

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438719. omarahmed added a comment. Format files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/d

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

craig.topper added inline comments. Comment at: llvm/docs/LangRef.rst:17289 insert into. Conceptually, this can be used to build a scalable vector out of -non-scalable vectors. +non-scalable vectors, however this intrinsic can also be used on purely fixed +types. ---

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 438722. pmatos added a comment. rebase on top of D128282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clan

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov updated this revision to Diff 438723. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128112/new/ https://reviews.llvm.org/D128112 Files: clang/test/AST/ast-dump-template-decls.cpp Index: clang/test/AST/ast-d

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

samestep added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:66 + SourceLocations Locs; + for (const CFGBlock *Block : Context->getCFG()) { +// Skip blocks that were not evaluated. xazax.hun wrote: > Wh

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

kadircet added a comment. I also agree with the typo correction verdict. In theory there'll be two cases: - typo correction helps, in which case it'll be obvious from the warning itself. - typo correction doesn't help, because the option doesn't exist at all, we'll be just showing a random opt

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Though it also looks like all the WEBASSEMBLY32/WEBASSEMBLY64 lines you're modifying match each other, so could be combined to single `WEBASSEMBLY:` lines. It might be worth doing that while y

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438727. sammccall added a comment. update test/binaries, tests now all pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127357/new/ https://reviews.llvm.org/D127357 Files: clang-tools-extra/pseudo/benchm

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438732. sammccall added a comment. tweak & document fast-path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127357/new/ https://reviews.llvm.org/D127357 Files: clang-tools-extra/pseudo/benchmarks/Benchmark

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127802/new/ https://reviews.llvm.org/D127802

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall updated this revision to Diff 438735. sammccall added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127357/new/ https://reviews.llvm.org/D127357 Files: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp clang-tools-e

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman added a comment. Thanks for this, it seems like an interesting feature! Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:263 +Check the config files to ensure each check and +option is recognised. +)"), Comment a

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall added a comment. Current numbers from my machine: Parse time (`ClangPseudoBenchmark SemaCodeComplete.cpp --benchmark_filter=glrParse --benchmark_min_time=10`) old: glrParse167033209 ns167026892 ns 84 bytes_per_second=2.24031M/s new: glrParse192320371 ns1

[clang] 271cc58 - [NFC] clang: Implement tests for PR56099

Author: Matheus Izvekov Date: 2022-06-21T18:35:17+02:00 New Revision: 271cc588054a90abf0d82f57af272c3db749ff56 URL: https://github.com/llvm/llvm-project/commit/271cc588054a90abf0d82f57af272c3db749ff56 DIFF: https://github.com/llvm/llvm-project/commit/271cc588054a90abf0d82f57af272c3db749ff56.dif

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG271cc588054a: [NFC] clang: Implement tests for PR56099 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

aaron.ballman added a subscriber: beanz. aaron.ballman added a comment. I'm a bit uncomfortable with this as we (at least currently) want to discourage non-terse diagnostics, and allowing newlines encourages longer diagnostics. There's an RFC kicking around about making more expressive diagnosti

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, great catch! That's not something I would have expected to be at the root of this performance issue. Thank you for the quick turnaround on the fix! Repository: rG LLVM G

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

tahonermann added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1600 - llvm::APInt LitVal(PP.getTargetInfo().getIntWidth(), 0); + llvm::APInt LitVal(PP.getTargetInfo().getChar32Width(), 0); sammccall wrote: > tahonermann wrote: > > I don't t

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added subscribers: thakis, rsmith. royjacobson added a comment. In D127593#3598234 , @sberg wrote: > In general, there's still a handful of `__has_trivial_*` calls across > Abseil's recent master branch `absl/meta/type_traits.h`. Breaking ab

[PATCH] D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin

lei created this revision. lei added reviewers: amyk, quinnp, power-llvm-team. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. lei requested review of this revision. Herald added a project: clang. ``vec_replace_unaligned`` is meant to return vuc to emphasize that elements

[PATCH] D127812: [AArch64] Function multiversioning support added.

aaron.ballman added a comment. In D127812#3587223 , @ilinpv wrote: > In D127812#3585249 , @erichkeane > wrote: > >> I'm concerned as to the design of this addition, I don't particularly >> appreciate the reasons

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall added a comment. My current thinking is this is too much overhead to accept. I'm going to try to take some of these ideas and apply them to our SLR(1) implementation, in particular store heads as nodes rather than pending actions. I think it's worth accepting some slowdown for this, wh

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

jsetoain added inline comments. Comment at: llvm/docs/LangRef.rst:17292-17294 +``llvm.vector.insert`` can be used to insert a fixed-width vector into a +scalable vector, but not the other way around. To answer Craig's point, I don't think it was clear before th

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. Thanks for the feedback on corner cases @aaron.ballman, this will give me more concrete things to think about here. At the moment I mainly thinking about a case: typedef int foo; enum : foo {} __attribute__((__clone_attrs_from__(foo))); This is mostly because of how

[clang] 9f499d9 - [HLSL] Support HLSL vector initializers

Author: Chris Bieneman Date: 2022-06-21T12:33:42-05:00 New Revision: 9f499d9d73edfc818978c64eb24b8d2d34995d76 URL: https://github.com/llvm/llvm-project/commit/9f499d9d73edfc818978c64eb24b8d2d34995d76 DIFF: https://github.com/llvm/llvm-project/commit/9f499d9d73edfc818978c64eb24b8d2d34995d76.diff

[PATCH] D127802: [HLSL] Support HLSL vector initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f499d9d73ed: [HLSL] Support HLSL vector initializers (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { pengfei wrote: > rjmccall wrote: > > zahiraam wrote: > > > r

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 438758. jhuber6 added a comment. Adding a test to ensure we no longer write temporary files for unused inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files:

[PATCH] D128249: Adding clone_attrs attribute.

aaron.ballman added a comment. In D128249#3599551 , @plotfi wrote: > Thanks for the feedback on corner cases @aaron.ballman, this will give me > more concrete things to think about here. > > At the moment I mainly thinking about a case: > > typedef int

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. I tried the following: FunctionDecl *FD = ND->getAsFunction(); DeclContext *DC = ND->getDeclContext(); DEBUG_WITH_TYPE("foo", llvm::dbgs() << "[FOO] DC->isExternCContext() : " << DC->isExternCContext() << "\n"); DEBUG_WITH_TYPE("foo", llvm::dbgs(

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

craig.topper added a comment. In D126461#3599122 , @reames wrote: > In D126461#3597862 , @craig.topper > wrote: > >> `dst` in the patch description is not the pointer being loaded, it's the >> pointer of where t

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

craig.topper added a comment. I have attempted to revise the title and description. Please take a look @pcwang-thead and @reames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 __

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 438778. steplong added a comment. Whoops, this is a clang-tidy test, so `-target` won't work here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang-too

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane updated this revision to Diff 438781. erichkeane added a comment. As promised, got it down to the 1 failure, and added tests for @ChuanqiXu and the std::vector example. That all seems to work, just a problem with the CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp test left. CHANGES

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

JonChesterfield added a comment. I've read it but can't promise it's correct - the diff is large and has some spurious noise in it which distracts significantly from the functional changes. Would you be willing to split this into two patches, one which renames variables and moves blocks of cod

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Note that the failure comes down to: template concept C = T::f(); template class P> struct S1{}; template struct X{}; S1 s11; and requires the -frelaxed-template-template-args flag: [ekeane1@scsel-clx-24 build]$ ./bin/clang -cc1 -std=c++20 temp.cpp -frela

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

reames added a comment. @craig.topper Much clearer, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 ___ cfe-commits mailing list cfe-commits@lists.ll

  1   2   >