[clang] f9e4964 - Revert "wip"

Author: Chris Bieneman Date: 2022-06-17T13:36:53-05:00 New Revision: f9e49644f4875ba1807781b1224b3136fefe38e9 URL: https://github.com/llvm/llvm-project/commit/f9e49644f4875ba1807781b1224b3136fefe38e9 DIFF: https://github.com/llvm/llvm-project/commit/f9e49644f4875ba1807781b1224b3136fefe38e9.diff

[PATCH] D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, clang-language-wg, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. When instantiating a class template, if the primary class template speci

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall accepted this revision. rjmccall added a comment. Okay, LGTM then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___ cfe-commits mailing list cfe-comm

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clan

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added a comment. Nice work adding the capability to the dump script. Comment at: clang/docs/ClangFormatStyleOptions.rst:4264 +and opening parentheses. +14 + This seems to be not entirely correct yet. :) Comment at:

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_Binary

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam updated this revision to Diff 438004. saiislam added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128090/new/ https://reviews.llvm.org/D128090 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Dr

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

dcaballe added subscribers: jsetoain, dcaballe. dcaballe added a comment. Hey Bradley! Thanks for pinging us about this upcoming change! Something that my colleague @jsetoain mentioned is that these vector insert/extract intrinsics can also work on fixed-length only vectors. However, the documen

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { zahiraam wrote: > rjmccall wrote: > > `EmitPromoted` should

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 438010. samitolvanen added a comment. Rebased after ToT member function name changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296 Files: clang/docs/Control

[PATCH] D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior

rsmith added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:1315-1316 !FieldRec->hasConstexprDefaultConstructor() && !isUnion()) // The standard requires any in-class initializer to be a constant // expression. We consider this to be a d

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks for taking care of this Roy and helping me out through the process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 ___ cfe

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Made good progress today, but got trapped down the CheckDeducedArgs path for quite a bit longer with partial specializations. I have all of the crashes I know of 'fixed', but have a few tests that still fail for unknown reasons. Because of that, i don't have anythi

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3585681 , @nikic wrote: > FYI this change had a measurable effect on compile-time > (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted by @nikic, D126061 causes a compile time regression of about 0.5% on -O0 builds

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. Fix for compile time regression submitted for review at https://reviews.llvm.org/D128097 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 _

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: egorzhdan. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, each job would overwrite the -MJ file. This didn't q

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman added a comment. Created Github issue to track: https://github.com/llvm/llvm-project/issues/56096 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe

[clang] 7bc00ce - [clang-repl] Remove memory leak of ASTContext/TargetMachine.

Author: Sunho Kim Date: 2022-06-18T06:36:25+09:00 New Revision: 7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56 URL: https://github.com/llvm/llvm-project/commit/7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56 DIFF: https://github.com/llvm/llvm-project/commit/7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56.diff LOG

[PATCH] D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bc00ce5cd41: [clang-repl] Remove memory leak of ASTContext/TargetMachine. (authored by sunho). Herald added a project: clang. Herald added a subscri

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "o

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

jansvoboda11 added a comment. Thanks for the review! Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=

[clang] 92c6ffa - [clang][driver] Ensure we don't accumulate entries in -MJ files

Author: Jan Svoboda Date: 2022-06-18T00:00:43+02:00 New Revision: 92c6ffa14cdeb3edd50b46d30c830698705db9f5 URL: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5 DIFF: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5.diff L

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92c6ffa14cde: [clang][driver] Ensure we don't accumulate entries in -MJ files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHA

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

tschuett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128098/new/ https://reviews.llvm.org/D128098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3546535 , @dblaikie wrote: > In D123319#3532811 , @dblaikie > wrote: > >> Ping > > @aprantl thoughts on this? Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud created this revision. t-rasmud added reviewers: NoQ, usama54321. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. t-rasmud requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added a comment. In D127142#3592207 , @yaxunl wrote: > In D127142#3590874 , @yaxunl wrote: > >> In D127142#3571260 , @MaskRay >> wrote: >> >>> In D127142#3570290

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

MaskRay added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=arm64-apple-macosx12.0.0

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Matcher tests are written as unittests in `unittests/ASTMatchers`, I don't think you need to make an entire new check for that hmmm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 _

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, krytarowski, arichardson. H

[PATCH] D128064: [Static Analyzer] Small array binding policy

NoQ added a comment. Another magic number around these parts is 4, which is our loop iteration budget. If an array is initialized by a loop with unknown bounds, it'll have 4 bindings. So I think it makes sense to reduce the default to 4 just because weird things may start happening above this t

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Please add a test. Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159 + if (ToolChain.getArch() == llvm::Triple::riscv64) +CmdArgs.push_back("-X");

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad added a comment. I will add a test. Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159 + if (ToolChain.getArch() == llvm::Triple::riscv64) +CmdArgs.push_back("-X"); MaskRay wrote: > isRISCV > > If OpenBSD gets riscv32, it'd need -X, too. There

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. In D123319#3517966 , @dblaikie wrote: > In D123319#3506745 , @shafik wrote: > >> > > What does the linkage name do for your use case? Which cases are missing > linkage names/where do the

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438070. brad added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.c

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438071. brad added a comment. Minus the new white space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Dr

[PATCH] D127207: [flang][driver] Fix support for `-x`

sunho added a comment. Hi! I'm not exactly sure what's going on. But, seems like build is failing here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127207/new/ https://reviews.llvm.org/D12

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438075. brad added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.

[clang] 8fc3d71 - Stop wrapping GCCAsmStmts inside StmtExprs to destruct temporaries

Author: Akira Hatanaka Date: 2022-06-17T17:28:00-07:00 New Revision: 8fc3d719eee7ab41641506cbdc59f3ade0eb36e4 URL: https://github.com/llvm/llvm-project/commit/8fc3d719eee7ab41641506cbdc59f3ade0eb36e4 DIFF: https://github.com/llvm/llvm-project/commit/8fc3d719eee7ab41641506cbdc59f3ade0eb36e4.diff

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc3d719eee7: Stop wrapping GCCAsmStmts inside StmtExprs to destruct temporaries (authored by ahatanak). Changed prior to commit: https://reviews.

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438073. mizvekov retitled this revision from "clang: fix pack substitution scope in function params" to "clang: fix checking parameter packs for expansion.". mizvekov edited the summary of this revi

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

MaskRay added inline comments. Comment at: clang/test/Driver/openbsd.c:133 +// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s +// CHECK-RISCV64-FLAGS: "-X" It's useful to check other values like the `-m` emulation and the dynamic linker. Repository:

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/docs/ReleaseNotes.rst:491 +- Support for ``AVX512-FP16`` instructions has been added. +- Support for ``_Float16`` type has been added. This line doesn't need anymore. Comment at: clang/lib/Basi

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mizvekov updated this revision to Diff 438089. mizvekov added a comment. mizvekov published this revision for review. mizvekov added reviewers: rsmith, v.g.vassilev. Herald added a project: clang.

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438084. mizvekov added a comment. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . Signed-off-by: Matheus Izvekov Repository

<    1   2