[PATCH] D127745: [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue.

2022-06-14 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97d69cdaf324: [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue. (authored by wyt, committed by gribozavr). Repository

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

2022-06-14 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 _

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

2022-06-14 Thread Nicolas van Kempen via Phabricator via cfe-commits
nicovank created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. nicovank retitled this revision from "[clang-tidy] Remove encode when outputting tool ouput running tests" to "[clang-tidy] Properly forward clang-tidy output when running tests". nicovank updated t

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436985. steplong added a comment. - Change logic for /Zc:alignedNew and /Zc:sizedDealloc - Add tests for different /std:c++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D1

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. I will fix it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 7fae15f - Revert "[Driver] Improve linking options for target AVR"

2022-06-14 Thread Haowei Wu via cfe-commits
Author: Haowei Wu Date: 2022-06-14T17:53:46-07:00 New Revision: 7fae15f9251d3b392058e2fc84898b53619d36ad URL: https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad DIFF: https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad.diff LOG

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-14 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. In D127182#3582540 , @jansvoboda11 wrote: > Should we add a FIXME saying we need to handle other kinds of attributes? There already is one where we call `mergeInheritableAttributes`. Repository: rG LLVM Github Monorepo CH

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. I already reverted the change in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad . It is likely the breakage is caused by the fact that Fuchsia's Clang by default use `lld`, see `clang/cmake/caches/Fuchsia-stage2.cmake:set(CLANG_DEFA

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: haowei, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. I think I have fixed in another patch https://reviews.llvm.org/D127814, could you please have a look? @haowei I have not your environment, my patch works on my ubuntu system, could you please try it on your build machine ? Repository: rG LLVM Github Monorepo CHA

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 436992. benshi001 added a reviewer: haowei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Dr

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D126192#3583795 , @haowei wrote: > I already reverted the change in > https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad > . It is likely the breakage is caused by the fact that Fuchsia's C

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

2022-06-14 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. I tested this patch on top of https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 (reverted in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad) and Clang driver tests now pass without issue. Reposit

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D127814#3583854 , @haowei wrote: > I tested this patch on top of > https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 > (reverted in > https://github.com/llvm/llvm-project/commit/7fae15f92

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. Emmm, I applied your latest patch on top of main(6e02e27536b9de25a651cfc9c2966ce471169355 ) but I still get a test failure on `Clang :: Driver/avr-toolchain.c`. `Clang :: Driver/avr-ld.c` no longer fai

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

2022-06-14 Thread Fazlay Rabbi via Phabricator via cfe-commits
mdfazlay updated this revision to Diff 436994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127454/new/ https://reviews.llvm.org/D127454 Files: clang/bindings/python/clang/cindex.py clang/include/clang-c/Index.h clang/include/clang/AST/Recurs

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

2022-06-14 Thread Fazlay Rabbi via Phabricator via cfe-commits
mdfazlay added inline comments. Comment at: clang/include/clang-c/Index.h:2641 */ - CXCursor_TranslationUnit = 300, + CXCursor_TranslationUnit = 350, ABataev wrote: > Does this change affect anything else in the compiler? We had to add and keep the CXCurs

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D126192#3583886 , @haowei wrote: > Emmm, I applied your latest patch on top of > main(6e02e27536b9de25a651cfc9c2966ce471169355 > ) but I > still get a te

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. It seems the file `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` is missing on your machine, which I have newly created in current patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.

[clang] af9ee33 - [HIP] fix long double size

2022-06-14 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-06-14T21:57:56-04:00 New Revision: af9ee3357cec931af68a3a0bb83e82de977caa37 URL: https://github.com/llvm/llvm-project/commit/af9ee3357cec931af68a3a0bb83e82de977caa37 DIFF: https://github.com/llvm/llvm-project/commit/af9ee3357cec931af68a3a0bb83e82de977caa37.dif

[PATCH] D127771: [HIP] fix long double size

2022-06-14 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9ee3357cec: [HIP] fix long double size (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. In D126192#3583915 , @benshi001 wrote: > It seems the file > `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` > is missing on your machine, which I have newly created in current patch. That

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D126192#3583924 , @haowei wrote: > In D126192#3583915 , @benshi001 > wrote: > >> It seems the file >> `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin

[PATCH] D126192: [Driver] Improve linking options for target AVR

2022-06-14 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. I tested this patch on our windows builder and it passed as well. This patch LGTM. (I cannot click accept as the this review is already closed) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 __

[clang] 753b915 - [Driver] Improve linking options for target AVR

2022-06-14 Thread Ben Shi via cfe-commits
Author: Ben Shi Date: 2022-06-15T02:57:31Z New Revision: 753b915167bd40375e879866c66be14b7b6a8db8 URL: https://github.com/llvm/llvm-project/commit/753b915167bd40375e879866c66be14b7b6a8db8 DIFF: https://github.com/llvm/llvm-project/commit/753b915167bd40375e879866c66be14b7b6a8db8.diff LOG: [Driv

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-14 Thread Namgoo Lee via Phabricator via cfe-commits
nlee updated this revision to Diff 437011. nlee added a comment. Warn if: - It is an assignment expression AND - RHS is a function call expression AND - The function returns by-const-value of a class or struct type AND - The class or struct has non-trivial move assignment operator Removed `defau

[PATCH] D127812: [AArch64] Function multiversioning support added.

2022-06-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + This file is auto-generated. Don't touch it. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1173 return None; - case ARM::BI_B

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

2022-06-14 Thread Javier Alvarez via Phabricator via cfe-commits
Javier-varez updated this revision to Diff 437033. Javier-varez added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 Files: clang-tools-extra/test/clang-tidy/checkers/moderniz

[clang] 07b3446 - [clang-format] Never analyze insert/remove braces in the same pass

2022-06-14 Thread via cfe-commits
Author: owenca Date: 2022-06-14T22:42:54-07:00 New Revision: 07b3446d72436c8372f50c43b45e46efe63182d9 URL: https://github.com/llvm/llvm-project/commit/07b3446d72436c8372f50c43b45e46efe63182d9 DIFF: https://github.com/llvm/llvm-project/commit/07b3446d72436c8372f50c43b45e46efe63182d9.diff LOG: [

[PATCH] D127685: [clang-format] Never analyze insert/remove braces in the same pass

2022-06-14 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b3446d7243: [clang-format] Never analyze insert/remove braces in the same pass (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

2022-06-14 Thread Martin Böhme via Phabricator via cfe-commits
mboehme marked 2 inline comments as done. mboehme added a comment. Thank you @aaron.ballman and @rsmith for the careful and productive reviews! Comment at: clang/lib/Parse/ParseStmt.cpp:229 default: { +bool HaveAttrs = !(CXX11Attrs.empty() && GNUAttrs.empty()); +auto

[PATCH] D127589: [Driver][test] Make RISCV tests robust with PATH=

2022-06-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > unknown-linux-gnu-ld riscv64-unknown-linux-gnu-ld. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D1275

[PATCH] D127270: [clang-format] Add space in placement new expression

2022-06-14 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Does this patch really fix https://github.com/llvm/llvm-project/issues/54703? If so, please add test for it. Otherwise remove the link from the summary (and if possible handle it in another review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] 3ecfeb4 - [clangd] Wire up compilation for style blocks

2022-06-14 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2022-06-15T08:15:32+02:00 New Revision: 3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4 URL: https://github.com/llvm/llvm-project/commit/3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4 DIFF: https://github.com/llvm/llvm-project/commit/3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4.dif

[PATCH] D127749: [clangd] Wire up compilation for style blocks

2022-06-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ecfeb4c2f45: [clangd] Wire up compilation for style blocks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127749/new/ https://review

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

2022-06-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp

2022-06-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

<    1   2   3