[PATCH] D127614: [clang-format] Handle more cases for RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Call mightFitO

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille marked 4 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/object-size-flex-array.c:34 + // CHECK: ret i32 % + // CHECK-STRICT: ret i32 % + return OBJECT_SIZE_BUILTIN(f->c, 1); kees wrote: > Shou

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Looks good on my side, waiting for feedback ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske marked an inline comment as done. balazske added a comment. Ping I have a question with Objective-C support. @njames93 Could you look at this again? Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:126 const LangOptions &LangOpts) const { -

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

uabelho added a comment. Hi, I noticed that on one of our downstream (not public) buildbots the clang/test/Driver/femit-dwarf-unwind.s test seems to fail rather randomly. So if I run clang -target x86_64-apple-macos11.0 -c ../clang/test/Driver/femit-dwarf-unwind.s -o foo.o llvm-objdump

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Will continue looking at the implementation tomorrow, for now a few minor comments and a suggested variation on a testcase. Comment at: clang-tools-extra/clangd/AST.h:19 #include "clang/AST/DeclObjC.h" +#include "clang/AST/Expr.h" #include "clang/AST/

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added a comment. Is there anything else that needs to happen on this change before it's ready to land? There is some breakage in the pre-merge checks, but it looks as if it's pre-existing breakage. See the comment-only change here that looks as if it exhibits similar breakage: https:/

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. @aaron.ballman Any further comments from you on this change? There is some breakage in the pre-merge checks, but it looks as if it's pre-existing breakage. See the comment-only change here that looks as if it exhibits similar breakage: https://reviews.llvm.org/D127494

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added inline comments. Comment at: flang/test/Driver/linker-flags-windows.f90:6 +! NOTE: The additional linker flags tested here are currently specified in +! clang/lib/Driver/Toolchains/MSVC.cpp. +! REQUIRES: windows-msvc mmuetzel wrote: > Since this te

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. I had the same idea about switching the tests to using target triples instead of having separate files for it, but initially I had some issues getting that to work properly. When specifying a triple, we need to provide an architecture. Leaving the triple as `unkown-linux-

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 436300. rovka added a comment. Herald added a subscriber: ormris. - Switch to the new style of testing (using triples rather than separate files) - Fix oversight in Darwin toolchain file I hope I've addressed all the comments and nothing slipped past during reb

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 436301. rovka added a comment. Missed a spot (removing the namespace in MinGW.cpp) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolC

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3577133 , @rovka wrote: > I had the same idea about switching the tests to using target triples instead > of having separate files for it, but initially I had some issues getting that > to work properly. When specify

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3572796 , @mmuetzel wrote: > In D126291#3572777 , @rovka wrote: > >> Moved the check for `-flang-experimental-exec` into >> addFortranRuntimeLibraryPath, so it affects all the to

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. Here's the preliminary list of mappings I've identified: "bits/align.h", "" "bits/atomic_wait.h", "" "bits/atomic_timed_wait.h", "" "bits/boost_concept_check.h", "" "bits/charconv.h", "" "bits/chrono.h", "" "bits/cow_string.h", "" "bits/fs_dir

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6119053dab67: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github Monorep

[clang] 6119053 - [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

Author: Lucas Prates Date: 2022-06-13T10:21:06+01:00 New Revision: 6119053dab67129eb1700dbf36db3524dd3e421f URL: https://github.com/llvm/llvm-project/commit/6119053dab67129eb1700dbf36db3524dd3e421f DIFF: https://github.com/llvm/llvm-project/commit/6119053dab67129eb1700dbf36db3524dd3e421f.diff

[PATCH] D127624: [C++20][Modules] Allow for redeclarations in partitions.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. this is really a bug fix, rather than a new feature - the cu

[clang] 33b9ad6 - Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records"

Author: Lucas Prates Date: 2022-06-13T11:00:49+01:00 New Revision: 33b9ad647e9142c8e48f51c3067bf2340b8416c3 URL: https://github.com/llvm/llvm-project/commit/33b9ad647e9142c8e48f51c3067bf2340b8416c3 DIFF: https://github.com/llvm/llvm-project/commit/33b9ad647e9142c8e48f51c3067bf2340b8416c3.diff

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3577159 , @mstorsjo wrote: > In D126291#3577133 , @rovka wrote: > >> I had the same idea about switching the tests to using target triples >> instead of having separate files for

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. In D126291#3577133 , @rovka wrote: > I had the same idea about switching the tests to using target triples instead > of having separate files for it, but initially I had some issues getting that > to work properly. Could you

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. 🤔 linker-flags.f90 is failing on Windows in the pre-commit CI. Not sure why - seems fine on Debian. Comment at: flang/test/Driver/linker-flags.f90:28 +! GNU-SAME: -lFortranDecimal +! WITHLM-SAME: -lm + Does `-SAME` makese sense here

[clang] b4f2f7b - [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

Author: David Truby Date: 2022-06-13T10:22:10Z New Revision: b4f2f7bebd29f7cedd3ce93c1925e8029b8e2b05 URL: https://github.com/llvm/llvm-project/commit/b4f2f7bebd29f7cedd3ce93c1925e8029b8e2b05 DIFF: https://github.com/llvm/llvm-project/commit/b4f2f7bebd29f7cedd3ce93c1925e8029b8e2b05.diff LOG: [

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f2f7bebd29: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. furkanusta requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes clangd issue #1137 Re

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta added a comment. I wasn't sure if I should add a URL to the commit message for easy access but here is the corresponding clangd issue: https://github.com/clangd/clangd/issues/1137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127629/new

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Oh dear. Hmm does running the test with ASAN enabled hit any memory issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commit

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Actually let me try it now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. Comment at: clang/lib/Format/FormatToken.h:982 kw_always = &IdentTable.get("always"); kw_always_com

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:323-329 + if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) { +Opts.EmitDwarfUnwind = +llvm::StringSwitch(A->getValue()) +.Case("always", EmitDwarfUnwindType::Always) +

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

uabelho added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:323-329 + if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) { +Opts.EmitDwarfUnwind = +llvm::StringSwitch(A->getValue()) +.Case("always", EmitDwarfUnwindType::Always) +

[PATCH] D127630: [MC] Fix likely uninitialized memory bug

int3 created this revision. int3 added reviewers: lld-macho, uabelho. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See https://reviews.llvm.org/D122258#inline-1223493. I can't repro the issue locally but

[PATCH] D127630: [MC] Fix likely uninitialized memory bug

uabelho accepted this revision. uabelho added a comment. This revision is now accepted and ready to land. As I haven't been able to reproduce the problem manually myself I can't confirm that this fixes the problem, but it does seem likely. Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew updated this revision to Diff 436338. andrew added a comment. Update the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Dri

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew added a comment. I'll leave it to someone else to get non-FreeBSD working as it's unlikely I'll have time to fix them in the hear future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 __

[clang] aebe24a - [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

Author: wangpc Date: 2022-06-13T19:12:15+08:00 New Revision: aebe24a856d2f40284d940970d4e159319dbb90f URL: https://github.com/llvm/llvm-project/commit/aebe24a856d2f40284d940970d4e159319dbb90f DIFF: https://github.com/llvm/llvm-project/commit/aebe24a856d2f40284d940970d4e159319dbb90f.diff LOG: [

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGaebe24a856d2: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h (authored by pcwang-thead). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ h

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. I'm guessing the Windows precommit is failing because --ld-path is ignored on Windows, even if we use a Linux target? I have a fix that works on my Windows machine, coming right up. Comment at: flang/test/Driver/linker-flags.f90:28 +! GNU-SAME: -lFortra

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 436340. rovka added a comment. - Stop using --ld-path, since it seems to be ignored on Windows. Instead, just match any path that ends in ld (should work with ld, lld, gold). This isn't very robust, but I don't have any better ideas (other than actually suppor

[clang] c12577c - [clang][driver] Introduce new -fdriver-only flag

Author: Jan Svoboda Date: 2022-06-13T13:30:56+02:00 New Revision: c12577c61dbf37b1b6ae25ed422a900ac71f18fe URL: https://github.com/llvm/llvm-project/commit/c12577c61dbf37b1b6ae25ed422a900ac71f18fe DIFF: https://github.com/llvm/llvm-project/commit/c12577c61dbf37b1b6ae25ed422a900ac71f18fe.diff L

[clang] a856700 - [clang][driver] Fix compilation database dump with multiple architectures

Author: Jan Svoboda Date: 2022-06-13T13:30:57+02:00 New Revision: a85670001ba2487988839656299771915ebc7633 URL: https://github.com/llvm/llvm-project/commit/a85670001ba2487988839656299771915ebc7633 DIFF: https://github.com/llvm/llvm-project/commit/a85670001ba2487988839656299771915ebc7633.diff L

[PATCH] D127408: [clang][driver] Introduce new -fdriver-only flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGc12577c61dbf: [clang][driver] Introduce new -fdriver-only flag (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D127408?vs=435569&id=436342#toc Repository: rG LLVM Github

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa85670001ba2: [clang][driver] Fix compilation database dump with multiple architectures (authored by jansvoboda11). Repository: rG LLVM Github Mon

[clang] 0f6f429 - Revert "[RISCV] Add vread_csr and vwrite_csr to riscv_vector.h"

Author: wangpc Date: 2022-06-13T19:31:25+08:00 New Revision: 0f6f4295d10fe8cc9c3933b85dc9a66b840e3eca URL: https://github.com/llvm/llvm-project/commit/0f6f4295d10fe8cc9c3933b85dc9a66b840e3eca DIFF: https://github.com/llvm/llvm-project/commit/0f6f4295d10fe8cc9c3933b85dc9a66b840e3eca.diff LOG: R

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead updated this revision to Diff 436344. pcwang-thead added a comment. Add `REQUIRES` to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 Files: clang/include/clang/Basic/riscv_vector.td

[clang] e4a21e1 - [MC] Fix likely uninitialized memory bug

Author: Jez Ng Date: 2022-06-13T07:41:17-04:00 New Revision: e4a21e1644f2015dd4f9c3a7c67378879aa912cc URL: https://github.com/llvm/llvm-project/commit/e4a21e1644f2015dd4f9c3a7c67378879aa912cc DIFF: https://github.com/llvm/llvm-project/commit/e4a21e1644f2015dd4f9c3a7c67378879aa912cc.diff LOG: [

[PATCH] D127630: [MC] Fix likely uninitialized memory bug

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4a21e1644f2: [MC] Fix likely uninitialized memory bug (authored by int3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127630/new/ https://reviews.llvm.or

[clang] 2de36d0 - [clang][driver] Only run multi-arch tests on Darwin

Author: Jan Svoboda Date: 2022-06-13T14:03:23+02:00 New Revision: 2de36d0369a5107a3f02aceebb55326adf4ad2cb URL: https://github.com/llvm/llvm-project/commit/2de36d0369a5107a3f02aceebb55326adf4ad2cb DIFF: https://github.com/llvm/llvm-project/commit/2de36d0369a5107a3f02aceebb55326adf4ad2cb.diff L

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

tbaeder added a comment. LGTM but can you try re-running the pre-commit CI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 ___ cfe-commits mailing list cfe-com

[clang] 93b4a41 - [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

Author: wangpc Date: 2022-06-13T20:38:52+08:00 New Revision: 93b4a41b55102fb400ef6507068148761bb10be1 URL: https://github.com/llvm/llvm-project/commit/93b4a41b55102fb400ef6507068148761bb10be1 DIFF: https://github.com/llvm/llvm-project/commit/93b4a41b55102fb400ef6507068148761bb10be1.diff LOG: [

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93b4a41b5510: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h (authored by pcwang-thead). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

kadircet added a reviewer: kadircet. kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1269 if (const auto *Using = dyn_cast(R.Declaration)) { CodeCompletionResult Result(Using->getTargetDecl(), getBasePriorit

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

kadircet added a comment. Also if you put `Fixes https://github.com/clangd/clangd/issues/1137` in the commit message, it'll automatically close the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127629/new/ https://reviews.llvm.org/D127629

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. Since `*.tcc` files are mapped as well and there are only a few of them missing, should I add them as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 _

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel marked an inline comment as done. ymandel added a comment. Ping... Gabor, Stanislav: what are your thoughts on this patch? I think we're in a place where I could do performance comparisons before/after if you think that's justified. Alternatively, I have a relatively simple proposal for

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta updated this revision to Diff 436369. furkanusta added a comment. [clang] Use correct visibility parameters when following a Using declaration Fixes https://github.com/clangd/clangd/issues/1137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders added a comment. One week gentle ping. + added reviewers from the https://reviews.llvm.org/D111400 patch that fixed the bug these tests covers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127201/new/ https://reviews.llvm.org/D127201 ___

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

Jake-Egan added a comment. Hi, it seems on AIX the target and arch options are ignored, so we don't get the expected output for this test. Any ideas about the course of action we should take? https://lab.llvm.org/buildbot/#/builders/214/builds/1785/steps/6/logs/FAIL__Clang__compilation_database_

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong added a comment. Hmm do you know how I can restart the pre-merge checks? It looks like the x64 debian openmp tests failed. I don't think this patch is related, but I want to make sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/n

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger updated this revision to Diff 436377. falbrechtskirchinger added a comment. Add more missing headers to the system header map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 Files:

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added a comment. In D121997#3577690 , @Jake-Egan wrote: > Hi, it seems on AIX the target and arch options are ignored, so we don't get > the expected output for this test. Any ideas about the course of action we > should take? > https://lab

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 436378. iains marked 2 inline comments as done. iains added a comment. rebased, fixed the fail for explicitly-specialized-template.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https://reviews.ll

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

hans added a comment. In D127452#3577729 , @steplong wrote: > Hmm do you know how I can restart the pre-merge checks? It looks like the x64 > debian openmp tests failed. I don't think this patch is related, but I want > to make sure You can rebase and

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 updated this revision to Diff 436380. jansvoboda11 added a comment. Replace the `Dir = File->getLastRef().getDir();` escape hatch with `FileMgr.getOptionalDirectoryRef(File->getDir()->getName())`. The former was causing failures in `clang/test/VFS/real-path-found-first.m` on Window

[clang] 35aaf54 - [clang][driver] fix to correctly set devtoolset on RHEL

Author: Quinn Pham Date: 2022-06-13T09:12:49-05:00 New Revision: 35aaf548237a4f213ba9d95de53b33c5ce1eadce URL: https://github.com/llvm/llvm-project/commit/35aaf548237a4f213ba9d95de53b33c5ce1eadce DIFF: https://github.com/llvm/llvm-project/commit/35aaf548237a4f213ba9d95de53b33c5ce1eadce.diff LO

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35aaf548237a: [clang][driver] fix to correctly set devtoolset on RHEL (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1314 LLVMStyle.SpaceBeforeParensOptions.AfterIfMacros = true; + LLVMStyle.SpaceBeforeParensOptions.AfterPlacementNew = true; LLVMStyle.SpaceBeforeRangeBasedForLoopColon = true; --

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder created this revision. tbaeder added reviewers: dblaikie, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/55962 i.e. instead

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains marked 3 inline comments as done. iains added a comment. In D126694#3576853 , @ChuanqiXu wrote: > In D126694#3576602 , @iains wrote: > >> @ChuanqiXu - I changed the module ownership name to "ModuleDiscardabl

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11422 llvm::APSInt Left = LHSResult.Val.getInt(); // If LHS does not have a signed type and non-negative value ... to early her

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added a comment. The code changes and test updates all look good to me. Please add a release note to `clang/docs/ReleaseNotes.rst`; I'll be happy to approve after that is done. It would be great to get an additional approval on this; I'm not an expert here. Repository: rG LLVM

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11425-11426 // then, the behavior is undefined before C++2a. Warn about it. if (Left.isNegative() && !S.getLangOpts().isSignedOverflowDefined() && !S.getLangOpts().CPlusPlus20) { S.DiagRun

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

erichkeane added a comment. In D127593#3576538 , @royjacobson wrote: > Hi Javier, thank you for submitting this patch! > > As far as I could tell, this patch implements the CWG2171 defect report from > 2016: https://www.open-std.org/jtc1/sc22/wg21/docs/

[PATCH] D127519: [clang-cl] Accept /FA[c][s][u], but ignore the arguments

hans added a comment. > Previously, /FAsc would emit a warning. Now, it will just do what /FA does. I suppose we could still warn that the 's' and 'c' parts are ignored.. though I suppose that becomes evident from the output file.. If we're going to treat them the same, how about just making th

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch doesn't turn on all the "on by default" /Zc arguments, but this should be a good enough starting point. https:

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

ldionne accepted this revision as: libc++abi. ldionne added a comment. LGTM for libc++abi once my comment is addressed, which should make the libc++ CI pass. Please don't submit this until you have a green check-mark from the libc++ CI. Comment at: llvm/include/llvm/ADT/Tripl

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

steplong added reviewers: rnk, hans, thakis. steplong added a comment. I'm not sure how to check for `/std:` at this stage to turn on arguments like `/Zc:alignedNew` Comment at: clang/test/Driver/cl-zc.cpp:98 // thread safe statics are off for versions < 19. // RUN: %clang_c

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong updated this revision to Diff 436394. steplong added a comment. - Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 Files: clang/include/clang/Driver/Options.td clang/test/Driver/c

[PATCH] D127201: [clang] Add tests for statement expression in initializers

erichkeane added a comment. The command line on one of the tests is a little strange to me, and I don't see the need for the -std=gnu11 on either, but the test content itself looks fine enough to me. Comment at: clang/test/CodeGen/stmtexpr-init.c:1 +// RUN: %clang_cc1 -O -std

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added inline comments. Comment at: flang/test/Driver/linker-flags.f90:28 + +! GNU-WITHOUTLM-LABEL: "{{.*}}ld" +! GNU-WITHOUTLM-SAME: "[[object_file]]" I think that GNU in this case might be a bit misleading. These linker invocations are defined in a

[clang] d9390b6 - Reapply "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()"

Author: Jan Svoboda Date: 2022-06-13T17:03:32+02:00 New Revision: d9390b6ac387345e7d3348bfc648929bc349d6b1 URL: https://github.com/llvm/llvm-project/commit/d9390b6ac387345e7d3348bfc648929bc349d6b1 DIFF: https://github.com/llvm/llvm-project/commit/d9390b6ac387345e7d3348bfc648929bc349d6b1.diff L

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 436396. pratlucas added a comment. Fixing assertion failure caused by incorrect use of tSTRr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files: clang/include

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

aaron.ballman added a comment. In D126061#3577054 , @mboehme wrote: > @aaron.ballman Any further comments from you on this change? Mostly just nits from me at this point, plus some answers to questions I had missed previously. > There is some breakage

[PATCH] D127646: [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true to svalbuilder-rearrange-comparisons.c

martong created this revision. martong added reviewers: vabridgers, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a p

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the return/argument types of `ModuleMap::{load,lookup

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436399. serge-sans-paille added a comment. - quiet output of the table conversion program when everything goes well - cross-compilation support (untested) - fix identifier retrieving CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille reopened this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. cc @thakis CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commit

[PATCH] D127201: [clang] Add tests for statement expression in initializers

aaron.ballman added a comment. Thanks for adding some more test coverage! Would it be worth mentioning the miscompile fix in the release notes more explicitly? Comment at: clang/test/Sema/stmtexpr-init.c:1 +// RUN: %clang_cc1 -verify -fsyntax-only -std=gnu11 %s + -

[PATCH] D127648: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the argument type of `ModuleMap::inferFrameworkModule(

[PATCH] D127649: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

martong created this revision. martong added reviewers: vabridgers, steakhal, NoQ, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) ckandeler wrot

[PATCH] D127651: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This patch changes the argument type of `ModuleMap::par

[PATCH] D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the type of `Module::Directory` from `const DirectoryE

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

jolanta.jensen created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Libraries use this flag to decide whether to use the fma builtin. Au

[clang] 1054a73 - [Clang] Change host/device only compilation to a driver mode

Author: Joseph Huber Date: 2022-06-13T11:33:54-04:00 New Revision: 1054a7318788beb99536d84b34f84fccf2289769 URL: https://github.com/llvm/llvm-project/commit/1054a7318788beb99536d84b34f84fccf2289769 DIFF: https://github.com/llvm/llvm-project/commit/1054a7318788beb99536d84b34f84fccf2289769.diff

[PATCH] D127515: [Clang] Change host/device only compilation to a driver mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1054a7318788: [Clang] Change host/device only compilation to a driver mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Since there are many moving pieces and the whole framework is experimental without many users, I'm fine with landing this as is as long we are tracking the improvement opportunities (tic

[PATCH] D127658: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces some calls to the deprecated `DirectoryEntry::getName

[PATCH] D127660: [clang][lex] NFCI: Use DirectoryEntryRef in MainFileDir::MainFileDir

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the type of `Preprocessor::MainFileDir` from `const D

[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:362-364 - /// Retrieves and sets the UserMode. This is a high-level option, - /// which is used to set other low-level options. It is not accessible - /// outside of AnalyzerOp

  1   2   3   >