[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. @nikic ping, can you confirm this current patch works for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 ___ cfe-commits mailing

[PATCH] D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Run clang-form

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1060 LocalInstantiationScope Scope(SemaRef); + auto EarlySubstitutionScope = getEarlySubstitutionRAII(); mark Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

nemanjai added a comment. In D127310#3567472 , @MaskRay wrote: > Do you have more authoritative answer when /root/usr is used and when it > isn't? These suffixes were always part of the code and the mentioned changeset removed it without any justificat

[PATCH] D127093: [clang][pseudo] Add missing Support lib to cxx

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Obsoleted by D127269 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127093/new/ https://reviews.llvm

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added a comment. > These functions are not available in libgcc but in libclang_rt.builtins. > Therefore --hip-link needs to link with libclang_rt.builtins by default. I think this is problematic. The current link sequence is `... "-lamdhip64" "/tmp/Debug/lib/clang/15.0.0/lib/linux/libc

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3566633 , @erichkeane wrote: > All of the comments from @ChuanqiXu done, thank you so much! > > As far as the crash you're seeing: That is typically a 'depth mismatch' kinda > thing. They sadly only show up when th

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 435409. Sockke edited the summary of this revision. Sockke added a comment. Fix test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemb

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:442-444 +} + } else if (FD->getTemplatedKind() == FunctionDecl::TK_MemberSpecialization || + FD->getTemplatedKind() == FunctionDecl::TK_DependentNonTemplate) { erichkeane

[PATCH] D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks

jmciver closed this revision. jmciver added a comment. Obsoleted by D127269 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127271/new/ https://reviews.llvm.org/D127271

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. Gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126495/new/ https://reviews.llvm.org/D126495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. Is it possible to move this back from "Closed" state to "Needs Review"? The merge has been rolled back due to a defect in the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235

[PATCH] D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET

MaskRay added a comment. This behavior requires that all participating modules have the module flag. In the absence of the module flag, what should be behavior be? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123493/new/ https://reviews.llvm.org/

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

njames93 added a comment. In D126495#3568998 , @LegalizeAdulthood wrote: > Gentle ping My previous point about the links in the header files not being updated hasn't been addressed. It would also be nice if there was a redirect that would dynamically

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

tbaeder added a comment. In D127310#3568777 , @nemanjai wrote: > In D127310#3567472 , @MaskRay wrote: > >> Do you have more authoritative answer when /root/usr is used and when it >> isn't? > > These suffixes wer

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This speeds up preprocessing, specifically for preprocessing the clang sources time is reduced by about -36%, using measure

[clang] e6a76a4 - [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

Author: Bruno Cardoso Lopes Date: 2022-06-08T23:13:39-07:00 New Revision: e6a76a49356efd11f5f36690181f0f60cecb2e01 URL: https://github.com/llvm/llvm-project/commit/e6a76a49356efd11f5f36690181f0f60cecb2e01 DIFF: https://github.com/llvm/llvm-project/commit/e6a76a49356efd11f5f36690181f0f60cecb2e01

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6a76a49356e: [Clang][CoverageMapping] Fix compile time explosions by adjusting only… (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1273

[PATCH] D126740: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! (I was a bit confused by the refactoring of `computeBuiltinTypes` but it is definitely better this way) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D126741: [RISCV][Clang] Refactor RISCVVEmitter. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126741/new/ https://reviews.llvm.org/D126741 _

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead added a comment. In D126461#3566626 , @khchen wrote: > IMO, if I'm an user, I would not expected intrinsic function will generate > the condition code to impact the performance, maybe we need to raise a issue > in rvv-intrinsic-doc. > maybe

[PATCH] D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:25442 "} while (hasMore() && Filter(*I));", - "do { ++I; } while (hasMore() && Filte

[clang] 7e17e15 - clang: Introduce -fexperimental-max-bitint-width

Author: Matthias Gehre Date: 2022-06-09T07:15:03+01:00 New Revision: 7e17e15c9f01a04283524c6a6735d639aac39fe6 URL: https://github.com/llvm/llvm-project/commit/7e17e15c9f01a04283524c6a6735d639aac39fe6 DIFF: https://github.com/llvm/llvm-project/commit/7e17e15c9f01a04283524c6a6735d639aac39fe6.diff

[PATCH] D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This is a huge number of test changes so I have checked a subset of files but the changes seems reasonable, as I imagine they're generated mechanically. We seem to be internally consistent

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/fpclamptosat.ll:569 ; CHECK-NEXT:cvttss2si %xmm0, %rax ; CHECK-NEXT:ucomiss {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0 +; CHECK-NEXT:movabsq $-9223372036854775808, %rcx # imm = 0x8000

<    1   2   3