[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

2022-06-02 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Thanks for the prompt reply. We have seen that when there is an inline/weak symbol with no use CodeGen decides not to emit that symbol and moves it into a map. Upon a use it would lazily emit it. However, in cling/clang-repl the use might come on the next line, wh

[clang] 3a96256 - [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible

2022-06-02 Thread Shilei Tian via cfe-commits
Author: Shilei Tian Date: 2022-06-02T17:45:02-04:00 New Revision: 3a96256b7e292de15ad57438202aeea4818956ba URL: https://github.com/llvm/llvm-project/commit/3a96256b7e292de15ad57438202aeea4818956ba DIFF: https://github.com/llvm/llvm-project/commit/3a96256b7e292de15ad57438202aeea4818956ba.diff L

[PATCH] D126602: [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible

2022-06-02 Thread Shilei Tian via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a96256b7e29: [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new

[clang] 4ad17d2 - Clean "./" from __FILE__ expansion.

2022-06-02 Thread Alan Zhao via cfe-commits
Author: Paul Pluzhnikov Date: 2022-06-02T18:00:19-04:00 New Revision: 4ad17d2e96a382e5f595bab30920ba26762a6fa9 URL: https://github.com/llvm/llvm-project/commit/4ad17d2e96a382e5f595bab30920ba26762a6fa9 DIFF: https://github.com/llvm/llvm-project/commit/4ad17d2e96a382e5f595bab30920ba26762a6fa9.dif

[PATCH] D126396: Clean "./" from __FILE__ expansion.

2022-06-02 Thread Alan Zhao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad17d2e96a3: Clean "./" from __FILE__ expansion. (authored by ppluzhnikov, committed by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126396/new/

[PATCH] D126396: Clean "./" from __FILE__ expansion.

2022-06-02 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao added a comment. In D126396#3554701 , @ppluzhnikov wrote: > Alan, > > Thanks for the approval. > Could you push this patch -- I don't have commit rights. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

2022-06-02 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 433901. cjdb added a comment. - simplifies code - minimises test to only a handful of cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Dia

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-02 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D126832#3553569 , @aaron.ballman wrote: > Can you post some examples of the output from this option so we can see what > the end results look like more easily? Right now this doesn't do anything at all, except feed the document

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

2022-06-02 Thread Mitch Phillips via Phabricator via cfe-commits
hctim created this revision. hctim added reviewers: vitalybuka, kstoimenov. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds generation of sanitizer metadata attributes (which were added in

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay, I understand. So, first off, I wouldn't really call that a "weak" symbol rather than, say, a lazily-emitted symbol; "weak" already has plenty of different senses, and we should try to avoid coining more. Also, your patch description makes it sound like there's

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + joaomoreira wrote: > samitolvanen wrote: > > joaomoreira wrote: > > > I did not revise the entire patch yet. With this said, IMHO, t

[clang-tools-extra] 987f9cb - [clang-tidy] Add proper emplace checks to modernize-use-emplace

2022-06-02 Thread Ivan Murashko via cfe-commits
Author: Nicolas van Kempen Date: 2022-06-03T00:14:57+01:00 New Revision: 987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 URL: https://github.com/llvm/llvm-project/commit/987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 DIFF: https://github.com/llvm/llvm-project/commit/987f9cb6b9708ff16980c4f8c3f8ba4674463fb5.

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

2022-06-02 Thread Ivan Murashko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG987f9cb6b970: [clang-tidy] Add proper emplace checks to modernize-use-emplace (authored by nicovank, committed by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] b64f6e5 - Add a release note for the scope enum initialization bug fix in

2022-06-02 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-06-02T17:13:05-07:00 New Revision: b64f6e5722024b29f0799f2a0eae08778162dc61 URL: https://github.com/llvm/llvm-project/commit/b64f6e5722024b29f0799f2a0eae08778162dc61 DIFF: https://github.com/llvm/llvm-project/commit/b64f6e5722024b29f0799f2a0eae08778162dc61.diff

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

2022-06-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 433922. ahatanak added a comment. Fix the comment to match the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126084/new/ https://reviews.llvm.org/D126084 Files: clang/lib/Sema/SemaInit.cpp clang/tes

[clang] 66e0899 - [Sema] Reject list-initialization of enumeration types from a

2022-06-02 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-06-02T17:25:11-07:00 New Revision: 66e08995b0b72d28acb5e87b90292e59fabfadae URL: https://github.com/llvm/llvm-project/commit/66e08995b0b72d28acb5e87b90292e59fabfadae DIFF: https://github.com/llvm/llvm-project/commit/66e08995b0b72d28acb5e87b90292e59fabfadae.diff

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

2022-06-02 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e08995b0b7: [Sema] Reject list-initialization of enumeration types from a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 48d6a6c - [OpenMP][NFC] update status for 'omp_all_memory' directive to 'done'

2022-06-02 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-06-02T17:31:33-07:00 New Revision: 48d6a6c9add90f3684de362907d5f05a0988244a URL: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a DIFF: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a.diff LOG

[PATCH] D126934: [clang-format] NFC Sort names of format token types

2022-06-02 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Suggested by HazardyKnusperkeks in D126845

[clang] b917433 - [NFC][Doc] Finish atomic compare

2022-06-02 Thread Shilei Tian via cfe-commits
Author: Shilei Tian Date: 2022-06-02T21:50:07-04:00 New Revision: b917433835473d5a9dff5b1034e861cf5dc9e5bc URL: https://github.com/llvm/llvm-project/commit/b917433835473d5a9dff5b1034e861cf5dc9e5bc DIFF: https://github.com/llvm/llvm-project/commit/b917433835473d5a9dff5b1034e861cf5dc9e5bc.diff L

[PATCH] D126934: [clang-format] NFC Sort names of format token types

2022-06-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:39-45 + TYPE(CSharpGenericTypeConstraint) \ + TYPE(CSharpGenericTypeConstraintColon) \ + TYPE(CSharpGenericTypeConstrain

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok created this revision. Herald added a project: All. MitalAshok added reviewers: akyrtzi, aaron.ballman, erichkeane, browneee. MitalAshok published this revision for review. MitalAshok added a project: LLVM. MitalAshok added a comment. Herald added a project: clang. Herald added a subscri

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5561 Var = cast_or_null(Instantiator.VisitVarTemplateSpecializationDecl( VarSpec->getSpecializedTemplate(), Def, VarSpec->getTemplateArgsInfo(), VarSpec->getTempla

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok planned changes to this revision. MitalAshok added a comment. Appears that more things need to be changed, I'll get that done soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937 __

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

2022-06-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:138-139 TYPE(CSharpGenericTypeConstraintComma) \ + TYPE(VerilogNumberBase) /* for the base in a number literal, not including \ + th

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

2022-06-02 Thread Andrew via Phabricator via cfe-commits
browneee created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. browneee requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It lo

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Andrew via Phabricator via cfe-commits
browneee added a comment. I was also looking into fixing this: https://reviews.llvm.org/D126944 I'm not yet sure if my changes are correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937 ___

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

2022-06-02 Thread Andrew via Phabricator via cfe-commits
browneee added a comment. More details on the bug: https://reviews.llvm.org/D125802#3551305 Alternative implementation for fix: https://reviews.llvm.org/D126937 I'm not yet sure if these changes are correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D126689: [IR] Enable opaque pointers by default

2022-06-02 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D126689#3553292 , @nikic wrote: > @uabelho Here's a slightly cleaned up test case that does not use opaque > pointers: > > target triple = "x86_64-unknown-linux-gnu" > > define void @test(i1 %cond, <1 x i16>* %p) { >

[clang] 9f97720 - [clang][driver] Dynamically select gcc-toolset/devtoolset

2022-06-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-06-03T08:12:27+02:00 New Revision: 9f97720268911abae2ad9d90e270358db234a1c1 URL: https://github.com/llvm/llvm-project/commit/9f97720268911abae2ad9d90e270358db234a1c1 DIFF: https://github.com/llvm/llvm-project/commit/9f97720268911abae2ad9d90e270358db234a1c1.diff LO

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

2022-06-02 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 433963. sepavloff added a comment. Update the patch - Add a flag to reflect rounding mode change by FENV_ROUND, - Keep dynamic mode in AST and change it later in CodeGen, - Add new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

2022-06-02 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In D126364#3548815 , @efriedma wrote: > The way I see it, there are two possibilities here: > > 1. In Sema, we have two rounding modes that correspond to FE_DYNAMIC: > llvm::RoundingMode::Dynamic, and llvm::RoundingMode::Neares

[PATCH] D126947: [clang][doc][NFC] Update get_started.html

2022-06-02 Thread Sheng via Phabricator via cfe-commits
0x59616e created this revision. Herald added a project: All. 0x59616e requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -cc1 is replaced by -Xclang. Update get_started.html to reflect this change. Repository: rG LLVM Github Monorepo http

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

2022-06-02 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 433965. junaire added a comment. remove `EmittedDeferredDecls` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/

[clang] e8402d5 - [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-06-03T09:32:00+03:00 New Revision: e8402d5de82ace9399498570a6a2d5cf64463af3 URL: https://github.com/llvm/llvm-project/commit/e8402d5de82ace9399498570a6a2d5cf64463af3 DIFF: https://github.com/llvm/llvm-project/commit/e8402d5de82ace9399498570a6a2d5cf64463af3.diff

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8402d5de82a: [clang] [MSVC] Enable unwind tables for ARM (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2   3