This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGca27f3e3b26e: [Clang][OpenMP] Support for omp nothing
(authored by koops, committed by Chi-Chun, Chen
).
Repository:
rG
lattner added a comment.
I'm not a competent reviewer for the patch, but +1 on aligning with GCC
behavior here. I don't recall the motivation for the original patch (apologies
again for the terrible commit message). This approach makes a lot of sense to
me.
Repository:
rG LLVM Github Mono
ChuanqiXu updated this revision to Diff 431890.
ChuanqiXu added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125291/new/
https://reviews.llvm.org/D125291
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/ItaniumCXXABI.cpp
clang/test/CodeGenCXX/cx
ChuanqiXu marked 2 inline comments as done.
ChuanqiXu added inline comments.
Comment at: llvm/include/llvm/IR/IRBuilder.h:746-747
+ /// Create a call to llvm.threadlocal.address intrinsic.
+ CallInst *CreateThreadLocalAddress(Value *Ptr);
+
nhaehnle wrote:
>
201 - 204 of 204 matches
Mail list logo