[clang-tools-extra] 03ea140 - Reland(3) "[clangd] Indexing of standard library"

2022-05-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-05-19T08:13:23+02:00 New Revision: 03ea140b3a285c9a4400ee007b1790b110cbf984 URL: https://github.com/llvm/llvm-project/commit/03ea140b3a285c9a4400ee007b1790b110cbf984 DIFF: https://github.com/llvm/llvm-project/commit/03ea140b3a285c9a4400ee007b1790b110cbf984.diff LO

[clang-tools-extra] 07c6635 - [clang-tidy] Fix logic of assertion

2022-05-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-05-19T08:13:23+02:00 New Revision: 07c663590114a7457a747653ad447c966c0e0cd1 URL: https://github.com/llvm/llvm-project/commit/07c663590114a7457a747653ad447c966c0e0cd1 DIFF: https://github.com/llvm/llvm-project/commit/07c663590114a7457a747653ad447c966c0e0cd1.diff LO

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

2022-05-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2164 + StringRef ToolsetDir = llvm::sys::path::filename(LI->path()); + + if (!ToolsetDir.startswith("gcc-toolset-") && delete blank line Comment at: clang/

[PATCH] D125944: Template instantiation error recovery

2022-05-18 Thread Purva Chaudhari via Phabricator via cfe-commits
Purva-Chaudhari updated this revision to Diff 430579. Purva-Chaudhari added a comment. Shifted private member CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cp

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-18 Thread Wang Pengcheng via Phabricator via cfe-commits
pcwang-thead created this revision. pcwang-thead added reviewers: asb, craig.topper, benshi001, luismarques, jrtc27. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruceh

[clang-tools-extra] cd387e4 - [pseudo] Squash some warnings. NFC

2022-05-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-05-19T08:20:12+02:00 New Revision: cd387e43bf89438a83352d47e3d33bc34b697761 URL: https://github.com/llvm/llvm-project/commit/cd387e43bf89438a83352d47e3d33bc34b697761 DIFF: https://github.com/llvm/llvm-project/commit/cd387e43bf89438a83352d47e3d33bc34b697761.diff LO

[clang-tools-extra] 4f35ca5 - [clangd] Suppress warning: control reaches end of function

2022-05-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-05-19T08:26:13+02:00 New Revision: 4f35ca59d0fe1f0955d9e085e2c8ebd1bf27e421 URL: https://github.com/llvm/llvm-project/commit/4f35ca59d0fe1f0955d9e085e2c8ebd1bf27e421 DIFF: https://github.com/llvm/llvm-project/commit/4f35ca59d0fe1f0955d9e085e2c8ebd1bf27e421.diff LO

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

2022-05-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 430583. ChuanqiXu added a comment. Address comments: - Lowering the introduced intrinsic in CodeGen pipelines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 Files: clang/lib/CodeGen/CGExpr.cpp cla

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

2022-05-18 Thread Joachim Priesner via Phabricator via cfe-commits
jspam updated this revision to Diff 430586. jspam added a comment. Update test as suggested by njames93. bugprone-argument-comment-literals.cpp also contains some instances of a UDL used as an argument which didn't lead to problems before because the argument didn't have a name. So that case is

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

2022-05-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 430585. ChuanqiXu added a comment. Cleanup codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/cxx11

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

2022-05-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: llvm/lib/CodeGen/PreISelIntrinsicLowering.cpp:1 //===- PreISelIntrinsicLowering.cpp - Pre-ISel intrinsic lowering pass ===// // I feel this is a better place than SelectDAG. CHANGES SINCE LAST ACTION https:/

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

2022-05-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D125311#3523388 , @hokein wrote: > In D125311#3503452 , @sammccall > wrote: > >> This looks good, but if that's the idiom we should add it to cook() also. > > cook is more tricky, it

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

2022-05-18 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:116 `bugprone-virtual-near-miss `_, "Yes" - `cert-dcl21-cpp `_, + `cert-dcl21-cpp `_, "Yes" `cert-dcl50-cpp `_, The problem with making this change

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

2022-05-18 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:116 `bugprone-virtual-near-miss `_, "Yes" - `cert-dcl21-cpp `_, + `cert-dcl21-cpp `_, "Yes" `cert-dcl50-cpp `_, LegalizeAdulthood wrote: > The probl

<    1   2   3