[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

uabelho added a comment. Herald added a project: All. Hello, I wrote an issue about a crash with this patch: https://github.com/llvm/llvm-project/issues/55546 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114887/new/ https://reviews.llvm.org/D114

[PATCH] D124816: [LibTooling] use ToolFileManager to store file managers for each CWD

Kale updated this revision to Diff 430268. Kale added a comment. 1. Use BaseFS as the condition to judge whether to invalidate previous file managers 2. Use WorkingDir as a parameter for getOrCreateFileManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125859: [clang][deps] stop reusing FileManager in DependencyScanningAction

Kale created this revision. Herald added a project: All. Kale requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DepFS already provides necessary caching, so explicitly stop reusing the FileMgr for possibly cache conflict. Repository: rG

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder created this revision. tbaeder added a reviewer: tstellar. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commit

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong marked an inline comment as done. martong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:352 + reports are lost compared to single-TU analysis, the lost reports are highly + likely to be false positives. xazax.hun wrote: > I wonder if

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c failure (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https:/

[clang] 7e65ffa - [test, x86] Fix spurious x86-target-features.c failure

Author: Thomas Preud'homme Date: 2022-05-18T09:27:32+01:00 New Revision: 7e65ffaa8bb65adc0324ccbea1fef56cab6eafe1 URL: https://github.com/llvm/llvm-project/commit/7e65ffaa8bb65adc0324ccbea1fef56cab6eafe1 DIFF: https://github.com/llvm/llvm-project/commit/7e65ffaa8bb65adc0324ccbea1fef56cab6eafe1.

[clang] 25ac078 - [clang][ASTImporter] Add isNewDecl

Author: Gabor Marton Date: 2022-05-18T10:35:52+02:00 New Revision: 25ac078a961de91522e5b5afaa6d4ffdd0dd05c4 URL: https://github.com/llvm/llvm-project/commit/25ac078a961de91522e5b5afaa6d4ffdd0dd05c4 DIFF: https://github.com/llvm/llvm-project/commit/25ac078a961de91522e5b5afaa6d4ffdd0dd05c4.diff

[clang] 56b9b97 - [clang][analyzer][ctu] Make CTU a two phase analysis

Author: Gabor Marton Date: 2022-05-18T10:35:52+02:00 New Revision: 56b9b97c1ef594f218eb06d2e62daa85cc238500 URL: https://github.com/llvm/llvm-project/commit/56b9b97c1ef594f218eb06d2e62daa85cc238500 DIFF: https://github.com/llvm/llvm-project/commit/56b9b97c1ef594f218eb06d2e62daa85cc238500.diff

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25ac078a961d: [clang][ASTImporter] Add isNewDecl (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG56b9b97c1ef5: [clang][analyzer][ctu] Make CTU a two phase analysis (authored by martong). Changed prior to

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead added a comment. Besides, should we add `vread_csr` and `vwrite_csr` like what in GCC ? These two functions doesn't exist in RVV intrinsics doc, is it a historical problem? R

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder created this revision. tbaeder added reviewers: tstellar, phosek. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This makes it possible to use the newest gcc-toolset/devtoolset on RHEL.

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. In the call on Monday, it was mentioned that the original users of the flang script have moved on to using a custom driver. It will be a good idea to, -> wait for t

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead updated this revision to Diff 430285. pcwang-thead added a comment. Move to separate RVVHeader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 Files: clang/include/clang/Basic/riscv_vector

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

whisperity added a comment. In D125771#3519606 , @LegalizeAdulthood wrote: > I thought there wasn't any support for validating fixits applied to header > files? It is not specifically about the fixits, but diagnostics as a whole. It was not clear that

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal updated this revision to Diff 430295. steakhal marked an inline comment as done. steakhal added a comment. - Move all the `details` stuff into an anonymous namespace. - Pass the `std::vector &IncludesToBeProcessed` directly to the callbacks. - Sink the `IncludeMarker` definition into the

[PATCH] D125769: [clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated-headers

steakhal updated this revision to Diff 430297. steakhal added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125769/new/ https://reviews.llvm.org/D125769 Files: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.cpp

[PATCH] D125769: [clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated-headers

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.h:63 std::vector IncludesToBeProcessed; + bool WarnIntoHeaders; }; LegalizeAdulthood wrote: > 1) How is this different from the clang-tidy option that

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.cpp:90 + // to the `ASTContext`. + Finder->addMatcher(ast_matchers::translationUnitDecl().bind("TU"), this); +}

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

steakhal updated this revision to Diff 430303. steakhal retitled this revision from "[clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated-headers" to "[clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers". steakhal edited the summary of this revis

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:181 + + static const auto Decltype = decltypeType(hasUnderlyingExpr(Call)); + static const auto TemplateArg = aaron.ballman wrote: > aaron.ballman wrot

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:181 + + static const auto Decltype = decltypeType(hasUnderlyingExpr(Call)); + static const auto TemplateArg = whisperity wrote: > aaron.ballman wrote:

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:2-4 // Copy the 'mylib.h' to a directory under the build directory. This is // required, since the relative order of the emitted diagnostics depends

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

steakhal updated this revision to Diff 430305. steakhal marked an inline comment as done. steakhal retitled this revision from "[clang-tidy] modernize-deprecated-headers should ignore system headers" to "[clang-tidy] modernize-deprecated-headers should ignore system headers". steakhal added a co

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37 -#include // FIXME: We should have no warning into system headers. -// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning: inclusion

[PATCH] D125868: [Driver] Recognize -std=gnu++20 enables C++ modules

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. In addition to -std=c++20. This used to result in wrong -cc1 flags produc

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added inline comments. Comment at: libcxx/cmake/caches/MinGW.cmake:3 -set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "") +set(LIBCXX_CXX_ABI libcxxabi-objects CACHE STRING "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") Unfortunately, setting `LIBCXX

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

steakhal added a comment. I found this report at `vim/src/term.c` (https://github.com/vim/vim.git at `v8.2.1920`): F23102904: image.png I'm not sure what the exact type of `BC` global variable is but I think it's declared as either `extern char *BC;` or just

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430314. pengfei added a comment. Use 32-bit spill slot for half type. Others still on going. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 Files: llvm/docs/Releas

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

martong created this revision. martong added reviewers: NoQ, steakhal, Szelethus. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, mgorny. Herald added a project: All. martong requested revi

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:847 -let ParentPackage = DeadCodeAlpha in { - TODO, update the ReleseNotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125684/new/ https://reviews.llvm.org/D125684

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:384 } + void VisitUnresolvedUsingType(const UnresolvedUsingType * UUT) { +Outer.add(UUT->getDecl(), Flags); nit: formatting around `*` Repository: rG LLVM

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125874: [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init statement or condition variable

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead created this revision. pcwang-thead added reviewers: asb, luismarques, kito-cheng, craig.topper. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, M

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430322. kosarev added a comment. Herald added a reviewer: bollu. Add Polly fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 Files: clang/test/CodeGen/cmse-cle

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 430324. pratlucas marked an inline comment as done. pratlucas added a comment. Fix incorrect use of r11 on load/store instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.ll

[PATCH] D125814: Fix strict prototype diagnostic wording for definitions

aaron.ballman updated this revision to Diff 430325. aaron.ballman added a comment. Went with a more simple implementation approach and the diagnostic results seem to be a mild improvement in terms of wording and behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125814/new/ https:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added a comment. Thanks @kosarev - CodeGen\X86 should be clean now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 ___ cfe-commits mailing list cfe-com

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-template-parameter.ll:36 ; CHECK-NEXT: DW_AT_name {{.*}} "i" -; CHECK_NEXT: DW_AT_default_value {{.*}} true +; TODO-NEXT: DW_AT_default_value {{.*}} true Should be fixed by rGf718664

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

aaron.ballman added a comment. In D125259#3520544 , @tahonermann wrote: >> I'm questioning the benefit to supporting _Generic in C++ and starting to >> wonder if perhaps we should pull this extension back. > > I imagine it may be used in shared system h

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added subscribers: chill, momchil.velikov, az, alex-t, keith.walker.arm, plotfi, aivchenk, zer0, awanpand, levivic, zlei. kosarev added a comment. Tagging more people in hope to add visibility. Comment at: clang/test/CodeGen/cmse-clear-return.c:235 // CHECK-BE-NOPT-NE

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal updated this revision to Diff 430326. steakhal marked an inline comment as done. steakhal edited the summary of this revision. steakhal added a comment. - Prefer `V.isUndef()` to `V.isa()`. - Remove tautologically true assertions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. NIT: typo in the change description > Randam-access Rand**o**m LGTM overall, the improvements in PCH and PCM sizes seem worthwhile. Please see the NIT about the naming before l

[PATCH] D125775: [ARM] Don't Enable AES Pass for Generic Cores

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125775/new/ https://reviews.llvm.org/D125775 __

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal updated this revision to Diff 430327. steakhal added a comment. - Added uses for `dyn_cast` and `cast` of the new specialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/ https://reviews.llvm.org/D125709 Files: clang/in

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal added a comment. In D125709#3519850 , @xazax.hun wrote: > While not having tests might be OK, but I'd prefer to introduce at least a > couple uses of the new facilities so existing tests cover them. I've added a use of the new `dyn_cast` and `c

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:53-54 - - if (Eng.hasWorkRemaining()) -return; - I thought this check guards this checker to be meaningful. @martong Repository: rG LLVM Github Monor

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

steakhal added a comment. Could you please give a few examples of these FPs for the record? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125871/new/ https://reviews.llvm.org/D125871 ___ cfe-commits mail

[clang] 21c29a8 - [OpenCL] Add cl_khr_subgroup_rotate builtins

Author: Sven van Haastregt Date: 2022-05-18T13:02:17+01:00 New Revision: 21c29a8ae053cb436141ee636333c4f816cc20c4 URL: https://github.com/llvm/llvm-project/commit/21c29a8ae053cb436141ee636333c4f816cc20c4 DIFF: https://github.com/llvm/llvm-project/commit/21c29a8ae053cb436141ee636333c4f816cc20c4.

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c29a8ae053: [OpenCL] Add cl_khr_subgroup_rotate builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.l

[PATCH] D125877: [clang-tidy] Fix readability-simplify-boolean-expr crash with implicit cast in return.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

hokein added a comment. sorry, I might be lack of the context, where is the user complaint? I'm not sure which cases are improved with this patch. Ideally we would not mark PP directives as inactive regions, but we never do that (FIXME

[clang] 2321c36 - [ARM] Don't Enable AES Pass for Generic Cores

Author: Archibald Elliott Date: 2022-05-18T13:10:31+01:00 New Revision: 2321c36fbf763e273ed78b4209168ce783b5cf96 URL: https://github.com/llvm/llvm-project/commit/2321c36fbf763e273ed78b4209168ce783b5cf96 DIFF: https://github.com/llvm/llvm-project/commit/2321c36fbf763e273ed78b4209168ce783b5cf96.d

[PATCH] D125775: [ARM] Don't Enable AES Pass for Generic Cores

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2321c36fbf76: [ARM] Don't Enable AES Pass for Generic Cores (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125868: [Driver] Recognize -std=gnu++20 enables C++ modules

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, but can you change the patch description as you're bringing the set up to date rather than just adding gnu++20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430349. pengfei added a comment. Replace __gnu_f2h_ieee/__gnu_h2f_ieee with __truncsfhf2/__extendhfsf2 to match with GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/CMakeLists.txt:1 +set(CLANG_PSEUDO_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) + I think these variables shared across CMakeLists.txt files generally add more confusion than value, it doesn't seem

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2689 + // A _BitInt type may not be unique if it has padding bits + // but if it is a bitfield the padding bits are not used + bool IsBitIntType = Comment at: cla

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

hans added a comment. Just one more comment, then I'm happy :) Comment at: clang/lib/CodeGen/CGExpr.cpp:5067 +// recursion. Honor __attribute__((no_builtin("foo"))) or +// __attribute((no_builtin("*"))) on the current function unless foo is +// not a predefined libr

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. In D116088#3393350 , @efriedma wrote: > D120026 is merged now, which addresses the > issue of the compiler generating __sync calls where it isn't supposed to. > > Does anyone want to continue di

[PATCH] D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, tahonermann, aeubanks, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. New diagnostics were added for unreachable generic selection expre

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

aaron.ballman added a comment. In D125259#3520118 , @aaron.ballman wrote: > In D125259#3519947 , @aaron.ballman > wrote: > >> Oh wow, good catch! I'll correct this. > > Oof, the plot thickens... the diagnostic i

[clang-tools-extra] ca87553 - Reland(2) "[clangd] Indexing of standard library"

Author: Sam McCall Date: 2022-05-18T15:30:37+02:00 New Revision: ca875539f788c8063e243ce9ceb877a0d2ad9115 URL: https://github.com/llvm/llvm-project/commit/ca875539f788c8063e243ce9ceb877a0d2ad9115 DIFF: https://github.com/llvm/llvm-project/commit/ca875539f788c8063e243ce9ceb877a0d2ad9115.diff LO

[PATCH] D125885: bugprone-argument-comment: Ignore calls to user-defined literals

jspam created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Without this change, code such as "f(/*param=*/1_op)" will check the comme

[PATCH] D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, s

[PATCH] D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Took me a bit to get the prose, but I think I got it now. PERHAPS there is use to 'finish the thought' on the outcome there? Either way, LGTM. Comment at: clang/li

[PATCH] D125889: clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. Since we already have a dedicated file for testing the /Zc: flags, let's be consistent about putting /Zc: tests there. No behavior change. https://reviews.llvm.org

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 430365. steplong added a comment. - Fixed comment about __attribute__((no_builtin)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 Files: clang/docs/ReleaseNotes.

[PATCH] D125604: [FileCheck] Catch missspelled directives.

dmgreen added inline comments. Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688 +; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h +; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h +; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]] +; TODO-CVT-DAG:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688 +; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h +; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h +; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]] +; TODO-CVT-DAG:

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430249. amyk added a comment. Address review comments: - Remove `-no-opaque-pointers` and updates CHECKs - Simplify runs and checks of C and IR test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125506/new/

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519403 , @DavidSpickett wrote: > Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me > know if/when the first half of the change goes in. https://reviews.llvm.org/D125832 for "patch 1".

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

MitalAshok updated this revision to Diff 430373. MitalAshok added a comment. Removed useless isReferenceType check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125802/new/ https://reviews.llvm.org/D125802 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam updated this revision to Diff 430375. jspam added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

kadircet marked an inline comment as done. kadircet added a comment. In D125863#3522025 , @hokein wrote: > sorry, I might be lack of the context, where is the user complaint? I'm not > sure which cases are improved with this patch. so the complaint was

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

lei added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) nit: same as before no need to test all combination f

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430379. awarzynski added a comment. Rename `flang-to-gfortran` as `flang-to-external-fc` I will also make this change depend on https://reviews.llvm.org/D125832 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D125889: clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125889/new/ https://reviews.llvm.org/D125889 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 ___ cfe

[clang] d39928e - clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp

Author: Nico Weber Date: 2022-05-18T11:01:10-04:00 New Revision: d39928e2cc393a21c8367ef318019166124f4b56 URL: https://github.com/llvm/llvm-project/commit/d39928e2cc393a21c8367ef318019166124f4b56 DIFF: https://github.com/llvm/llvm-project/commit/d39928e2cc393a21c8367ef318019166124f4b56.diff LO

[PATCH] D125889: clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd39928e2cc39: clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp (authored by thakis). Herald added a project: clang. Repository: rG LLVM Gi

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125886/new/ https://reviews.llvm.org/D125886 __

[clang] 1467e01 - [RISCV][NFC] Rename variable in RISCVVEmitter.cpp

Author: Kito Cheng Date: 2022-05-18T23:14:29+08:00 New Revision: 1467e01f8f699fa2a69937dd07e51325ba71a93b URL: https://github.com/llvm/llvm-project/commit/1467e01f8f699fa2a69937dd07e51325ba71a93b DIFF: https://github.com/llvm/llvm-project/commit/1467e01f8f699fa2a69937dd07e51325ba71a93b.diff LO

[PATCH] D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1467e01f8f69: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125886/new/ https://

[PATCH] D115232: [clangd] Indexing of standard library

thakis added a comment. In D115232#3520461 , @sammccall wrote: > Hmm, the test keeps crashing on the GN bot: > http://45.33.8.238/win/58316/step_9.txt > Unfortunately the stacktrace is not symbolized, and I'm not seeing this > elsewhere (e.g. premerge b

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

kito-cheng created this revision. kito-cheng added a reviewer: khchen. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37 -#include // FIXME: We should have no warning into system headers. -// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning:

[PATCH] D125874: [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init statement or condition variable

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125874/new/ https://reviews.llvm.org/D125874 __

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

martong marked an inline comment as done. martong added a comment. In D125871#3521967 , @steakhal wrote: > Could you please give a few examples of these FPs for the record? Out of thin air I could come up with the following one below. Seems like `try` i

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

kito-cheng updated this revision to Diff 430390. kito-cheng added a comment. Changes: - Fix dumb typo... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893 Files: clang/include/clang/Support/RISCVVIntrins

[PATCH] D125877: [clang-tidy] Fix readability-simplify-boolean-expr crash with implicit cast in return.

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Another good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125877/new/ https://reviews.llvm.org/D125877 __

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 _

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

kito-cheng updated this revision to Diff 430391. kito-cheng added a comment. Changes: - clang-format has applied on unexpected part, remove that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893 Files:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430392. kosarev added a comment. Herald added a project: Flang. Added Flang fixes and rebased. Thanks Simon for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.l

  1   2   3   >