[clang] 52af5df - [Driver][test] run one test in darwin-dsymutil.c for Darwin only

Author: Yuanfang Chen Date: 2022-05-11T14:45:00-07:00 New Revision: 52af5df8aef737b5b609912ea28f79fcb3d9ba22 URL: https://github.com/llvm/llvm-project/commit/52af5df8aef737b5b609912ea28f79fcb3d9ba22 DIFF: https://github.com/llvm/llvm-project/commit/52af5df8aef737b5b609912ea28f79fcb3d9ba22.diff

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5219 +// function. +else if (!CGF.CurFn->getAttributes().hasFnAttr(AttributeNoBuiltin)) return CGCallee::forBuiltin(builtinID, FD); steplong wrote: > hans wrote: > > What if C

[PATCH] D125425: Explicitly add -target for Windows builds in file_test_windows.c

ayzhao created this revision. Herald added a subscriber: pengfei. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that the llvm buildbots run the test with -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64

[clang] 8016a0e - Explicitly add -target for Windows builds in file_test_windows.c

Author: Alan Zhao Date: 2022-05-11T15:05:55-07:00 New Revision: 8016a0e5a56b8afc0f328412adae97369c71af78 URL: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78 DIFF: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78.diff LOG

[PATCH] D125425: Explicitly add -target for Windows builds in file_test_windows.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8016a0e5a56b: Explicitly add -target for Windows builds in file_test_windows.c (authored by ayzhao, committed by aeubanks). Repository: rG LLVM Gi

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:218 + llvm::sys::path::remove_dots(CleanFilename, /*remove_dot_dot=*/false); + Filename = CleanFilename; + kadircet wrote: > this is actually breaking the [contract of > FileEntryRe

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

yln added inline comments. Comment at: compiler-rt/lib/asan/asan_poisoning.cpp:263 +#if SANITIZER_ARM64 + // The ARM64 cookie has a second "size_t" entry so poison it as well + *(reinterpret_cast(s)-1) = kAsanArrayCookieMagic; Comment at: co

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

aaronpuchert updated this revision to Diff 428800. aaronpuchert added a comment. Add an AST test to check that we parse the arguments correctly. (We don't use them for diagnostics currently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125422/new

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That's required to support `\n`, but can also used for other commands.

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added inline comments. Comment at: clang/include/clang/AST/Comment.h:303 - -Argument(SourceRange Range, StringRef Text) : Range(Range), Text(Text) { } }; Removing that allows me to build an array without initializing all members right away. A

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125141/new/ https://reviews.llvm.org/D125141 ___ cfe-commits mailing list cfe-commits@

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 ___ cfe-commits mailing list cfe-commits@

[clang] 9519dac - Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support"

Author: David Tenty Date: 2022-05-11T20:47:48-04:00 New Revision: 9519dacab7b8afd537811fc2abaceb4d14f4e16a URL: https://github.com/llvm/llvm-project/commit/9519dacab7b8afd537811fc2abaceb4d14f4e16a DIFF: https://github.com/llvm/llvm-project/commit/9519dacab7b8afd537811fc2abaceb4d14f4e16a.diff L

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

craig.topper added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} There appear to be two installs of ppc_wrapper_files with different components. Is that intentional? Repository: rG LLVM Github Mon

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428826. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. Thank you for your support! I updated the code, so could you please review this patch again? Comment at: llvm/lib/Support/StringRef.cpp:102 +// Find a similar string in `Candidates`. +Optional StringRef::find_similar_str(const std::vector &Candidat

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428827. ken-matsui added a comment. Remove unused includes in `StringRef.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: clang/include/clang/Basic/Diag

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:36 +// elfidef: c2x-cpp2b-warning@-12 {{invalid preprocessing directive, did you mean '#elifdef'?}} +// elfindef: c2x-cpp2b-warning@-12 {{invalid preprocessing directive, did you

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3504789 , @rnk wrote: > This seems reasonable, but I worry about the consequences of creating lots of > unnamed global variables. What will gdb do with so many unnamed globals? What > will the PDB linker do with all the

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428840. ken-matsui added a comment. Updated the code as reviewed, added a release note, and merged `ext-cpp2b-pp-directive.cpp` & `ext-c2x-pp-directive.c` into `ext-pp-directive.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. Thank you so much for your review! My public email address is: `07softy_br...@icloud.com`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3506210 , @balazske wrote: > I found one other place in **LibASTImporter.rst** where `ImportError` is > used. LLDB should be checked too. Yeah , I update the file **LibASTImporter.rst**, I'm not sure if there is n

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 428861. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

<    1   2   3