void updated this revision to Diff 427909.
void added a comment.
- Support SVE registers.
- Initial feature to gather argument registers from the *CallingConv.td files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124836/new/
https://reviews.llvm.
upsj updated this revision to Diff 427910.
upsj marked 13 inline comments as done.
upsj added a comment.
review updates:
- Pass ParseForwardingFunctions via ParseOptions
- Simplify check for forwarding function
- Add test checking diagnostics for make_shared
Repository:
rG LLVM Github Monorep
upsj updated this revision to Diff 427911.
upsj added a comment.
update test docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124688/new/
https://reviews.llvm.org/D124688
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/cla
Author: Simon Pilgrim
Date: 2022-05-08T09:42:58+01:00
New Revision: f2b16488129ef408e89c900f61dc53b1a6699c45
URL:
https://github.com/llvm/llvm-project/commit/f2b16488129ef408e89c900f61dc53b1a6699c45
DIFF:
https://github.com/llvm/llvm-project/commit/f2b16488129ef408e89c900f61dc53b1a6699c45.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf2b16488129e: [X86] Fix some signedness errors in x86
headers (authored by RKSimon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
RKSimon updated this revision to Diff 427913.
RKSimon edited the summary of this revision.
RKSimon added a comment.
Use \code{.operation} ... \endcode
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125170/new/
https://reviews.llvm.org/D125170
Files
kees updated this revision to Diff 427916.
kees added a comment.
Report flag as "unused"
Adjust flags and tests to have the option warn about being unused now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125142/new/
https://reviews.llvm.org/D125
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125170/new/
https://reviews.llvm.org/D125170
Author: Simon Pilgrim
Date: 2022-05-08T10:46:26+01:00
New Revision: 6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a
URL:
https://github.com/llvm/llvm-project/commit/6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a
DIFF:
https://github.com/llvm/llvm-project/commit/6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6b3a111a2867: [Headers][X86] Replace \operation with
\code{.operation} (authored by RKSimon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
Author: Simon Pilgrim
Date: 2022-05-08T10:53:28+01:00
New Revision: 72eb630207b812dced21fb820c6d65ecc2978c0a
URL:
https://github.com/llvm/llvm-project/commit/72eb630207b812dced21fb820c6d65ecc2978c0a
DIFF:
https://github.com/llvm/llvm-project/commit/72eb630207b812dced21fb820c6d65ecc2978c0a.diff
upsj updated this revision to Diff 427928.
upsj added a comment.
- add test for emplace-like functions
- fix RecursiveASTVisitor early exit
- fix handling of skipped parameters
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124690/new/
https://revie
upsj updated this revision to Diff 427930.
upsj added a comment.
attempt to fix the patch issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124690/new/
https://reviews.llvm.org/D124690
Files:
clang-tools-extra/clangd/InlayHints.cpp
clang-too
upsj added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:208
+// If the parameter is part of an expanded pack and not yet resolved
+if (/*isExpandedParameter(Param) && */
+ForwardedParams.find(Param) == ForwardedParams.end()) {
-
upsj added a comment.
It seems like except for the caveats I listed before, all the obvious cases
seem to work: `make_unique`, `make_shared`, `emplace_back` with exact type
matches. One point that still needs some work is if the parameter needs to be
converted inside one of the forwarding funct
kparzysz updated this revision to Diff 427938.
kparzysz added a comment.
Replace the direct storage class examination with `hasLocalStorage`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125177/new/
https://reviews.llvm.org/D125177
Files:
clang
kparzysz updated this revision to Diff 427939.
kparzysz added a comment.
Use the proper diff file this time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125177/new/
https://reviews.llvm.org/D125177
Files:
clang/lib/Analysis/CFG.cpp
clang/tes
Qwinci created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
Qwinci requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125177/new/
https://reviews.llvm.org/D125177
___
VoltrexMaster updated this revision to Diff 427959.
VoltrexMaster added a comment.
Rebase and add upstream changes to fix CI.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124147/new/
https://reviews.llvm.org/D124147
Files:
clang/CMakeLists.txt
Index: clang/CMakeLists.txt
==
rsundahl created this revision.
rsundahl added reviewers: yln, kubamracek, rjmccall, dcoughlin, delcypher,
aralisza, thetruestblue, wrotki.
Herald added subscribers: pengfei, kristof.beyls.
Herald added a project: All.
rsundahl requested review of this revision.
Herald added projects: clang, Sanit
nridge added a comment.
Is there a related change that explains what this setting does?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125088/new/
https://reviews.llvm.org/D125088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
srishti-pm updated this revision to Diff 427964.
srishti-pm added a comment.
Fixing a comment typo and enhancing the commit summary even further.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124750/new/
https://reviews.llvm.org/D124750
Files:
c
zixuan-wu added a comment.
Could anybody else have a review or nominate a reviewer?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124977/new/
https://reviews.llvm.org/D124977
___
cfe-commits mailing list
LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99
+
+ if (!Current->isLiteral() || isStringLiteral(Current->getKind()) ||
+ !isIntegralCons
LegalizeAdulthood marked 2 inline comments as done.
LegalizeAdulthood added a comment.
OK, so thinking about this review a little more, I propose this:
- Take the check as is, but document that the initializing expressions may
result in an invalid enum, particularly for C which restricts the und
Sockke added a comment.
Friendly ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123924/new/
https://reviews.llvm.org/D123924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
tomasz-kaminski-sonarsource updated this revision to Diff 427982.
tomasz-kaminski-sonarsource added a comment.
Updated patch to match master after revert.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124658/new/
https://reviews.llvm.org/D124658
Files:
clang/lib/StaticAnalyzer/Core/S
sunshaoce added inline comments.
Comment at: clang/test/Driver/riscv-arch.c:583
+// RV32-ZHINX-BADVERS: unsupported version number 0.1 for extension 'zhinx'
\ No newline at end of file
Add a newline here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
29 matches
Mail list logo