[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 427460. ppluzhnikov added a comment. Herald added a subscriber: carlosgalvezp. Fix Winx64 `clang-tidy/checkers/google-upgrade-googletest-case.cpp` failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12173

[clang] 8b626a2 - [clang-format] Fix another bug in AlignConsecutiveAssignments

Author: owenca Date: 2022-05-05T14:48:56-07:00 New Revision: 8b626a2caa672a174829105ff7749d8d9a080f2a URL: https://github.com/llvm/llvm-project/commit/8b626a2caa672a174829105ff7749d8d9a080f2a DIFF: https://github.com/llvm/llvm-project/commit/8b626a2caa672a174829105ff7749d8d9a080f2a.diff LOG: [

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b626a2caa67: [clang-format] Fix another bug in AlignConsecutiveAssignments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/

[clang] e7aed73 - [clang-format][NFC] Add a few regression tests

Author: owenca Date: 2022-05-05T15:12:24-07:00 New Revision: e7aed737eb2d8fb2150f38e48d1c3e0108931999 URL: https://github.com/llvm/llvm-project/commit/e7aed737eb2d8fb2150f38e48d1c3e0108931999 DIFF: https://github.com/llvm/llvm-project/commit/e7aed737eb2d8fb2150f38e48d1c3e0108931999.diff LOG: [

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. It turns out clang::expandUCNs only works on tokens that co

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, yaxunl, JonChesterfield, saiislam, ronlieb. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a projec

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall updated this revision to Diff 427475. sammccall added a comment. rename testcase to be more descriptive, add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125049/new/ https://reviews.llvm.org/D125049 Files: clang-tools-extra/ps

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124721/new/ https://reviews.llvm.org/D124721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Vector t

[clang] 1c50909 - Revert "Pedantically warn about // comments in gnu89 mode"

Author: Aaron Ballman Date: 2022-05-05T18:39:13-04:00 New Revision: 1c50909f6f8ac183b82e973457522439a8856e96 URL: https://github.com/llvm/llvm-project/commit/1c50909f6f8ac183b82e973457522439a8856e96 DIFF: https://github.com/llvm/llvm-project/commit/1c50909f6f8ac183b82e973457522439a8856e96.diff

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313 + if (BoundArch.empty()) +checkSystemForAMDGPU(Args, *this, Arch); DAL->AddJoinedA

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 427482. ken-matsui added a comment. Update codes as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/clang/Basic/DiagnosticGroups.td

[clang] c2572d8 - [docs] Add blank lines to help Sphinx parse nested bullets.

Author: Richard Smith Date: 2022-05-05T15:58:26-07:00 New Revision: c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50 URL: https://github.com/llvm/llvm-project/commit/c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50 DIFF: https://github.com/llvm/llvm-project/commit/c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50.diff

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. @aaron.ballman I could suppress the strange warnings by using `isWrittenInBuiltinFile` and `isWrittenInCommandLineFile`. Thank you! Could you please review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12453

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

aykevl added a comment. @benshi001 I have been looking through the GCC code and I think avr-gcc also has a special calling convention for many other functions, including `__mulqi3` and `__mulhi3`. Source: 1. I think this is where the ABI is specified in the compiler: https://github.com/gcc-mi

[clang] f6c7493 - [docs] Fix uses of `foo` that should be ``foo`` throughout release notes.

Author: Richard Smith Date: 2022-05-05T16:04:19-07:00 New Revision: f6c74932b59619aa1a680caa7c4b78d4d29c2877 URL: https://github.com/llvm/llvm-project/commit/f6c74932b59619aa1a680caa7c4b78d4d29c2877 DIFF: https://github.com/llvm/llvm-project/commit/f6c74932b59619aa1a680caa7c4b78d4d29c2877.diff

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

tra added a comment. Just a drive-by style review. I didn't look at the functionality of the changes much. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && + (C.getInputArgs().hasArg(options::OPT_fopenmp_ta

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; ymandel wrote: > xaza

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall updated this revision to Diff 427490. sammccall added a comment. oops, forgot testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125049/new/ https://reviews.llvm.org/D125049 Files: clang-tools-extra/pseudo/include/clang-pseudo/Toke

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Currently if a lexically-valid UCN encodes an invalid codepoint, t

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313 + if (BoundArch.empty()) +checkSystemForAMDGPU(Args, *this, Arch); DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_march_EQ), Arch); tra wrote:

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

sammccall added a comment. With this and D125049 , I no longer get any low-hanging fuzzer crashes. (Though we're probably mostly fuzzing the lexer. Providing a list of tokens as a dictionaly may help) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 updated this revision to Diff 427496. jhuber6 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs()

[PATCH] D125061: [clang] A more robust way to attach comments

zixuw created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current implementation in `getRawCommentForDeclNoCacheIm

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161 if (needsPrologueENDBR(MF, M)) { -auto MBB = MF.begin(); -Changed |= addENDBR(*MBB, MBB->begin()); +if (!ManualENDBR || MF.getFunction().doesCfCheck()) { +

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427509. int3 added a comment. make things work under cc1as too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D125061: [clang] A more robust way to attach comments

zixuw added a comment. Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow. And if folks have concerns or opinions of the performance/space cost of adding the extra pointer to `DeclBase`, I can try to keep the

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 marked 3 inline comments as done. int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCR

[clang] 3b762b3 - [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

Author: Volodymyr Sapsai Date: 2022-05-05T19:19:41-07:00 New Revision: 3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab URL: https://github.com/llvm/llvm-project/commit/3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab DIFF: https://github.com/llvm/llvm-project/commit/3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab.di

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b762b3ab8d2: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of… (authored by vsapsai). Repository: rG LLVM Github Mon

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

benshi001 added a comment. In D123200#3495356 , @aykevl wrote: > @benshi001 I have been looking through the GCC code and I think avr-gcc also > has a special calling convention for many other functions, including > `__mulqi3` and `__mulhi3`. > > Source:

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 427526. ppluzhnikov added a comment. Fix more UNIX and Winx64 failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 Files: clang-tools-extra/clang-tidy/goog

[PATCH] D125061: [clang] A more robust way to attach comments

akyrtzi added a comment. Since the issue is specific to enumerators I would recommend against increasing the size of `DeclBase`, which would increase the size of every single `Decl` in the AST. There are multiple ways to approach this: - Consider whether bringing back the comma check just for

[PATCH] D104975: Implement P1949

intractabilis added a comment. In D104975#3493992 , @tahonermann wrote: > Please refrain from such unhelpful comments. Absolutely, no problem. It's great that my other comments were helpful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/crash/bad-ucn.c:4 +// RUN: clang-pseudo -source=%s +A\U nit: this test seems duplicated with the one in

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427529. njames93 added a comment. Remove unnecessary tests in ReadabilityTidyModule now that the SimplifyBooleanExprMatchers header has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125064/new/ https://reviews.llvm.org/D125064 ___

[PATCH] D125037: [pseudo] Add fuzzer for the pseudoparser.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/fuzzer/Fuzzer.cpp:81 + bool PrintForest = false; + unsigned O = 1; + for (int I = 1; I < *Argc; ++I) { nit: I'd

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/crash/backslashes.c:2 +// We used to try to interpret these backslashes as UCNs. +// RUN: clang-pseudo -source=%s +\ ---

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161 if (needsPrologueENDBR(MF, M)) { -auto MBB = MF.begin(); -Changed |= addENDBR(*MBB, MBB->begin()); +if (!ManualENDBR || MF.getFunction().doesCfCheck()) { +

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

sgatev added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:39-45 + using dataflow::ControlFlowContext; + using dataflow::DataflowAnalysisContext; + using dataflow::DataflowAnalysisState; + using dataflow::Environment; +

[clang] 8175509 - [Lex] Don't assert when decoding invalid UCNs.

Author: Sam McCall Date: 2022-05-06T08:51:42+02:00 New Revision: 817550919e78ba9bb8336685fe1f40e4f650b2e4 URL: https://github.com/llvm/llvm-project/commit/817550919e78ba9bb8336685fe1f40e4f650b2e4 DIFF: https://github.com/llvm/llvm-project/commit/817550919e78ba9bb8336685fe1f40e4f650b2e4.diff LO

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG817550919e78: [Lex] Don't assert when decoding invalid UCNs. (authored by sammccall). Changed prior to c

[clang-tools-extra] 232cc44 - [pseudo] Only expand UCNs for raw_identifiers

Author: Sam McCall Date: 2022-05-06T08:53:31+02:00 New Revision: 232cc446ff7b39a625ddae8a6a8beb3ed2bfb557 URL: https://github.com/llvm/llvm-project/commit/232cc446ff7b39a625ddae8a6a8beb3ed2bfb557 DIFF: https://github.com/llvm/llvm-project/commit/232cc446ff7b39a625ddae8a6a8beb3ed2bfb557.diff LO

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG232cc446ff7b: [pseudo] Only expand UCNs for raw_identifiers (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D125049?vs=427490&id=427535#toc Repository: rG LLVM Github Monor

<    1   2   3