[PATCH] D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree

MaskRay commandeered this revision. MaskRay edited reviewers, added: mgorny; removed: MaskRay. MaskRay added a comment. Obsoleted by D122444 (Hope I am not mistaken) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122424/new/ https://reviews.llvm.org/D12

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *LastE = nullptr; xazax.hun wrote:

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ConstraintManager.cpp:51 +ProgramStateRef StFalse = assume(State, Cond, false); +if (!StFalse) { // both infeasible + ProgramStateRef Infeasible = State->cloneAsInfeasible(); ma

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:196 +const char *CreateExportListExec = Args.MakeArgString( +llvm::sys::path::parent_path(ToolChain.getDriver().ClangExecutable) + +"/llvm-nm"); Use sys::path::appe

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426783. li.zhe.hua added a comment. Handle FullExprs in the transfer function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807 Files: clang/lib/Analysis/FlowSens

[PATCH] D124842: [NFC][CUDA][HIP] rework mangling number for aux target

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/AST/ASTContext.cpp:11770-11778 + if (!LangOpts.CUDA || LangOpts.CUDAIsDevice) { +assert(!ForAuxTarget && "Only CUDA/HIP host compilation supports m

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong updated this revision to Diff 426785. martong added a comment. - Add LLVM_UNLIKELY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124674/new/ https://reviews.llvm.org/D124674 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Co

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426786. red1bluelost added a comment. Adds regression tests for enum to int sign conversion warnings and notes the changes in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ ht

[clang] f2639cf - [randstruct] Move initializer check to be more effective

Author: Bill Wendling Date: 2022-05-03T11:23:12-07:00 New Revision: f2639cf3fe46c30ad450cc2533c81eacd4788c33 URL: https://github.com/llvm/llvm-project/commit/f2639cf3fe46c30ad450cc2533c81eacd4788c33 DIFF: https://github.com/llvm/llvm-project/commit/f2639cf3fe46c30ad450cc2533c81eacd4788c33.diff

[PATCH] D124694: [randstruct] Move initializer check to be more effective

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2639cf3fe46: [randstruct] Move initializer check to be more effective (authored by void). Changed prior to commit: https://reviews.llvm.org/D124694?vs=426149&id=426788#toc Repository: rG LLVM Github

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: aaron.ballman. Herald added subscribers: mattd, carlosgalvezp, dexonsmith. Herald added a project: All. yaxunl requested review of this revision. CUDA/HIP programs use `__noinline__` like a keyword e.g. `__noinlin

[clang-tools-extra] 9f38da2 - [pseudo] Implement the GLR parsing algorithm.

Author: Haojian Wu Date: 2022-05-03T20:25:23+02:00 New Revision: 9f38da258ea75874808e6da756bac831cada180f URL: https://github.com/llvm/llvm-project/commit/9f38da258ea75874808e6da756bac831cada180f DIFF: https://github.com/llvm/llvm-project/commit/9f38da258ea75874808e6da756bac831cada180f.diff LO

[clang] 3971880 - [clang-format][NFC] Clean up tryToParseLambdaIntroducer()

Author: owenca Date: 2022-05-03T11:36:38-07:00 New Revision: 397188036d4cdec7c3bc9236b4a5197232283413 URL: https://github.com/llvm/llvm-project/commit/397188036d4cdec7c3bc9236b4a5197232283413 DIFF: https://github.com/llvm/llvm-project/commit/397188036d4cdec7c3bc9236b4a5197232283413.diff LOG: [

[PATCH] D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer()

This revision was automatically updated to reflect the committed changes. Closed by commit rG397188036d4c: [clang-format][NFC] Clean up tryToParseLambdaIntroducer() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124818/new/ htt

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl updated this revision to Diff 426794. yaxunl added a comment. add feature cuda_noinline_keyword to facilitate CUDA/HIP headers removing __noinline__ macro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124866/new/ https://reviews.llvm.org/D124866 Files: clang/include/clang/Bas

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 426795. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/no-builtin-2.c Index: clang/test/CodeGen/no-builti

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman wr

[clang] c7ecfad - Fix some places where PseudoObjectExpr handling assumed that a

Author: Richard Smith Date: 2022-05-03T11:55:14-07:00 New Revision: c7ecfadf9beb936e5101db4362dd2935d415b04d URL: https://github.com/llvm/llvm-project/commit/c7ecfadf9beb936e5101db4362dd2935d415b04d DIFF: https://github.com/llvm/llvm-project/commit/c7ecfadf9beb936e5101db4362dd2935d415b04d.diff

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:682 +// The called routine is expected to preserve r19-r28 +// r29 and r30 are used as frame pointer and link register resp. +return 0; What happens if

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 by unary operators. +- ``-Wenum-conversion`` now warns on conversion of signed enum to unsigned enum + and unsigned enum to signed enum rather than ``-Wsign-conversion``. M

[PATCH] D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added reviewers: benlangmuir, bnbarham, jansvoboda11. dexonsmith added subscribers: bnbarham, benlangmuir. dexonsmith added a comment. Adding @bnbarham, @jansvoboda11, and @benlangmuir, who have been looking at various FileManager issues recently. If you post a follow up I suggest keep

[clang] c1e17c7 - ExtractAPI: Use %clang_cc1 and -verify in enum.c

Author: Duncan P. N. Exon Smith Date: 2022-05-03T11:57:24-07:00 New Revision: c1e17c7dfedd27b95c8c2fba2b6473c7348f0e77 URL: https://github.com/llvm/llvm-project/commit/c1e17c7dfedd27b95c8c2fba2b6473c7348f0e77 DIFF: https://github.com/llvm/llvm-project/commit/c1e17c7dfedd27b95c8c2fba2b6473c7348f

[PATCH] D124634: ExtractAPI: Use %clang_cc1 and -verify in enum.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e17c7dfedd: ExtractAPI: Use %clang_cc1 and -verify in enum.c (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124634/new/ https://r

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17 +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result balazske wrote: > This include is not needed here. Hey thanks for reviewi

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426803. zixuw added a comment. - Capture whether the include is quoted in KnownFiles - Misc: use `getInputBufferName()` instead of string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 426802. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang/lib/Parse/ParsePragma.cpp

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; --

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426804. red1bluelost marked 4 inline comments as done. red1bluelost added a comment. Addresses comments to improve wording and remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/n

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 by unary operators. +- ``-Wenum-conversion`` now warns on conversion of signed enum to unsigned enum + and unsigned enum to signed enum rather than ``-Wsign-conversion``. aa

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

krasimir added a comment. In D121370#3488401 , @kwk wrote: > @krasimir could you please test this patch on your side? @kwk thank you! the new version of the patch looks good! I didn't know before about the issue you found with the `/* a comment before *

[PATCH] D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Looks ok, but please let someone else have a look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124868/new/ https://reviews.llvm.org/D1

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added subscribers: aprantl, rnk. dblaikie added a comment. Tried this patch on some internal targets and metrics and it seems actually quite reasonable. Tested with split DWARF, on Linux, with compressed debug info in .o/.dwo files, uncompressed in exe/dwp files. With -O0 and -O3, roug

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

eugenis added a comment. I've always viewed the current implementation as a hack, and believed this data should live in debug info. It can be convenient to get symbolized reports for global overflow bug in a stripped binary, but those bugs are quite rare, and "symbolization" only affects the g

[PATCH] D124842: [NFC][CUDA][HIP] rework mangling number for aux target

rnk accepted this revision. rnk added a comment. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124842/new/ https://reviews.llvm.org/D124842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang-tools-extra] ed1b327 - [pseudo] Print the GSS::Node details when the unittest fails, NFC.

Author: Haojian Wu Date: 2022-05-03T22:06:10+02:00 New Revision: ed1b32791dbb4c02cd761742a63cdf1e9d644ae6 URL: https://github.com/llvm/llvm-project/commit/ed1b32791dbb4c02cd761742a63cdf1e9d644ae6 DIFF: https://github.com/llvm/llvm-project/commit/ed1b32791dbb4c02cd761742a63cdf1e9d644ae6.diff LO

[PATCH] D124831: [pseudo] Use a real language option in the parser.

hokein updated this revision to Diff 426811. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124831/new/ https://reviews.llvm.org/D124831 Files: clang-tools-extra/pseudo/include/clang-pseudo/Token.h clang-tools-ext

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:776-778 + // For GPRs, we only care to clear out the 64-bit register. + if (MCRegister XReg = getRegisterOrZero(Reg)) +GPRsToZero.set(XReg); nick

[clang] 37471cf - [clang][OpenMP] Local variable alignment incorrect with align clause

Author: David Pagan Date: 2022-05-03T13:10:01-07:00 New Revision: 37471cf2c3fd02fac0b0dc6e513cfe6098f37764 URL: https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764 DIFF: https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764.diff L

[PATCH] D124676: [clang][OpenMP] Local variable alignment incorrect with align clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG37471cf2c3fd: [clang][OpenMP] Local variable alignment incorrect with align clause (authored by ddpagan, committed by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repo

[clang-tools-extra] c454609 - [pseudo] Use a real language option in the parser.

Author: Haojian Wu Date: 2022-05-03T22:24:56+02:00 New Revision: c4546091ed29763df3e4649327679fec5dcb5ff6 URL: https://github.com/llvm/llvm-project/commit/c4546091ed29763df3e4649327679fec5dcb5ff6 DIFF: https://github.com/llvm/llvm-project/commit/c4546091ed29763df3e4649327679fec5dcb5ff6.diff LO

[PATCH] D124831: [pseudo] Use a real language option in the parser.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4546091ed29: [pseudo] Use a real language option in the parser. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma updated this revision to Diff 426814. efriedma edited the summary of this revision. efriedma added a comment. Switch to use llvm.seh_localunwind intrinsic. I'd appreciate any feedback at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { rsmith wrote: > aaron.ballman wrote: > > yihanaa wrote: > > > I think this is better maintained i

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added a comment. > Now support @ and #.Clearly support "" and <> as ell as an `as well as`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 _

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added a comment. In D121370#3489245 , @krasimir wrote: > In D121370#3488401 , @kwk wrote: > >> @krasimir could you please test this patch on your side? > > @kwk thank you! the new version of the patch look

[PATCH] D123243: [pseudo] Strip directives from a token stream

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. would be nice to land it in some of form. Comment at: clang-tools-extra/pseudo/unittests/DirectiveTreeTest.cpp:316 + std::string Code = R"cpp( +a a a +#warning AAA -

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426823. li.zhe.hua added a comment. Switch from implementing in the trasfer function to skipping `ExprWithCleanups`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua marked 4 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *La

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff adds a new frontend flag `-fmodule-file-home-is-cwd`. The behavior of this flag is similar to `-fmodule-map-file-home-is

[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBo

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

owenpan added a comment. Is this patch NFC? Comment at: clang/lib/Format/FormatTokenLexer.cpp:859-867 +switch (Cur[0]) { +case '\n': +case '\r': +case '\f': +case '\v': +case ' ': +case '\t': I'd replace the `switch` with `if (isspac

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 426854. python3kgae added a comment. Add option -fcgl which output clang codeGen result to avoid test dependent on build DirectX backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://r

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida updated this revision to Diff 426858. cishida added a comment. Hold include name in `HeaderSearch` itself, keeping HeaderFileInfo lightweight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 Files

[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

li.zhe.hua updated this revision to Diff 426860. li.zhe.hua edited the summary of this revision. li.zhe.hua added a comment. Expand `ignoreExprWithCleanups` comment with more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https:

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:776-778 + // For GPRs, we only care to clear out the 64-bit register. + if (MCRegister XReg = getRegisterOrZero(Reg)) +GPRsToZero.set(XReg); nickdesaulniers

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:752 +#undef CASE + } +} kristof.beyls wrote: > Just a drive-by comment: I'm wondering if SVE registers should also be listed > here? I'm not familiar with the SVE registers

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman wrot

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

smeenai resigned from this revision. smeenai added a comment. LGTM after changing to an error with a warning downgrade. Resigning to clear my queue, plus the Apple folks should get the final accept here :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4310-4311 // If no results were found, try to correct typos. TypoCorrection Corr; MemInitializerValidatorCCC CCC(ClassDecl); rnk wrote: > We have to make sure our MS comp

[clang-tools-extra] 0e86cdd - [psuedo] Fix for unused warning by moving code into debug macro.

Author: Weverything Date: 2022-05-03T16:07:59-07:00 New Revision: 0e86cddf988081018200bcdce22a96d9e91a URL: https://github.com/llvm/llvm-project/commit/0e86cddf988081018200bcdce22a96d9e91a DIFF: https://github.com/llvm/llvm-project/commit/0e86cddf988081018200bcdce22a96d9e91a.diff L

[clang] 46a5a80 - [OpenMP] Fix save-temps name in linker wrapper

Author: Joseph Huber Date: 2022-05-03T20:51:05-04:00 New Revision: 46a5a8029e151daf6cb97d51c9cdd1aeab59de78 URL: https://github.com/llvm/llvm-project/commit/46a5a8029e151daf6cb97d51c9cdd1aeab59de78 DIFF: https://github.com/llvm/llvm-project/commit/46a5a8029e151daf6cb97d51c9cdd1aeab59de78.diff

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. @aaron.ballman > If so, I think putting Diag after the call of this function would be better. With the above change, I tried to add comments to failed tests, but there were over 300 files. During my investigation, I found most tests printed warnings without file in

[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

ymandel accepted this revision. ymandel added a comment. Nice!! As Gabor said, thank you for the detailed explanation (on top of the work to get this all done in a principled manner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https

[PATCH] D27068: Improve string::find

Tangmou added inline comments. Herald added a project: All. Comment at: libcxx/trunk/include/__string:557 + _CharT __f2 = *__first2; + while (true) { +__len1 = __last1 - __first1; Sorry for the comment after such a long time, but I have a question about thi

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

OikawaKirie added a comment. In D92160#3485400 , @Kale wrote: > In D92160#2449507 , @dexonsmith > wrote: > >> But it's possible we don't need this. If it's safe for us to update the >> tests and make `FileManager:

<    1   2