[PATCH] D124611: [RISCV][Clang] add more tests for clang driver. (NFC)

2022-05-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:541 +// RUN: FileCheck -check-prefix=RV32-ZVE32F-GOOD %s +// RV32-ZVE32F-GOOD: "-target-feature" "+zve32f" Do we have tests for zve64*? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer()

2022-05-02 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124818/new/ https://reviews.llvm.org/D124818 __

[PATCH] D124774: [clang][ASTImporter][NFC]: Address a fixme in ASTImporterSharedState.h

2022-05-02 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. The `ASTImporterLookupTable` was not dependent on the `ImportError` so the header should not be included in that file. It is better in **ASTImporterSharedState.h**. Alternative solution is to add class `ASTImportError` into **ASTImporterSharedState.h** (no new header i

[PATCH] D124774: [clang][ASTImporter][NFC]: Address a fixme in ASTImporterSharedState.h

2022-05-02 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. A better title: "Move clang::ImportError into own header and rename it (NFC)." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe

<    1   2   3