[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11d3e31c60bd: [CUDA][HIP] Fix mangling number for local struct (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi, Thank you for your work on the patch, it seems to work now! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void updated this revision to Diff 425932. void added a comment. Rebase with top-of-tree. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 Files: clang/lib/Sema/SemaDecl.cpp clang/unittests/AST/

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93. LegalizeAdulthood added projects: clang-tools-extra, All. Herald added subscribers: carlosgalvezp, xazax.hun. LegalizeAdulthood requested review of this revision. Make the following simplifications

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. General question: There is the question of whether or not the replacement should have `()`s around the whole thing because we don't analyze the context to see if the change in precedence between `operator!` and `operator&&` or `operator||` makes any difference

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf68c0a2f58e4: [analyzer] Add path note tags to standard library fu

[clang] f68c0a2 - [analyzer] Add path note tags to standard library function summaries.

Author: Artem Dergachev Date: 2022-04-28T17:17:05-07:00 New Revision: f68c0a2f58e484f008883ab290e36a36e851c1bf URL: https://github.com/llvm/llvm-project/commit/f68c0a2f58e484f008883ab290e36a36e851c1bf DIFF: https://github.com/llvm/llvm-project/commit/f68c0a2f58e484f008883ab290e36a36e851c1bf.dif

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:400 + /// then the return value is 0 + /// and the note may say "Assuming the character is non-alphabetical". + class SummaryCa

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

MaskRay added a comment. Probably no from my view, as I got another internal feedback that "this seems rather crufty". It seems that it is the build system maintainer's responsibility. If you add `-Wno-unknown-warning-option` temporarily, after a new clang is rolled, you may remove `-Wno-unknow

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Some of our users are not very happy with the churn probably caused by this change where the declaration has the "void" argument but the later definition does not have explicit "void". void foo(void); void foo() { } GCC does not warn about this usage: h

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

dexonsmith added a comment. In D124635#3481346 , @benlangmuir wrote: > LGTM, although I made a suggestion about the spelling. Thanks for the review! >> This fixes theoretical bugs related to proxy streams, which may have >> cleanups to run in their des

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

MaskRay accepted this revision. MaskRay added a comment. Happy if Aaron is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 ___ cfe-commits mailing list c

[PATCH] D119296: KCFI sanitizer

joaomoreira added a subscriber: craig.topper. joaomoreira added a comment. > This seems like a reasonable approach, and was also the approach taken for > the PAuth ABI. The PAuth ABI attaches an operand bundle to the call > instruction and arranges for the code for the check to be generated toge

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 425942. samitolvanen marked an inline comment as done. samitolvanen added a comment. - Moved the KCFI pass to InstCombine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3480793 , @pcc wrote: >> Yes, I suspect this might be an issue with Clang's existing CFI schemes too, >> and would probably require an additional pass to drop checks before calls >> that were either inlined or op

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3481573 , @joaomoreira wrote: > At first I was on the boat of KCFI being implemented in the IR level because > being architecture agnostic is certainly a great plus. The original plan was to just lower the intri

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425944. int3 added a comment. add --no-force-dwarf-unwind-info; only omit by default on aarch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/cl

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d133867833f: Frontend: Delete output streams before closing CompilerInstance outputs (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D124635?vs=425893&id=425946#toc Reposit

[clang] 2d13386 - Frontend: Delete output streams before closing CompilerInstance outputs

Author: Duncan P. N. Exon Smith Date: 2022-04-28T19:07:40-07:00 New Revision: 2d133867833fe8eb20c11377ff1221f71afc1db3 URL: https://github.com/llvm/llvm-project/commit/2d133867833fe8eb20c11377ff1221f71afc1db3 DIFF: https://github.com/llvm/llvm-project/commit/2d133867833fe8eb20c11377ff1221f71afc

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce95a1a554: [NFC] Prevent shadowing a variable declared in `if` (authored by ken-matsui, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 52ce95a - [NFC] Prevent shadowing a variable declared in `if`

Author: Ken Matsui Date: 2022-04-28T22:22:27-04:00 New Revision: 52ce95a1a55424256f0d56e32392396896ed7f76 URL: https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76 DIFF: https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76.diff LO

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

rjmccall added a comment. My only comment about the design is that maybe it should be `__builtin_kcfi_call_unchecked`, which does not seem like something you need to hold up LKML discussion for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425953. int3 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/O

[clang] a70cf56 - Reland: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Author: Qiongsi Wu Date: 2022-04-29T00:03:06-04:00 New Revision: a70cf56d20b956fc008d24420e14226127ba9f4a URL: https://github.com/llvm/llvm-project/commit/a70cf56d20b956fc008d24420e14226127ba9f4a DIFF: https://github.com/llvm/llvm-project/commit/a70cf56d20b956fc008d24420e14226127ba9f4a.diff LO

[clang] 7858219 - [asan] Enable detect_stack_use_after_return=1 by default on Linux

Author: Vitaly Buka Date: 2022-04-28T21:08:16-07:00 New Revision: 78582194361e4454e95d3af23367b81dd63b7943 URL: https://github.com/llvm/llvm-project/commit/78582194361e4454e95d3af23367b81dd63b7943 DIFF: https://github.com/llvm/llvm-project/commit/78582194361e4454e95d3af23367b81dd63b7943.diff L

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78582194361e: [asan] Enable detect_stack_use_after_return=1 by default on Linux (authored by vitalybuka). Changed prior to commit: https://reviews

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124509/new/ https://reviews.llvm.org/D124509 ___

[PATCH] D124348: [1/2][RISCV]Add Intrinsics for B extension in Clang

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM, but please fix the title to not use "B extension" since the "B extension" was never ratified. Only Zba, Zbb, Zbc, Zbs were ratified and there will never be a B. Repository:

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3477316 , @erichkeane wrote: > Correct the caching behavior to make the FriendFunc example work. > > I THINK this is ready to review! I'd like to do the lambda examples in a > followup patch as I believe that is a

[clang] eaca933 - [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

Author: jonasyhwang Date: 2022-04-29T12:58:53+08:00 New Revision: eaca933c59fd61b3df4697b5fae0eeec67acfaeb URL: https://github.com/llvm/llvm-project/commit/eaca933c59fd61b3df4697b5fae0eeec67acfaeb DIFF: https://github.com/llvm/llvm-project/commit/eaca933c59fd61b3df4697b5fae0eeec67acfaeb.diff L

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaca933c59fd: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name (authored by jonasyhwang ). Reposit

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. Thank you all commit in eaca933c59fd61b3df4697b5fae0eeec67acfaeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. > I agree that a separate pass wasn't ideal, but InstCombine seems to be full > of code to "fix what other passes messed up". :) I'm not sure if messed up > is the correct term though, these are checks that were necessary before > optimizations, but are no longer

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. > I looked at your code quickly and I wonder if using operand bundles would be > better than adding an attribute. Thoughts? Perhaps @pcc can provide a better feedback on the hassle (or joys) behind using operand bundles. My insights on the attribute is that it is ve

<    1   2   3