[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 created this revision. Herald added subscribers: dexonsmith, jdoerfert, pengfei. Herald added a project: All. LiuChen3 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. For now clang will assume the integer parameters have be

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire updated this revision to Diff 425134. junaire added a comment. use std::move(). I'm not sure this will be better but hope it will make others happy :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D1234

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 updated this revision to Diff 425135. LiuChen3 added a comment. fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Bas

[PATCH] D124436: [analyzer] Fix Static Analyzer g_memdup false-positive

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, martong, xazax.hun, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D124437: [AST] Consider QualifiedTemplateName in TemplateName::getAsUsingDecl().

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. If the underlying template name of a qualified template

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal commandeered this revision. steakhal edited reviewers, added: alishuja; removed: steakhal. steakhal added a comment. Herald added a reviewer: Szelethus. Herald added a project: All. I'll finish this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal updated this revision to Diff 425139. steakhal edited the summary of this revision. steakhal added a comment. - rebased (now using `matchesAny(...)` - added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/ https://reviews.l

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 425143. sgatev marked 2 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang

[PATCH] D124384: [clang] Fix a constant evaluator crash on a NULL-type expr.

hokein added a comment. In D124384#3471917 , @sammccall wrote: > This is a reasonable immediate fix, but creating null-typed expressions that > live *outside* the recoveryexpr seems scary, and likely to violate expected > invariants elsewhere too... Ye

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

whisperity added a comment. After adding improvements to the documentation, I think this will be good to go, and thank you! Perhaps just for a safety measure you could run it on a few projects (LLVM itself?) to ensure we didn't miss a case where it might magically crash, but I wonder how many s

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436 _

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev marked an inline comment as done. sgatev added a comment. In D124395#3472974 , @xazax.hun wrote: > Nice! Did you do some measurements? Does this improve the performance or > decrease the memory consumption? I didn't do any measurements :( I imple

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme updated this revision to Diff 425145. mboehme marked an inline comment as done. mboehme added a comment. Eliminate hasSavedAttrs as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123783/new/ https://reviews.llvm.org/D123783 Files: c

[PATCH] D124420: [Serialization] Compress serialized macro expansion SLocEntries

ilya-biryukov added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2181 + // Common cases are covered by abbreviations. + unsigned Abbrev = [&]() -> unsigned { +if (!Expansion.isExpansionTokenRange()) // Token splits. NIT: ma

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; aaron.ballman wrote: > mboehme wrote: > > aaron.ballman wrot

[clang] d6f9000 - [clang] Fix a constant evaluator crash on a NULL-type expr.

Author: Haojian Wu Date: 2022-04-26T10:08:30+02:00 New Revision: d6f9000ecabeca5819f4f03d774548c7cbb1ff21 URL: https://github.com/llvm/llvm-project/commit/d6f9000ecabeca5819f4f03d774548c7cbb1ff21 DIFF: https://github.com/llvm/llvm-project/commit/d6f9000ecabeca5819f4f03d774548c7cbb1ff21.diff LO

[PATCH] D124384: [clang] Fix a constant evaluator crash on a NULL-type expr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6f9000ecabe: [clang] Fix a constant evaluator crash on a NULL-type expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124427: [Serialization] Pack Expr ObjectKind and ValueKind into one VBR.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124427/new/ https://reviews.llvm.org/D124427 __

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Overall LGTM, but I didn't look closely if there are cases that break now. Do we have any tests to check this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 218dcda - [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

Author: Jun Zhang Date: 2022-04-26T16:45:01+08:00 New Revision: 218dcdad8a0c0f3340a97dafa24456125fe9b4fb URL: https://github.com/llvm/llvm-project/commit/218dcdad8a0c0f3340a97dafa24456125fe9b4fb DIFF: https://github.com/llvm/llvm-project/commit/218dcdad8a0c0f3340a97dafa24456125fe9b4fb.diff LOG

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG218dcdad8a0c: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. In D119544#3472537 , @erichkeane wrote: > Alright, a touch more: It looks like the looping through the `CurContext` at > line 6084 finds the wrong thing in evaluating this `CXXMethodDecl`! The > "broken" version has its Cur

[PATCH] D124348: [1/2][RISCV]Add Intrinsics for B extension in Clang

kito-cheng added a comment. > And I want to know that do you have any documents about intrinsic of bitmanip > extension, like RISC-V Vector Extension Intrinsic Document. No, we didn't a formal document for that, I expect we will have one once this finalized https://github.com/riscv-non-isa/risc

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

whisperity added a comment. Regarding FixIts... FixIts are implemented in the "Diagnostic" library, which is non-specific to neither Clang-Tidy nor Sema whatsoever, they use the same infrastructure under the hood. Why the apply logic in CSA might do the same FixIt multiple times is beyond me, b

[clang-tools-extra] 910fb5d - [pseudo] NFC, fix some code-style naming violations.

Author: Haojian Wu Date: 2022-04-26T10:50:50+02:00 New Revision: 910fb5d7e03afc0009638707f091e94fb63e2a5e URL: https://github.com/llvm/llvm-project/commit/910fb5d7e03afc0009638707f091e94fb63e2a5e DIFF: https://github.com/llvm/llvm-project/commit/910fb5d7e03afc0009638707f091e94fb63e2a5e.diff LO

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:453 +diag(CallOrRef->getBeginLoc(), + "functions with other than C linkage are not allowed as signal " + "handler (until C++17)"); s/with

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

triplef accepted this revision. triplef added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I tested these changes with our app’s code base, which was triggering the bug in a couple of places, and it all builds fine with the patch. Repository: rG LLVM Github Monor

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I imagine tablegen side is being tested automatically? Btw do we need to set the feature macro for SPIR/SPIR-V target and then test it too? Repository: rG LLVM Github Monorepo

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Anastasia added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:367 +add_header_target("mips-resource-headers") +add_header_target("opencl-resource-headers") +add_header_target("ppc-resource-headers") I feel that the above comment doesn't apply here

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a subscriber: MaskRay. Herald added projects: clang, clang-tools-extra.

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

sammccall added a comment. In D124422#3474003 , @ilya-biryukov wrote: > Overall LGTM, but I didn't look closely if there are cases that break now. > Do we have any tests to check this? Serialization tests do exist, though I think coverage isn't amazing.

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

peterwaller-arm added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6266 +LHS = ImpCastExprToType(LHS.get(), ResultType, CK_VectorSplat); +RHS = ImpCastExprToType(RHS.get(), ResultType, CK_VectorSplat); + } I get an assert with the followin

[PATCH] D124442: [analyzer] Allow exploded graph dumps in release builds

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, pengfei, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of thi

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

bernhardmgruber added a comment. Ping. Can someone merge this please for me? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

ilya-biryukov added a comment. Yeah, that sounds promising. Various source locations inside the same nodes are probably very close. Probably even across nodes. If we are willing to take on a bit more complexity, we could probably get even bigger wins by storing all source locations in a single a

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks great! Only thing I'm uncomfortable with is the lack of test coverage outside clangd. I think the most valuable thing would be to have some direct testing of how RecursiveASTV

[PATCH] D124435: [X86] Always extend the integer parameters in callee

skan added a comment. Should we update the `clang/docs/ReleaseNotes.rst` for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435 ___ cfe-commits mailing list

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. You may wait for a day in case there are comments from other reviewers. I think the CI is complaining about some clang-format issue in clang/test/OpenMP/critical_c

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. In D124435#3474130 , @skan wrote: > Should we update the `clang/docs/ReleaseNotes.rst` for this? Maybe? I will update it in the next patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124443: [analyzer] Allow CFG dumps in release builds

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

ilya-biryukov added a comment. In D124441#3474123 , @sammccall wrote: > This looks great! > > Only thing I'm uncomfortable with is the lack of test coverage outside clangd. > I think the most valuable thing would be to have some direct testing of how > R

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passin

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 425166. Sockke added a comment. Rename the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplac

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

sammccall added a comment. In D124422#3474110 , @ilya-biryukov wrote: > Yeah, that sounds promising. Various source locations inside the same nodes > are probably very close. Probably even across nodes. Yeah. The reason to avoid compressing across node

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2451 + // attribute to the callee. + if (AttrOnCallSite || AI.getKind() == ABIArgInfo::Extend) { +if (AI.isSignExt()) pengfei wrote: > Does the change affect Windows? Seems

[PATCH] D124436: [analyzer] Fix Static Analyzer g_memdup false-positive

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Ok. LGTM. (Just a note: it looks kind of interesting that we support the GTK related Glib functions explicitly here. I suppose they are far less frequently used than the `libc` or POSIX fun

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

ilya-biryukov updated this revision to Diff 425171. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Check 'Concept auto' completion, - set -std=c++20 unconditionally, - use char instead of int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3584 + std::vector Syms = {conceptSym("same_as")}; + for (auto P : Code.points("tparam")) { +ASSERT_THAT(completions(TU, P, Syms).Completions, sammccal

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with two minor questions. Comment at: clang/include/clang/Sema/Sema.h:3300 - Decl *ActOnObjCContainerStartDefinition(Decl *IDecl); + void ActOnObjCContai

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

jansvoboda11 added a comment. This looks good IMO. Let's see if others have more suggestions besides the `Parser`/`Sema` layering. Comment at: clang/lib/Parse/ParseObjc.cpp:16 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/Ta

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

bahramib created this revision. bahramib added reviewers: aaron.ballman, njames93, whisperity. bahramib added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. bahramib requested review of this revision. Flags function

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

bahramib created this revision. bahramib added reviewers: aaron.ballman, njames93, whisperity, martong. bahramib added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, arphaman, rnkovacs, xazax.hun. Herald added a project: All. bahramib requested review of this revision. This

[PATCH] D124448: [clang-tidy] Add project-level analysis support to misc-discarded-return-value

bahramib created this revision. bahramib added reviewers: aaron.ballman, njames93, whisperity, martong. bahramib added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. bahramib requested review of this revision. This e

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

jansvoboda11 added a comment. This sounds reasonable to me. What use-cases does `ASTStructuralEquivalence` fit better than ODR hashes? Comment at: clang/include/clang/Sema/Sema.h:3300 +typename = std::enable_if_t::value>> + bool ActOnDuplicateDefinition(T *Duplica

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2451 + // attribute to the callee. + if (AttrOnCallSite || AI.getKind() == ABIArgInfo::Extend) { +if (AI.isSignExt()) LiuChen3 wrote: > pengfei wrote: > > Does the change af

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/integer_argument_passing.c:2 +// RUN: %clang_cc1 -O2 -triple -x86_64-linux-gnu %s -emit-llvm -o - | FileCheck %s --check-prefixes=EXTEND,CHECK +// RUN: %clang_cc1 -O2 -triple -i386-linux-gnu %s -emit-llvm -o - | F

[PATCH] D124442: [analyzer] Allow exploded graph dumps in release builds

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, thanks! For the record, I am inserting the url of the issue: https://github.com/llvm/llvm-project/issues/53873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D124443: [analyzer] Allow CFG dumps in release builds

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124443/new/ https://reviews.llvm.org/D124443

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

steakhal added a comment. In D118996#3473934 , @whisperity wrote: > After adding improvements to the documentation, I think this will be good to > go, and thank you! Perhaps just for a safety measure you could run it on a > few projects (LLVM itself?)

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/integer_argument_passing.c:2 +// RUN: %clang_cc1 -O2 -triple -x86_64-linux-gnu %s -emit-llvm -o - | FileCheck %s --check-prefixes=EXTEND,CHECK +// RUN: %clang_cc1 -O2 -triple -i386-linux-gnu %s -emit-llvm -o - |

[clang] a037eac - Fix test from 5ff992 to work with win 32 bit, fix a typo.

Author: Erich Keane Date: 2022-04-26T06:37:19-07:00 New Revision: a037eace91a350b2a45d0b901f547903df3d3cb3 URL: https://github.com/llvm/llvm-project/commit/a037eace91a350b2a45d0b901f547903df3d3cb3 DIFF: https://github.com/llvm/llvm-project/commit/a037eace91a350b2a45d0b901f547903df3d3cb3.diff L

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

ilya-biryukov updated this revision to Diff 425198. ilya-biryukov added a comment. - clang-format the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124441/new/ https://reviews.llvm.org/D124441 Files: clang-tools-extra/clangd/CodeComplete.cp

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

whisperity added a comment. In D123065#3474107 , @bernhardmgruber wrote: > Ping. > > Can someone merge this please for me? Thank you! Yes, sure, just please specify what `user.name` and `user.email` would you like to be associated with the commit's aut

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2431-2439 + //if (TrailingRequiresClause) { + // Sema::CXXThisScopeRAII ThisScope(SemaRef, Record, D->getMethodQualifiers()); + // ExprResult Rebuilt = + // SemaRef.RebuildExp

[clang] 75e16fd - [Index] [clangd] Support for concept declarations and requires expressions

Author: Ilya Biryukov Date: 2022-04-26T13:50:01Z New Revision: 75e16fd2c656fb7d27e6edc46dc1a63ff8323999 URL: https://github.com/llvm/llvm-project/commit/75e16fd2c656fb7d27e6edc46dc1a63ff8323999 DIFF: https://github.com/llvm/llvm-project/commit/75e16fd2c656fb7d27e6edc46dc1a63ff8323999.diff LOG:

[PATCH] D124441: [Index] [clangd] Support for concept declarations and requires expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75e16fd2c656: [Index] [clangd] Support for concept declarations and requires expressions (authored by ilya-biryukov). Repository: rG LLVM Github M

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

bernhardmgruber added a comment. > Yes, sure, just please specify what `user.name` and `user.email` would you > like to be associated with the commit's author? `user.name`: Bernhard Manfred Gruber `user.email`: bernhardmgru...@gmail.com Thanks a lot! CHANGES SINCE LAST ACTION https://review

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Looks ok, but I'm not very familiar with this part of clang-format, so please leave some time for others to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] b375882 - [PS5] Correctly test for analyzer defaults

Author: Paul Robinson Date: 2022-04-26T07:14:48-07:00 New Revision: b375882014ccaa19c14bc7dc46a666a5a09bbb40 URL: https://github.com/llvm/llvm-project/commit/b375882014ccaa19c14bc7dc46a666a5a09bbb40 DIFF: https://github.com/llvm/llvm-project/commit/b375882014ccaa19c14bc7dc46a666a5a09bbb40.diff

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice work. On the surface, this adds complexity to the system and so should be justified in terms of performance improvements. However, having read through the patch, I think it overall redu

[clang] 712b59c - [clang-format][docs] Fix incorrect 'clang-format 9' option marker

Author: Krystian Kuzniarek Date: 2022-04-26T16:22:04+02:00 New Revision: 712b59cdc5a7d879341cf0caa4d6107f032fff78 URL: https://github.com/llvm/llvm-project/commit/712b59cdc5a7d879341cf0caa4d6107f032fff78 DIFF: https://github.com/llvm/llvm-project/commit/712b59cdc5a7d879341cf0caa4d6107f032fff78.

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG712b59cdc5a7: [clang-format][docs] Fix incorrect 'clang-format 9' option marker (authored by kuzkry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123299/ne

[clang] c89433d - [HIP] Fix diag msg about sanitizer

Author: Yaxun (Sam) Liu Date: 2022-04-26T10:36:36-04:00 New Revision: c89433d7fa10f9a3fe3858ac455ece5913092107 URL: https://github.com/llvm/llvm-project/commit/c89433d7fa10f9a3fe3858ac455ece5913092107 DIFF: https://github.com/llvm/llvm-project/commit/c89433d7fa10f9a3fe3858ac455ece5913092107.dif

[PATCH] D124396: [HIP] Fix diag msg about sanitizer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGc89433d7fa10: [HIP] Fix diag msg about sanitizer (authored by yaxunl). Herald added a project: clang. Chang

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 updated this revision to Diff 425214. jhuber6 added a comment. Small change, returning an empty action type should let us stop without an extra check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D1242

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123783/new/ https://reviews.llvm.org/D123783 _

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

aaron.ballman added a comment. Continues to LGTM Comment at: clang/lib/Analysis/ThreadSafety.cpp:911-919 +UnderlyingMutexes.push_back(UnderlyingCapability{M, UCK_Acquired}); } void addExclusiveUnlock(const CapabilityExpr &M) { -UnderlyingMutexes.emplace_back(M.s

[clang] 2fb1316 - [OpenMP] Fix incorrect path taken when searching for LLD for offloading

Author: Joseph Huber Date: 2022-04-26T10:51:04-04:00 New Revision: 2fb131668fff921dcfedb0b22efb908cc794c07f URL: https://github.com/llvm/llvm-project/commit/2fb131668fff921dcfedb0b22efb908cc794c07f DIFF: https://github.com/llvm/llvm-project/commit/2fb131668fff921dcfedb0b22efb908cc794c07f.diff

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 425221. sgatev marked 4 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev marked an inline comment as done. sgatev added a comment. In D124395#3474597 , @ymandel wrote: > Nice work. On the surface, this adds complexity to the system and so should > be justified in terms of performance improvements. However, having read

[PATCH] D124316: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few small nits. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:230 + void rememberExpressionName(const Token &Tok); + voi

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. I found Comment at: clang/test/SemaTemplate/concepts.cpp:386-388 + []() +requires(constraint) + {}(); erichkeane wrote: > ChuanqiXu wrote: > > We might need more negative tests. > > Now it would pass even if I write: > > ``` >

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 425224. erichkeane added a comment. Now crashes a few times in concepts.cpp, but sets up the instantiation-scope for functions such that local variable references work for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://r

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:507 + + ContextRAII SavedContext{*this, const_cast(FD)}; + LocalInstantiationScope Scope(*this, true); This line was the one that fixed the variable lookup in non-templates. CHANGES

[clang] 9b38e2e - [SystemZ] Fix C++ ABI for passing args of structs containing zero width bitfield.

Author: Jonas Paulsson Date: 2022-04-26T17:16:14+02:00 New Revision: 9b38e2efa0f0c819ec696d13731ac1ce08f81930 URL: https://github.com/llvm/llvm-project/commit/9b38e2efa0f0c819ec696d13731ac1ce08f81930 DIFF: https://github.com/llvm/llvm-project/commit/9b38e2efa0f0c819ec696d13731ac1ce08f81930.diff

[PATCH] D122388: [SystemZ] Fix C++ ABI for passing args of structs containing zero width bitfield.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b38e2efa0f0: [SystemZ] Fix C++ ABI for passing args of structs containing zero width… (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @yurai007 I've put up https://reviews.llvm.org/D124459 to fix this optimization failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/ https://reviews.llvm.org/D123300 ___

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:507 + + ContextRAII SavedContext{*this, const_cast(FD)}; + LocalInstantiationScope Scope(*this, true); erichkeane wrote: > This line was the one that fixed the variable lookup in non-t

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. In D118409#3474131 , @kiranchandramohan wrote: > I think the CI is complaining about some clang-format issue in > clang/test/OpenMP/critical_codegen_attr.cpp clang-format should not be applied on Clang tests, many of them h

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rjmccall added a comment. Hmm. Allowing a version on `-stdlib` is intuitively appealing, but I'm not sure it actually gives us the information we need. As I recall, `-stdlib` selects the high-level stdlib and not the low-level one, and those are related in code but not necessarily at runtime;

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. Size still seems moderately concerning, but might be acceptable. Got a summary of what the DWARF looks like now (without names)? (maybe there's something else we can strip/optimize) & how many of these descriptions get added to the debug info? Numbers for Split DWARF

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov updated this revision to Diff 425248. ASDenysPetrov marked 4 inline comments as done. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. @martong thank you for the idea. I've tried to implement it. Could you look at the patch once again, please? CHAN

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2435 DetermineNoUndef(ParamType, getTypes(), DL, AI)) { - Attrs.addAttribute(llvm::Attribute::NoUndef); + if(!FuncAttrs.contains(llvm::Attribute::Convergent)) +Attrs.addAttribute(llv

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3473693 , @shafik wrote: > In D123319#3473283 , @dblaikie > wrote: > >> ('scuse the delay) >> >> Baseline: I'm still not really sure this is the right direction. Is there a >

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

dblaikie added a comment. In D123436#3462567 , @dblaikie wrote: > Perhaps GlobalModuleIndex should create the cursor itself - it's being handed > the buffer anyway? Ping on this ^ - would this be a better direction that addresses the concerns? Reposit

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

dblaikie added subscribers: aaron.ballman, rsmith. dblaikie added a comment. @rsmith @aaron.ballman - might be especially interesting to know your thoughts on the C++ chapter-based testing and what the intent there is as clang changes default versions/new versions are added. (& also whether ther

[PATCH] D124466: [CUDA][HIP] Fix linkage of __clang_gpu_used_external

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. Different TU's may have this globl var. appending linkage can only be used with lld recognized special variables. Change it to inter

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

aaron.ballman added a comment. I went through the changes and they look correct to me... yet I'm still mildly terrified. :-D Have you tried running clang-tidy through its paces with ASan/MSan enabled to see if the change introduces any use-after-free issues in practice? Repository: rG LLVM

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 425261. jhuber6 added a comment. Changing this to simply require that the user manually passes `-fgpu-rdc` in order to use the new driver. I think this makes more sense in the short term and we can move to make the new driver the default rdc approach later.

  1   2   3   >