[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added a subscriber: rnk. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6225 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasArg(options::OPT_fno_gpu_rdc) && IsCudaDevice &

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6225 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasArg(options::OPT_fno_gpu_rdc) && IsCudaDevice && +Args.hasArg(op

[clang] 2518d4f - [nfc][msan] Add D123875 into release notes

Author: Vitaly Buka Date: 2022-04-22T11:14:28-07:00 New Revision: 2518d4f6d8548d558968749e6d728ccac98cc1c1 URL: https://github.com/llvm/llvm-project/commit/2518d4f6d8548d558968749e6d728ccac98cc1c1 DIFF: https://github.com/llvm/llvm-project/commit/2518d4f6d8548d558968749e6d728ccac98cc1c1.diff L

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 424543. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h clang/include/c

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124285 File

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, rsmith. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Instead of emitting a redefinition error, check that definitions are equivalent

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl marked 7 inline comments as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/device-var-linkage.cu:1-2 // RUN: %clang_cc1 -no-opaque-pointers -triple nvptx -fcuda-is-device \ // RUN: -emit-llvm -o - -x hip %s \ // RUN: | FileCheck -check-prefix

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, rsmith, bruno. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. The purpose of the change is to start using ODR hash for comparison inste

[PATCH] D124288: [Index] Add a USR and symbol kind for UnresolvedUsingIfExists

bnbarham created this revision. bnbarham added reviewers: benlangmuir, arphaman, jansvoboda11. Herald added a project: All. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `UnresolvedUsingIfExists` has existed for a long time now,

[PATCH] D124289: [modules] Proof of concept in using ODR hash to detect mismatching duplicate ObjCInterfaceDecl during deserialization.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124289 Files: clang

[PATCH] D124288: [Index] Add a USR and symbol kind for UnresolvedUsingIfExists

bnbarham added inline comments. Comment at: clang/test/Index/using_if_exists.cpp:9 +// CHECK: [[@LINE-1]]:11 | using/C++ | foo | c:@UD@foo | | Decl | rel: 0 +// CHECK: [[@LINE-2]]:11 | using/using-unresolved/C++ | foo | c:using_if_exists.cpp@UUIE@foo | | Ref | rel: 0

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai added a comment. As a proof of concept how ODR hash comparison can be used during deserialization, please see D124289 . My point is to highlight the amount of reuse we gain from using ODR hash (I particularly enjoy the test case reuse). I agree the err

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

vsapsai added a comment. I also have a very similar change with `ActOnDuplicateDefinition` for `ObjCProtocolDecl`. If anybody is interested in how it compares with `ObjCInterfaceDecl`, I can publish that but it's not finished yet. Comment at: clang/lib/Parse/ParseObjc.cpp:16

[PATCH] D124280: [git-clang-format] Change run line from python to python3

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Especially that we already use python3 in clang-format-diff and other scripts, and it's used in many places in LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124280/new

[PATCH] D124282: [git-clang-format] Add some examples to the help text

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124282/new/ https://reviews.llvm.org/D124282 ___ cfe-commits mailing list cfe-comm

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wi

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai updated this revision to Diff 424561. vsapsai added a comment. Rebase and trigger pre-commit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 Files: clang/include/clang/Testing/CommandLine

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D124066#3463109 , @LegalizeAdulthood wrote: > In D124066#3463008 , @aaron.ballman > wrote:

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifyin

[PATCH] D124282: [git-clang-format] Add some examples to the help text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa45764f2f9cf: [git-clang-format] Add some examples to the help text (authored by thakis). Herald added a project: clang. Repository: rG LLVM Githu

[clang] a45764f - [git-clang-format] Add some examples to the help text

Author: Nico Weber Date: 2022-04-22T15:14:04-04:00 New Revision: a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc URL: https://github.com/llvm/llvm-project/commit/a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc DIFF: https://github.com/llvm/llvm-project/commit/a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc.diff LO

[clang] c94a02e - [git-clang-format] Change run line from python to python3

Author: Nico Weber Date: 2022-04-22T15:14:51-04:00 New Revision: c94a02e0e223bcce3b2c88741fae35d31a2d4f1d URL: https://github.com/llvm/llvm-project/commit/c94a02e0e223bcce3b2c88741fae35d31a2d4f1d DIFF: https://github.com/llvm/llvm-project/commit/c94a02e0e223bcce3b2c88741fae35d31a2d4f1d.diff LO

[PATCH] D124280: [git-clang-format] Change run line from python to python3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc94a02e0e223: [git-clang-format] Change run line from python to python3 (authored by thakis). Herald added a project: clang. Repository: rG LLVM G

[PATCH] D124131: Thread safety analysis: Store capability kind in CapabilityExpr

aaron.ballman added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h:277 + /// The kind of capability as specified by @ref CapabilityAttr::getName. + StringRef CapKind; + Hr, I think this may actually be safe, but it d

[PATCH] D124292: [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, JonChesterfield. Herald added subscribers: mattd, guansong, inglorion, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald adde

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov marked 10 inline comments as done. ASDenysPetrov added a comment. Thank you for the review @martong! Your work is not less harder then mine. I'll rework and update the revision ASAP. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:421-426

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

aaron.ballman added a comment. Thank you for looking into this! I've also thought that the `__builtin_dump_struct` implementation hasn't been quite as robust as it could be. However, the primary use case for that builtin has been for kernel folks to debug when they have no access to an actual d

[PATCH] D124292: [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a minor test nit. Comment at: clang/test/Driver/linker-wrapper.c:41 -// LTO: ptxas{{.*}}-m64 -o {{.*}}.cubin -O2 --gpu-name sm_70 -c {{.*}}.s -// LTO: nvlink{{.*}}-m64

[PATCH] D124292: [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility

jhuber6 updated this revision to Diff 424587. jhuber6 added a comment. Add test line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124292/new/ https://reviews.llvm.org/D124292 Files: clang/test/Driver/linker-wrapper.c clang/tools/clang-linker-

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 updated this revision to Diff 424589. tianshilei1992 added a comment. Herald added a subscriber: MaskRay. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253 Files: clang/lib/Driver/To

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. Hi, could you please reupload your patch with the full diff context? And please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___

[PATCH] D124253: [Clang][OpenMP] Fix the issue that temp cubin files are not removed after compilation when using new OpenMP driver

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253 ___

[clang] 04fb816 - [CUDA][HIP] Externalize kernels with internal linkage

Author: Yaxun (Sam) Liu Date: 2022-04-22T17:05:36-04:00 New Revision: 04fb81674ed7981397ffe70fe6a07b7168f6fe2f URL: https://github.com/llvm/llvm-project/commit/04fb81674ed7981397ffe70fe6a07b7168f6fe2f DIFF: https://github.com/llvm/llvm-project/commit/04fb81674ed7981397ffe70fe6a07b7168f6fe2f.dif

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG04fb81674ed7: [CUDA][HIP] Externalize kernels with internal linkage (authored by yaxunl). Herald added a pro

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:561-567 + Finder->addMatcher(varDecl(TopLevelDecl).bind("top"), this); + Finder->addMatcher(functionDecl(TopLevel

[PATCH] D124288: [Index] Add a USR and symbol kind for UnresolvedUsingIfExists

bnbarham updated this revision to Diff 424621. bnbarham added a comment. After speaking with Ben, we decided it makes more sense to just remove the reference entirely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124288/new/ https://reviews.llvm.

[PATCH] D124288: [Index] Remove reference to `UnresolvedUsingIfExists`

bnbarham updated this revision to Diff 424622. bnbarham retitled this revision from "[Index] Add a USR and symbol kind for UnresolvedUsingIfExists" to "[Index] Remove reference to `UnresolvedUsingIfExists`". bnbarham edited the summary of this revision. bnbarham added a comment. Update title/mes

[PATCH] D124288: [Index] Remove reference to `UnresolvedUsingIfExists`

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Minor suggestion for the test case, but otherwise LGTM. Comment at: clang/test/Index/using_if_exists.cpp:9 +// CHECK: [[@LINE-1]]:11 | using/C++ | foo | c:@UD@foo |

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:561-567 + Finder->addMatcher(varDecl(TopLevelDecl).bind("top"), this); + Finder->addMatcher(functionDecl(TopLevel

[clang] 20a9fb9 - [Clang][OpenMP] Fix the issue that temp cubin files are not removed after compilation when using new OpenMP driver

Author: Shilei Tian Date: 2022-04-22T18:07:28-04:00 New Revision: 20a9fb953e46b1d97aaee7b182b0f3d48f340bd1 URL: https://github.com/llvm/llvm-project/commit/20a9fb953e46b1d97aaee7b182b0f3d48f340bd1 DIFF: https://github.com/llvm/llvm-project/commit/20a9fb953e46b1d97aaee7b182b0f3d48f340bd1.diff L

[PATCH] D124253: [Clang][OpenMP] Fix the issue that temp cubin files are not removed after compilation when using new OpenMP driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG20a9fb953e46: [Clang][OpenMP] Fix the issue that temp cubin files are not removed after… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D124288: [Index] Remove reference to `UnresolvedUsingIfExists`

bnbarham updated this revision to Diff 424631. bnbarham added a comment. Remove line for check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124288/new/ https://reviews.llvm.org/D124288 Files: clang/lib/Index/IndexDecl.cpp clang/test/Index/us

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b4437c084e2: [asan] Enable detect_stack_use_after_return=1 by default (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added a comment. In D124221#3468706 , @aaron.ballman wrote: > Thank you for looking into this! I've also thought that the > `__builtin_dump_struct` implementation hasn't been quite as robust as it > could be. However, the primary use case for th

[PATCH] D124131: Thread safety analysis: Store capability kind in CapabilityExpr

aaronpuchert added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h:277 + /// The kind of capability as specified by @ref CapabilityAttr::getName. + StringRef CapKind; + aaron.ballman wrote: > Hr, I think this may actu

[clang-tools-extra] b985b6e - [clang-tidy] Ignore macros defined within declarations

Author: Richard Date: 2022-04-22T17:46:54-06:00 New Revision: b985b6e3c15a863112e1676d6211c80c7683f3eb URL: https://github.com/llvm/llvm-project/commit/b985b6e3c15a863112e1676d6211c80c7683f3eb DIFF: https://github.com/llvm/llvm-project/commit/b985b6e3c15a863112e1676d6211c80c7683f3eb.diff LOG:

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wi

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb985b6e3c15a: [clang-tidy] Ignore macros defined within declarations (authored by LegalizeAdulthood). Changed prior to commit: https://reviews.llv

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 424663. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang

[clang] 4604db9 - [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

Author: Volodymyr Sapsai Date: 2022-04-22T16:51:19-07:00 New Revision: 4604db9493ffb22e1f411d907f163bf021193d84 URL: https://github.com/llvm/llvm-project/commit/4604db9493ffb22e1f411d907f163bf021193d84 DIFF: https://github.com/llvm/llvm-project/commit/4604db9493ffb22e1f411d907f163bf021193d84.di

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4604db9493ff: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121

[PATCH] D124312: [Driver] Call hasFlag instead of hasArg

ahatanak created this revision. ahatanak added a reviewer: zero9178. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. `_HAS_STATIC_RTTI` should be set to 0 only by `-fno-rtti` according to the summary of

[clang] 089b6ef - [Index] Remove reference to `UnresolvedUsingIfExists`

Author: Ben Barham Date: 2022-04-22T17:19:33-07:00 New Revision: 089b6efefc3dbfc88e8fa92673eeb63ee78e4adf URL: https://github.com/llvm/llvm-project/commit/089b6efefc3dbfc88e8fa92673eeb63ee78e4adf DIFF: https://github.com/llvm/llvm-project/commit/089b6efefc3dbfc88e8fa92673eeb63ee78e4adf.diff LO

[PATCH] D124288: [Index] Remove reference to `UnresolvedUsingIfExists`

This revision was automatically updated to reflect the committed changes. Closed by commit rG089b6efefc3d: [Index] Remove reference to `UnresolvedUsingIfExists` (authored by bnbarham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124288/new/ https:

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 424672. cjdb marked 5 inline comments as done. cjdb edited the summary of this revision. cjdb added a comment. - handles VLAs - adds `__is_referenceable` which is used by portions of the standard library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124312: [Driver] Call hasFlag instead of hasArg

zero9178 accepted this revision. zero9178 added a comment. This revision is now accepted and ready to land. Ouch! Two bugs, and the one in the testsuite covered up the former one. Thank you for noticing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 424673. cjdb added a comment. fixes formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/

[clang] a7f9f2f - [fixup] Handle enum constant `Lang_OBJC` introduced in 4604db94.

Author: Volodymyr Sapsai Date: 2022-04-22T17:59:17-07:00 New Revision: a7f9f2fea506fa213e4ce9c6230a816cd5bcfa38 URL: https://github.com/llvm/llvm-project/commit/a7f9f2fea506fa213e4ce9c6230a816cd5bcfa38 DIFF: https://github.com/llvm/llvm-project/commit/a7f9f2fea506fa213e4ce9c6230a816cd5bcfa38.di

[PATCH] D124316: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. If a macro

[clang] 72e00c4 - [asan] Don't enable detect_stack_use_after_return on Windows

Author: Vitaly Buka Date: 2022-04-22T19:10:30-07:00 New Revision: 72e00c45a4e7b1651c0fdfe4bfc12ff5e2a201d3 URL: https://github.com/llvm/llvm-project/commit/72e00c45a4e7b1651c0fdfe4bfc12ff5e2a201d3 DIFF: https://github.com/llvm/llvm-project/commit/72e00c45a4e7b1651c0fdfe4bfc12ff5e2a201d3.diff L

[clang] 3b578ae - [Driver] Call hasFlag instead of hasArg

Author: Akira Hatanaka Date: 2022-04-22T20:14:50-07:00 New Revision: 3b578ae9088caf08932dc7d18e87d2a17fb4f7a8 URL: https://github.com/llvm/llvm-project/commit/3b578ae9088caf08932dc7d18e87d2a17fb4f7a8 DIFF: https://github.com/llvm/llvm-project/commit/3b578ae9088caf08932dc7d18e87d2a17fb4f7a8.diff

[PATCH] D124312: [Driver] Call hasFlag instead of hasArg

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b578ae9088c: [Driver] Call hasFlag instead of hasArg (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124312/new/ https://reviews.llvm

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl marked 7 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx;

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl updated this revision to Diff 424688. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Artem's and Reid's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 Files: clang/include/clang/AST/ASTContext.h

<    1   2