[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. Please do not change names in the FFI API at least. It's okay to drop it entirely, but renaming is unnecessarily hostile for FFI APIs. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:95 +#endif + Builder.populateModulePassManagerLegacy(

[clang] d46fa02 - [clang-format] SortIncludes should support "@import" lines in Objective-C

Author: Konrad Kleine Date: 2022-04-20T07:03:35Z New Revision: d46fa023caa2db5a9f1e21dd038bcb626261d958 URL: https://github.com/llvm/llvm-project/commit/d46fa023caa2db5a9f1e21dd038bcb626261d958 DIFF: https://github.com/llvm/llvm-project/commit/d46fa023caa2db5a9f1e21dd038bcb626261d958.diff LOG:

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C (authored by kwk). Changed prior to commit: https://review

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay marked an inline comment as done. MaskRay added a comment. In D124063#3461133 , @nikic wrote: > Please do not change names in the FFI API at least. It's okay to drop it > entirely, but renaming is unnecessarily hostile for FFI APIs. Why? Repos

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. In D124063#3461171 , @MaskRay wrote: > In D124063#3461133 , @nikic wrote: > >> Please do not change names in the FFI API at least. It's okay to drop it >> entirely, but renaming is unnecess

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

rovka added a comment. I just have a couple of nits, I'll leave it to the clang devs to properly review this. Comment at: clang/test/CMakeLists.txt:17 LLVM_WITH_Z3 + CLANG_BUILT_STANDALONE ) Nit: These seem to be sorted alphabetically. ===

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 RKSimon wro

[clang-tools-extra] f483481 - [clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee-namespace`

Author: Whisperity Date: 2022-04-20T10:15:03+02:00 New Revision: f4834815f439d4b874e4b501f27a909f59f6a426 URL: https://github.com/llvm/llvm-project/commit/f4834815f439d4b874e4b501f27a909f59f6a426 DIFF: https://github.com/llvm/llvm-project/commit/f4834815f439d4b874e4b501f27a909f59f6a426.diff LO

[PATCH] D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4834815f439: [clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. In D123300#3459023 , @nikic wrote: > @markus Without tracing through it in detail, I'd guess that without opaque > pointers this creates two getelementptr constant expressions that get folded > together. With opaque pointers, the

[clang] bd0d126 - [RISCV][Clang][NFC] Update vid intrinsic tests.

Author: Zakk Chen Date: 2022-04-20T01:35:53-07:00 New Revision: bd0d126302a870df15f60fde4925617c06a36e3f URL: https://github.com/llvm/llvm-project/commit/bd0d126302a870df15f60fde4925617c06a36e3f DIFF: https://github.com/llvm/llvm-project/commit/bd0d126302a870df15f60fde4925617c06a36e3f.diff LOG

[PATCH] D124062: [RISCV][Clang][NFC] Update vid intrinsic tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd0d126302a8: [RISCV][Clang][NFC] Update vid intrinsic tests. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124062/new/ https://review

[PATCH] D124062: [RISCV][Clang][NFC] Update vid intrinsic tests.

khchen added a comment. In D124062#3461069 , @frasercrmck wrote: > Were they perhaps passing because `i64 [[VL:%.*]]` was matching the `, i64 0` > too? Seems like a flaw in the checks generated by the script, but I can see > how the majority of the tim

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 xiangzhangl

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 xiangzhangllvm wr

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:310-313 for (; J != AnnotatedLines.begin(); --J) -if (!(*J)->InPPDirective && (*J)->Level < TheLine->Level) +if ((TheLine->InPPDirective || !(*J)->InPPDirecti

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein updated this revision to Diff 423843. hokein marked an inline comment as done. hokein added a comment. simplify the code in ASTImporter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123775/new/ https://reviews.llvm.org/D123775 Files: cla

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:9189 +TemplateName UnderlyingTN = QTN->getUnderlyingTemplate(); +if (UsingShadowDecl *USD = UnderlyingTN.getAsUsingShadowDecl()) { + if (ExpectedDecl ToUSDOrErr = Import(USD)) sa

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems right to me! Comment at: clang/lib/Sema/TreeTransform.h:7947 // Always rebuild; we don't know if this needs to be injected into a new // context or i

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 LiuChen3 wr

[clang] 3c776c7 - [PowerPC] add XLC compat builtin __abs

Author: Chen Zheng Date: 2022-04-20T05:14:22-04:00 New Revision: 3c776c70a76e9fe51fd978595315e6cef8e7fbb0 URL: https://github.com/llvm/llvm-project/commit/3c776c70a76e9fe51fd978595315e6cef8e7fbb0 DIFF: https://github.com/llvm/llvm-project/commit/3c776c70a76e9fe51fd978595315e6cef8e7fbb0.diff LO

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c776c70a76e: [PowerPC] add XLC compat builtin __abs (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 88d61cc - [X86][SSE] Add i386 test coverage to sse3 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T10:44:28+01:00 New Revision: 88d61cc6e934225059490249ce12e48f4559587d URL: https://github.com/llvm/llvm-project/commit/88d61cc6e934225059490249ce12e48f4559587d DIFF: https://github.com/llvm/llvm-project/commit/88d61cc6e934225059490249ce12e48f4559587d.diff

[clang] 6574d75 - [XOP] Add i386 test coverage to xop intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T10:44:27+01:00 New Revision: 6574d75b8dae6219d003fe8b1046db34199248f2 URL: https://github.com/llvm/llvm-project/commit/6574d75b8dae6219d003fe8b1046db34199248f2 DIFF: https://github.com/llvm/llvm-project/commit/6574d75b8dae6219d003fe8b1046db34199248f2.diff

[clang] c86588a - [X86][SSE] Add i386 test coverage to ssse3 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T10:44:28+01:00 New Revision: c86588af6596d96d046513269dbb1284016391a4 URL: https://github.com/llvm/llvm-project/commit/c86588af6596d96d046513269dbb1284016391a4 DIFF: https://github.com/llvm/llvm-project/commit/c86588af6596d96d046513269dbb1284016391a4.diff

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; aaron.ballman wrote: > mboehme wrote: > > aaron.ballman wrot

[clang] b402ea5 - [X86][SSE] Add i386 test coverage to sse4a intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T10:48:47+01:00 New Revision: b402ea55a834c956de87816143f05fab7fde74ca URL: https://github.com/llvm/llvm-project/commit/b402ea55a834c956de87816143f05fab7fde74ca DIFF: https://github.com/llvm/llvm-project/commit/b402ea55a834c956de87816143f05fab7fde74ca.diff

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 423856. mboehme marked 2 inline comments as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Fil

[clang] e67b1b0 - [OpenCL] Add missing __opencl_c_atomic_scope_device guards

Author: Sven van Haastregt Date: 2022-04-20T11:02:50+01:00 New Revision: e67b1b0ccf520a0168758d116e88f63160812e99 URL: https://github.com/llvm/llvm-project/commit/e67b1b0ccf520a0168758d116e88f63160812e99 DIFF: https://github.com/llvm/llvm-project/commit/e67b1b0ccf520a0168758d116e88f63160812e99.

[clang] 90e5c69 - [X86][SSE] Add i386 test coverage to sse41 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T11:06:06+01:00 New Revision: 90e5c690e2a0b4973e86fb6c010264e5452319f9 URL: https://github.com/llvm/llvm-project/commit/90e5c690e2a0b4973e86fb6c010264e5452319f9 DIFF: https://github.com/llvm/llvm-project/commit/90e5c690e2a0b4973e86fb6c010264e5452319f9.diff

[clang] ba2e567 - [X86][SSE] Add i386 test coverage to sse42 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T11:06:07+01:00 New Revision: ba2e567f049df942b374c2002da9aef06e0b6dc4 URL: https://github.com/llvm/llvm-project/commit/ba2e567f049df942b374c2002da9aef06e0b6dc4 DIFF: https://github.com/llvm/llvm-project/commit/ba2e567f049df942b374c2002da9aef06e0b6dc4.diff

[PATCH] D124081: [clang] Reject non-declaration C++11 attributes on declarations.

mboehme created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang has allowed this so far, transferring the attributes to the declaration's type

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. I'm updating the sse builtin test files to include i386 coverage - should be done in an hour or so CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits mailing li

[clang] 7c1bff3 - [X86][FMA4] Add i386 test coverage to fma4 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T11:14:18+01:00 New Revision: 7c1bff3f7bc569fa2fcbc10365efc787552caa49 URL: https://github.com/llvm/llvm-project/commit/7c1bff3f7bc569fa2fcbc10365efc787552caa49 DIFF: https://github.com/llvm/llvm-project/commit/7c1bff3f7bc569fa2fcbc10365efc787552caa49.diff

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. In D124038#3460731 , @efriedma wrote: > The fix doesn't look right. > > A CompoundLiteralExpr is itself an lvalue; we should catch any issues when we > visit it, not a VarDecl that contains a pointer to it. Well, the v

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. thanks for multiple iterations! I think maybe you are using a too old clang-format? it seems that clang-format >= llvm-14 removes spaces around module partition colons ... so `A : Part`==>`A:P

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt Please take a look and revert for now if it takes a while to fix. (Maybe just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124083: [clang] [draft] Reject C++ 11 attributes appertaining to the wrong entity type.

mboehme created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. mboehme requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. DRAFT -- do not review. Depends On D11

[clang] 3949c2d - [X86][SSE] Add i386 test coverage to sse2 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T12:05:10+01:00 New Revision: 3949c2de79813231492e631cfd3680198d146fe9 URL: https://github.com/llvm/llvm-project/commit/3949c2de79813231492e631cfd3680198d146fe9 DIFF: https://github.com/llvm/llvm-project/commit/3949c2de79813231492e631cfd3680198d146fe9.diff

[PATCH] D123610: [Testing] Drop clangTesting from clang's public library interface

sammccall added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:6 +# Not add_clang_library: this is not part of clang's public library interface. +# Unit tests should depend on this with target_link_libraries, not clang_TLL. +add_llvm_library(clangTesting --

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. OK - SSE2/SSE41 now have i386 coverage - please can you rebase and update the checks to use CHECK/X64/X86 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits m

[PATCH] D124081: [clang] [draft] Reject non-declaration C++11 attributes on declarations.

mboehme added a comment. I'd like to mark this patch as a draft so that Herald doesn't keep adding reviewers -- but I'm not sure how? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124081/new/ https://reviews.llvm.org/D124081 _

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall added a comment. (Would be great to land this in some form if you get a chance!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 ___ cfe-commits maili

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein added a comment. In D123212#3461557 , @sammccall wrote: > (Would be great to land this in some form if you get a chance!) sure, I plan to land it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 1dfe027 - [OpenMP] Add explicit triple to linker wrapper test

Author: Joseph Huber Date: 2022-04-20T07:24:51-04:00 New Revision: 1dfe0273fda3972662bd979de3c216155b18f6ed URL: https://github.com/llvm/llvm-project/commit/1dfe0273fda3972662bd979de3c216155b18f6ed DIFF: https://github.com/llvm/llvm-project/commit/1dfe0273fda3972662bd979de3c216155b18f6ed.diff

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added a comment. In D124039#3461482 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt > > Please take a look and revert for now if it takes a while to fix. (Maybe just > needs an explicit triple?)

[clang] 4cec789 - [Testing] Drop clangTesting from clang's public library interface

Author: Sam McCall Date: 2022-04-20T13:28:44+02:00 New Revision: 4cec789c177d4d69d9e313db1369a0df097362c8 URL: https://github.com/llvm/llvm-project/commit/4cec789c177d4d69d9e313db1369a0df097362c8 DIFF: https://github.com/llvm/llvm-project/commit/4cec789c177d4d69d9e313db1369a0df097362c8.diff LO

[PATCH] D123610: [Testing] Drop clangTesting from clang's public library interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cec789c177d: [Testing] Drop clangTesting from clang's public library interface (authored by sammccall). Changed prior to commit: https://reviews.

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1686 + // would require retrieving the attribute arguments, which we don't have here. + if (T->getAttrKind() == attr::AnnotateType) +return;

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall added a comment. ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/ https://reviews.llvm.org/D123668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

sammccall added a comment. (This is ready to land, right?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123289/new/ https://reviews.llvm.org/D123289 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. This had a "LG" comment above... want to take another pass? (Not urgent, just checking) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 _

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet closed this revision. kadircet added a comment. Landed in 001e88ac83b5c3a4d4f4e61480953ebcabc82b88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123289/new/ https://rev

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, this looks good; just few nits regarding the comments. Comment at: clang/include/clang/Testing/TestAST.h:9 +// +// In normal operation of clang, the FrontendActio

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. Alternatively, the following also works, but it splits the logic into anotherplace, while current patch is at least consistent with existing state diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index 498f0d4..233307f 100644 -

[clang] ee74aba - [OpenMP] Add triple to the linker wrapper job

Author: Joseph Huber Date: 2022-04-20T08:23:43-04:00 New Revision: ee74abaad71e80628540ca7e8abc42ba0cde2101 URL: https://github.com/llvm/llvm-project/commit/ee74abaad71e80628540ca7e8abc42ba0cde2101 DIFF: https://github.com/llvm/llvm-project/commit/ee74abaad71e80628540ca7e8abc42ba0cde2101.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 423878. bc-lee added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/Options.td clang/include/

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee marked 3 inline comments as done. bc-lee added inline comments. Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-a

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423879. hvdijk added a comment. Fixed release notes to use correct RST syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Thanks, that did the trick :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D123958: [randstruct] Randomize all elements of a record

aaron.ballman added a comment. In D123958#3461020 , @void wrote: > In D123958#3459205 , @aaron.ballman > wrote: > >> I think you'll need a more targeted approach than assuming the only kinds of >> declarations i

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

hokein added a comment. Hi, this patch seems to break the following code which was previously compiled: #include #include #include template auto MapJoin(It first, It last, MapFn map_fn) { return std::accumulate( first, last, map_fn(*first), [=](typename std::r

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; mboehme wrote: > aaron.ballman wrote: > > mboehme wrote: > > > aaron.ballman wrote: > > > > Isn'

[PATCH] D124081: [clang] [draft] Reject non-declaration C++11 attributes on declarations.

aaron.ballman added a comment. In D124081#3461556 , @mboehme wrote: > I'd like to mark this patch as a draft so that Herald doesn't keep adding > reviewers -- but I'm not sure how? In that case, I usually set the permissions on the review explicitly so

[PATCH] D124081: [clang] [draft] Reject non-declaration C++11 attributes on declarations.

mboehme added a comment. In D124081#3461731 , @aaron.ballman wrote: > In D124081#3461556 , @mboehme wrote: > >> I'd like to mark this patch as a draft so that Herald doesn't keep adding >> reviewers -- but I'm n

[PATCH] D124081: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

aaron.ballman added a comment. In D124081#3461742 , @mboehme wrote: > In D124081#3461731 , @aaron.ballman > wrote: > >> In D124081#3461556 , @mboehme >> wrote: >> >>> I'

[clang] f26c41e - [RISCV] Moving RVV intrinsic type related util to clang/Support

Author: Kito Cheng Date: 2022-04-20T21:13:13+08:00 New Revision: f26c41e8dd28d86030cd0f5a6e9c11036acea5d2 URL: https://github.com/llvm/llvm-project/commit/f26c41e8dd28d86030cd0f5a6e9c11036acea5d2 DIFF: https://github.com/llvm/llvm-project/commit/f26c41e8dd28d86030cd0f5a6e9c11036acea5d2.diff LO

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf26c41e8dd28: [RISCV] Moving RVV intrinsic type related util to clang/Support (authored by kito-cheng). Changed prior to commit: https://reviews.l

[PATCH] D124081: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme added a comment. In D124081#3461761 , @aaron.ballman wrote: > [snip] > However, it sounds to me like you want anyone to be able to come by and > comment if they'd like while you're prepping the patch, so I'd stick with the > [WIP] in the tit

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added a comment. @erichkeane I will land that later today to unstuck people relying on main, let me know if you still want to have a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

erichkeane added a comment. In D124012#3461781 , @cor3ntin wrote: > @erichkeane I will land that later today to unstuck people relying on main, > let me know if you still want to have a look I didn't see anything on a quick pass, so LGTM! Repository:

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

thakis added a comment. Please add a clear comment to the new library's CMakeLists.txt file that explains when to put code there and when in clang/lib/Basic. (The patch description does say it, but the patch description is harder to find than a comment in the cmake file.) Repository: rG LLV

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille updated this revision to Diff 423890. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Adopt a better wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 69dd89f - [Clang] Fix references to captured variables in dependant context.

Author: Corentin Jabot Date: 2022-04-20T15:35:20+02:00 New Revision: 69dd89fdcbd846375a45e2fe3a88710887236d7a URL: https://github.com/llvm/llvm-project/commit/69dd89fdcbd846375a45e2fe3a88710887236d7a DIFF: https://github.com/llvm/llvm-project/commit/69dd89fdcbd846375a45e2fe3a88710887236d7a.diff

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69dd89fdcbd8: [Clang] Fix references to captured variables in dependant context. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein updated this revision to Diff 423892. hokein added a comment. implement a pseudo-VisitTemplateName locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 Files: clang-tools-extra/clangd/FindTar

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:82 bool VisitTemplateSpecializationType(TemplateSpecializationType *TST) { -add(TST->getTemplateName().getAsTemplateDecl()); // Primary template. +

[clang-tools-extra] 95f0f69 - [clangd] Handle the new Using TemplateName.

Author: Haojian Wu Date: 2022-04-20T15:42:24+02:00 New Revision: 95f0f69441fb8b33528d25ba2b40e3fa703c6ea5 URL: https://github.com/llvm/llvm-project/commit/95f0f69441fb8b33528d25ba2b40e3fa703c6ea5 DIFF: https://github.com/llvm/llvm-project/commit/95f0f69441fb8b33528d25ba2b40e3fa703c6ea5.diff LO

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG95f0f69441fb: [clangd] Handle the new Using TemplateName. (authored by hokein). Repository: rG LLVM Githu

[clang] bea5e88 - [clang][Sema] Fix typo in checkBuiltinArgument helper

Author: Alex Bradbury Date: 2022-04-20T14:42:41+01:00 New Revision: bea5e88bcf5908b676da35fb8c64f9f8449ba73b URL: https://github.com/llvm/llvm-project/commit/bea5e88bcf5908b676da35fb8c64f9f8449ba73b DIFF: https://github.com/llvm/llvm-project/commit/bea5e88bcf5908b676da35fb8c64f9f8449ba73b.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 423895. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated the diagnostic wording, putting it through precommit CI again to see if I missed any tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added a comment. @erichkeane @aaron.ballman Thanks! I'll keep an eye out for further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 ___ cfe-co

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:884 +// +// Note: currently, abstract function calls are uninterpreted, so the test +// exercises this case. If and when we change t

[PATCH] D123682: [clang-tblgen] Automatically document options values

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682 ___ cfe-commits mailing list cfe-comm

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang. T

[clang] 2c176f2 - [X86][AVX] Add i386 test coverage to avx intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T15:12:11+01:00 New Revision: 2c176f2f1ed7b4dcad3d229b9a61e77e17370baf URL: https://github.com/llvm/llvm-project/commit/2c176f2f1ed7b4dcad3d229b9a61e77e17370baf DIFF: https://github.com/llvm/llvm-project/commit/2c176f2f1ed7b4dcad3d229b9a61e77e17370baf.diff

[clang] 0140a67 - [X86][AVX] Add i386 test coverage to avx-vnni intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T15:12:12+01:00 New Revision: 0140a672a62b9a01742d0c449adc3a710e446ad7 URL: https://github.com/llvm/llvm-project/commit/0140a672a62b9a01742d0c449adc3a710e446ad7 DIFF: https://github.com/llvm/llvm-project/commit/0140a672a62b9a01742d0c449adc3a710e446ad7.diff

[clang] 72d4e3d - [X86][AVX] Add i386 test coverage to avx2 intrinsic tests

Author: Simon Pilgrim Date: 2022-04-20T15:12:12+01:00 New Revision: 72d4e3dc2d6f560e44fffefd7fc6987e9083698f URL: https://github.com/llvm/llvm-project/commit/72d4e3dc2d6f560e44fffefd7fc6987e9083698f DIFF: https://github.com/llvm/llvm-project/commit/72d4e3dc2d6f560e44fffefd7fc6987e9083698f.diff

[clang] 1226d27 - [X86][AVX512] Rename avx512popcntdq intrinsics tests files to match *-builtins.c naming convention

Author: Simon Pilgrim Date: 2022-04-20T15:12:12+01:00 New Revision: 1226d276b46d084e4c39357d0d6d72827e88c7b4 URL: https://github.com/llvm/llvm-project/commit/1226d276b46d084e4c39357d0d6d72827e88c7b4 DIFF: https://github.com/llvm/llvm-project/commit/1226d276b46d084e4c39357d0d6d72827e88c7b4.diff

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane marked 10 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/AST/Decl.h:1891 +TK_DependentFunctionTemplateSpecialization, +// A Dependent function that itself is not a function. +TK_DependentNonTemplate --

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 423901. erichkeane marked 6 inline comments as done. erichkeane added a comment. Thanks for the review @ChuanqiXu ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 423902. aaron.ballman added a comment. Rebased to hopefully get precommit CI to test it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-too

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6664- +// OpenCL disallows variadic functions, so it also disallows a function +// without a prototype. However, it doesn't enforce strict pr

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. XL considers different vector types to be incompatible with each oth

[clang-tools-extra] f25935a - [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

Author: Fabian Wolff Date: 2022-04-20T16:55:29+02:00 New Revision: f25935a000917f2c06b52bbc7273e20a82543782 URL: https://github.com/llvm/llvm-project/commit/f25935a000917f2c06b52bbc7273e20a82543782 DIFF: https://github.com/llvm/llvm-project/commit/f25935a000917f2c06b52bbc7273e20a82543782.diff

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGf25935a00091: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D114292?vs=400634&id=423908#toc Repository: r

[clang-tools-extra] fb3b3f7 - [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

Author: Fabian Wolff Date: 2022-04-20T17:03:30+02:00 New Revision: fb3b3f76bf75875684eedfe0711424e7ceba4b41 URL: https://github.com/llvm/llvm-project/commit/fb3b3f76bf75875684eedfe0711424e7ceba4b41 DIFF: https://github.com/llvm/llvm-project/commit/fb3b3f76bf75875684eedfe0711424e7ceba4b41.diff

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb3b3f76bf75: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers (authored by fwolff). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D115124?v

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Hm, is adding this flag the right thing to do? Looking at clang's -S output for (say) ` -target arm64-apple-macos -darwin-target-variant arm64-apple-ios13.1-macab`, it emits lines like: .build_version macos, 12, 0 sdk_version 12, 3 .build_version macC

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcce79514ff40: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent… (authored by fwolff). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D11349

  1   2   3   >