[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng updated this revision to Diff 423754. pzheng added a comment. Address comments from @mstorsjo. Thanks for catching the missing test, @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 File

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng added a comment. Thanks for reviewing the patch, @rnk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 8c64928 - [OpenMP] Add necessary registered targets for linker wrapper test

Author: Joseph Huber Date: 2022-04-19T18:48:58-04:00 New Revision: 8c64928887997a176c8f78b26c0edf00d6b2f59d URL: https://github.com/llvm/llvm-project/commit/8c64928887997a176c8f78b26c0edf00d6b2f59d DIFF: https://github.com/llvm/llvm-project/commit/8c64928887997a176c8f78b26c0edf00d6b2f59d.diff

[clang] 20c873c - [PS5] Avoid a driver crash

Author: Paul Robinson Date: 2022-04-19T15:55:32-07:00 New Revision: 20c873c12fa5563bbfb07c880db51fa68db571cc URL: https://github.com/llvm/llvm-project/commit/20c873c12fa5563bbfb07c880db51fa68db571cc DIFF: https://github.com/llvm/llvm-project/commit/20c873c12fa5563bbfb07c880db51fa68db571cc.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

jyknight accepted this revision. jyknight added a comment. Looks good to me, whichever way you go regarding rsmith's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 ___ cfe-commits mailing

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed to use clang-include-fixer. Repository:

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240 + GCC. This breaks binary compatibility with code compiled with earlier versions + of clang; use the `-fclang-abi-compat=14` option to get the old mangling. This is incorrect rst synta

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/test/Frontend/stack-usage-safestack.c:3 + +// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s +// RUN: %clang_cc1 %s -fwarn-stack-

[clang] 0d0a99c - [msan] Advance before destroying entry

Author: Vitaly Buka Date: 2022-04-19T16:42:04-07:00 New Revision: 0d0a99cb96183027af8212d0b8545356b65be0d3 URL: https://github.com/llvm/llvm-project/commit/0d0a99cb96183027af8212d0b8545356b65be0d3 DIFF: https://github.com/llvm/llvm-project/commit/0d0a99cb96183027af8212d0b8545356b65be0d3.diff L

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 423775. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118052/new/ https://reviews.llvm.org/D118052 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/X86/x86-cf-protection.c

[clang] 8b0e7f2 - [CodeGen] Fix -Wswitch after D116462

Author: Fangrui Song Date: 2022-04-19T17:28:54-07:00 New Revision: 8b0e7f2293b39a11d83ff9889f5250947de80c53 URL: https://github.com/llvm/llvm-project/commit/8b0e7f2293b39a11d83ff9889f5250947de80c53 DIFF: https://github.com/llvm/llvm-project/commit/8b0e7f2293b39a11d83ff9889f5250947de80c53.diff

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

delcypher created this revision. delcypher added reviewers: rapidsna, fcloutier, aaron.ballman. Herald added a project: All. delcypher requested review of this revision. Herald added a project: clang. The previous code unneccessarily duplicated the creation of a diagnostic where the only differenc

[clang] a57d16b - [CodeGen] Fix -Wswitch after D116462

Author: Fangrui Song Date: 2022-04-19T17:33:15-07:00 New Revision: a57d16bf80db1bdb785df6b7bca96cb4daff5ea7 URL: https://github.com/llvm/llvm-project/commit/a57d16bf80db1bdb785df6b7bca96cb4daff5ea7 DIFF: https://github.com/llvm/llvm-project/commit/a57d16bf80db1bdb785df6b7bca96cb4daff5ea7.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Jake-Egan added a comment. Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://revi

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka created this revision. vitalybuka added reviewers: eugenis, kda. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. By default -fsanitize=address alre

[PATCH] D124058: [msan] Update Use-after-destruction documentation

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124058 Files: clang/docs/MemorySanitizer.rst Ind

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. The fix doesn't look right. A CompoundLiteralExpr is itself an lvalue; we should catch any issues when we visit it, not a VarDecl that contains a pointer to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ h

[PATCH] D86351: WIP: llvm-buildozer

arsenm added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else Do command line flags like this really need to be thread local?

[clang] af21445 - [CMake][Fuchsia] Include find-all-symbols in the distribution

Author: Petr Hosek Date: 2022-04-19T19:27:46-07:00 New Revision: af21445ea87021a1bb0a870a2d63cee27f57b43e URL: https://github.com/llvm/llvm-project/commit/af21445ea87021a1bb0a870a2d63cee27f57b43e DIFF: https://github.com/llvm/llvm-project/commit/af21445ea87021a1bb0a870a2d63cee27f57b43e.diff LO

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf21445ea870: [CMake][Fuchsia] Include find-all-symbols in the distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124053/new/

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 423793. jhuber6 added a comment. Herald added a subscriber: mattd. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123810/new/ https://reviews.llvm.org/D123810 Files: clang/tools/clang-linker-wrapper/C

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423796. jhuber6 added a comment. Addings tests for wrapper codegen and fatbinary usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/lin

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423797. ChuanqiXu added a comment. Address comments: - Add tests for GMF - Avoid to compare string if M is private module fragment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:550-553 if (isModulePartition()) { auto pos = Name.find(':'); return StringRef(Name.data(), pos); } iains wrote: > if we find this is repeated too many times,

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, power-llvm-team. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch tur

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Darwin.h:495 + Optional getTargetVariantTriple() const override { +return TargetVariantTriple; + } llvm::

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372 _

[PATCH] D124062: [RISCV][Clang][NFC] Update vid intrinsic tests.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 updated this revision to Diff 423805. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/ https://reviews.llvm.org/D123200 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/base-config-ix.cmake compiler-rt/cmake/builtin-config-ix.cmake compi

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan accepted this revision. owenpan added a comment. LGTM as I defer to @MyDeveloperDay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 ___ cfe-commits mai

[clang-tools-extra] 08881c2 - [clang-tidy] Improve macro handling in modernize-macro-to-enum

Author: Richard Date: 2022-04-19T21:28:17-06:00 New Revision: 08881c2de66b267446f01b908ea2e7297bdf3083 URL: https://github.com/llvm/llvm-project/commit/08881c2de66b267446f01b908ea2e7297bdf3083 DIFF: https://github.com/llvm/llvm-project/commit/08881c2de66b267446f01b908ea2e7297bdf3083.diff LOG:

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

This revision was automatically updated to reflect the committed changes. LegalizeAdulthood marked 2 inline comments as done. Closed by commit rG08881c2de66b: [clang-tidy] Improve macro handling in modernize-macro-to-enum (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHA

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 added a comment. I added three functions __mulqi3: int8 multiplication __mulhi3: int16 multiplication _exit : golobal terminator All of them are contained in libgcc and are necessary. Some key points, 1. The functions are written in the minimal avrtiny instruction set, so the

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay created this revision. MaskRay added reviewers: aeubanks, nikic. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, StephenFan, kbarton, hiraditya, nemanjai. Herald added a reviewer: bollu. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 423813. ASDenysPetrov added a comment. Loaded with comment updateds according to the remarks. @martong thank you for your time for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files:

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. Modernize-m

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423815. LegalizeAdulthood added a comment. Add comments describing test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:13397 + + verifyFormat("//\n" + "#define a \\\n" aeubanks wrote: > not sure if you

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423818. LegalizeAdulthood added a comment. Delete debugging aids CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang-tools

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added a comment. In D123958#3459205 , @aaron.ballman wrote: > I think you'll need a more targeted approach than assuming the only kinds of > declarations in a struct are field-like in C. > > It seems that the issue you've got is with anonymous obje

[clang] c952754 - Make tests slightly more flexible for platforms which emit arguments in between some of the expected arguments.

Author: Douglas Yung Date: 2022-04-19T23:25:22-07:00 New Revision: c95275420610ac94c0eeebf0bc171b8d342a1c77 URL: https://github.com/llvm/llvm-project/commit/c95275420610ac94c0eeebf0bc171b8d342a1c77 DIFF: https://github.com/llvm/llvm-project/commit/c95275420610ac94c0eeebf0bc171b8d342a1c77.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.h:495 + Optional getTargetVariantTriple() const override { +return TargetVariantTriple; + } MaskRay wrote: > llvm::None Do you mean to modify the method in `clang/include/clang/Dri

[PATCH] D124062: [RISCV][Clang][NFC] Update vid intrinsic tests.

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. Were they perhaps passing because `i64 [[VL:%.*]]` was matching the `, i64 0` too? Seems like a flaw in the checks generated by the script, but I can see how the majority of the time

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/Decl.h:1891 +TK_DependentFunctionTemplateSpecialization, +// A Dependent function that itself is not a function. +TK_DependentNonTemplate hmmm, what does this literally mean? In my u

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-commits mailing list cfe-commit

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.h:495 + Optional getTargetVariantTriple() const override { +return TargetVariantTriple; + } bc-lee wrote: > MaskRay wrote: > > llvm::None > Do you mean to modify the method in `cl

<    1   2   3