[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:119 Opts.Digraphs = Std.hasDigraphs(); + Opts.StrictPrototypes = Std.isCPlusPlus() || Std.isC2x(); cor3ntin wrote: > Stupid ques

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

rsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "require function types to have a prototype") LANGOPT(Digraphs , 1, 0, "digraphs") ---

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman created this revision. aaron.ballman added a reviewer: lattner. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. As a project, Clang has gotten negative public feedback about our lack of communicating changes to users. There

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423459. jhuber6 added a comment. Rebase & update after making the new driver default for OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/includ

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 423460. jhuber6 added a comment. Herald added subscribers: mattd, dexonsmith, MaskRay. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/include/

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 3 inline comments as done. aaron.ballman added a subscriber: NoQ. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "requi

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423461. jhuber6 added a comment. Rebase after making the new driver default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Actio

[PATCH] D123958: [randstruct] Randomize all elements of a record

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A record may have more than just FieldDecls i

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

tahonermann added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1034-1042 + if (T.isNull() || !T->getAs()) +// If the type is invalid or is not a function type, we cannot get +// a block pointer type for it. This isn't i

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. I played around with this and it seems to have the overriding behavior I would expect Comment at: clang/test/CodeGen/denormalfpmode-f32.c:21 + +// CHECK-LABEL: main +

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423464. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Action.cpp clan

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423465. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Compila

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423466. jhuber6 added a comment. Fix for real after rebasing failure... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423468. jhuber6 added a comment. Sorry for the spam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Ac

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423470. jhuber6 added a comment. Fix after fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Dri

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik updated this revision to Diff 423471. shafik marked 4 inline comments as done. shafik added a comment. - Making test more robust - Adding comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 Files: clang/lib/CodeGen/CGDebugInfo.cp

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Remove constraint that an initializing expression of struct type

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423478. jhuber6 added a comment. Hopefully this is the last time I need to update this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Dr

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423479. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Driver/Op

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Great, thanks for adding the test case! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://reviews.llvm.org/D122691 ___

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423482. hvdijk added a comment. Extend test, add assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk marked 2 inline comments as done. hvdijk added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubs

[PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#3453565 , @bowang wrote: >> Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work >> had been sitting in https://reviews.llvm.org/D102817/new/ since last May >> 2021. It's been reviewed, and feedba

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added a comment. Please add a test where calls to `@llvm.kcfi.check` produce `KCFI_CHECK` during instruction selection. (You can use `-stop-before=finalize-isel` to dump the IR prior to isel; this can stay a .ll test, I think, rather than .mir). Comment at: cl

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The script is located in the llvm/ sub-directory, so it is not available for when doing a stand-alone build. Repository: rG

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp: + + const MCSectionELF &ElfSec = static_cast(TextSec); + unsigned Flags = ELF::SHF_LINK_ORDER; nickdesaulniers wrote: > or just `cast`. > https://llvm.org/docs/ProgrammersM

[clang] 2d92ee9 - Reapply "[OpenMP] Refactor OMPScheduleType enum."

Author: Michael Kruse Date: 2022-04-18T21:56:47-05:00 New Revision: 2d92ee97f1afb3657579a46a7dd4611b61e9cc16 URL: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16 DIFF: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16.diff

[clang] cac4e2f - [CUDA][HIP] Fix gpu.used.external

Author: Yaxun (Sam) Liu Date: 2022-04-18T23:10:31-04:00 New Revision: cac4e2fe258239489c12dd5f153da3e69e17ebba URL: https://github.com/llvm/llvm-project/commit/cac4e2fe258239489c12dd5f153da3e69e17ebba DIFF: https://github.com/llvm/llvm-project/commit/cac4e2fe258239489c12dd5f153da3e69e17ebba.dif

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac4e2fe2582: [CUDA][HIP] Fix gpu.used.external (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123946/new

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423514. jhuber6 added a comment. Removing unnecessary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: mattd, guansong. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. When new operator is called in OpenMP parallel regi

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

yaxunl updated this revision to Diff 423515. yaxunl added a comment. remove redundant casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123976/new/ https://reviews.llvm.org/D123976 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/SemaCUDA/openmp-parallel.cu Index: clang/test/S

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 marked an inline comment as done. int3 added inline comments. Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:131-132 + size_t Size) { + if (Size == 0) +return; registerEHFramesInProcess(Addr, Size);

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 423532. int3 added a comment. Herald added a subscriber: dexonsmith. - Use a separate ForceDwarfUnwindInfo flag - Fix the remaining tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.l

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423542. ChuanqiXu added a comment. Address comments: - Add Cache in isInCurrentModule to avoid too many string comparisons. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/B

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; aaron.ballman wrote: > Isn't the same true for this variable? It seems like: > > `trivial` == `savedA

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:537-543 + static StringRef getPrimaryModuleInterfaceName(StringRef Name) { +return Name.split(':').first; + } + /// Get the primary module interface name from a partition. StringRef getPri

<    1   2