[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:489 + // Attn Reviewers: we need to do this for the function constraints for + // comparison of constraints to work, but do we also need to do it for + // CheckInstantiatedFunctionConstraints? That on

[clang] 97e4960 - [Clang][CSKY] Add the CSKY target and compiler driver

Author: Zi Xuan Wu Date: 2022-04-06T11:37:37+08:00 New Revision: 97e496054a378131227262109c856f89b288c309 URL: https://github.com/llvm/llvm-project/commit/97e496054a378131227262109c856f89b288c309 DIFF: https://github.com/llvm/llvm-project/commit/97e496054a378131227262109c856f89b288c309.diff LO

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97e496054a37: [Clang][CSKY] Add the CSKY target and compiler driver (authored by zixuan-wu). Changed prior to commit: https://reviews.llvm.org/D12

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14461 if (!ResultType->isDependentType() && !ResultType->isVoidType() && - !FD->isInvalidDecl() && + !FD->isInvalidDecl() && !FnDeleted && RequireCompleteType(FD->getLocation(), ResultTyp

[clang] 9906d38 - [NFC][CSKY] Fix the test error in toolchain case in windows by add UNSUPPORTED: system-windows

Author: Zi Xuan Wu Date: 2022-04-06T12:18:54+08:00 New Revision: 9906d38252d112894f304ba1b4fbdcd2cc93ab19 URL: https://github.com/llvm/llvm-project/commit/9906d38252d112894f304ba1b4fbdcd2cc93ab19 DIFF: https://github.com/llvm/llvm-project/commit/9906d38252d112894f304ba1b4fbdcd2cc93ab19.diff LO

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

dyung added a comment. Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/2452 Repository: rG LLVM Github Monore

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ updated this revision to Diff 420701. NoQ added a comment. - Eliminate notes on known paths. - Add some documentation for the new class. - Mostly moved from existing documentation for the entire summary class. - Fix incorrect assessment that Exploded Graph is a tree. It's not even acyclic

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added a comment. I think interestingness definitely requires more work. In particular, in null dereference from `getenv()`, the note should be unprunable. But we can't control prunability dynamically yet, so it requires a bit more work. So I think this patch is ok to go and I'll hopefully f

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rjmccall added a comment. In D116203#3430332 , @aaron.ballman wrote: > In D116203#3425512 , @cjdb wrote: > >> I've noticed that libstdc++ has `using __remove_cv = typename >> remove_cv::type`, which causes Clang

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG330268ba346b: [Support/Hash functions] Change the `final()` and `result()` of the hashing… (authored by akyrtzi). Repository: rG LLVM Github Monor

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

NoQ added a comment. I looked up the history. I believe this refers to https://clang.llvm.org/docs/LanguageExtensions.html#memory-references-to-specified-segments: > Annotating a pointer with address space #256 causes it to be code generated > relative to the X86 GS segment register, address sp

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder added a comment. What patches are you talking about exactly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.llvm.org/D122885 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3431569 , @dyung wrote: > Hi, one of the tests you added. csky-toolchain.c seems to be failing on a > Windows build bot, and from a quick look, it appears to be a path separator > issue. Can you take a look? > > htt

[PATCH] D123182: [Concepts] Fix issue #53640

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constraints were used for overload resolution tie breaking even when it was not allowed because the functions had d

[PATCH] D123182: [Concepts] Fix issue #53640

royjacobson updated this revision to Diff 420708. royjacobson added a comment. Fixed missing doc for new argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D122885: [clang] Draft: Implement P1703R1

ChuanqiXu added a comment. In D122885#3431618 , @tbaeder wrote: > What patches are you talking about exactly? I mean D121588 D121589 D121590 D12159

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

steakhal accepted this revision. steakhal added a comment. LGTM. Please note that we dont guarantee abi nor api compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155 _

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

ChuanqiXu added a comment. In D119136#3421531 , @cor3ntin wrote: > In D119136#3418585 , @ChuanqiXu > wrote: > >> I've just skimmed over the patch and it is a little bit hard to understand >> for people who don't

<    1   2   3