[PATCH] D122413: [C++20][Modules] Limit ModuleInternalLinkage to modules-ts.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, dblaikie, Bigcheese, rsmith, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. At present, we are generating wrong code for C++20 mod

[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

alexfh added a comment. What's the right fix for this warning, using a literal of the same floating point type? Did you consider adding a fixit hint to the diagnostic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121306/new/ https://reviews.llvm.

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

davidxl added a comment. Should this be fixed in Clang (not generating coverage record)? Adding the logic here is a little confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122336/new/ https://reviews.llvm.org/D122336 _

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3405644 , @yihanaa wrote: > In D122248#3405166 , @erichkeane > wrote: > >> In D122248#3405062 , >> @aaron.ballman wrote: >> >>>

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 417976. dgoldman marked an inline comment as done. dgoldman added a comment. Properly handle generation and restoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179

[PATCH] D122417: [Clang][NFC] Prefer using variadic isa<> over non-variadic isa<>s

hkmatsumoto created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. hkmatsumoto requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Given that isa(A) is equivalent to isa(A)

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:449 +// For layout on Linux, we support up to 16 bytes. +if (getTriple().isOSLinux() && hasFeature("quadword-atomics")) { + MaxAtomicPromoteWidth = 128; Many `isOSLinux()` usage

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. Agreed. `DeclarationName::getAsString` is in no way marked deprecated though, so you could call that? `FieldDecl->getDeclName()->getAsString()` or the `DeclarationName` `operator<<` would both be equivalent with no threat of deprecation. Repository: rG LLVM Gith

[PATCH] D122417: [Clang][NFC] Prefer using variadic isa<> over non-variadic isa<>s

hkmatsumoto updated this revision to Diff 417982. hkmatsumoto added a comment. Correct unintended typo: Cxx -> CXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122417/new/ https://reviews.llvm.org/D122417 Files: clang-tools-extra/clangd/InlayHi

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417981. jyu2 added a comment. Address Alexey comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

dblaikie updated this revision to Diff 417985. dblaikie added a comment. Try Dean's suggestion of moving this check further down Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328 Files: clang/lib/Sema/Sem

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 ___

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem added a comment. In D122336#3405835 , @davidxl wrote: > Should this be fixed in Clang (not generating coverage record)? Adding the > logic here is a little confusing. @davidxl, I originally did that (not generating coverage records) because I thi

[clang] 0ee06c3 - [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

Author: Daniel Grumberg Date: 2022-03-24T17:44:00Z New Revision: 0ee06c31aa57576c05c7ca3e68d2cac9ddf59811 URL: https://github.com/llvm/llvm-project/commit/0ee06c31aa57576c05c7ca3e68d2cac9ddf59811 DIFF: https://github.com/llvm/llvm-project/commit/0ee06c31aa57576c05c7ca3e68d2cac9ddf59811.diff LO

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ee06c31aa57: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/n

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant added a comment. Thanks David. Is it possible to add a regression test for the problem that cropped up with the first try? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328 _

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

dblaikie updated this revision to Diff 417989. dblaikie added a comment. Add regression test for the -Wnon-c-typedef-for-linkage issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328 Files: clang/lib/Se

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

dblaikie added a comment. In D121328#3405623 , @deansturtevant wrote: > Aha! (I think). > If the code to test "isExternalVisible" is executed *after* the code to test > whether it's a C++ member function (the very next test), then the problem > wouldn'

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant accepted this revision. deansturtevant added a comment. This revision is now accepted and ready to land. This looks good from my standpoint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417990. yihanaa added a comment. Support dump bitwidth of bitfields, and unnamed bitfields. for example: struct Bar { unsigned c : 1; unsigned : 3; unsigned : 0; unsigned b; }; struct Bar { unsigned int c : 1 = 0 unsigned int : 3 = 0

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer && CurLexer->Is_Prag

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3405866 , @aaron.ballman wrote: > In D122248#3405644 , @yihanaa wrote: > >> In D122248#3405166 , @erichkeane >> wrote: >> >>> In D122

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:81 `Issue 50541 `_. - +- The builtin function __builtin_dump_struct would crash clang when the target + struct have bitfield. Now it fixed, and __buil

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

dblaikie added a comment. @aaron.ballman wouldn't mind your take on this to see if this seems sufficiently robust, tested, etc. (should I move the isExternallyVisible check even further down? So its side effects are even less impactful (maybe there are other warnings that care about this sort o

[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

efriedma added a comment. In D121306#3405824 , @alexfh wrote: > What's the right fix for this warning, using a literal of the same floating > point type? Probably? Depends on why you're trying to use equality on floating-point numbers; "x == 0.3" is in

Re: [PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

I had given this some thought. I have a very limited knowledge of the code in this space. IIUC this only matters if the idea of linkage can change, which would happen only if a tag name needs manufacturing, which can only happen in the case we ran across (someone check my logic here?). The other t

[clang] 6bb836a - Revert "[clang][deps] NFC: De-duplicate clang-cl tests"

Author: Gulfem Savrun Yeniceri Date: 2022-03-24T18:10:08Z New Revision: 6bb836af2a60a11580c97c92487e4cf644ca051a URL: https://github.com/llvm/llvm-project/commit/6bb836af2a60a11580c97c92487e4cf644ca051a DIFF: https://github.com/llvm/llvm-project/commit/6bb836af2a60a11580c97c92487e4cf644ca051a.d

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa marked an inline comment as done. yihanaa added a comment. Maybe add the changes under "Attribute Changes in Clang"? Comment at: clang/docs/ReleaseNotes.rst:81 `Issue 50541 `_. - +- The builtin function __builtin_dum

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:81 `Issue 50541 `_. - +- The builtin function __builtin_dump_struct would crash clang when the target + struct have bitfield. Now it fixed, and __buil

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. State in the description whether this is a partial or full revert of D121405 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; zixuan-wu wrote: > It's same name as `Language` variable above, and it cause compile error. > @

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417999. yihanaa marked an inline comment as done. yihanaa added a comment. Use ``FD->getDeclName().empty()`` instead of ``FD->getNameAsString().empty()`` Add a the format changes to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. Waitting for CI... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418001. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Please give Aaron a few hours (perhaps until tomorrow?) to take 1 last look before committing. Also, if you lack commit rights and need someone to commit for you, please provid

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418004. dgoldman added a comment. if/else formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

[clang] 7b498be - DebugInfo: Classify noreturn function types as non-reconstructible

Author: David Blaikie Date: 2022-03-24T18:53:14Z New Revision: 7b498beef03ae07bb98796461a957af836074b92 URL: https://github.com/llvm/llvm-project/commit/7b498beef03ae07bb98796461a957af836074b92 DIFF: https://github.com/llvm/llvm-project/commit/7b498beef03ae07bb98796461a957af836074b92.diff LOG:

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3406117 , @erichkeane wrote: > LGTM! Please give Aaron a few hours (perhaps until tomorrow?) to take 1 last > look before committing. > > Also, if you lack commit rights and need someone to commit for you, please >

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a tiny nit with one of the release notes. Comment at: clang/docs/ReleaseNotes.rst:140-144 +- Improve __builtin_dump_struct: + + - Support bitfields in struct and union. + + - Improve the du

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3406145 , @aaron.ballman wrote: > LGTM aside from a tiny nit with one of the release notes. I'd be happy to fix it In D122248#3406145 , @aaron.ballman wrote: > LGTM aside f

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3406162 , @yihanaa wrote: > In D122248#3406145 , @aaron.ballman > wrote: > >> LGTM aside from a tiny nit with one of the release notes. > > I'd be happy to fix it > > In D12

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

vsk added a subscriber: cishida. vsk added a comment. Sorry for ay delayed replies - I've switched teams at Apple and find it difficult to keep up with llvm reviews. > it's my understanding is that we might be generating coverage record for > unused functions for TAPI. Coverage function record

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

Mordante created this revision. Mordante added reviewers: serge-sans-paille, aaron.ballman. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D117296 removed wording for

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 418008. yihanaa added a comment. Put the dump format changes under the "Non-comprehensive list of changes in this release" heading instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://rev

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

asavonic updated this revision to Diff 418011. asavonic added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixed Clang build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121299/new/ https://reviews.llvm.org/

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

aaron.ballman accepted this revision. aaron.ballman added a comment. In D121328#3406017 , @dblaikie wrote: > @aaron.ballman wouldn't mind your take on this to see if this seems > sufficiently robust, tested, etc. (should I move the isExternallyVisible >

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3406180 , @erichkeane wrote: > In D122248#3406162 , @yihanaa wrote: > >> In D122248#3406145 , >> @aaron.ballman wrote: >> >>> LGTM as

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. Thank you for the fix and the improvements here, @yihanaa! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 ___ cfe-commits mailin

[clang] 27439a7 - [AMDGPU] New gfx940 mfma instructions

Author: Stanislav Mekhanoshin Date: 2022-03-24T12:12:52-07:00 New Revision: 27439a764230e5eb54568b2fc053a20c9005970f URL: https://github.com/llvm/llvm-project/commit/27439a764230e5eb54568b2fc053a20c9005970f DIFF: https://github.com/llvm/llvm-project/commit/27439a764230e5eb54568b2fc053a20c900597

[PATCH] D122044: [AMDGPU] New gfx940 mfma instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27439a764230: [AMDGPU] New gfx940 mfma instructions (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. R

[PATCH] D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree

mgorny created this revision. mgorny added reviewers: MaskRay, sunlin. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Change the code responsible for adding `../lib` directory relative to the clang executable directory to apply only if

[clang] d414451 - [CUDA][HIP] Fix hostness check with -fopenmp

Author: Yaxun (Sam) Liu Date: 2022-03-24T15:19:47-04:00 New Revision: d41445113bccaa037e5876659b4fd98d96af03e4 URL: https://github.com/llvm/llvm-project/commit/d41445113bccaa037e5876659b4fd98d96af03e4 DIFF: https://github.com/llvm/llvm-project/commit/d41445113bccaa037e5876659b4fd98d96af03e4.dif

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGd41445113bcc: [CUDA][HIP] Fix hostness check with -fopenmp (authored by yaxunl). Herald added a project: cla

[PATCH] D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree

MaskRay added a comment. Is `addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths);` from D108286 the issue? If yes, I lean toward reverting D108286 and possibly unsupporting `LIBCXX_LIBDIR_SUFFIX`. The multilib style `lib32`

[clang] 7faa956 - [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

Author: wangyihan Date: 2022-03-24T12:23:29-07:00 New Revision: 7faa95624eb3a01b75ccc391f32768ba70b3b630 URL: https://github.com/llvm/llvm-project/commit/7faa95624eb3a01b75ccc391f32768ba70b3b630 DIFF: https://github.com/llvm/llvm-project/commit/7faa95624eb3a01b75ccc391f32768ba70b3b630.diff LOG

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7faa95624eb3: [clang][CodeGen]Fix clang crash and add bitfield support in… (authored by yihanaa, committed by erichkeane). Changed prior to commit:

[clang] dd67e69 - [ASan] Reland of D116182 to always link asan_static library.

Author: Kirill Stoimenov Date: 2022-03-24T19:32:23Z New Revision: dd67e6972f85b4f0d00f7c68aea857b09e7a0b8a URL: https://github.com/llvm/llvm-project/commit/dd67e6972f85b4f0d00f7c68aea857b09e7a0b8a DIFF: https://github.com/llvm/llvm-project/commit/dd67e6972f85b4f0d00f7c68aea857b09e7a0b8a.diff L

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd67e6972f85: [ASan] Reland of D116182 to always link asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122407/new

[clang] 6e3e14f - [AMDGPU] Support gfx940 smfmac instructions

Author: Stanislav Mekhanoshin Date: 2022-03-24T12:40:42-07:00 New Revision: 6e3e14f600afa1fa64a699df97c8bbac6d0f8b5a URL: https://github.com/llvm/llvm-project/commit/6e3e14f600afa1fa64a699df97c8bbac6d0f8b5a DIFF: https://github.com/llvm/llvm-project/commit/6e3e14f600afa1fa64a699df97c8bbac6d0f8b

[PATCH] D122191: [AMDGPU] Support gfx940 smfmac instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e3e14f600af: [AMDGPU] Support gfx940 smfmac instructions (authored by rampitec). Herald added subscribers: cfe-commits, hsmhsm. Herald added a proje

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 418025. paulkirth added a comment. Add missing GenerateArgs call to propagate flags to the backend outside of cc1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Fi

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

MaskRay added a comment. In D122407#3406066 , @MaskRay wrote: > State in the description whether this is a partial or full revert of D121405 > ? The commit message does not mention D121405

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1554 + Twine(*Opts.DiagnosticsMisExpectTolerance), SA); + for (StringRef Sanitizer : serializeSanitizerKinds(Opts.SanitizeRecover)) I really don't understand wh

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, a second time. :-D Sorry for missing that the first time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122423/new/ https://

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains added a comment. In D122119#3400267 , @dblaikie wrote: > SOrry, I don't have much context here - the more informative (module/internal > linkage) diagnostic does seem better to me than saying "is not exported", > even if it's a bit esoteric for so

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418030. dgoldman added a comment. Another formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

tambre added inline comments. Comment at: clang/docs/ReleaseNotes.rst:95-96 +- The builtin function __builtin_dump_struct would crash clang when the target + struct have bitfield. Now it fixed, and __builtin_dump_struct support dump + the bitwidth of bitfields. + This fixes `

[PATCH] D122378: Be more explicit about -fvisibility= documentation

serge-sans-paille added a comment. thanks for the guidance. I'll check if I can update tablegen to generate possible options then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378 _

[clang] a6cdac4 - Eliminate extra set of simd variant function attribute.

Author: Jennifer Yu Date: 2022-03-24T13:27:28-07:00 New Revision: a6cdac48ffaf1aba9c2055db0ea92f8d25e629d8 URL: https://github.com/llvm/llvm-project/commit/a6cdac48ffaf1aba9c2055db0ea92f8d25e629d8 DIFF: https://github.com/llvm/llvm-project/commit/a6cdac48ffaf1aba9c2055db0ea92f8d25e629d8.diff L

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6cdac48ffaf: Eliminate extra set of simd variant function attribute. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 added a comment. In D122338#3405948 , @ABataev wrote: > LG Thank you so much Alexey. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988 if (isa(E)) { Pos = ParamPositions[FD]; } else { --

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains updated this revision to Diff 418038. iains marked 3 inline comments as done. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122119/new/ https://reviews.llvm.org/D122119 Files: clan

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:814-815 +diagExportedUnnamedDecl(S, UnnamedDeclKind::Namespace, D, BlockStart); + else +; // We allow an empty named namespace decl. +} else if (DC->getRedeclContext()->isFileContext()

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

iains updated this revision to Diff 418041. iains added a comment. rebased, renamed helper method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121095/new/ https://reviews.llvm.org/D121095 Files: clang/include/clang/Basic/LangOptions.def clan

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

sammccall updated this revision to Diff 418044. sammccall added a comment. Address comments from D121150 , except still need to add: - represent tokens as forestnodes - GLR parser operates on a range of tokens - limit GLR parser public interface - GLR parser nev

[PATCH] D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree

mgorny added a comment. In D122424#3406275 , @MaskRay wrote: > Is `addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths);` from D108286 > the issue? No, the issue is actually the hardcoded `lib` directory that breaks mu

[clang] e5a7d27 - [NFC][clang][extract-api] Add missing virtual anchors

Author: Zixu Wang Date: 2022-03-24T14:30:14-07:00 New Revision: e5a7d272ab04aef47bf9ae5a34ca34878353197c URL: https://github.com/llvm/llvm-project/commit/e5a7d272ab04aef47bf9ae5a34ca34878353197c DIFF: https://github.com/llvm/llvm-project/commit/e5a7d272ab04aef47bf9ae5a34ca34878353197c.diff LOG

[clang] 826e661 - [NFC][clang][extract-api] Rename variable

Author: Zixu Wang Date: 2022-03-24T15:12:40-07:00 New Revision: 826e661a96a2aa7eb309dbca16c85a3d05edcec8 URL: https://github.com/llvm/llvm-project/commit/826e661a96a2aa7eb309dbca16c85a3d05edcec8 DIFF: https://github.com/llvm/llvm-project/commit/826e661a96a2aa7eb309dbca16c85a3d05edcec8.diff LOG

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw marked an inline comment as done. zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; zixuw wrote: > zixuan-wu wrote: > > It's same name as `L

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

sammccall updated this revision to Diff 418059. sammccall added a comment. Parse terminal nodes instead of tokens directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122408/new/ https://reviews.llvm.org/D122408 Files: clang-tools-extra/pseudo

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw updated this revision to Diff 418061. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h Index: clang/lib/For

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

sammccall updated this revision to Diff 418062. sammccall added a comment. Pass terminal range into parser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122408/new/ https://reviews.llvm.org/D122408 Files: clang-tools-extra/pseudo/include/clang-p

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3405091 , @aaron.ballman wrote: > @thakis -- is it possible your build bot is configured to disable generation > of crash dumps? So with a lot of trial and error, it seems that on certain windows configurations, cr

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 418071. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnot

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:749 + if (Current.isNot(tok::comment) && + Previous.isConditionLParen(/*IncludeSpecial=*/true)) { // Treat the condition inside an if as if it w

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

sammccall updated this revision to Diff 418072. sammccall added a comment. Simplify shift, avoid some allocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122408/new/ https://reviews.llvm.org/D122408 Files: clang-tools-extra/pseudo/include/c

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 418073. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/Fo

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 2 inline comments as done. sstwcw added a comment. This is how checking for `while` changes behavior. diff --git a/flang/lib/Evaluate/tools.cpp b/flang/lib/Evaluate/tools.cpp index 68b2a40d48c5..3f811fee9bad 100644 --- a/flang/lib/Evaluate/tools.cpp +++ b/flang/lib/Evaluate/

[PATCH] D122443: [OpenMP] Replace device kernel linkage with weak_odr

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: asavonic, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked 9 inline comments as done. sstwcw added a comment. I tried formatting the files in `clang-formatted-files.txt`. Besides the files in the list that get changed when formatted with the program built from `main`, none gets changed when I format them with the program built from this pa

[clang] bfda793 - [OpenMP] Add a semantic check for updating hidden or internal values

Author: Joseph Huber Date: 2022-03-24T19:38:30-04:00 New Revision: bfda79341bb5e5d8eb9a8fa63958ecfe75f57d78 URL: https://github.com/llvm/llvm-project/commit/bfda79341bb5e5d8eb9a8fa63958ecfe75f57d78 DIFF: https://github.com/llvm/llvm-project/commit/bfda79341bb5e5d8eb9a8fa63958ecfe75f57d78.diff

[PATCH] D122403: [OpenMP] Add a semantic check for updating hidden or internal values

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfda79341bb5: [OpenMP] Add a semantic check for updating hidden or internal values (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D122403?vs=417932&id=418078#toc Repository:

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains updated this revision to Diff 418079. iains added a comment. rebased, added a testcase for multiple inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 Files: clang/include/clang/Basic/Diagnos

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 418081. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/new/ https://reviews.llvm.org/D121097 Files: clang/include/clang/Basic/Module.h clang/include/clang/Serialization/A

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 418082. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 418083. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121099/new/ https://reviews.llvm.org/D121099 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/Pre

[clang] fed96f3 - Re-commit: Driver: Don't warn on -mbranch-protection when linking

Author: Tom Stellard Date: 2022-03-24T16:57:42-07:00 New Revision: fed96f31bb5b68f77dd617ee8e698dd8171ee71b URL: https://github.com/llvm/llvm-project/commit/fed96f31bb5b68f77dd617ee8e698dd8171ee71b DIFF: https://github.com/llvm/llvm-project/commit/fed96f31bb5b68f77dd617ee8e698dd8171ee71b.diff

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem added a comment. In D122336#3406186 , @vsk wrote: > Sorry for ay delayed replies - I've switched teams at Apple and find it > difficult to keep up with llvm reviews. > >> it's my understanding is that we might be generating coverage record for >>

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

vsk added a comment. So long as it doesn't change behavior expected by tapi on Darwin, I think it's OK. I doubt any other platforms are similarly affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122336/new/ https://reviews.llvm.org/D122336

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem added a comment. In D122336#3406843 , @vsk wrote: > So long as it doesn't change behavior expected by tapi on Darwin, I think > it's OK. I doubt any other platforms are similarly affected. I don't think it should impact TAPI because it relies on

<    1   2   3   >