[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains added inline comments. Comment at: clang/test/Driver/cxx20-header-units-01.cpp:7 + +// RUN: %clang++ -### -std=c++20 -xc++-header-unit-header %S/Inputs/header-unit-01.hh 2>&1 | \ +// RUN: FileCheck -check-prefix=CHECK-ABS %s -DTDIR=%S/Inputs vsapsai wrot

[PATCH] D121873: [clang][extract-api] Add enum support

sammccall added a comment. Hey, apologies for missing the initial patch in D119479 . This sounds really interesting! The lack of docs make it very difficult to understand what this library is for and how to use it if you don't already know. It's not clear what

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains added a comment. In D121588#3390956 , @vsapsai wrote: > Thanks for explaining the desired interplay between PCH and PCM. The problem > I'm seeing is that it can be hard to find correct compiler flags to achieve > the desired result (what is enable

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

vsapsai accepted this revision. vsapsai added a comment. Thanks for your patience and for all the explanations, I have no other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121588/new/ https://reviews.llvm.org/D121588 __

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham planned changes to this revision. bnbarham added a comment. Blocked on the dependent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121425/new/ https://reviews.llvm.org/D121425 ___ cfe-commits ma

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

vsapsai added a comment. I don't know how "intsafe.h" looks like and how it is involved with the modules (it's not in winsdk.modulemap as far as I can tell). My immediate guess would be that "intsafe.h" doesn't include all the headers that are supposed to provide necessary macros. And if "intsa

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added a comment. I've looked into the details as much as I can and I don't find explicit errors. --- It is better to add tests in clang/unittest by using `VarDecl::isNRVOVariable()`. Comment at: clang/include/clang/Sema/Scope.h:533-535 +if (NRVO.getPointer() !=

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

ChuanqiXu added a comment. I feel good if we could add the test from: http://eel.is/c++draft/cpp.import#8. Comment at: clang/include/clang/Serialization/ASTWriter.h:21 #include "clang/Basic/LLVM.h" +#include "clang/Basic/Module.h" #include "clang/Basic/SourceLocation.h"

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2855-2857 + assert((DashX.getHeaderUnit() == InputKind::HeaderUnit_None || + Inputs.size() == 1) && + "Expected only one input file for header unit"); iains w

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3388842 , @rengolin wrote: > I'm surprised these tests are passing for you. Perhaps you're not building or > running them all. > > To make sure you're running your tests, you need to build both clang and llvm > (`-D

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \ hubert.reinterpretcast wrote: > hubert.reinterpret

[clang] 9247145 - [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

Author: Kai Luo Date: 2022-03-18T13:22:28+08:00 New Revision: 9247145fbae7c4273acd6b8f3b331716ca80bf18 URL: https://github.com/llvm/llvm-project/commit/9247145fbae7c4273acd6b8f3b331716ca80bf18 DIFF: https://github.com/llvm/llvm-project/commit/9247145fbae7c4273acd6b8f3b331716ca80bf18.diff LOG:

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9247145fbae7: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Scope.h:518 void addNRVOCandidate(VarDecl *VD) { +// every candidate except VD is "spoiled" now, remove them from the set Firstly I am wondering why here doesn't check `NRVO.getInt()`

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \ lkail wrote: > hubert.reinterpret

[PATCH] D121678: [pseudo] Split greatergreater token.

uabelho added a comment. Hello, It seems like the new testcase fails when run with sanitizers: https://lab.llvm.org/buildbot/#/builders/5/builds/20833 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678

[PATCH] D119479: [clang][extract-api] Add global record support

uabelho added a comment. In D119479#3389684 , @zixuw wrote: > In D119479#3388498 , @uabelho wrote: > >> Hello, >> >> Did you see this sanitizer error when running global_record.c? >> >> https://lab.llvm.org/buildb

<    1   2   3