[clang] 3587b15 - [Clang] [P2025] More exhaustive tests for NRVO

2022-03-16 Thread Evgeny Shulgin via cfe-commits
Author: Evgeny Shulgin Date: 2022-03-17T03:58:40+03:00 New Revision: 3587b15abe683f164093f8d057e921f913572007 URL: https://github.com/llvm/llvm-project/commit/3587b15abe683f164093f8d057e921f913572007 DIFF: https://github.com/llvm/llvm-project/commit/3587b15abe683f164093f8d057e921f913572007.diff

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

2022-03-16 Thread Evgeny Shulgin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3587b15abe68: [Clang] [P2025] More exhaustive tests for NRVO (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119927/new/ https://reviews

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

2022-03-16 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 416040. vitalybuka added a comment. addressing some @kda comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119300/new/ https://reviews.llvm.org/D119300 Files: clang/lib/CodeGen/CGClass.cpp clang/te

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

2022-03-16 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121815/new/ https://reviews.llvm.org/D121815

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

2022-03-16 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.cpp:67-68 + +// Undefining a macro invalidates adjacent macros +// from being considered as an enum. +#defi

[clang] c5ea8e9 - Use-after-dtor detection for trivial base classes.

2022-03-16 Thread Vitaly Buka via cfe-commits
Author: Evgenii Stepanov Date: 2022-03-16T18:20:27-07:00 New Revision: c5ea8e9138931b74b60221f667da304e244dc57d URL: https://github.com/llvm/llvm-project/commit/c5ea8e9138931b74b60221f667da304e244dc57d DIFF: https://github.com/llvm/llvm-project/commit/c5ea8e9138931b74b60221f667da304e244dc57d.di

[clang] cb96464 - Stricter use-after-dtor detection for trivial members.

2022-03-16 Thread Vitaly Buka via cfe-commits
Author: Evgenii Stepanov Date: 2022-03-16T18:20:27-07:00 New Revision: cb96464f12c44320150c48d639070cf0e4fd8bd2 URL: https://github.com/llvm/llvm-project/commit/cb96464f12c44320150c48d639070cf0e4fd8bd2 DIFF: https://github.com/llvm/llvm-project/commit/cb96464f12c44320150c48d639070cf0e4fd8bd2.di

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

2022-03-16 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb96464f12c4: Stricter use-after-dtor detection for trivial members. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github Mo

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

2022-03-16 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5ea8e913893: Use-after-dtor detection for trivial base classes. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github Monore

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

2022-03-16 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I don't have an example module sadly. It was something that I ran into with Swift code import the WinSDK module defined in https://github.com/apple/swift/blob/main/stdlib/public/Platform/winsdk.modulemap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

2022-03-16 Thread Julian Lettner via Phabricator via cfe-commits
yln added a comment. I've added 2 additional calls to `initializeLowerGlobalDtorsLegacyPassPass()`. The one in the constructor of the legacy pass should ensure that the pass is always registered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1217

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

2022-03-16 Thread Julian Lettner via Phabricator via cfe-commits
yln added a comment. Plan to land tomorrow morning. Test passes on the Debian bot : PASS: LLVM :: Transforms/LowerGlobalDestructors/lower-global-dtors.ll (72299 of 93291) Repository: rG

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

2022-03-16 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. I have updated the patch. Any more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

2022-03-16 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 416051. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121753/new/ https://reviews.llvm.org/D121753 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/Unwrappe

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

2022-03-16 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:947 + /* C# */ \ + KEYWORD(dollar, 0)

[PATCH] D121756: [clang-format] Clean up code looking for if statements

2022-03-16 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 416052. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format

[PATCH] D121756: [clang-format] Clean up code looking for if statements

2022-03-16 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 4 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:133 Left->ParentBracket != tok::less && -(isKeywordWithCondition(*Line.First) || - CurrentToken->getStartOfNonWhitespace() =

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

2022-03-16 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 416057. khchen added a comment. Herald added subscribers: s, arichardson. rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120228/new/ https://reviews.llvm.org/D120228 Files: clang/include/clang/

[PATCH] D121846: [clang-format] Correctly recognize binary operators in template arguments with parenthesized literals.

2022-03-16 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2186 + NextNonParen = NextNonParen->getNextNonComment(); +} +if (NextNonParen && (NextNonParen->Tok.isLiteral() || Remove braces. :) Repo

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

2022-03-16 Thread Owen Pan via Phabricator via cfe-commits
owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. Because this patch would impact inserting/removing braces, we must test it against a large codebase. Before I landed `RemoveBracesLLVM` and `InsertBraces`, I had tested them with `

<    1   2   3