[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. In D121233#3384495 , @thakis wrote: > Is there a reason why this can't be part of clang-tools-extra/test This was discussed pretty extensively in the review above. Other projects across LLVM use proj/{lib,include,unittest,test}

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's Bugzilla, but unfortunately there's been no response for almost a week. I'm even not sure there's really a bug fix for GCC or not. Can you guys decide how to deal with this issue? Repository: rG L

[clang-tools-extra] e4cab4e - [lit] Remove clang_libs_dir

Author: Sam McCall Date: 2022-03-16T03:03:02+01:00 New Revision: e4cab4e24d17e4a434d0edd6d7d037f0d05ced36 URL: https://github.com/llvm/llvm-project/commit/e4cab4e24d17e4a434d0edd6d7d037f0d05ced36 DIFF: https://github.com/llvm/llvm-project/commit/e4cab4e24d17e4a434d0edd6d7d037f0d05ced36.diff LO

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. In D121098#3383835 , @iains wrote: >> I am a little bit confused for the intuition. Couldn't we just import the >> pre-processed header? What's the problem? Could you elaborate on this? > > We cannot import a pre-processed file

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song updated this revision to Diff 415665. yonghong-song retitled this revision from "[Clang] Fix an unused-but-set-variable warning with compond assignment" to "[Clang] Fix an unused-but-set-variable warning with volatile variable". yonghong-song edited the summary of this revision. yon

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song added inline comments. Comment at: clang/test/Sema/warn-unused-but-set-variables.c:66 + for (int i = 0; i < 1000; i++) +j += 1; + return; efriedma wrote: > The handling of this testcase without your patch seems fine. Even if the > value of j

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall created this revision. sammccall added reviewers: hokein, thakis, mgorny. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall updated this revision to Diff 415672. sammccall added a comment. add gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121763/new/ https://reviews.llvm.org/D121763 Files: clang-tools-extra/clangd/test/CMakeLists.txt clang-tools-extra/

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added a comment. Trolling for reviewers: @hokein: this is another -10 lines per test suite! @thakis: the GN changes seem trivial (no standalone build) but wonder if you have opinions @mgorny: because I don't truly understand the standalone build, and only hope I'm getting this right

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a subscriber: rsmith. ChuanqiXu added a comment. @rsmith told me that the ideal situation would combine C++20 modules and clang modules together in D113391 I think the most important thing here is to get in consensus for the module status. Here

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415677. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-noexcept.cpp Index: clang

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: carlosgalvezp, guansong. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CUDA/HIP determines whether a function can

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead commandeered this revision. pcwang-thead edited reviewers, added: zixuan-wu; removed: pcwang-thead. pcwang-thead added a comment. Herald added a subscriber: arichardson. Herald added a project: All. In D70401#3250049 , @khchen wrote: > 1. plea

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 415684. lkail added a comment. Fix typo; Add `pwr7` and `pwr8` as `-target-cpu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/ato

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. In D121425#3384492 , @dexonsmith wrote: > Can you be more detailed about the overall state at the time of `cat`, which > causes it to fail? Sure. I think there's also some confusion with names here but I'm generally trying to

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

vsapsai added a comment. Sorry, I'm pretty ignorant in this area but based on > The job construction is altered to build a C++20 header unit (rather than a > PCH file, as would be the case for other headers). I want to clarify. The goal is to allow mixing PCH and PCM files, right? I haven't do

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:101 + + auto b = [](int n) constexpr { +if (!n) I think a lambda marked `constexpr` and one that isn't has fundamental differences in behaviour in rel

[PATCH] D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous

vsapsai added a comment. My concern with this approach is I'm not sure if `isEquivalentInternalLinkageDeclaration` is a desired long-term solution for anonymous C++ enums. If it is, we can piggy-back on it, otherwise hitching our wagon to this train might be undesirable. Also I need to check t

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle reminder @JonasToth @alexfh @aaron.ballman @njames93 @LegalizeAdulthood Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.org/D

[PATCH] D121670: [RISCV] Add zihintntl instructions

s updated this revision to Diff 415703. s added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add preprocessor test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 File

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:425 + /// values in order to be included in misexpect diagnostics. + Optional DiagnosticsMisExpectTollerance = 0; + s/Tollerance/Tolerance/ (and elsewhere throughout patch)

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:745 - ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, &endLoc, + ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullpt

<    1   2   3