void updated this revision to Diff 414500.
void added a comment.
Improve bad cast warning message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120857/new/
https://reviews.llvm.org/D120857
Files:
clang/include/clang/AST/Decl.h
clang/include/c
efriedma updated this revision to Diff 414499.
efriedma added a comment.
Drop _except; __except is a contextual keyword.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
Files:
clang/include/clang/Basic/
Author: Eli Friedman
Date: 2022-03-10T14:49:16-08:00
New Revision: 27a574962567224d3a36a70cf8abf0ad3d751ec5
URL:
https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5
DIFF:
https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rG27a574962567: [Sema][Windows] Don't special-case void*
in __unaligned conversions. (authored by efriedma).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1209
andrew.w.kaylor added a comment.
This example illustrates the problem this patch intends to fix:
https://godbolt.org/z/j445sxPMc
For Intel microarchitectures before Skylake, the LLVM cost model says that
vector fsqrt is slow, so if fast-math is enabled, we'll use an approximation
rather than t
Author: Sam McCall
Date: 2022-03-10T23:57:27+01:00
New Revision: 7f0df31ee3f596c36a0bb6af4248aaf431541e3a
URL:
https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a
DIFF:
https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a.diff
LO
Author: Zequan Wu
Date: 2022-03-10T15:00:32-08:00
New Revision: d54c4df31470044a66605ebb8a2f936e8dd552af
URL:
https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af
DIFF:
https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af.diff
LOG
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd54c4df31470: [clang-format] Fix namespace format when the
name is followed by a macro (authored by zequanwu).
Changed prior to commit:
https://reviews.llvm.org/D121269?vs=414442&id=414506#toc
Reposito
andrew.w.kaylor added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067
+ // favor this processor.
+ TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName();
+}
Unfortunately, I don't think it's this easy. The list of name
jyu2 added inline comments.
Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622
+if (InTy->isIntegerType() || InTy->isPointerType() ||
+InTy->isStructureType() || InTy->isConstantArrayType())
InputDomain = AD_Int;
Are you sure you want to change the
sammccall created this revision.
sammccall added reviewers: aaron.ballman, hokein.
Herald added subscribers: usaxena95, kadircet.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang-tools-extra
bnbarham created this revision.
bnbarham added reviewers: keith, dexonsmith, JDevlieghere, vsapsai.
Herald added a subscriber: carlosgalvezp.
Herald added a project: All.
bnbarham requested review of this revision.
Herald added projects: clang, LLDB, LLVM, clang-tools-extra.
Herald added subscriber
bnbarham added inline comments.
Comment at: llvm/include/llvm/Support/Error.h:1284
- StringRef getFileName() { return FileName; }
+ StringRef getFileName() const { return FileName; }
Should this be in a change all by itself?
Repository:
rG LLVM Github M
sammccall created this revision.
sammccall added reviewers: aaron.ballman, hokein.
Herald added subscribers: usaxena95, kadircet, arphaman, delcypher.
Herald added a project: All.
sammccall requested review of this revision.
Herald added projects: LLVM, clang-tools-extra.
Herald added subscribers:
bnbarham abandoned this revision.
bnbarham added a comment.
Herald added a project: All.
Rather than trying to fix nested RedirectingFileSystems, I've instead put up a
bunch of patches to simplify RedirectingFileSystem. This does mean we can't
"chain" remappings any more, but that seems like a g
dexonsmith added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273
+ // However, some module maps loaded implicitly during the dependency scan can
+ // describe anti-dependencies. That happens when the current module is marked
+ /
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120474/new/
https://reviews.llvm.org/D120474
__
rnk added a subscriber: rsmith.
rnk added a comment.
@rsmith has previously advocated for a policy of only permitting conforming
language extensions under fms-extensions. These single underscore names are not
in the implementors namespace, so he has argued they should be under
fms-compatibility
efriedma added a comment.
That makes sense, sure. -fms-compatibility is on by default for clang-cl
anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
___
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067
+ // favor this processor.
+ TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName();
+}
andrew.w.kaylor wrote:
> Unfortunately, I don't think it's this ea
4vtomat created this revision.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence,
vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton,
Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,
edward-jones, zzheng, jrtc27, kit
benshi001 updated this revision to Diff 414538.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121359/new/
https://reviews.llvm.org/D121359
Files:
clang/lib/Basic/Targets/AVR.cpp
clang/lib/Driver/ToolChains/AVR.cpp
clang/test/Misc/target-invalid-cpu-note.c
llvm/lib/Target/AVR/AVRD
kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121431/new/
https://reviews.llvm.org/D121431
__
owenpan created this revision.
owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks.
owenpan added a project: clang-format.
Herald added a project: All.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Also increases
kerbowa updated this revision to Diff 414559.
kerbowa added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add clang builtin and tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120976/new/
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rG25df633c243f: Split up large test files(over 10k lines)
under clang/test/CodeGen/RISCV… (authored by 4vtomat).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
vsapsai updated this revision to Diff 414565.
vsapsai added a comment.
Fix tests on Debian by using `-fobjc-nonfragile-abi` explicitly as declaring
ivars in extensions is supported only with non-fragile ABI.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
lkail created this revision.
lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC.
Herald added subscribers: steven.zhang, shchenz, nemanjai.
Herald added a project: All.
lkail requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
owenpan updated this revision to Diff 414572.
owenpan added a comment.
Swapped the order of the definitions of `BracesRemover` and `BracesInserter`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121434/new/
https://reviews.llvm.org/D121434
Files:
clang/lib/Format/Format.cpp
Index: c
lkail updated this revision to Diff 414574.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
clang/test/Sema/atomic-ops.c
Index: clang/test/Sema/ato
lkail updated this revision to Diff 414575.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
clang/test/Sema/atomic-ops.c
Index: clang/test/Sema/ato
chhzh123 added a comment.
Hi @ftynse , could you please take a look at it and see if there is anything
that should be changed? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
lkail updated this revision to Diff 414583.
lkail added a comment.
Add `-verify`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
clang/test/Sema/a
zixuan-wu created this revision.
zixuan-wu added reviewers: rengolin, kito.cheng, rsmith, asb, DavidSpickett,
kaz7.
Herald added subscribers: krytarowski, mgorny.
Herald added a project: All.
zixuan-wu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe
kavitha-natarajan updated this revision to Diff 414577.
kavitha-natarajan added a comment.
@aprantl Updated the comments following LLVM coding style.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120989/new/
https://reviews.llvm.org/D120989
Files:
Hiralo created this revision.
Hiralo added a reviewer: vsk.
Hiralo added a project: clang.
Herald added subscribers: dexonsmith, wenlei, dang.
Herald added a project: All.
Hiralo requested review of this revision.
Herald added a subscriber: cfe-commits.
commit 87f30be546daca55664ded147acceb9f20639
kavitha-natarajan added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3921
+ return cast(GVE);
+return dyn_cast_or_null(N);
+ }
aprantl wrote:
> When would we enter a nullptr into the cache?
In this change, only llvm::DIImportedEntity e
101 - 137 of 137 matches
Mail list logo