[PATCH] D120857: WIP [randstruct] Add randomize structure layout support

2022-03-10 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 414500. void added a comment. Improve bad cast warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h clang/include/c

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

2022-03-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 414499. efriedma added a comment. Drop _except; __except is a contextual keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412 Files: clang/include/clang/Basic/

[clang] 27a5749 - [Sema][Windows] Don't special-case void* in __unaligned conversions.

2022-03-10 Thread Eli Friedman via cfe-commits
Author: Eli Friedman Date: 2022-03-10T14:49:16-08:00 New Revision: 27a574962567224d3a36a70cf8abf0ad3d751ec5 URL: https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5 DIFF: https://github.com/llvm/llvm-project/commit/27a574962567224d3a36a70cf8abf0ad3d751ec5.diff

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

2022-03-10 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG27a574962567: [Sema][Windows] Don't special-case void* in __unaligned conversions. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1209

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

2022-03-10 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. This example illustrates the problem this patch intends to fix: https://godbolt.org/z/j445sxPMc For Intel microarchitectures before Skylake, the LLVM cost model says that vector fsqrt is slow, so if fast-math is enabled, we'll use an approximation rather than t

[clang-tools-extra] 7f0df31 - [clang-tools-extra] Don't consider python below LLVM_MINIMUM_PYTHON_VERSION. NFC

2022-03-10 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-03-10T23:57:27+01:00 New Revision: 7f0df31ee3f596c36a0bb6af4248aaf431541e3a URL: https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a DIFF: https://github.com/llvm/llvm-project/commit/7f0df31ee3f596c36a0bb6af4248aaf431541e3a.diff LO

[clang] d54c4df - [clang-format] Fix namespace format when the name is followed by a macro

2022-03-10 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2022-03-10T15:00:32-08:00 New Revision: d54c4df31470044a66605ebb8a2f936e8dd552af URL: https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af DIFF: https://github.com/llvm/llvm-project/commit/d54c4df31470044a66605ebb8a2f936e8dd552af.diff LOG

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-10 Thread Zequan Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd54c4df31470: [clang-format] Fix namespace format when the name is followed by a macro (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D121269?vs=414442&id=414506#toc Reposito

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

2022-03-10 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} Unfortunately, I don't think it's this easy. The list of name

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-10 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; Are you sure you want to change the

[PATCH] D121422: [clang-tools-extra] Reuse llvm_config.use_clang() to set up test environment

2022-03-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: aaron.ballman, hokein. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

2022-03-10 Thread Ben Barham via Phabricator via cfe-commits
bnbarham created this revision. bnbarham added reviewers: keith, dexonsmith, JDevlieghere, vsapsai. Herald added a subscriber: carlosgalvezp. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added subscriber

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

2022-03-10 Thread Ben Barham via Phabricator via cfe-commits
bnbarham added inline comments. Comment at: llvm/include/llvm/Support/Error.h:1284 - StringRef getFileName() { return FileName; } + StringRef getFileName() const { return FileName; } Should this be in a change all by itself? Repository: rG LLVM Github M

[PATCH] D121427: [lit] add lit_config.substitute to interpolate lit_config.params

2022-03-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: aaron.ballman, hokein. Herald added subscribers: usaxena95, kadircet, arphaman, delcypher. Herald added a project: All. sammccall requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers:

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

2022-03-10 Thread Ben Barham via Phabricator via cfe-commits
bnbarham abandoned this revision. bnbarham added a comment. Herald added a project: All. Rather than trying to fix nested RedirectingFileSystems, I've instead put up a bunch of patches to simplify RedirectingFileSystem. This does mean we can't "chain" remappings any more, but that seems like a g

[PATCH] D120465: [clang][deps] Disable implicit module maps

2022-03-10 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273 + // However, some module maps loaded implicitly during the dependency scan can + // describe anti-dependencies. That happens when the current module is marked + /

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

2022-03-10 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120474/new/ https://reviews.llvm.org/D120474 __

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

2022-03-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a subscriber: rsmith. rnk added a comment. @rsmith has previously advocated for a policy of only permitting conforming language extensions under fms-extensions. These single underscore names are not in the implementors namespace, so he has argued they should be under fms-compatibility

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

2022-03-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. That makes sense, sure. -fms-compatibility is on by default for clang-cl anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412 ___

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

2022-03-10 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} andrew.w.kaylor wrote: > Unfortunately, I don't think it's this ea

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

2022-03-10 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat created this revision. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kit

[PATCH] D121359: [AVR] Add more devices

2022-03-10 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 414538. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121359/new/ https://reviews.llvm.org/D121359 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Driver/ToolChains/AVR.cpp clang/test/Misc/target-invalid-cpu-note.c llvm/lib/Target/AVR/AVRD

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

2022-03-10 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121431/new/ https://reviews.llvm.org/D121431 __

[PATCH] D121434: [clang-format][NFC] Group QualifierAlignment with other C++ passes

2022-03-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also increases

[PATCH] D120976: [AMDGPU] Add llvm.amdgcn.s.setprio intrinsic

2022-03-10 Thread Austin Kerbow via Phabricator via cfe-commits
kerbowa updated this revision to Diff 414559. kerbowa added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add clang builtin and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120976/new/ https://reviews.llv

[PATCH] D121431: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV including:

2022-03-10 Thread Brandon Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG25df633c243f: Split up large test files(over 10k lines) under clang/test/CodeGen/RISCV… (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

2022-03-10 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 414565. vsapsai added a comment. Fix tests on Debian by using `-fobjc-nonfragile-abi` explicitly as declaring ivars in extensions is supported only with non-fragile ABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

2022-03-10 Thread Kai Luo via Phabricator via cfe-commits
lkail created this revision. lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC. Herald added subscribers: steven.zhang, shchenz, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D121434: [clang-format][NFC] Group QualifierAlignment with other C++ passes

2022-03-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 414572. owenpan added a comment. Swapped the order of the definitions of `BracesRemover` and `BracesInserter`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121434/new/ https://reviews.llvm.org/D121434 Files: clang/lib/Format/Format.cpp Index: c

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

2022-03-10 Thread Kai Luo via Phabricator via cfe-commits
lkail updated this revision to Diff 414574. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index: clang/test/Sema/ato

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

2022-03-10 Thread Kai Luo via Phabricator via cfe-commits
lkail updated this revision to Diff 414575. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index: clang/test/Sema/ato

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

2022-03-10 Thread Hongzheng Chen via Phabricator via cfe-commits
chhzh123 added a comment. Hi @ftynse , could you please take a look at it and see if there is anything that should be changed? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

2022-03-10 Thread Kai Luo via Phabricator via cfe-commits
lkail updated this revision to Diff 414583. lkail added a comment. Add `-verify`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/a

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

2022-03-10 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, kito.cheng, rsmith, asb, DavidSpickett, kaz7. Herald added subscribers: krytarowski, mgorny. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D120989: Support debug info for alias variable

2022-03-10 Thread Kavitha Natarajan via Phabricator via cfe-commits
kavitha-natarajan updated this revision to Diff 414577. kavitha-natarajan added a comment. @aprantl Updated the comments following LLVM coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989 Files:

[PATCH] D121446: Add -no-unused-coverage option

2022-03-10 Thread Hiral via Phabricator via cfe-commits
Hiralo created this revision. Hiralo added a reviewer: vsk. Hiralo added a project: clang. Herald added subscribers: dexonsmith, wenlei, dang. Herald added a project: All. Hiralo requested review of this revision. Herald added a subscriber: cfe-commits. commit 87f30be546daca55664ded147acceb9f20639

[PATCH] D120989: Support debug info for alias variable

2022-03-10 Thread Kavitha Natarajan via Phabricator via cfe-commits
kavitha-natarajan added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3921 + return cast(GVE); +return dyn_cast_or_null(N); + } aprantl wrote: > When would we enter a nullptr into the cache? In this change, only llvm::DIImportedEntity e

<    1   2