[clang] 9abeb80 - [Driver][OpenBSD] Disable unwind tables on Arm

2022-03-09 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2022-03-09T20:33:16-05:00 New Revision: 9abeb80e80d0f2e9dd7603491d33fa0683a33ac1 URL: https://github.com/llvm/llvm-project/commit/9abeb80e80d0f2e9dd7603491d33fa0683a33ac1 DIFF: https://github.com/llvm/llvm-project/commit/9abeb80e80d0f2e9dd7603491d33fa0683a33ac1.diff LO

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

2022-03-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei updated this revision to Diff 414251. wenlei added a comment. Herald added projects: clang, All. Herald added a subscriber: cfe-commits. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D12061

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414252. yonghong-song added a comment. - clang-format fix - change variable names to be llvm compliant. - remove Attr from BTFTagAttributedTypeLoc as it can be retrieved from the BTFTagAttributedType - Also transform the attribute in TreeTransform - add

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

2022-03-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. In D120610#3348997 , @dblaikie wrote: > This should include a test - and could you describe more about where this > issue came up/what motivated the change? Sure, sorry for the delay as I just got back to this today. I sent the f

[clang] 6730b44 - [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-03-09T20:57:27-05:00 New Revision: 6730b44480fcce18bfbbae0c46719250e9eae425 URL: https://github.com/llvm/llvm-project/commit/6730b44480fcce18bfbbae0c46719250e9eae425 DIFF: https://github.com/llvm/llvm-project/commit/6730b44480fcce18bfbbae0c46719250e9eae425.dif

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6730b44480fc: [HIP] Fix HIP include path (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120132/new/ http

[clang] da9a703 - [HIP] Fix -fno-gpu-sanitize

2022-03-09 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-03-09T20:58:50-05:00 New Revision: da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff URL: https://github.com/llvm/llvm-project/commit/da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff DIFF: https://github.com/llvm/llvm-project/commit/da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff.dif

[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda9a70313d60: [HIP] Fix -fno-gpu-sanitize (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

2022-03-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D118352#3371425 , @h-vetinari wrote: > Something must have gone wrong... communication-wise... as @urnathan seems to > have abandoned (resp. resigned from) all modules PRs. Hope any > misunderstandings or grievances can be

[clang] 89c94c2 - [clang][Driver] Get darwin -Xarch_ working for subtypes, again.

2022-03-09 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2022-03-09T18:21:45-08:00 New Revision: 89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 URL: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 DIFF: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2.diff

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414263. yonghong-song added a comment. - further clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/include/clang-c/Index.h cl

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414267. yonghong-song added a comment. - use BTFTypeTagAttr instead of Attr in PropertiesBase.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

2022-03-09 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review, Chuanqi! I believe you were touching recently `isSameEntity`. Do you have any concerns about using `StructuralEquivalenceContext` instead of `isSameEntity`? I've decided to go with `StructuralEquivalenceContext` because at this point we are still

[PATCH] D121352: [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

2022-03-09 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @aaron.ballman @erichkeane Hopefully I addressed your comments. Could you take a look again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 ___

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 414276. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:679 + !llvm::isPowerOf2_32(OutSize)) +targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg); + jyu2 wrote: > Error message is not very clear to me. I think we

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 414277. pengfei added a comment. Remove outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

2022-03-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D121177#3371695 , @vsapsai wrote: > Thanks for the review, Chuanqi! I believe you were touching recently > `isSameEntity`. Do you have any concerns about using > `StructuralEquivalenceContext` instead of `isSameEntity`? I'v

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-09 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___

<    1   2