[clang] 1c55f05 - Properly diagnose constant evaluation issues at TU scope

Author: Aaron Ballman Date: 2022-03-08T10:19:15-05:00 New Revision: 1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 URL: https://github.com/llvm/llvm-project/commit/1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 DIFF: https://github.com/llvm/llvm-project/commit/1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3.diff

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've committed in 1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

sfertile added a comment. Thanks for the updates Zarko. I think we are almost there. Comment at: clang/lib/Sema/SemaChecking.cpp:5242 +// Here we try to get information about the alignment of the struct member +// from the struct passed to the caller function.We only warn when

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h:30 +// A node in a forest. +class ForestNode { +public: sammccall wrote: > I wonder if we should put these in a namespace `forest::Node` rather than > giving them the

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3366825 , @aaron.ballman wrote: > In D121078#3366025 , @tonic wrote: > >> In D121078#3365542 , @SimplyDanny >> wrote: >> >>> In D121078

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 413818. ZarkoCA added a comment. - Restructured checks - fixed comment - removed unnecessary parameter passed to function - slightly reworded summary of patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5255 + const auto *PVD = dyn_cast( + (dyn_cast( + (dyn_cast(Arg->IgnoreParens()))->getSubExpr())) sfertile wrote: > I find these l

[clang] 9bb8c80 - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-08T09:45:15-08:00 New Revision: 9bb8c80beaa0da12ae29913faa45db2add152be7 URL: https://github.com/llvm/llvm-project/commit/9bb8c80beaa0da12ae29913faa45db2add152be7 DIFF: https://github.com/llvm/llvm-project/commit/9bb8c80beaa0da12ae29913faa45db2add152be7.diff

[PATCH] D121153: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBuiltin.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb8c80beaa0: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121153/new

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev updated this revision to Diff 413852. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121197/new/ https://reviews.llvm.org/D121197 Files: clang/i

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

whisperity added a comment. Is "partial aliasing" a new notion? Or... is the alias not partial, but the coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121214/new/ https://reviews.llvm.org/D121214 _

[clang] 550b2ea - [RISCV] Add combination crypto extensions in ISAInfo

Author: eopXD Date: 2022-03-08T09:52:38-08:00 New Revision: 550b2eaaa6e402ce664fe55c038e5fe387258af7 URL: https://github.com/llvm/llvm-project/commit/550b2eaaa6e402ce664fe55c038e5fe387258af7 DIFF: https://github.com/llvm/llvm-project/commit/550b2eaaa6e402ce664fe55c038e5fe387258af7.diff LOG: [R

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG550b2eaaa6e4: [RISCV] Add combination crypto extensions in ISAInfo (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:20 +/// +/// FIXME: Consider separating the models from the unchecked access analysis. +class UncheckedOptionalAccessModel ymandel wrote: >

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:20 +/// +/// FIXME: Consider separating the models from the unchecked acce

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 413861. yonghong-song added a comment. - address @erichkeane comments - further TODO: add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: cl

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @erichkeane Just posted a patch to address your comments. Could you take a look? I will try to add more tests, esp. serialization and libclang. If you have any suggestions in these two areas (as I am not familiar with them), it would be great! Repository: rG L

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

andrew.w.kaylor added a comment. The fix for the eval_method crash should be moved to a separate patch. Otherwise, this looks good. I have only minor comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1600 +} else { + OS << getTUFPEvalMethod(); + // __FLT_E

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall created this revision. sammccall added reviewers: hokein, aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added projects: clang, clang-tools-extra. This

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

clementval accepted this revision. clementval added a comment. In D121198#3366774 , @awarzynski wrote: > In D121198#3366741 , @clementval > wrote: > >> I’m not sure this is a feature we want to expose in the mai

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. Herald added a subscriber: ormris. @hokein I talked about making some headers private, but realized that change really is unrelated, and would be confusing to mix in here. This is awkward to review. I think the main things to check: - whether the intended renames (see

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

erichkeane added a comment. I don't particularly understand this qualifier, is this something that perhaps @rnk could take a look at? Comment at: clang/test/SemaCXX/MicrosoftExtensions.cpp:88 __unaligned B_unaligned *p3 = 0; - int p4 = foo_unaligned(p3); + int p4 = foo_u

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. In D119910#3364920 , @ychen wrote: > In D119910#3364892 , @thakis wrote: > >> Looks like this breaks tests on mac and win: >> http://45.33.8.238/win/54551/step_7.txt >> http://45.33.8.238/ma

[clang] 8321579 - [flang][driver] Add support for `-debug-dump-pft`

Author: Andrzej Warzynski Date: 2022-03-08T19:21:58Z New Revision: 8321579b2830d1475a69306a02b61789f8ca3cf7 URL: https://github.com/llvm/llvm-project/commit/8321579b2830d1475a69306a02b61789f8ca3cf7 DIFF: https://github.com/llvm/llvm-project/commit/8321579b2830d1475a69306a02b61789f8ca3cf7.diff

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8321579b2830: [flang][driver] Add support for `-debug-dump-pft` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121198/new/ https://

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D121078#3367289 , @tonic wrote: > In D121078#3366825 , @aaron.ballman > wrote: >

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > cjdb wrote: > > owenpan wrote: > > > Do we still n

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. Herald added a project: All. Should we backport this to the release/14.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ c

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

NoQ added a comment. I guess there's the usual direction that I occasionally suggest: develop a way to verify that all possible paths were explored during symbolic execution (`CoreEngine::hasWorkRemaining()` on steroids), then do most of the work in `checkEndAnalysis`. We also already have `al

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, rsmith. Herald added a subscriber: jdoerfert. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC supports: - `namespace identifie

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 413913. iains added a comment. updated to remove a single-use variable. Having some difficulty in reproducing the CI fails outside the harness, however the code setting the removed variable could have faulted if there was no macro data for the identifier. Se

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Precommit CI is failing: Failed Tests (1): Clang :: Headers/stdbool.c Comment at: clang/lib/Headers/stdbool.h:18 +#warning \ +"the header is deprecated in C2x. bool, t

<    1   2