[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:72 SmallString<256> FilePath(SP.getDirectory()); sys::path::append(FilePath, SP.getFilename()); sys::path::native(FilePath); These sys::path calls introduce host-dependence, and

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like I hit submit too early... I wanted to say the path thing is a pre-existing issue, and it seems reasonable to address that as a separate patch. If you don't have plans to do a follow up p

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S <

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

2022-03-04 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. @phosek @rovka no need those changes for `CrossWinToARMLinux.cmake`. `TARGET_TRIPLE` is using to parametrize the cache file only. But if there is a goal to completely remove `TARGET_TRIPLE` from the source tree I will update the cache file and the buildbot configura

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S < %

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413149. sstwcw marked 2 inline comments as done. sstwcw added a comment. Herald added a project: All. Take out things in other revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

2022-03-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM, but please wait for other reviewers in case they have more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://r

[PATCH] D120288: [OpenMP] Implement dense map info for device file

2022-03-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added a project: All. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120288/new/ https://reviews.llvm.org/D120288 __

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

2022-03-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Herald added a project: All. @saiislam Ok to postpone the bundle entry usage to a follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413152. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/dump_

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 7 inline comments as done. sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type, fi

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S <

[clang] 9129743 - [Docs] List __has_feature(dataflow_sanitizer) in LanguageExtensions docs.

2022-03-04 Thread Andrew Browne via cfe-commits
Author: Andrew Browne Date: 2022-03-04T15:48:07-08:00 New Revision: 9129743dde267f7ff678441c64bdfb9e24f7b448 URL: https://github.com/llvm/llvm-project/commit/9129743dde267f7ff678441c64bdfb9e24f7b448 DIFF: https://github.com/llvm/llvm-project/commit/9129743dde267f7ff678441c64bdfb9e24f7b448.diff

[clang] be57057 - [clang-format] fix namepsace format when the name is macro expansion

2022-03-04 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2022-03-04T16:01:17-08:00 New Revision: be5705767aad8d8eafd40225f7dba8e7e661c6b5 URL: https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5 DIFF: https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5.diff LOG

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

2022-03-04 Thread Zequan Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5705767aad: [clang-format] fix namepsace format when the name is macro expansion (authored by zequanwu). Repository: rG LLVM Github Monorepo CH

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-03-04 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S <

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

2022-03-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Is it ok to land this change? Or shall we continue to wait on @NoQ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 ___ cfe-commits

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

2022-03-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Is it ok to land this change? Or shall we continue to wait on @NoQ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___ cfe-commits

[clang] 3be9e0b - [WebAssembly] Check bulk-memory when adjusting lang opts

2022-03-04 Thread Thomas Lively via cfe-commits
Author: Thomas Lively Date: 2022-03-04T16:07:16-08:00 New Revision: 3be9e0ba972cc3486971f745a606e2c44472b655 URL: https://github.com/llvm/llvm-project/commit/3be9e0ba972cc3486971f745a606e2c44472b655 DIFF: https://github.com/llvm/llvm-project/commit/3be9e0ba972cc3486971f745a606e2c44472b655.diff

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

2022-03-04 Thread Thomas Lively via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3be9e0ba972c: [WebAssembly] Check bulk-memory when adjusting lang opts (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file.

2022-03-04 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka created this revision. vvereschaka added a reviewer: vvereschaka. Herald added subscribers: kristof.beyls, mgorny. Herald added a project: All. vvereschaka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid using `TARGET_TRIP

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

2022-03-04 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:123 + if (Constraints1.empty() || Constraints2.empty()) { +// Disjunction of empty set and non-empty set is represented as empty set. +return JoinedConstraints;

[clang] d860ac5 - [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file. NFC.

2022-03-04 Thread Vladimir Vereschaka via cfe-commits
Author: Vladimir Vereschaka Date: 2022-03-04T16:39:28-08:00 New Revision: d860ac5da6d71dd759d347a3c7d5e63705443694 URL: https://github.com/llvm/llvm-project/commit/d860ac5da6d71dd759d347a3c7d5e63705443694 DIFF: https://github.com/llvm/llvm-project/commit/d860ac5da6d71dd759d347a3c7d5e63705443694

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file. NFC.

2022-03-04 Thread Vlad Vereschaka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd860ac5da6d7: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm… (authored by vvereschaka). Repository: rG LLVM Github

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

2022-03-04 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth created this revision. Herald added a subscriber: hiraditya. paulkirth updated this revision to Diff 409705. paulkirth added a comment. paulkirth updated this revision to Diff 409797. tstellar added a subscriber: serge-sans-paille. paulkirth edited the summary of this revision. paulkirth

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

2022-03-04 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. This change seems to be causing many bots to fail when running the clang :: Preprocessor/init.c test, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/18081 https://lab.llvm.org/buildbot/#/builders/216/builds/881 https://lab.llvm.org/buildbot/#/buil

LLVM build master will be restarted at 9pm PST today

2022-03-04 Thread Galina Kistanova via cfe-commits
Hello, LLVM build master will be restarted at 9pm PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c01ec30 - [WebAssembly] Update Preprocessor/init.c test after 3be9e0ba972c

2022-03-04 Thread Thomas Lively via cfe-commits
Author: Thomas Lively Date: 2022-03-04T18:40:10-08:00 New Revision: c01ec3083026f7e24e6c06f48a05d413e2c697d4 URL: https://github.com/llvm/llvm-project/commit/c01ec3083026f7e24e6c06f48a05d413e2c697d4 DIFF: https://github.com/llvm/llvm-project/commit/c01ec3083026f7e24e6c06f48a05d413e2c697d4.diff

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

2022-03-04 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo &FrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeSta

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

2022-03-04 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. @dyung, this should be fixed by https://reviews.llvm.org/rGc01ec3083026f7e24e6c06f48a05d413e2c697d4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121014/new/ https://reviews.llvm.org/D121014 __

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

2022-03-04 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo &FrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeSt

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

2022-03-04 Thread Anmol P. Paralkar via Phabricator via cfe-commits
appcs added a comment. In D23934#3355355 , @emaste wrote: > The original author appears to have given up on it. Someone will need to > rebase and work on pushing it forward Please see: https://reviews.llvm.org/D121040 CHANGES SINCE LAST ACTION https:

[clang] fa9c8ba - [RISCV] Support k-ext clang intrinsics

2022-03-04 Thread Shao-Ce SUN via cfe-commits
Author: Shao-Ce SUN Date: 2022-03-05T13:57:18+08:00 New Revision: fa9c8bab0c7a7aed423191baa8a980533ae5602a URL: https://github.com/llvm/llvm-project/commit/fa9c8bab0c7a7aed423191baa8a980533ae5602a DIFF: https://github.com/llvm/llvm-project/commit/fa9c8bab0c7a7aed423191baa8a980533ae5602a.diff L

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-03-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

2022-03-04 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 413195. junaire added a comment. This update proibit any use of ({}) in the default argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files: clang/include/c

[PATCH] D121042: [clang-format] Handle goto labels for RemoveBracesLLVM

2022-03-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

<    1   2