[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:51 +template +using MatchSwitch = std::function; + --

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. And the PS4 build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/18001 https://lab.llvm.org/buildbot/#/builders/216/builds/801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D12

[clang] 56eaf86 - [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

Author: Shivam Date: 2022-03-04T00:21:06+05:30 New Revision: 56eaf869be27585bff7320505dfad32b5b3b6189 URL: https://github.com/llvm/llvm-project/commit/56eaf869be27585bff7320505dfad32b5b3b6189 DIFF: https://github.com/llvm/llvm-project/commit/56eaf869be27585bff7320505dfad32b5b3b6189.diff LOG: [

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 412772. njames93 added a comment. Herald added a project: All. Moved tests into ASTMatchersInternal, makes sense in here and removes the dirty clang-tidy plugin hack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

ymandel added a comment. Can you rollback until a fix is found? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108 + template >>::value, +int> = 0> Given that we're simply passing this off to the NoMetadataImpl which accepts a std::function, I don't see a

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:116 + explicit Transformer(transformer::RewriteRuleWith Rule, + ConsumerFn Consumer); asoffer wrote: > li.zhe

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

shafik added a comment. Looks like it also broke lldb green dragon incremental as well: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41865/consoleFull#-27141295349ba4694-19c4-4d7e-bec5-911270d8a58c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108 + template >>::value, +int> = 0> asoffer wrote: > Given that we're simply passing this off to the NoMetadataImpl which accepts > a std::f

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

HazardyKnusperkeks added a comment. In D120884#3356751 , @kwk wrote: > In D120884#3356746 , > @HazardyKnusperkeks wrote: > >> Please use the clang-format tag. > > Yes, sorry that I forgot it again. And thank you

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 412793. njames93 added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 Files: clang-tools-extra/docs/ReleaseNotes.rst clang/lib/ASTMa

[clang] 94623fb - [NFC] move CheckInstantiatedFunctionTemplateConstraints to SemaConcepts.cpp

Author: Erich Keane Date: 2022-03-03T11:47:20-08:00 New Revision: 94623fb1c94841a3abc818c4d99a7154a9ed7df2 URL: https://github.com/llvm/llvm-project/commit/94623fb1c94841a3abc818c4d99a7154a9ed7df2 DIFF: https://github.com/llvm/llvm-project/commit/94623fb1c94841a3abc818c4d99a7154a9ed7df2.diff L

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua updated this revision to Diff 412799. li.zhe.hua added a comment. Try removing all the SFINAE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files: clang-tools-extra/clang-tidy/abseil/Cleanu

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu created this revision. zequanwu added reviewers: klimek, sammccall. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Originally filed at crbug.com/1184570. When the name of a namespace is a macr

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 412810. jhuber6 added a comment. Herald added a project: All. Updating to use fatbinaries and fatbinary magic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files:

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This path refactor

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412812. jhuber6 added a comment. Herald added a subscriber: dang. Herald added a project: All. Updating, embed fatbinaries now and small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https:

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

efriedma created this revision. efriedma added reviewers: rnk, mstorsjo, andreybokhanko, majnemer, aaron.ballman. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. As far as I can tell, MSVC allows the relevant conversions for all pointer typ

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412816. jhuber6 added a comment. Adding comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/i

[clang] d74a3a5 - Fixed sphinx build due to indentation

Author: Aaron Ballman Date: 2022-03-03T16:03:05-05:00 New Revision: d74a3a514cf64731ecd21e1453aa78af79a565f2 URL: https://github.com/llvm/llvm-project/commit/d74a3a514cf64731ecd21e1453aa78af79a565f2 DIFF: https://github.com/llvm/llvm-project/commit/d74a3a514cf64731ecd21e1453aa78af79a565f2.diff

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412821. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua updated this revision to Diff 412823. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files: clang-too

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108 + template >>::value, +int> = 0> li.zhe.hua wrote: > asoffer wrote: > > Given that we're simply passing this off to the NoMetadataImpl whi

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412826. ZarkoCA added a comment. - Try to remove deeply nested ifs by using early returns - Fix note so it refers to struct - Add a struct that isn't called byval in test case to make it clearer that warning isn't emitted on every declaration Repository:

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, Should this be `" : "` instead? Comment at: clang/lib/ASTMatchers/AST

[PATCH] D114425: [clang] Add __builtin_bswap128

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11071-11072 -QualType ElementType = DecodeTypeFromStr(Str, Context, Error, - RequiresICE, false); +QualType ElementType = +DecodeTypeFromStr

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, aaron.ballman wrote: > Should this be `" : "` instead? Good catch Comment

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4099-4102 + for (auto &Arg : Args.getAllArgValues(options::OPT_offload_arch_EQ)) +Archs.insert(getCanonicalArchString(C, Args, Arg, Kind)); + for (auto &Arg : Args.getAllArgValues(options::OPT_no_offload_

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:796 +MV.ActiveASTContext->getSourceManager()); +} else if (const auto *T = Item.second.get()) { + OS << T->getTypeClassName() << "Type :

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4099-4102 + for (auto &Arg : Args.getAllArgValues(options::OPT_offload_arch_EQ)) +Archs.insert(getCanonicalArchString(C, Args, Arg, Kind)); + for (auto &Arg : Args.getAllArgValues(options::OPT_no_offload

[PATCH] D114425: [clang] Add __builtin_bswap128

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11071-11072 -QualType ElementType = DecodeTypeFromStr(Str, Context, Error, - RequiresICE, false); +QualType ElementType = +DecodeTypeFromStr(Str, C

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:796 +MV.ActiveASTContext->getSourceManager()); +} else if (const auto *T = Item.second.get()) { + OS << T->getTypeClassName() << "Type : "; --

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. Essentially looks good to me now, thanks! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, njames93 wrote: > aaron.ballman wrote: > > Should

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira planned changes to this revision. joaomoreira added inline comments. Herald added a project: All. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-p

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412840. ZarkoCA added a comment. - Remove formatting changes to unrelated code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/include/clang/Basic/Diag

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5246 + + if (const auto *ICE = dyn_cast(Arg->IgnoreParens())) { +if (const auto *DR = dyn_cast(ICE->getSubExpr())) { sfertile wrote: > Nit: To avoid the deep nesting, can we instead h

[clang] 19c1b08 - [CMake] Update cache file for Win to ARM cross tooolchain. NFC.

Author: Vladimir Vereschaka Date: 2022-03-03T14:32:16-08:00 New Revision: 19c1b084a7da9087fcdc16071b461ea33b6a68b4 URL: https://github.com/llvm/llvm-project/commit/19c1b084a7da9087fcdc16071b461ea33b6a68b4 DIFF: https://github.com/llvm/llvm-project/commit/19c1b084a7da9087fcdc16071b461ea33b6a68b4

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:76 +"int j;\n" +"}// namespace", +fixNamespaceEndComments("#define M(x) x##x\n" but its not an anonymous namespace? wou

[PATCH] D118004: [hmaptool] Fix dumping

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118004/new/ https://reviews.llvm.org/D118004

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118005/new/ https://reviews.llvm.org/D118005

[clang] 0c1d330 - [hmaptool] Fix dumping

Author: Shoaib Meenai Date: 2022-03-03T15:18:09-08:00 New Revision: 0c1d330431f59011fd861e291d5048858a973c5a URL: https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a DIFF: https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a.diff

[PATCH] D118004: [hmaptool] Fix dumping

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1d330431f5: [hmaptool] Fix dumping (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118004/new/ https://reviews.llvm.org/D118004 Files

[clang] b4c1cbf - [hmaptool] Fix string decoding for Python 3

Author: Shoaib Meenai Date: 2022-03-03T15:18:21-08:00 New Revision: b4c1cbff79d0631c35ca2efa97bd2a47929945b8 URL: https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8 DIFF: https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8.diff

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c1cbff79d0: [hmaptool] Fix string decoding for Python 3 (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118005/new/ https://reviews.l

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3356355 , @pengfei wrote: > Good question! This is actually the scope of ABI. Unfortunately, we don't > have the BF16 ABI at the present. We can't assume what are the physical > registers the arguments been pa

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

bruno requested changes to this revision. bruno added a comment. This revision now requires changes to proceed. Herald added a project: All. > It would be nice to have some mechanism to notify developers that includes > are still performed regardless of requires I'd like to see a module remark f

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:86 +"int j;\n" +"}// namespace A::M", +fixNamespaceEndComments("#define M(x) x##x\n" MyDeveloperDay wrote: > same here its not

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu updated this revision to Diff 412856. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/Form

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: njames93, aaron.ballman, ymandel. LegalizeAdulthood added a project: clang-tools-extra. Herald added a project: All. LegalizeAdulthood requested review of this revision. Herald added a project: clang. Document how to creat

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. In D120395#3358453 , @andrew.w.kaylor wrote: > In D120395#3356355 , @pengfei wrote: > >> Good question! This is actually the scope of ABI. Unfortunately, we don't >> have the BF16 A

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. In D120395#3358533 , @craig.topper wrote: > In D120395#3358453 , > @andrew.w.kaylor wrote: > >> In D120395#3356355 , @pengfei >> wrote: >>

[PATCH] D120949: [clang][AST matchers] adding hasSubStmt matcher under attributedStmt so we can actually match the stmt inside the attribute is attached to

ajohnson-uoregon created this revision. Herald added a project: All. ajohnson-uoregon requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. fixing to use new [[clang::matcher_block]] attr and clean up some old code; currently i

[PATCH] D120949: [clang][AST matchers] adding hasSubStmt matcher under attributedStmt so we can actually match the stmt inside the attribute is attached to

ajohnson-uoregon updated this revision to Diff 412871. ajohnson-uoregon added a comment. Herald added a reviewer: aaron.ballman. Fixing to actually have the right commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llv

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313 break; + if ((*J)->Level == TheLine->Level) +return false; To be safe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412873. ajohnson-uoregon added a comment. Still doesn't have right files/commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/include/clang

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412875. ajohnson-uoregon added a comment. Still trying to get right commits, apologies XD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang-tool

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412877. ajohnson-uoregon added a comment. updated resolution rules to try to get right commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412878. ajohnson-uoregon added a comment. arcanist why Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412879. ajohnson-uoregon added a comment. Herald added a reviewer: aaron.ballman. maybe this will work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files:

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412882. ajohnson-uoregon added a comment. had to split a commit because past me messed up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang-tool

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412883. ajohnson-uoregon added a comment. getting the commit range right, finally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/include/clan

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon added a comment. Okay this is actually the right commits now, sorry about the spam, Aaron. 🙃 Didn't realize I'd put unrelated things in the first commit. The names for isAttr and hasSubStmt are up for debate, I just picked things that were close enough and weren't already in us

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

ajohnson-uoregon created this revision. ajohnson-uoregon added reviewers: klimek, jdoerfert. Herald added a subscriber: yaxunl. Herald added a project: All. ajohnson-uoregon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adding more AST ma

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 412886. ChuanqiXu added a comment. Address comments: - File an issue and add a reference to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp clang/test/CodeGenCXX/in

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() { + dblaikie

[PATCH] D120954: adding a check that the number of arguments given in the matcher is the same as the number of arguments in the matched code

ajohnson-uoregon created this revision. Herald added a project: All. ajohnson-uoregon requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120954 Files: clang-tools-

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

ajohnson-uoregon created this revision. ajohnson-uoregon added reviewers: klimek, jdoerfert. Herald added a project: All. ajohnson-uoregon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. new AST matcher that checks the actual number of argu

[PATCH] D120959: [clang][AST matchers] new hasExpectedReturnType submatcher for ReturnStmts

ajohnson-uoregon created this revision. ajohnson-uoregon added reviewers: klimek, jdoerfert. Herald added a project: All. ajohnson-uoregon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. new AST matcher that matches the expected return type

[PATCH] D120954: adding a check that the number of arguments given in the matcher is the same as the number of arguments in the matched code

ajohnson-uoregon abandoned this revision. ajohnson-uoregon added a comment. created by accident Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120954/new/ https://reviews.llvm.org/D120954 ___ cfe-commits

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu updated this revision to Diff 412899. ChuanqiXu added a comment. Format tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/search-partitions.cpp Index: clang/test/Mod

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added inline comments. Comment at: clang/test/Modules/search-partitions.cppm:20 +//--- partition1.cpp +export module A : Part1; + iains wrote: > ChuanqiXu wrote: > > @MyDeveloperDay hi, I remember the support for partitions in clang-format > > is done

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. If I don't misread the codes, it looks like `mangleModuleInitializer` is not called. --- Now we could add test for partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 __

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

tschuett added a comment. Stupid question: this works with Windows as well? And the `BTW` sounds odd. gcc also decided to use a dash as the separator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 ___

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

tschuett added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:199 + // The separator of C++20 modules partitions (':') is not good for file + // systems, here we choose '-' by default since it is not a valid + // character of C++ indentifiers. So we co

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 412901. ajohnson-uoregon added a comment. making clang-format happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/include/clang/ASTMatchers/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412908. jhuber6 added a comment. Correctly handle offloading architecture options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/

[PATCH] D120967: [NFC] Divide tests into smaller files

4vtomat created this revision. Herald added subscribers: luke957, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project:

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu updated this revision to Diff 412928. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/search-partitions.cpp Index: clang/test

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D120874#3358870 , @tschuett wrote: > Stupid question: this works with Windows as well? And the `BTW` sounds odd. > gcc also decided to use a dash as the separator. It should work

[clang] 9c300c1 - [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

Author: phyBrackets Date: 2022-03-04T12:17:58+05:30 New Revision: 9c300c18a4eaf79eb7044744bbdb705764579220 URL: https://github.com/llvm/llvm-project/commit/9c300c18a4eaf79eb7044744bbdb705764579220 DIFF: https://github.com/llvm/llvm-project/commit/9c300c18a4eaf79eb7044744bbdb705764579220.diff L

[PATCH] D120967: [NFC] Divide tests into smaller files

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Do you mind give more comment on SUMMARY to describe what you did? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://rev

[PATCH] D120967: [NFC] Divide tests into smaller files

4vtomat added a comment. In D120967#3359188 , @kito-cheng wrote: > LGTM, but do you mind give more comment on SUMMARY to describe what you did? You are right lol. I've added some~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313 break; + if ((*J)->Level == TheLine->Level) +return false; owenpan wrote: > To be safe? Good idea. Will do. Any idea how to provoke thi

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. Thanks for fixing the problem with the original commit, but in the future, if you make follow-up commits, can you change the commit message to reflect what the commit contains? Having three different commits with the exact same commit message can be very confusing. Repo

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added a comment. I would recommend committing changes in the morning, to give some time for the bots to chew through your commit. This way you could react to breakages and revert if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Cool. Lets not punish Florian for improving things. If anyone want to go and split this file sensibly, that sounds good. In the meantime this LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei added a comment. > if we define the `__bfloat16` type as the built-in `__bf16` type, then the > front end can apply whatever rules it has for that type, including adding > whatever ABI handling is needed for BF16 values. I don't agree. Unlike `__fp16`, `__bf16` is simple an ARM specific

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Same as D120875 , if anyone wants to split this up more naturally that would be good, but until then this LGTM. Repository: rG LLVM Github Monorepo CHAN

<    1   2