[clang] f1315c6 - [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

2022-02-28 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-28T12:53:09-08:00 New Revision: f1315c61a03ea6ef72ec11522f9abecd782f4856 URL: https://github.com/llvm/llvm-project/commit/f1315c61a03ea6ef72ec11522f9abecd782f4856 DIFF: https://github.com/llvm/llvm-project/commit/f1315c61a03ea6ef72ec11522f9abecd782f4856.diff

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

2022-02-28 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1315c61a03e: [docs] Add note about interaction between clang plugins and -clear-ast-before… (authored by aeubanks). Repository: rG LLVM Github Mo

[clang-tools-extra] de9611b - [NFC] Don't pass temporary LangOptions to Lexer

2022-02-28 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-02-28T12:53:59-08:00 New Revision: de9611befeebeb85324062cb1ae8978a82a09e26 URL: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26 DIFF: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26.di

[clang] 092f15a - [HIP] File device library ABI version file name

2022-02-28 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-02-28T16:24:50-05:00 New Revision: 092f15ac40ce35d077e0225a4462bc4dfa379391 URL: https://github.com/llvm/llvm-project/commit/092f15ac40ce35d077e0225a4462bc4dfa379391 DIFF: https://github.com/llvm/llvm-project/commit/092f15ac40ce35d077e0225a4462bc4dfa379391.dif

[PATCH] D120557: [HIP] File device library ABI version file name

2022-02-28 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG092f15ac40ce: [HIP] File device library ABI version file name (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https:

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

2022-02-28 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray marked 4 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > lichray wrote: > > aaron.ballman wrote: > > > We're a

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

2022-02-28 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

2022-02-28 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mll

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

2022-02-28 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. There seem to be regressions on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/81394#c0e8e7e4-1f70-47d3-852a-e65469d70c41 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.or

[PATCH] D120132: [HIP] Fix HIP include path

2022-02-28 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D120132#3349538 , @tra wrote: > In D120132#3345534 , @yaxunl wrote: > >> I just found one issue with the current patch. It adds HIP include path for >> non-HIP programs. >> >> We should

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

2022-02-28 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA updated this revision to Diff 411912. ZarkoCA retitled this revision from "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function" to "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function". Zar

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

2022-02-28 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D119949#3338818 , @junaire wrote: > Gentle ping~ Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 __

[PATCH] D120132: [HIP] Fix HIP include path

2022-02-28 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D120132#3349936 , @yaxunl wrote: > Users may use clang driver to compile HIP program and C++ program with one > clang driver invocation, e.g. > > clang --offload-arch=gfx906 a.hip b.cpp > > Clang driver will create job actions f

[PATCH] D111457: [test] Add lit helper for windows paths

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 411921. keith marked 3 inline comments as done. keith edited the summary of this revision. keith added a comment. Use the actual drive on windows, split out into fssrcroot and fstmproot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 411922. keith added a comment. Update tests with new syntax and FileCheck variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/CodeGen/CGDebugIn

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 411923. keith added a comment. Update test with new variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/te

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 411926. keith added a comment. Fix parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/rela

[PATCH] D111457: [test] Add lit helper for windows paths

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ probinson wrote: > rnk wrote: > > It is pretty common to run the LLVM test suite on secondary drives, > > esp

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

2022-02-28 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I would structure this as a LangOpt, and feed the target checks and ABI compat checks into the default setting for it. It could be something like `DefaultedSMFArePOD` / `-f[no-]defaulted-smf-are-pod` (smf being special member functions). The LangOpt default is true, and the

[PATCH] D111457: [test] Add lit helper for windows paths

2022-02-28 Thread Keith Smiley via Phabricator via cfe-commits
keith added a comment. For reference here's an example of a test that uses this https://reviews.llvm.org/D111579 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 __

[PATCH] D111457: [test] Add lit helper for windows paths

2022-02-28 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 136b293 - [c++2b] Implement P0849R8 auto(x)

2022-02-28 Thread Zhihao Yuan via cfe-commits
Author: Zhihao Yuan Date: 2022-02-28T19:21:08-06:00 New Revision: 136b2931292083c8d69c09de9b952c86417b2c5d URL: https://github.com/llvm/llvm-project/commit/136b2931292083c8d69c09de9b952c86417b2c5d DIFF: https://github.com/llvm/llvm-project/commit/136b2931292083c8d69c09de9b952c86417b2c5d.diff L

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

2022-02-28 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG136b29312920: [c++2b] Implement P0849R8 auto(x) (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] d1a59ee - [Clang] Remove redundant init-parens in AST print

2022-02-28 Thread Zhihao Yuan via cfe-commits
Author: Zhihao Yuan Date: 2022-02-28T19:31:16-06:00 New Revision: d1a59eefd3a09f08ba425a20899fbd1766babc45 URL: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45 DIFF: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45.diff L

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

2022-02-28 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a59eefd3a0: [Clang] Remove redundant init-parens in AST print (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Are there any other errors now? @krasimir @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits ma

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/zfinx-types.ll:5 +; RUN:| FileCheck --check-prefix=RV32IF %s +; RUN: llc -mtriple=riscv32 -mattr=+zfh -target-abi=ilp32f < %s \ +; RUN:| FileCheck --check-prefix=RV32IF %s I'm not sur

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

2022-02-28 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. In D119051#3316026 , @dblaikie wrote: > Ah, looks like this is the existing > https://github.com/itanium-cxx-abi/cxx-abi/issues/66 If you're going to change the ABI, you might as well tackle the rest of the differences mention

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411959. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @craig.topper's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

2022-02-28 Thread Shivam Rajput via Phabricator via cfe-commits
phyBrackets added a comment. Hey @NoQ and @steakhal , can i land this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing list cfe-c

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

2022-02-28 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

2022-02-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 _

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

2022-02-28 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, JonChesterfield. Herald added a subscriber: guansong. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. `hip-openmp-compatible` flag treats hip and

[clang] d8a2afb - [clang][analyzer] Add modeling of 'errno'.

2022-02-28 Thread Balázs Kéri via cfe-commits
Author: Balázs Kéri Date: 2022-03-01T08:20:33+01:00 New Revision: d8a2afb244da6cd1c8753115610c74ed0312f2e2 URL: https://github.com/llvm/llvm-project/commit/d8a2afb244da6cd1c8753115610c74ed0312f2e2 DIFF: https://github.com/llvm/llvm-project/commit/d8a2afb244da6cd1c8753115610c74ed0312f2e2.diff L

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

2022-02-28 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a2afb244da: [clang][analyzer] Add modeling of 'errno'. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

2022-02-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Herald added a project: clang-tools-extra. It would be nice to update the code example in the LibTooling documentation as well Repository: rG LLVM Github Monorepo C

<    1   2