[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

aaron.ballman added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119 +++End; + return llvm::makeArrayRef(&Actions[Start], &Actions[End]); +} hokein wrote: > aaron.ballman wrote: > > This is causing an assertion with debug builds o

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 410915. lichray added a comment. - Add more tests to diagnose other forms of casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rs

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410919. jhuber6 added a comment. Guarding where we set attrs in the case that it's not a valid function now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353 Files:

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein added a comment. Yeah, that's what happens with this patch; Reference binds against an `llvm::Function` declaration, linker resolves it to the actual ifunc in another translation unit and therefore emits IFUNC relocation. Thinking about it more, this is inelegant. I would have liked

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray marked an inline comment as done. lichray added a comment. In D113393#3340878 , @aaron.ballman wrote: > I spotted some test coverage that I think we should add: > > static_cast(whatever); > reinterpret_cast(whatever); > const_cast(whatever)

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

erichkeane added a comment. In D120266#3341378 , @ibookstein wrote: > Yeah, that's what happens with this patch; Reference binds against an > `llvm::Function` declaration, linker resolves it to the actual ifunc in > another translation unit and therefo

[clang] 4cb24ef - [clang] Remove Address::deprecated() from CGClass.cpp

Author: Arthur Eubanks Date: 2022-02-23T13:31:56-08:00 New Revision: 4cb24ef90a691489f22a36976a1b33acd65901fa URL: https://github.com/llvm/llvm-project/commit/4cb24ef90a691489f22a36976a1b33acd65901fa DIFF: https://github.com/llvm/llvm-project/commit/4cb24ef90a691489f22a36976a1b33acd65901fa.diff

[clang] 2b97b16 - [OpenMP] Add option to make offloading mandatory

Author: Joseph Huber Date: 2022-02-23T16:45:36-05:00 New Revision: 2b97b16f294af91281d8a138759f3f772952a902 URL: https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902 DIFF: https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902.diff

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b97b16f294a: [OpenMP] Add option to make offloading mandatory (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

efriedma added a comment. Is there a corresponding ARM specification update for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323 ___ cfe-commits mailing li

[clang] 0c1fd90 - [Clang][Docs] Add '-fopenmp-offload-mandatory' to command line reference

Author: Joseph Huber Date: 2022-02-23T16:54:01-05:00 New Revision: 0c1fd90fe0828aa87518d9be542bd00d36d258d7 URL: https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7 DIFF: https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7.diff

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0dc4ac28f00: [NVPTX] Expose float tys min, max, abs, neg as builtins (authored by jchlanda, committed by tra). Changed prior to commit: https://r

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe672934ff88: [NVPTX] Add more FMA intriniscs/builtins (authored by jchlanda, committed by tra). Changed prior to commit: https://reviews.llvm.org

[PATCH] D119157: [NVPTX] Add ex2 f16 support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69a8350c232a: [NVPTX] Add ex2.approx.f16/f16x2 support (authored by npmiller, committed by tra). Changed prior to commit: https://reviews.llvm.org

[clang] cd37594 - Fix unused lambda capture warning, NFC

Author: Reid Kleckner Date: 2022-02-23T14:01:01-08:00 New Revision: cd37594c0374f287318d47818cc6d55496d3e9c0 URL: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0 DIFF: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0.diff

[clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

Author: Reid Kleckner Date: 2022-02-23T14:07:04-08:00 New Revision: 1d1b089c5d503e2fc8697887411730105f66c774 URL: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774 DIFF: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774.diff

[clang] dcc4feb - Use function prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-23T17:12:25-05:00 New Revision: dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42 URL: https://github.com/llvm/llvm-project/commit/dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42 DIFF: https://github.com/llvm/llvm-project/commit/dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42.diff

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. In D119061#3340884 , @kuhar wrote: > LGTM but please get at least one additional approval before submitting Thank you. Yeah, I would like to get lgtm from @aaron.ballman here :) CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 1592d88 - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-23T15:00:18-08:00 New Revision: 1592d88aa7bc13c9f53cf09d25b98e7318a57bfb URL: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb DIFF: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

enh added a comment. In D117611#3339137 , @glandium wrote: > This doesn't leave much room to use `__attribute__((format(printf)))` on > custom printf implementations that do support `%n` on Android does it? it would be pretty hard to get into that situa

[clang] 119d71c - [OpenMP][NFC] Address warnings and lint messages in CGOpenMPRuntime

Author: Joseph Huber Date: 2022-02-23T18:07:25-05:00 New Revision: 119d71cb73a888a57b368cb5c74ac8ac07fb5c32 URL: https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32 DIFF: https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32.diff

[clang] 18fa0b1 - [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC.

Author: Vladimir Vereschaka Date: 2022-02-23T15:16:56-08:00 New Revision: 18fa0b15ccf610f34af1231440f89d20cb99e7a0 URL: https://github.com/llvm/llvm-project/commit/18fa0b15ccf610f34af1231440f89d20cb99e7a0 DIFF: https://github.com/llvm/llvm-project/commit/18fa0b15ccf610f34af1231440f89d20cb99e7a0

[PATCH] D120383: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18fa0b15ccf6: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC. (authored by vvereschaka). Repository: rG LLVM Github

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

yaxunl added a comment. In D120298#3341250 , @tra wrote: > LGTM with a minor nit. > >> Also -DHIP_API_PER_THREAD_DEFAULT_STREAM is passed to clang -cc1 to enable >> other per-thread stream > > You may want to rephrase patch description it a bit to match

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } tra wrote: > yaxunl wrote: > >

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. In D109239#3331917 , @zahiraam wrote: > In D109239#3331914 , @thakis wrote: > >> Thank you for reverting my follow-up as well! >> >> zahiraam, for the reland please include that follow-up f

[PATCH] D120132: [HIP] Fix HIP include path

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } yaxunl wrote: > tra wrote: > > ya

[clang] 34285bc - Reland "unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82"

Author: Nico Weber Date: 2022-02-23T18:41:20-05:00 New Revision: 34285bcd5ac260246c9d59708a63ea3d5972f75c URL: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c DIFF: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c.diff LO

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Actually, I did it myself in 34285bcd5ac260246c9d59708a63ea3d5972f75c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun added a comment. In D120289#3341008 , @sgatev wrote: > it seems tailored to the Z3 API. As far as I understand, there were downstream patches that used the same API with other SMT solvers. The authors did not upstream it because they did not

[clang] 0477cac - [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

Author: Fangrui Song Date: 2022-02-23T16:08:25-08:00 New Revision: 0477cac332d5abf7b2b51b470370afcbb1e8d513 URL: https://github.com/llvm/llvm-project/commit/0477cac332d5abf7b2b51b470370afcbb1e8d513 DIFF: https://github.com/llvm/llvm-project/commit/0477cac332d5abf7b2b51b470370afcbb1e8d513.diff

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0477cac332d5: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections… (authored by MaskRay). Changed prior to commit: htt

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119004/new/ https://reviews.llvm.org/D119004 ___ cfe-commits mailing list cfe

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

aminya added a comment. Clang-tidy is very slow if you use it on a medium or large project. Something like this feature, even if it is not perfect, will definitely improve the experience with clang-tidy. The low performance of clang-tidy is one of the biggest frictions for using it. Repositor

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos created this revision. penagos added reviewers: curdeius, MyDeveloperDay. penagos published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44544. Repository: rG LLVM Github Monorepo htt

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410986. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6067 + if (VPtr) { +VOpVal = {VPtr, VPtr->getType()->getPointerElementType(), + V->getType().isVolatileQualified(),

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int &x = *p; +} @Sockke Could you please add the following tests? ``` i

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int &x = *p; +} MTC wrote: > @Sockke Could you please add the followi

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int &x = *p; +} Sockke wrote: > MTC wrote: > > @Sockke Could you please

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } tra wrote: > yaxunl wrote: > >

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

arcbbb created this revision. arcbbb added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, monkchiang, eopXD, khchen. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewe

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d899d8f0187: [HIP] Support `-fgpu-default-stream` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANG

[clang] 9d899d8 - [HIP] Support `-fgpu-default-stream`

Author: Yaxun (Sam) Liu Date: 2022-02-23T22:28:29-05:00 New Revision: 9d899d8f01872e91b9909a6ee5937a796a399276 URL: https://github.com/llvm/llvm-project/commit/9d899d8f01872e91b9909a6ee5937a796a399276 DIFF: https://github.com/llvm/llvm-project/commit/9d899d8f01872e91b9909a6ee5937a796a399276.dif

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:767-768 s->getType()->isBlockPointerType()); -assert(isa(sreg) || isa(sreg)); +assert(isa(sreg) || isa(sreg) || + isa(sreg)); } -

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

tstellar created this revision. tstellar requested review of this revision. Herald added a project: clang. Also add some javascript to automatically change that status to "In Progress" when the issue is assigned to someone, and "Clang ToT" when the issue is closed. Note that the feature entries w

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 closed this revision. fakepaper56 added a comment. Herald added subscribers: pcwang-thead, eopXD. The patch content is in D119727 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ https://revi

[clang] 8b62f19 - [Driver][RISCV] Add missing rv64 test case

Author: eopXD Date: 2022-02-23T22:53:42-08:00 New Revision: 8b62f19f27d4152e2ba0e329261fbe2a964f9950 URL: https://github.com/llvm/llvm-project/commit/8b62f19f27d4152e2ba0e329261fbe2a964f9950 DIFF: https://github.com/llvm/llvm-project/commit/8b62f19f27d4152e2ba0e329261fbe2a964f9950.diff LOG: [D

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b62f19f27d4: [Driver][RISCV] Add missing rv64 test case (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; Nit: V-spec prefers to call instructions without masking operands "unmasked instru

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; eopXD wrote: > Nit: V-spec prefers to call instructions without masking operands "u

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD updated this revision to Diff 411014. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD added a comment. Friendly ping @VincentWu ;) Any comments to the latest response? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay updated this revision to Diff 411016. MaskRay marked an inline comment as done. MaskRay added a comment. Explain pie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 Files: clang/CMakeLists.txt

<    1   2   3