[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Depends on D120331

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

2022-02-22 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:239 help='Specify the path of .clang-tidy or custom config' - 'file: e.g. -config-file=/some/path/myTidyConfigFile' +

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

2022-02-22 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I think will be good to merge these changes to D120331 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120385/new/ https://reviews.llvm.org/D120385

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

2022-02-22 Thread Shangwu Yao via Phabricator via cfe-commits
shangwuyao added a comment. Looking into the (new) build failure on Windows, since the change has already been reviewed, will try to commit after resolving the build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://review

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker accepted this revision. SAtacker added a comment. This revision is now accepted and ready to land. In D120385#3339440 , @Eugene.Zelenko wrote: > I think will be good to merge these changes to D120331 > . Thank

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - spaces: - Consistent with the rest of the opt

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker updated this revision to Diff 410715. SAtacker retitled this revision from "[clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385" to "[clang-tidy][run-clang-tidy.py] Whitespace addition". SAtacker edited the summary of this revision. SAtacker added a comment. Fix CI bu

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker updated this revision to Diff 410717. SAtacker added a comment. Suspected reason why the patch isn't applied: trailing space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-e

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker updated this revision to Diff 410718. SAtacker added a comment. Removed whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py I

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

2022-02-22 Thread Shreyas via Phabricator via cfe-commits
SAtacker updated this revision to Diff 410719. SAtacker added a comment. Attempt to update this commit appropriately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-extra/clang-tidy/t

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

2022-02-22 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. In D120374#3339337 , @penagos wrote: > Though it's still unclear to me whether or not it'd make more sense to > continue to pursue a change to int

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

2022-02-22 Thread Dawid Jurczak via Phabricator via cfe-commits
yurai007 added a comment. In D120334#3338367 , @jansvoboda11 wrote: > In D120334#3338314 , @yurai007 > wrote: > >> In D120334#3337961 , @jansvoboda11 >> wrote: >> >>> T

<    1   2   3