[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

2022-02-09 Thread Mitch Phillips via Phabricator via cfe-commits
hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, hiraditya. Herald added a reviewer: aaron.ballman. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-com

[PATCH] D119296: KCFI sanitizer

2022-02-09 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); pcc wrote: > samitolvanen wrote: > >

[PATCH] D110485: Support [[no_unique_address]] for all targets.

2022-02-09 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. To pick up the thread here again, `[[no_unique_address]]` is done and settled in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is accepted, without any warning (in C++20 mode), but it has no effect. (This, not related to LLVM, but because they h

[PATCH] D110485: Support [[no_unique_address]] for all targets.

2022-02-09 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D110485#3308854 , @mstorsjo wrote: > To pick up the thread here again, `[[no_unique_address]]` is done and settled > in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is > accepted, without any warning

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

2022-02-09 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. @majnemer Review please :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[libunwind] dfa5ab7 - [libunwind] Avoid a warning in 32 bit builds. NFC.

2022-02-09 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-02-09T23:00:46+02:00 New Revision: dfa5ab7b2b510e68ca2b11b043898c192633c0f6 URL: https://github.com/llvm/llvm-project/commit/dfa5ab7b2b510e68ca2b11b043898c192633c0f6 DIFF: https://github.com/llvm/llvm-project/commit/dfa5ab7b2b510e68ca2b11b043898c192633c0f6.diff

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm created this revision. Herald added a subscriber: carlosgalvezp. devjgm requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option allows callers to disable the warning from https://clang.llvm.org/extra/clang-tidy/checks

[clang] e329b58 - [clang-format] Honour "// clang-format off" when using QualifierOrder.

2022-02-09 Thread Marek Kurdej via cfe-commits
Author: Marek Kurdej Date: 2022-02-09T22:15:20+01:00 New Revision: e329b5866f1732f5c24cf2ae96479971f7101914 URL: https://github.com/llvm/llvm-project/commit/e329b5866f1732f5c24cf2ae96479971f7101914 DIFF: https://github.com/llvm/llvm-project/commit/e329b5866f1732f5c24cf2ae96479971f7101914.diff

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

2022-02-09 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe329b5866f17: [clang-format] Honour "// clang-format off" when using QualifierOrder. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407267. devjgm added a comment. Here is also updated the documentation to include the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-

[clang] a77c67f - [clang-format] Fix formatting of the array form of delete.

2022-02-09 Thread Marek Kurdej via cfe-commits
Author: Marek Kurdej Date: 2022-02-09T22:36:13+01:00 New Revision: a77c67f93917596f9eded9edaced4a9d355a4e1c URL: https://github.com/llvm/llvm-project/commit/a77c67f93917596f9eded9edaced4a9d355a4e1c DIFF: https://github.com/llvm/llvm-project/commit/a77c67f93917596f9eded9edaced4a9d355a4e1c.diff

[PATCH] D119117: [clang-format] Fix formatting of the array form of delete.

2022-02-09 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGa77c67f93917: [clang-format] Fix formatting of the array form of delete. (authored by curdeius). Changed

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

2022-02-09 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron created this revision. Izaron added reviewers: aaron.ballman, cor3ntin. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Value-dependent ConstantExprs are not meant to be evaluated. There is an assert in Expr::EvaluateAsConstan

[clang] a7b5e5b - [clang-format] Fix formatting of macro definitions with a leading comment.

2022-02-09 Thread Marek Kurdej via cfe-commits
Author: Marek Kurdej Date: 2022-02-09T22:39:59+01:00 New Revision: a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a URL: https://github.com/llvm/llvm-project/commit/a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a DIFF: https://github.com/llvm/llvm-project/commit/a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a.diff

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

2022-02-09 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b5e5b413bd: [clang-format] Fix formatting of macro definitions with a leading comment. (authored by curdeius). Repository: rG LLVM Github Monore

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:197-198 } } else if (ReceivingExpr) { -if ((*InvocationParmType)->isRValueRefere

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

2022-02-09 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 407284. Quuxplusone added a comment. Rebase; clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119184/new/ https://reviews.llvm.org/D119184 Files: clang/include/clang/Sema/Sema.h clang/lib/Se

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

2022-02-09 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron added a comment. The assert that I mentioned in the summary: https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/ExprConstant.cpp#L14969 (Although `assert`s are deleted in release builds, one can check the violation by `llvm::errs() << isValueDependent() << "\n";` in the method)

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

2022-02-09 Thread Jameson Nash via Phabricator via cfe-commits
vtjnash added a comment. @cristian.adam Is this good now? You are blocking merging this, but I think it is ready to land, and I would like to not hold it up for other people if it is fixing their issues (and the issues you discovered too) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

2022-02-09 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 407287. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ext

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. I don't fully understand the reasoning for the patch, and you haven't really explained it. I think what you are saying is that the `IsAux` argument to `getTargetFeatures` should be considered because it's `true` for offloading to another compiler, but I don't understand

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

2022-02-09 Thread Cristian Adam via Phabricator via cfe-commits
cristian.adam resigned from this revision. cristian.adam added a comment. This revision is now accepted and ready to land. In D119199#3309117 , @vtjnash wrote: > @cristian.adam Is this good now? You are blocking merging this, but I think > it is ready to

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407288. devjgm added a comment. Accepted ymandel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveCo

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

2022-02-09 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 407295. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files: clang/include/clang/AST/ASTFwd.h clang/include/clang/AS

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407300. devjgm added a comment. - accepted ymandel's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveC

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

2022-02-09 Thread Jameson Nash via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG76cad51ba700: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/

[clang] 76cad51 - replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

2022-02-09 Thread Jameson Nash via cfe-commits
Author: Jameson Nash Date: 2022-02-09T17:31:34-05:00 New Revision: 76cad51ba700233d6e3492eddcbb466b6adbc2eb URL: https://github.com/llvm/llvm-project/commit/76cad51ba700233d6e3492eddcbb466b6adbc2eb DIFF: https://github.com/llvm/llvm-project/commit/76cad51ba700233d6e3492eddcbb466b6adbc2eb.diff

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

2022-02-09 Thread Jameson Nash via Phabricator via cfe-commits
vtjnash added a comment. Thanks, if you encounter more issues next week, let me know, and I will continue trying to adjust it to work for all config option combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/new/ https://reviews.llv

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 407307. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and mark related functions as unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https:/

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 407308. ychen added a comment. - add ARM64 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/tes

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 407309. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. use `LLVM_FALLTHROUGH` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. In D119301#3309140 , @lenary wrote: > I don't fully understand the reasoning for the patch, and you haven't really > explained it. I think what you are saying is that the `IsAux` argument to > `getTargetFeatures` should be conside

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 407312. tianshilei1992 added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 407313. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/test-wunalig

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. In D119301#3309253 , @ychen wrote: > In D119301#3309140 , @lenary wrote: > >> I don't fully understand the reasoning for the patch, and you haven't really >> explained it. I think what you

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 407314. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp clang/lib/Driver/ToolCha

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

2022-02-09 Thread Mitch Phillips via Phabricator via cfe-commits
hctim planned changes to this revision. hctim marked 8 inline comments as done. hctim added a comment. Pushed the [1/3] ELF note parsing over to D119381 . Will leave this review for the clang-side changes, and send a new patch for the LLD changes. All of your co

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

2022-02-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: aaron.ballman, mstorsjo, rjmccall, rsmith. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For me, `cmake -Hclang -B/path/to/build` currently

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

2022-02-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/CMakeLists.txt:16 if(CLANG_BUILT_STANDALONE) set(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ standard to conform to") set(CMAKE_CXX_STANDARD_REQUIRED YES) For the main branch, we can delete this block. Reposit

[PATCH] D117809: [clang] Add an extract-api driver option

2022-02-09 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added a comment. In D117809#3306785 , @MaskRay wrote: > Thanks for working on such tools but the patch order is not right. > You should implement the functionality first, and in the last, add the driver > option. > The driver option is user-facing

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 407336. ychen added a comment. - Handle ARM - Add driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp c

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

2022-02-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thanks for improving the documentation. I occasionally see folks (and two today!) puzzled by LLVM_ENABLE_RUNTIMES and this patch should help them. Personally I use the `-S -B` style (actually `-H`, but now I see that `-S` is documented I

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This is a follow-up patch of D1193

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: README.md:71 + mlir, openmp, polly, or pstl. ``LLVM_ENABLE_RUNTIMES`` can include any of + libcxx, libcxxabi, libunwind, or compiler-rt. FWIW, OpenMP can be put into either of them. In OpenMP

[clang-tools-extra] 4f30a52 - NFC: fix GCC warning -Wcast-qual

2022-02-09 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2022-02-09T18:03:25-08:00 New Revision: 4f30a5269696ff03fd600e756e934a44d4c71b46 URL: https://github.com/llvm/llvm-project/commit/4f30a5269696ff03fd600e756e934a44d4c71b46 DIFF: https://github.com/llvm/llvm-project/commit/4f30a5269696ff03fd600e756e934a44d4c71b46.diff

[clang] 8c930ce - [NFC] [Modules] Refactor ODR checking for default template argument in

2022-02-09 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-02-10T10:10:10+08:00 New Revision: 8c930cef0e4c6d76fdb483051187c59d5aea6db7 URL: https://github.com/llvm/llvm-project/commit/8c930cef0e4c6d76fdb483051187c59d5aea6db7 DIFF: https://github.com/llvm/llvm-project/commit/8c930cef0e4c6d76fdb483051187c59d5aea6db7.diff LO

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

2022-02-09 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c930cef0e4c: [NFC] [Modules] Refactor ODR checking for default template argument in (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc" ---

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

2022-02-09 Thread Yang Haonan via Phabricator via cfe-commits
haonanya created this revision. haonanya added reviewers: Anastasia, svenvh. haonanya added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. haonanya requested review of this revision. Herald added a subscriber: cfe-commits. It is necessary to guard atomic_double type accordin

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

2022-02-09 Thread Tom Stellard via Phabricator via cfe-commits
tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to sta

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-09 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD, Jim wrote: > Is

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

2022-02-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D119383#3309796 , @tstellar wrote: > I would like to keep this supported upstream as this is how we build clang in > Fedora. If some people find the stand-alone builds burdensome, then I think > it would be best to start a t

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

2022-02-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire created this revision. junaire added reviewers: Quuxplusone, aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang diagnostics should say "floating-point literal" instead of "floating-point constant" accordin

[PATCH] D118428: [clang-cl] Support the /JMC flag

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 407384. ychen marked an inline comment as done. ychen added a comment. - Remove CodeViewDebug.cpp and the associated test. It was needed because the instrumented flag variables were scoped inside the associated method in the CodeView. The current patch puts th

[PATCH] D118428: [clang-cl] Support the /JMC flag

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/test/CodeGen/X86/jmc-instrument.ll:2 +; Check that the flag symbol is not full-qualified. +; RUN: llc < %s -enable-jmc-instrument | FileCheck %s + hans wrote: > ychen wrote: > >

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

2022-02-09 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 407387. tianshilei1992 added a comment. recover test cases removed by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenM

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

2022-02-09 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC, shchenz. Herald added subscribers: kbarton, krytarowski. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

2022-02-09 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

2022-02-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, iains, urnathan, dblaikie. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This fixes issue51873 . The issu

<    1   2