[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. In D110869#3302625 , @nickdesaulniers wrote: > All built+boot. I know @nathanchance pointed out an issue with some already > complex code, but I'm of the opinion that fn should be attributed in kernel > sources. Aside fro

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406664. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/li

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie added a comment. In D119051#3302125 , @rnk wrote: > Looks like the test fails on the Windows pre-merge bot: > https://buildkite.com/llvm-project/premerge-checks/builds/77696#1836f181-a998-4695-b587-a83239ea > > The debian bot seems to be fai

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118608/new/ https://reviews.llvm.org/D118608

[PATCH] D119207: [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels

shangwuyao created this revision. Herald added subscribers: carlosgalvezp, ThomasRaoux, Anastasia, yaxunl. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch converts CUDA pointer kernel arguments with default address spa

[PATCH] D119209: Implement -mctor_dtor_return_this ABI option.

scw created this revision. Herald added subscribers: dexonsmith, dang, kristof.beyls. scw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option forces constructors and non-deleting destructors to return `this` pointer. This is simila

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

phosek added a comment. Have you checked if all the tests are still passing? Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:160 +AddLinkerInputs(ToolChain, Inputs, Args, CmdArgs, JA); +ToolChain.addProfileRTLibs(Args, CmdArgs); This shouldn't mov

[clang] 45084ea - [clang] Fix some clang->llvm type cache invalidation issues

Author: Arthur Eubanks Date: 2022-02-07T18:59:09-08:00 New Revision: 45084eab5e63550bf2fdbf325d8fa5498263130d URL: https://github.com/llvm/llvm-project/commit/45084eab5e63550bf2fdbf325d8fa5498263130d DIFF: https://github.com/llvm/llvm-project/commit/45084eab5e63550bf2fdbf325d8fa5498263130d.diff

[PATCH] D118744: [clang] Fix some clang->llvm type cache invalidation issues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45084eab5e63: [clang] Fix some clang->llvm type cache invalidation issues (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10176-10184 +if (auto *TTP = dyn_cast(D)) + return TTP->hasDefaultArgument() && + !TTP->defaultArgumentWasInherited(); +if (auto *NTTP = dy

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

jacquesguan created this revision. jacquesguan added reviewers: eopXD, kito-cheng. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehou

[clang] e39ba04 - [C++20] [Coroutines] Warning for always_inline coroutine

Author: Chuanqi Xu Date: 2022-02-08T11:43:42+08:00 New Revision: e39ba0461757339f7172f6bc3882f41116bb7c13 URL: https://github.com/llvm/llvm-project/commit/e39ba0461757339f7172f6bc3882f41116bb7c13 DIFF: https://github.com/llvm/llvm-project/commit/e39ba0461757339f7172f6bc3882f41116bb7c13.diff LO

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

This revision was automatically updated to reflect the committed changes. Closed by commit rGe39ba0461757: [C++20] [Coroutines] Warning for always_inline coroutine (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D115867?vs=406314&id=406684#toc Repository: rG LLVM G

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. Although this wasn't accepted formally, both @urnathan and @rsmith says this looks good to them. So I guess it might not be bad to land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 _

[clang] 3504937 - [C++20] [Modules] Don't create multiple global module fragment

Author: Chuanqi Xu Date: 2022-02-08T11:52:09+08:00 New Revision: 3504937dfb2b7d90b2c3b3c7b28c472d31489007 URL: https://github.com/llvm/llvm-project/commit/3504937dfb2b7d90b2c3b3c7b28c472d31489007 DIFF: https://github.com/llvm/llvm-project/commit/3504937dfb2b7d90b2c3b3c7b28c472d31489007.diff LO

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3504937dfb2b: [C++20] [Modules] Don't create multiple global module fragment (authored by ChuanqiXu). Repository: rG LL

[PATCH] D119124: Removing unnecessary condition

harishch4 updated this revision to Diff 406691. harishch4 added a comment. - Remove unnecessary condition - missed return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119124/new/ https://reviews.llvm.org/D119124 Files: clang/lib/Frontend/Compil

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When not going through the main Clang->LLVM type cache, we'd accidentally create multiple different opaque types for a member pointer type. This allow

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks updated this revision to Diff 406705. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/lib/CodeGen/CodeGenTypes

[PATCH] D119207: [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels

jlebar added a comment. > [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels Rephrase this? This patch is about kernel *arguments*, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207 _

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds created this revision. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, foad, dcaballe, cota, teijeong, rdzhabarov, tatianashp, okura, jdoerfert, msifontes, jurahul, kuter, Kayjukh, grosul1, uenoku, Joonsoo, kerbowa, liufengdb, aartbik, mgester, arpith-jacob, csigg,

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

pengfei added a comment. > So xorl %ecx, %edx doesn't zero out all 64-bits of %rcx and %rdx? That's two > 32-bit writes to two different registers, isn't it? `xorl %ecx, %edx` only zero out bit 63:32 of `rdx`. 1. There's only 1 write to register in the instruction, i.e. `%edx`; 2. As a src, non

<    1   2   3