[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

2022-02-04 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added a comment. @alxu Just realized you don't have commit access. Do you want one of us to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753 ___

[PATCH] D119045: Fix address space for function types with AS qualifier

2022-02-04 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews created this revision. eandrews added reviewers: rjmccall, dylanmckay, bader. eandrews requested review of this revision. This patch fixes a bug introduced in commit 4eaf5846d0e7 - https://reviews.llvm.org/D111566 Co

[PATCH] D59254: [RFC] Implementation of Clang randstruct

2022-02-04 Thread Connor Kuehl via Phabricator via cfe-commits
connorkuehl added a comment. In D59254#3298184 , @void wrote: > In D59254#1792134 , @connorkuehl > wrote: > >> In D59254#1792068 , @xbolva00 wrote: >> >>> Re-ping >> >> Stil

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

2022-02-04 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; yaxunl wrote: > tra wrote: > > When will it ever be set to `none`? Do

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

2022-02-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] 280716e - [OpenMP] Change amdgcn to amdgpu in device library handling

2022-02-04 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-02-04T20:51:05-05:00 New Revision: 280716e75f76820f1c8b7c13812c96237dc4bcc5 URL: https://github.com/llvm/llvm-project/commit/280716e75f76820f1c8b7c13812c96237dc4bcc5 DIFF: https://github.com/llvm/llvm-project/commit/280716e75f76820f1c8b7c13812c96237dc4bcc5.diff

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

2022-02-04 Thread Alex Xu (Hello71) via Phabricator via cfe-commits
alxu added a comment. In D116753#3298299 , @pirama wrote: > @alxu Just realized you don't have commit access. Do you want one of us to > merge this? Yes, I forgot about this patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

2022-02-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I am testing check-clang-driver and will cherry pick this into release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753 ___ cfe-co

[clang] 8ea4aed - [OpenMP] Add search path for llvm-strip

2022-02-04 Thread Kelvin Li via cfe-commits
Author: Kelvin Li Date: 2022-02-04T22:15:14-05:00 New Revision: 8ea4aed50a9f84d9617219ccc936c005c5f31c24 URL: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24 DIFF: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24.diff LOG

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

2022-02-04 Thread Kelvin Li via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea4aed50a9f: [OpenMP] Add search path for llvm-strip (authored by kkwli0). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 38449c9 - [Driver] Default to -fno-math-errno for musl

2022-02-04 Thread Fangrui Song via cfe-commits
Author: Alex Xu (Hello71) Date: 2022-02-04T19:20:30-08:00 New Revision: 38449c98f3d33dffdaf7e1feeb9dfdcf63b5126b URL: https://github.com/llvm/llvm-project/commit/38449c98f3d33dffdaf7e1feeb9dfdcf63b5126b DIFF: https://github.com/llvm/llvm-project/commit/38449c98f3d33dffdaf7e1feeb9dfdcf63b5126b.d

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

2022-02-04 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG38449c98f3d3: [Driver] Default to -fno-math-errno for musl (authored by alxu, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

2022-02-04 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Found the problem, tweaking a test-case; will commit shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D113620 ___ cfe-commits mailing

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

2022-02-04 Thread David Blaikie via Phabricator via cfe-commits
dblaikie created this revision. dblaikie added reviewers: rsmith, Bhramar.vatsa, rjmccall, rnk. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119051 Files: clang

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

2022-02-04 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Hmm, I guess it might be the C++11 definition, as suggested - since a base class (even a public one) seems to classify the type as "non pod" as far as GCC is concerned ( In D117616#3298001 , @dblaikie wrote: > In D117616#32958

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

2022-02-04 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Test case showing GCC's behavior here: https://godbolt.org/z/4W7j8Yd54 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

2022-02-04 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D119051#3298491 , @dblaikie wrote: > Test case showing GCC's behavior here: https://godbolt.org/z/4W7j8Yd54 Oh, and demonstrating this applies (as best as I can figure) even when compiling in C++03 mode: https://godbolt.org/

[clang] caa1ebd - Don't assume that a new cleanup was added to InnermostEHScope.

2022-02-04 Thread James Y Knight via cfe-commits
Author: James Y Knight Date: 2022-02-04T23:39:42-05:00 New Revision: caa1ebde70673ddb7124a0599ba846362a1f8b1e URL: https://github.com/llvm/llvm-project/commit/caa1ebde70673ddb7124a0599ba846362a1f8b1e DIFF: https://github.com/llvm/llvm-project/commit/caa1ebde70673ddb7124a0599ba846362a1f8b1e.diff

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

2022-02-04 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Should be fixed by rGcaa1ebde70673ddb7124a0599ba846362a1f8b1e . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D1136

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

2022-02-04 Thread cqwrteur via Phabricator via cfe-commits
expnkx reopened this revision. expnkx added a comment. This revision is now accepted and ready to land. This patch is simply wrong. cqwrteur@Home-Server:~/fast_io_cleanup/fast_io/examples/0001.helloworld$ clang++ -o helloworld helloworld.cc -Ofast -std=c++2b -s -flto -fuse-ld=lld --target=wasm3

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

2022-02-04 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc added a comment. Sorry I somehow missed the acceptance back on 10 Jan. I lack commit access, it would be great if you could push for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97625/new/ https://reviews.llvm.org/D97625 ___

<    1   2   3