[clang] fd33cca - [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

Author: Marek Kurdej Date: 2022-02-01T09:17:59+01:00 New Revision: fd33cca762fac265d28abbb080eec57f011f7cb4 URL: https://github.com/llvm/llvm-project/commit/fd33cca762fac265d28abbb080eec57f011f7cb4 DIFF: https://github.com/llvm/llvm-project/commit/fd33cca762fac265d28abbb080eec57f011f7cb4.diff

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd33cca762fa: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting. (authored by curdeius). Changed prior to commit: https://

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-templates.cpp:16 + int value_int = 42; + // CHECK-MESSAGES:[[@LINE-1]]:3: warning: variable 'value_int' of ty

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-pointer-as-values.cpp:12 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'p_local0' of type '

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. Hi and thanks for taking the time to go through the review. In D118652#3285601 , @MaskRay wrote: > Thanks for working on this. I spot checked some files. In general it looks > great. > > One file replaces a forward dec

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. In D118652#3286018 , @mehdi_amini wrote: > I'm not sure how it'd help clients of the released version of LLVM to delay, > the development branch and the release seems fairly disconnected to me from > this point of vie

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404849. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test/Driver/wasm-toolchain.cpp Index: clang/t

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > >

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions --

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 404854. tyb0807 added a comment. Add support for `+nomops` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/C

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

ZarkoCA added inline comments. Comment at: clang/test/SemaTemplate/instantiate-attr.cpp:1 // RUN: %clang_cc1 -fsyntax-only -verify %s // expected-no-diagnostics hubert.reinterpretcast wrote: > Add `-Wno-aix-compat` instead? I agree with this, this way AIX still

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

RKSimon updated this revision to Diff 404885. RKSimon added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118609/new/ https://reviews.llvm.org/D118609 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/i

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev updated this revision to Diff 404886. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 Files: clang/in

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev updated this revision to Diff 404888. sgatev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev added a comment. Mentioned the breaking interface change in the description. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:151 -if (auto *FirstVal = dyn_cast(Val)) { - auto *SecondVal = cast(It->second); - if (&FirstVal->getPointeeL

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev updated this revision to Diff 404890. sgatev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, this looks much better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 ___ cfe-commits mai

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 404889. steffenlarsen added a comment. Added tests for redeclarations and template specialization using `clang::annoate` with packs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/in

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this is great! Just a few cases that regex couldn't quite understand, and one bona fide bug! Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103 -static

[clang] 545317c - [clang-format] Use ranged for loops. NFC.

Author: Marek Kurdej Date: 2022-02-01T14:10:48+01:00 New Revision: 545317cb8eb96947ae20b432525f5667f816df49 URL: https://github.com/llvm/llvm-project/commit/545317cb8eb96947ae20b432525f5667f816df49 DIFF: https://github.com/llvm/llvm-project/commit/545317cb8eb96947ae20b432525f5667f816df49.diff

[clang] 34b4f00 - [clang-format] De-pessimize appending newlines. NFC.

Author: Marek Kurdej Date: 2022-02-01T14:10:48+01:00 New Revision: 34b4f00686ffa030fb0fed3bdd24b5e8588dae89 URL: https://github.com/llvm/llvm-project/commit/34b4f00686ffa030fb0fed3bdd24b5e8588dae89 DIFF: https://github.com/llvm/llvm-project/commit/34b4f00686ffa030fb0fed3bdd24b5e8588dae89.diff

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:56 + /// operations. + class ValueModel { public: I really like this new name/API. Much clearer concept. Comment at: clang/include/

[clang] e75a342 - [clang-format] Use std::iota and reserve. NFC.

Author: Marek Kurdej Date: 2022-02-01T14:24:01+01:00 New Revision: e75a3428a92016b2689d5efb7ac95ae91761949d URL: https://github.com/llvm/llvm-project/commit/e75a3428a92016b2689d5efb7ac95ae91761949d DIFF: https://github.com/llvm/llvm-project/commit/e75a3428a92016b2689d5efb7ac95ae91761949d.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 3 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4179 + MutableArrayRef AllArgs) { + assert(AllArgs.size()); + erichkeane wrote: > Does this work with a

[clang] af8f1db - [clang-format] Use std::iota and reserve when sorting Java imports. NFC.

Author: Marek Kurdej Date: 2022-02-01T14:29:31+01:00 New Revision: af8f1dbb43bc1a6267ea0b760c7b0fae635938ff URL: https://github.com/llvm/llvm-project/commit/af8f1dbb43bc1a6267ea0b760c7b0fae635938ff DIFF: https://github.com/llvm/llvm-project/commit/af8f1dbb43bc1a6267ea0b760c7b0fae635938ff.diff

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel marked 4 inline comments as done. kuhnel added a comment. Thx @sammccall for your patience with this cleanup. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103 -static clang::clangd::Key kFileBeingProcessed; +static clang::clangd::Key KFileBeingProcessed;

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 404897. tyb0807 added a comment. Revert latest patchset, as it should be put into a separate commit for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files:

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445 addSystemInclude(DriverArgs, CC1Args, - getDriver().SysRoot + "/include/c++/v1"); + getDriver().SysRoot + "/include/c++/11"); +break; ---

[PATCH] D118698: [clangd][nfc] cleanup of remaining clang-tidy findings

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There were some left-overs

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob created this revision. rpenacob added reviewers: rogfer01, MaskRay, sthibaul. rpenacob requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC's compiled with --enable-version-specific-runtime-libs. change the paths where includes and

[PATCH] D118698: [clangd][nfc] cleanup of remaining clang-tidy findings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > clang-tidy is complaining in some files about Which files? And which clang-tidy --version vs clang-format --version? I can take a look Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445 addSystemInclude(DriverArgs, CC1Args, - getDriver().SysRoot + "/include/c++/v1"); + getDriver().SysRoo

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

tbaeder added a comment. @thakis After re-applying this patch locally, I can't see the breakage you described with the reproducer provided. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/ https://reviews.llvm.org/D109611 ___

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added a comment. I think I'm happy, though there are the opens for Aaron (deciding whether the 'create as delayed' should happen without entry into 'handleAnnotateAttr', and whether the 'parsing' looks correct, despite not being the way we discussed), so you'll need to wait on him.

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), ychen wrote: > hans wrote: >

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Tests have been failing on Mac for over 20 hours now. Time to revert and fix async? % bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -fopenmp-new-driver -no-canonical-prefixes -ccc-print-bindings /Users/thakis/src/llvm-project/clang/test/Driver/o

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287330 , @thakis wrote: > Tests have been failing on Mac for over 20 hours now. Time to revert and fix > async? > >% bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda > -fopenmp-new-driver -no-c

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? tbaeder wrote: > sbc100 wrote: > > Just early return here if no headers can be found? Looking at Gnu.cpp it >

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

Szelethus added a comment. Ping ^-^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116597/new/ https://reviews.llvm.org/D116597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 404910. achieveartificialintelligence added a comment. Separate the Zhinxmin and Zhinx extensions. Inspired by D118581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. In D116541#3287342 , @jhuber6 wrote: > In D116541#3287330 , @thakis wrote: > >> Tests have been failing on Mac for over 20 hours now. Time to revert and fix >> async? >> >>% bin/clang

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. ps "This is inconvenient to revert since 20 patches landed" means you're landing too many patches too quickly. This landed less than 24h ago, so if it's difficult to revert, that's a bit of a problem for the project, right? Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] e9cba78 - [clangd] Group and extend release notes

Author: Sam McCall Date: 2022-02-01T15:51:57+01:00 New Revision: e9cba7865323425e9c7d3b8a14d7c19fab3d6b65 URL: https://github.com/llvm/llvm-project/commit/e9cba7865323425e9c7d3b8a14d7c19fab3d6b65 DIFF: https://github.com/llvm/llvm-project/commit/e9cba7865323425e9c7d3b8a14d7c19fab3d6b65.diff LO

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287379 , @thakis wrote: > Just build and run tests on any mac. This fails on 3 different macs I tried > (2x arm, 1x intel), in a bunch of different build configs. > > For the particular build I sent the output from, t

[clang] 28c1534 - [OpenMP] Temporarily remove checks to fix failing test on MACOS

Author: Joseph Huber Date: 2022-02-01T09:56:09-05:00 New Revision: 28c15341368bc8c557313d8929a4220a8c38516c URL: https://github.com/llvm/llvm-project/commit/28c15341368bc8c557313d8929a4220a8c38516c DIFF: https://github.com/llvm/llvm-project/commit/28c15341368bc8c557313d8929a4220a8c38516c.diff

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. Removed the two lines in rG28c15341368b , let me know if this lets the tests pass. I'll look into getting an access somehow so I can reproduce this and figure it out. Repository: rG LLVM Github Mon

[clang-tools-extra] 7af1a2e - [clangd] Fix handling of co_await in go-to-type

Author: Sam McCall Date: 2022-02-01T16:01:53+01:00 New Revision: 7af1a2ed815dda133f9088fdfd3979f843edfcc9 URL: https://github.com/llvm/llvm-project/commit/7af1a2ed815dda133f9088fdfd3979f843edfcc9 DIFF: https://github.com/llvm/llvm-project/commit/7af1a2ed815dda133f9088fdfd3979f843edfcc9.diff LO

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev updated this revision to Diff 404923. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 Files: clang/in

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:64 +/// +/// `Val1` must be assigned to a storage location of type `Type`. +/// ymandel wrote: > What does this comment mean, now that there's

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob updated this revision to Diff 404930. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118700/new/ https://reviews.llvm.org/D118700 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/gcc_version_parsing_rt_libs/lib/gcc/x86_64-redhat-linux/10.2.0/crtbegin.o

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda added a comment. In D117887#3262024 , @tra wrote: > > If you only intended to add instructions available in PTX-7.0, which, based > on the constraints used in the patch, appears to be the case, I'd mention > that in the commit log. Yeap, w

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8800dfb5c9: [clang][dataflow] Enable comparison of distinct values in Environment (authored by sgatev). Repository: rG LLVM Github Monorepo CHA

[clang] 6b8800d - [clang][dataflow] Enable comparison of distinct values in Environment

Author: Stanislav Gatev Date: 2022-02-01T15:25:59Z New Revision: 6b8800dfb5c9486c7302cc2d8d2ae362ef8fdfbd URL: https://github.com/llvm/llvm-project/commit/6b8800dfb5c9486c7302cc2d8d2ae362ef8fdfbd DIFF: https://github.com/llvm/llvm-project/commit/6b8800dfb5c9486c7302cc2d8d2ae362ef8fdfbd.diff LO

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404935. tbaeder marked an inline comment as done. tbaeder added a comment. Stop hardcoding `v1` or `11` and make the tests work like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > > > Just early ret

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Tests are passing again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3285825 , @efriedma wrote: > In D91607#3283350 , @ro wrote: > >> In D91607#3280808 , @efriedma wrote: >> >>> Testcase? >> >> I thought the 3 tes

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro updated this revision to Diff 404939. ro added a comment. Herald added a subscriber: jrtc27. - Use `CreateGEP` - Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 Files: clang/lib/CodeGen/Ta

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 404940. vabridgers added a comment. Simplify assertion per comments. Add a "temp" fix in SValBuilder that permits the additional test cases to pass without crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. I think @steakhal will have a more comprehensive change to back out the makeNull() calls to makeNullWithWidth() calls. I'll back out the change to SValBuilder.cpp once that change is pushed. For now, this is my update. Thanks Repository: rG LLVM Github Monorepo C

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers marked 7 inline comments as done. vabridgers added a comment. I think the comments have been addressed for now. Please let me know if I missed something, or anything else needs to be done (besides back out the change to SValBuilder.cpp when ready). Thanks for the comments. Best Repo

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

pkubaj added a comment. Since I'm not a LLVM committer, can you commit it and merge to 14 branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117972/new/ https://reviews.llvm.org/D117972 ___ cfe-commit

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/31592. This commits enables l

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404947. stevewan added a comment. Use "-Wno-aix-compat" so that we don't lose coverage on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Ana

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:229 MacroBuilder &Builder) const { + // FIXME: this does not handle the case where MOPS is disabled using +nomops + Builder.defineMacro("__ARM_FEATURE_M

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/test/Analysis/padding_c.c:7 // RUN: not %clang_analyze_cc1 -verify %s \ // RUN: -analyzer-checker=core \ Even if it works as-is, might be good to add `-Wno-aix-compat` here too since `-verify`

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of tagging intrinsics from `arm_acle.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404951. stevewan added a comment. Add the flag to all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Analysis/padding_c.c clang/test/Analysis/

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D11

[clang] 245b8e5 - [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

Author: Steven Wan Date: 2022-02-01T11:49:53-05:00 New Revision: 245b8e5691ed9e4483b3e0f807706fe1fb6eaa38 URL: https://github.com/llvm/llvm-project/commit/245b8e5691ed9e4483b3e0f807706fe1fb6eaa38 DIFF: https://github.com/llvm/llvm-project/commit/245b8e5691ed9e4483b3e0f807706fe1fb6eaa38.diff LO

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG245b8e5691ed: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX (authored by stevewan). Repository: rG LLVM Github M

[PATCH] D118708: [OpenMP] Add kernel string attribute to kernel function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118708/new/ https://reviews.llvm.org/D118708 ___

[PATCH] D118711: [hack] Build a tree of preprocessing directives

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: ymandel. Herald added subscribers: carlosgalvezp, kbarton, mgorny, nemanjai. LegalizeAdulthood requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This cod

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because e.g. + // the sequence "<::" will be inconditi

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. In D118199#3287636 , @chill wrote: > I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang > -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of > tagging intrinsics from `arm_acle.h`.

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-pointer-as-values.cpp:12 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'p_local0' of type 'double *' can be declared 'const' +

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

rsmith added a comment. Thanks, this looks functionally good to me. I'm happy for this to land with the `Sema` member renamed. Comment at: clang/lib/Sema/SemaModule.cpp:727 +ModuleMap &Map = PP.getHeaderSearchInfo().getModuleMap(); +GlobalModuleFragmentCache = Map.crea

[PATCH] D118070: Add /winsysroot support to lld

pkasting marked 9 inline comments as done. pkasting added a comment. In D118070#3278123 , @thakis wrote: > Things that can still improve: > > 1. This now does way more than just /winsysroot:. It also makes it so that > lld-link works in a non-msvc shell

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 404993. vtjnash added a comment. - Reland "enable plugins for clang-tidy" - fixup! Reland "enable plugins for clang-tidy": Disable the test if the user has disabled support for building it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. I decided it made the most sense to me to go with option 3, so this should be ready to land again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 404994. pkasting marked 5 inline comments as done. pkasting retitled this revision from "Add /winsysroot support to lld" to "Make lld-link work in a non-MSVC shell". pkasting edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham updated this revision to Diff 404999. bnbarham added a reviewer: nathawes. bnbarham added a comment. Noticed one of the unit tests wasn't actually testing the right thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://r

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118652/new/ https://reviews.llvm.org/D118652 __

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham added a comment. @keith I don't have commit access, would you be able to merge this if you're happy with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://reviews.llvm.org/D117937 _

[PATCH] D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute

egorzhdan abandoned this revision. egorzhdan added a comment. Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, I think this approach is worth trying. I agree with you that we're in a bit of new territory here regarding the testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. Apart from some minor inline comments this revision addresses all my outstanding comments. LGTM. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:17747 + +SDValue

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 405018. ychen marked 2 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNot

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), hans wrote: > ychen wrote:

[clang] f6ce456 - [clang] Correctly(?) handle placeholder types in ExprRequirements.

Author: Arthur O'Dwyer Date: 2022-02-01T15:16:17-05:00 New Revision: f6ce456707898f0ae2c70748e896130e1c897960 URL: https://github.com/llvm/llvm-project/commit/f6ce456707898f0ae2c70748e896130e1c897960 DIFF: https://github.com/llvm/llvm-project/commit/f6ce456707898f0ae2c70748e896130e1c897960.diff

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ce45670789: [clang] Correctly(?) handle placeholder types in ExprRequirements. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorep

[clang] c0185ff - [clang] Don't typo-fix an expression in a SFINAE context.

Author: Arthur O'Dwyer Date: 2022-02-01T15:17:28-05:00 New Revision: c0185ffaec3cb0aa7677b13a898eaa485ef29421 URL: https://github.com/llvm/llvm-project/commit/c0185ffaec3cb0aa7677b13a898eaa485ef29421 DIFF: https://github.com/llvm/llvm-project/commit/c0185ffaec3cb0aa7677b13a898eaa485ef29421.diff

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0185ffaec3c: [clang] Don't typo-fix an expression in a SFINAE context. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. What the fuck. I know of trigraphs, and that we got rid of them, but these... Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. Hey! Looks like Diff 404763 for an x86 defconfig plus CONFIG_ZERO_CALL_USED_REGS=y starts booting! Looks like it panics though trying to launch `init`(pid 1) though. [0.702163] Run /bin/sh as init process [0.702913] Failed to execute /bin/sh (error -

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1269 + const TargetFrameLowering &TFI = *MF.getSubtarget().getFrameLowering(); + for (auto RestoreBlock : RestoreBlocks) +TFI.emitZeroCallUsedRegs(RegsToZero, *RestoreBlock); --

  1   2   >