[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1182 + + if (!F.hasFnAttribute("zero-call-used-regs") || + // No need to zero call regs in main(). Should the frontend avoid putting the attribute on "main" instead of

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Neat use of tablegen; will take me a bit to wrap my head around it. I'll give this a shot on some kernel builds first thing tomorrow! Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:232-240 + /// Returns true if a register can be u

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

2022-01-31 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Still failing: http://45.33.8.238/macm1/26873/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 ___ cfe-commits mailing list cf

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:621 +BitVector X86RegisterInfo::getArgumentRegs(const MachineFunction &MF) const { + const X86Subtarget &Subtarget = MF.getSubtarget(); nickdesaulniers wrote: > pengfei

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Bill Wendling via Phabricator via cfe-commits
void marked 2 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1182 + + if (!F.hasFnAttribute("zero-call-used-regs") || + // No need to zero call regs in main(). craig.topper wrote: > Should the fron

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 404761. void added a comment. Remove "zero-call-used-regs" attribute in front-end if it's "main". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 404763. void added a comment. Remove attribute from "main" function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/i

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D116541#3285927 , @thakis wrote: > Still failing: http://45.33.8.238/macm1/26873/step_7.txt Weird, can you show me what `-fopenmp -fopenmp-targets=nvptx64 -fopenmp-new-driver -ccc-print-bindings` looks like there? I'm not sur

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Bill Wendling via Phabricator via cfe-commits
void marked 3 inline comments as done. void added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:232-240 + /// Returns true if a register can be used as an argument to a function. + bool isArgumentRegister(const MachineFunction &MF, MCRegister Reg)

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: jhuber6, JonChesterfield. Herald added subscribers: ormris, hiraditya, mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D116542

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. @jhuber6 Please don't do 4a780aa13ee5e1c8268de54ef946200a270127b9 .. OK, I was late. See D118666 for the proper fix. I'd be better to revert this relevant changes if

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D116542#3285983 , @MaskRay wrote: > @jhuber6 Please don't do 4a780aa13ee5e1c8268de54ef946200a270127b9 > .. OK, I > was late. > > See D118666

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118666/new/ https://reviews.llvm.org/D118666

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:168 - /// Embeds the memory buffer \p Buf into the module \p M as a global using the - /// section name \p SectionName. Note that the convention is to use imperative sentenc

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

2022-01-31 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/zero-call-used-regs-fmod.ll:15 +; CHECK-NEXT:xorps %xmm1, %xmm1 +; CHECK-NEXT:popq %rax +; CHECK-NEXT:.cfi_def_cfa_offset 8 void wrote: > craig.topper wrote: > > Is it ok that this

[clang] 85dfe19 - [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-01-31T16:33:57-08:00 New Revision: 85dfe19b36ba6e9657612e072c9183ce168fdbbc URL: https://github.com/llvm/llvm-project/commit/85dfe19b36ba6e9657612e072c9183ce168fdbbc DIFF: https://github.com/llvm/llvm-project/commit/85dfe19b36ba6e9657612e072c9183ce168fdbbc.diff

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85dfe19b36ba: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils (authored by MaskRay). Changed prior to commit: https://reviews.llvm.o

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D116542#3285985 , @jhuber6 wrote: > In D116542#3285983 , @MaskRay wrote: > >> @jhuber6 Please don't do 4a780aa13ee5e1c8268de54ef946200a270127b9 >>

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D116541#3285927 , @thakis wrote: > Still failing: http://45.33.8.238/macm1/26873/step_7.txt It seems what's happening here is that we are building the host.bc twice, this will work fine but isn't ideal. I prevent this manuall

[PATCH] D118652: Cleanup header dependencies in LLVMCore

2022-01-31 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. I'm not sure how it'd help clients of the released version of LLVM to delay, the development branch and the release seems fairly disconnected to me from this point of view. (what can help are deprecating APIs with instructions about how to update so that they can up

[clang] 7aaf024 - [BitcodeWriter] Fix cases of some functions

2022-01-31 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-01-31T16:46:11-08:00 New Revision: 7aaf024dac719d6cc73e15074ec8c9ad804229ad URL: https://github.com/llvm/llvm-project/commit/7aaf024dac719d6cc73e15074ec8c9ad804229ad DIFF: https://github.com/llvm/llvm-project/commit/7aaf024dac719d6cc73e15074ec8c9ad804229ad.diff

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

2022-01-31 Thread Steven Wan via Phabricator via cfe-commits
stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These tests emit unexpected diagnostics on AIX because the byval alignment warning is emitted too aggressively. https://reviews.llvm.org/D118350 is s

[clang] 275c562 - Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"

2022-01-31 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2022-01-31T17:34:51-08:00 New Revision: 275c56226d7fbd6a4d554807374f78d323aa0c1c URL: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c DIFF: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c.diff

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

2022-01-31 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Please mention the (breaking) API changes to `runDataflowAnalysis`, etc. in the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2022-01-31 Thread Florin Iucha via Phabricator via cfe-commits
0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-pointer-as-values.cpp:12 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'p_local0' of type 'double *' can be declared 'const' + // CH

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

2022-01-31 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as part of the patch set, and given the runtime test for coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116545/new/ https://r

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

2022-01-31 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as part of the patch set, and given the runtime test for coverage. Some nits are left for later though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

2022-01-31 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as part of the patch set, and given the runtime test for coverage. Some nits. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8154 +for (auto TI = OpenMPTCRa

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM with two nits. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:75 +static cl::opt +BitcodeLibrary("target-library", +

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

2022-01-31 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaTemplate/instantiate-attr.cpp:1 // RUN: %clang_cc1 -fsyntax-only -verify %s // expected-no-diagnostics Add `-Wno-aix-compat` instead? Comment at: clang/test/SemaTemplate

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:75 +static cl::opt +BitcodeLibrary("target-library", + cl::desc("Path for the target bitcode library"), tianshilei1992 wrote: > `target-librar

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8154 +for (auto TI = OpenMPTCRange.first, TE = OpenMPTCRange.second; TI != TE; + ++TI) { + const ToolChain *TC = TI->second; jdoerfert wrote: > Nit: maybe `for (auto

[PATCH] D118197: [OpenMP] Replace sysmtem call to `llc` with target machine

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118197/new/ https://reviews.llvm.org/D118197 _

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG. One nit. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:98 +static cl::opt +PtxasOption("ptxas-option", cl::ZeroOrMore, +

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:98 +static cl::opt +PtxasOption("ptxas-option", cl::ZeroOrMore, +cl::desc("Argument to pass to the ptxas invocation"),

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. @JonChesterfield can we just accept the patch and make it in 14? If we later find anything broken, we could have bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117246/new/ https://reviews.llvm.org/D117246 _

[PATCH] D118198: [OpenMP] Remove call to 'clang-offload-wrapper' binary

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118198/new/ https://reviews.llvm.org/D118198 _

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. LG with one nit. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:777-781 +// Record if we've seen these symbols in any object or shared libraries. +if ((*ObjFile)->isRelocatableObject()) { + UsedInReg

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:777-781 +// Record if we've seen these symbols in any object or shared libraries. +if ((*ObjFile)->isRelocatableObject()) { + UsedInRegularObj[*Name] = tru

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 404785. jhuber6 added a comment. Removing clang flag because LTO won't be supported when these land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.org/D117049 Files: clang/li

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

2022-01-31 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I'm gonna accept it for now to make it in 14. We can always come back later if we see anything wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] b8239af - [OpenMP] Add support for extracting device code in linker wrapper

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: b8239af0eeedfa67d9fac28d20685b7a09e2935a URL: https://github.com/llvm/llvm-project/commit/b8239af0eeedfa67d9fac28d20685b7a09e2935a DIFF: https://github.com/llvm/llvm-project/commit/b8239af0eeedfa67d9fac28d20685b7a09e2935a.diff

[clang] d074458 - [Clang] Initial support for linking offloading code in tool

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: d0744585f9ea842ca97855b2e002fddc893c4a92 URL: https://github.com/llvm/llvm-project/commit/d0744585f9ea842ca97855b2e002fddc893c4a92 DIFF: https://github.com/llvm/llvm-project/commit/d0744585f9ea842ca97855b2e002fddc893c4a92.diff

[clang] 0e82c75 - [OpenMP] Search for static libraries in offload linker tool

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: 0e82c7553be95343f1cb62946eb0b84bd26f1563 URL: https://github.com/llvm/llvm-project/commit/0e82c7553be95343f1cb62946eb0b84bd26f1563 DIFF: https://github.com/llvm/llvm-project/commit/0e82c7553be95343f1cb62946eb0b84bd26f1563.diff

[clang] c732c3d - [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: c732c3df749b3d5a127708c05656a226ed5753ab URL: https://github.com/llvm/llvm-project/commit/c732c3df749b3d5a127708c05656a226ed5753ab DIFF: https://github.com/llvm/llvm-project/commit/c732c3df749b3d5a127708c05656a226ed5753ab.diff

[clang] 3762111 - [OpenMP] Link the bitcode library late for device LTO

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: 3762111aa9608fce12c4f938bfef2b38aed766dd URL: https://github.com/llvm/llvm-project/commit/3762111aa9608fce12c4f938bfef2b38aed766dd DIFF: https://github.com/llvm/llvm-project/commit/3762111aa9608fce12c4f938bfef2b38aed766dd.diff

[clang] f28c315 - [OpenMP] Add support for embedding bitcode images in wrapper tool

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: f28c3153ee6d93aa07610682519bdf0ea93755b4 URL: https://github.com/llvm/llvm-project/commit/f28c3153ee6d93aa07610682519bdf0ea93755b4 DIFF: https://github.com/llvm/llvm-project/commit/f28c3153ee6d93aa07610682519bdf0ea93755b4.diff

[clang] cb7cfae - [OpenMP] Add extra flag handling to linker wrapper

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:41-05:00 New Revision: cb7cfaec71850d0a6bc6e00729f0ef6107c51419 URL: https://github.com/llvm/llvm-project/commit/cb7cfaec71850d0a6bc6e00729f0ef6107c51419 DIFF: https://github.com/llvm/llvm-project/commit/cb7cfaec71850d0a6bc6e00729f0ef6107c51419.diff

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8239af0eeed: [OpenMP] Add support for extracting device code in linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[clang] ce16ca3 - [OpenMP] Add support for linking AMDGPU images

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b URL: https://github.com/llvm/llvm-project/commit/ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b DIFF: https://github.com/llvm/llvm-project/commit/ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b.diff

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0744585f9ea: [Clang] Initial support for linking offloading code in tool (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org

[clang] 46d0190 - [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: 46d019041cd924d8bdf69c818bbe13f6cd37f466 URL: https://github.com/llvm/llvm-project/commit/46d019041cd924d8bdf69c818bbe13f6cd37f466 DIFF: https://github.com/llvm/llvm-project/commit/46d019041cd924d8bdf69c818bbe13f6cd37f466.diff

[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e82c7553be9: [OpenMP] Search for static libraries in offload linker tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] a47b1cf - [OpenMP] Embed bitcode after optimizations instead of linking

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: a47b1cf306fb7494d493784c25dafb2dd6084b99 URL: https://github.com/llvm/llvm-project/commit/a47b1cf306fb7494d493784c25dafb2dd6084b99 DIFF: https://github.com/llvm/llvm-project/commit/a47b1cf306fb7494d493784c25dafb2dd6084b99.diff

[clang] bf499c5 - [OpenMP] Implement save temps functionality in linker wrapper

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: bf499c58af3d3a96661f5c7ef81b264eac575541 URL: https://github.com/llvm/llvm-project/commit/bf499c58af3d3a96661f5c7ef81b264eac575541 DIFF: https://github.com/llvm/llvm-project/commit/bf499c58af3d3a96661f5c7ef81b264eac575541.diff

[clang] 58dc981 - [OpenMP] Include the executable name in the temporary files

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: 58dc981e082df9db2de1cbd867fa6d73e8eea214 URL: https://github.com/llvm/llvm-project/commit/58dc981e082df9db2de1cbd867fa6d73e8eea214 DIFF: https://github.com/llvm/llvm-project/commit/58dc981e082df9db2de1cbd867fa6d73e8eea214.diff

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc732c3df749b: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper (authored by jhuber6). Changed prior to commit: https:/

[clang] eb6ddf2 - [OpenMP] Replace sysmtem call to `llc` with target machine

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b URL: https://github.com/llvm/llvm-project/commit/eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b DIFF: https://github.com/llvm/llvm-project/commit/eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b.diff

[clang] 9375f15 - [OpenMP] Cleanup the Linker Wrapper

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:42-05:00 New Revision: 9375f1563e87e115cc8f9d052760d68460889f4e URL: https://github.com/llvm/llvm-project/commit/9375f1563e87e115cc8f9d052760d68460889f4e DIFF: https://github.com/llvm/llvm-project/commit/9375f1563e87e115cc8f9d052760d68460889f4e.diff

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3762111aa960: [OpenMP] Link the bitcode library late for device LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 19fac74 - [OpenMP] Remove call to 'clang-offload-wrapper' binary

2022-01-31 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-01-31T23:11:43-05:00 New Revision: 19fac745e3226fbe9db4d3eab106fdaf19d9019d URL: https://github.com/llvm/llvm-project/commit/19fac745e3226fbe9db4d3eab106fdaf19d9019d DIFF: https://github.com/llvm/llvm-project/commit/19fac745e3226fbe9db4d3eab106fdaf19d9019d.diff

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf28c3153ee6d: [OpenMP] Add support for embedding bitcode images in wrapper tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGcb7cfaec7185: [OpenMP] Add extra flag handling to linker wrapper (authored by jhuber6). Repository: rG L

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce16ca3c7419: [OpenMP] Add support for linking AMDGPU images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46d019041cd9: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D118197: [OpenMP] Replace sysmtem call to `llc` with target machine

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb6ddf288cd0: [OpenMP] Replace sysmtem call to `llc` with target machine (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D118198: [OpenMP] Remove call to 'clang-offload-wrapper' binary

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19fac745e322: [OpenMP] Remove call to 'clang-offload-wrapper' binary (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D118

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

2022-01-31 Thread Sameer Sahasrabuddhe via Phabricator via cfe-commits
sameerds added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9434 + if (Callee && + (Callee->getName() == "__ockl_call_host_function" || + Callee->getName() == "__ockl_fprintf_stderr_begin")) { Just to confirm what others have probably

[PATCH] D118428: [clang-cl] Support the /JMC flag

2022-01-31 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 404805. ychen marked 10 inline comments as done. ychen added a comment. - address hans's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/Re

[PATCH] D118428: [clang-cl] Support the /JMC flag

2022-01-31 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. @hans @aganea I think all comments are addressed except that I don't know how to test the ARM/ARM64 JMC function (I don't have ARM hardware or is there any ARM-based Windows virtual machine?). PTAL. Comment at: clang/docs/ReleaseNotes.rst:155 +- Add sup

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

2022-01-31 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:151 -if (auto *FirstVal = dyn_cast(Val)) { - auto *SecondVal = cast(It->second); - if (&FirstVal->getPointeeLoc() == &SecondVal->getPointeeLoc()) { -LocTo

[clang] 95bf0a9 - [clang-format] Don't break block comments when sorting includes.

2022-01-31 Thread Marek Kurdej via cfe-commits
Author: Marek Kurdej Date: 2022-02-01T08:51:10+01:00 New Revision: 95bf0a9ebdb4ee6f78699e20751602c8c3c5733f URL: https://github.com/llvm/llvm-project/commit/95bf0a9ebdb4ee6f78699e20751602c8c3c5733f DIFF: https://github.com/llvm/llvm-project/commit/95bf0a9ebdb4ee6f78699e20751602c8c3c5733f.diff

[PATCH] D118627: [clang-format] Don't break block comments when sorting includes.

2022-01-31 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95bf0a9ebdb4: [clang-format] Don't break block comments when sorting includes. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGE

<    1   2   3