[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

2022-01-25 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1f7b296ac0: [C++20] [Modules] Only check decls under namespace scope in… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

2022-01-25 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 403114. qiucf marked 3 inline comments as done. qiucf edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110 Files: clang/CMakeLists.txt

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

2022-01-25 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for long double, but there should be > a way to set up lit to know the default through its configuration files. Yes, lit doesn't know about it. But li

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

2022-01-25 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 403116. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

2022-01-25 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 403117. khchen added a comment. rebase and address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D117939: [clang-tidy] Add more documentation about check development

2022-01-25 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 403118. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index: clang-to

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

2022-01-25 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:72-73 -const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, - StringRef Id) { +static const Expr *getBoolLiteral(c

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

2022-01-25 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:72-73 -const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, - StringRef Id) { +static const Expr *getBoolLiteral(c

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

2022-01-25 Thread Mike Hommey via Phabricator via cfe-commits
glandium created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. glandium requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a build failure with MSVC introduced in https://reviews.llvm.org/D112906 Repository:

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

2022-01-25 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 403121. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticGroups.td clang/

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

2022-01-25 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D115867#3270137 , @Quuxplusone wrote: > LGTM now, modulo my suggested edits (and the necessary corresponding edits in > the test case). > I don't think I'm really qualified to acc

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2022-01-25 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 added a comment. Yes, https://reviews.llvm.org/D116160 is deprecated and will be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 ___ cfe-comm

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

2022-01-25 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117972/new/ https://reviews.llvm.org/D117972 ___

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

2022-01-25 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 403130. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp clang/test/CXX/module/module

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

2022-01-25 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D115610#3269265 , @urnathan wrote: > Seems good to me, @iains you've been looking at this? According to the discussion in https://github.com/llvm/llvm-project/issues/51682, it looks like Iains plans to implement something

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

2022-01-25 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 403135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[clang-tools-extra] f0726ae - Refactor: Extract Class MessagePrefix (NFC)

2022-01-25 Thread via cfe-commits
Author: Richard Date: 2022-01-25T23:19:33-07:00 New Revision: f0726ae0f9fa3fc5fadec7fdc940cc2f88759001 URL: https://github.com/llvm/llvm-project/commit/f0726ae0f9fa3fc5fadec7fdc940cc2f88759001 DIFF: https://github.com/llvm/llvm-project/commit/f0726ae0f9fa3fc5fadec7fdc940cc2f88759001.diff LOG:

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

2022-01-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. The change looks fine to me. I've started a set of benchmark to make sure it provides the expected speedup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169

[clang] f563bd7 - [NFC] Group PowerPC clang codegen tests into directory

2022-01-25 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2022-01-26T15:19:22+08:00 New Revision: f563bd74cb9a4f0d2d3eb49d35536b648361ec53 URL: https://github.com/llvm/llvm-project/commit/f563bd74cb9a4f0d2d3eb49d35536b648361ec53 DIFF: https://github.com/llvm/llvm-project/commit/f563bd74cb9a4f0d2d3eb49d35536b648361ec53.diff L

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

2022-01-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille accepted this revision. serge-sans-paille added a comment. No performance regression on my side either (but only minor gains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169 ___

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

2022-01-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:65 Base.SuppressTemplateArgsInCXXConstructors = true; + Base.CleanUglifiedParameters = true; return Base; hokein wrote: > IIUC, the

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

2022-01-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 403149. sammccall marked an inline comment as done. sammccall added a comment. Fix hover revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files: clang-tool

<    1   2   3