[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/test/CodeGenCXX/dllimport.cpp:2 // RUN: %clang_cc1 -disable-noundef-analysis -triple i686-windows-msvc -fno-rtti -fno-threadsafe-statics -fms-extensions -emit-llvm -std=c++1y -O0 -o - %s -DMSABI -w | FileCheck --check-prefix=

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

achieveartificialintelligence added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=r

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=riscv32 -mattr=+experimen

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 ___

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=riscv32 -mattr=+ex

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 ___

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:137 + +def GPR : RegisterClass<"RISCV", [XLenVT], 32, GPRAllocationList> { let RegInfos = XLenRI; Does putting this back the way it was and using "(add GPR)" in GPRF16,

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

carlosgalvezp added a comment. Amazing job @salman-javed-nz ! Here's some initial comments. Reviewing the `NoLintPragmaHandler.cpp` will take some more time from me. It would have been easier to see the diff if the contents had been moved as an NFC patch to a separate file, and then applying th

[PATCH] D112986: [RISCV] Restrict zvamo, zvlsseg with zve macro-s

eopXD abandoned this revision. eopXD added a comment. This revision is no longer needed as zvamo and zvlsseg will be removed from arch string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9466 verifyFormat("operator SomeType>();"); + verifyFormat("operator< <>();"); + verifyFormat("< <>"); Looking at other related bug reports, I think that we should test `operat

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius added a comment. Or I'll add it when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117398/new/ https://reviews.llvm.org/D117398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401525. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Sup

[clang] 560eb22 - [clang-format] Fix bug in parsing `operator<` with template

Author: Jino Park Date: 2022-01-20T08:59:04+01:00 New Revision: 560eb2277bb5aea0982ce5f90321788cda3fe4b3 URL: https://github.com/llvm/llvm-project/commit/560eb2277bb5aea0982ce5f90321788cda3fe4b3 DIFF: https://github.com/llvm/llvm-project/commit/560eb2277bb5aea0982ce5f90321788cda3fe4b3.diff LOG

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG560eb2277bb5: [clang-format] Fix bug in parsing `operator<` with template (authored by pjessesco, committed by curdeius). Changed prior to commit:

<    1   2   3