[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @vitalybuka could you or someone else help me get the lsan tests running on Windows? For example lets look at `compiler-rt\test\lsan\TestCases\leak_check_at_exit.cpp` (and basically all other tests, this serves as an easy example) I imagine that the following defi

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

MyDeveloperDay added a comment. Can you test the typedef case you added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list cfe-commit

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207150 , @clemenswasser wrote: > @vitalybuka could you or someone else help me get the lsan tests running on > Windows? > For example lets look at > `compiler-rt\test\lsan\TestCases\leak_check_at_exit.cpp` (and b

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`. Also there are many test cases, where `LSAN_BASE` gets used multiple times. Removing it would result in bad repetition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I suspect Driver part is going to be reverted a couple of time. Maybe extract it into a separate patch? Comment at: compiler-rt/lib/asan/CMakeLists.txt:167 if(APP

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. I don't like the name "asan_dso". DSO means "dynamic shared object", and this is the very opposite of that. Maybe "asan_private" or "asan_helper"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.l

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. Maybe `asan_client` (like `stats_client` above), or `asan_inline`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 ___ cfe-commits mail

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207210 , @clemenswasser wrote: > The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`. Off-cause , I am asking to replace with correct value each test. > Also there are many test cases, w

[PATCH] D116196: [clangd] Add CompileFlags.Compiler option to override argv0

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is separate from --query

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:398-400 + if (Tok && Tok->is(tok::kw_typedef)) +Tok = Tok->getNextNonComment(); + if (Tok && Tok->isOneOf(tok::kw_class, tok::kw_struct)) { Nits: - It's unnec

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395954. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; Quuxplusone wrote: > FWIW

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; ChuanqiXu wrote: > Quux

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395959. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Format codes and edit summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/Diagnos

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; Quuxplusone wrote: > Chua

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid added a comment. I do not have commit access to the main repo. If someone who does could push it up I would appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. Look almost good! Thanks for doing this. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Do we st

[clang] 682d01a - [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

Author: Phoebe Wang Date: 2021-12-23T11:46:03+08:00 New Revision: 682d01a1c1c52bd95d3d06267d6017395770256b URL: https://github.com/llvm/llvm-project/commit/682d01a1c1c52bd95d3d06267d6017395770256b DIFF: https://github.com/llvm/llvm-project/commit/682d01a1c1c52bd95d3d06267d6017395770256b.diff L

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG682d01a1c1c5: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables (authored by pengfei). Repository: rG LLVM Github Monorepo

[clang] a954558 - Revert "[X86][MS-InlineAsm] Use exact conditions to recognize MS global variables"

Author: Phoebe Wang Date: 2021-12-23T12:44:33+08:00 New Revision: a954558e878ed9e97e99036229e99af8c6b6c881 URL: https://github.com/llvm/llvm-project/commit/a954558e878ed9e97e99036229e99af8c6b6c881 DIFF: https://github.com/llvm/llvm-project/commit/a954558e878ed9e97e99036229e99af8c6b6c881.diff L

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei reopened this revision. pengfei added a comment. This revision is now accepted and ready to land. There are several buildbot fail. Need to investigate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/ https://reviews.llvm.org/D1

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116203 Files:

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb added a comment. This patch is heavily based off D67052 , and I'll be listing @zoecarver as a co-author in my commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203

[PATCH] D116204: [C++20] [Coroutines] Allow promise_type to not define return_void or return_value

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind, Quuxplusone, urnathan. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. According to [[dcl.fct.def.coroutine]p6](http://eel.is/c++draft/dcl.fct.def.c

[PATCH] D116205: [clang] adds `__add_volatile` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116205 Files:

[clang] f66d602 - [clang-format] Fix wrong indentation after trailing requires clause.

Author: Marek Kurdej Date: 2021-12-23T08:22:12+01:00 New Revision: f66d602c3f58bd8a312c79bb404eac9dabf1a730 URL: https://github.com/llvm/llvm-project/commit/f66d602c3f58bd8a312c79bb404eac9dabf1a730 DIFF: https://github.com/llvm/llvm-project/commit/f66d602c3f58bd8a312c79bb404eac9dabf1a730.diff

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66d602c3f58: [clang-format] Fix wrong indentation after trailing requires clause. (authored by curdeius). Repository: rG LLVM Github Monorepo CH

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev updated this revision to Diff 395979. sgatev marked an inline comment as done. sgatev added a comment. Rename a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files: clang/include/clang/An

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196 + +class VirtualDestructorTest : public ::testing::Test { +protected: gribozavr2 wrote: > DYM "Noretu

[PATCH] D116206: [clang] adds `__add_cv` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116206 Files:

[clang] 8043beb - [JSONNodeDumper] Do not print mangled names for local variables (PR49111)

Author: Nikita Popov Date: 2021-12-23T08:55:41+01:00 New Revision: 8043beb8901cb95fce4266b498262acf08494510 URL: https://github.com/llvm/llvm-project/commit/8043beb8901cb95fce4266b498262acf08494510 DIFF: https://github.com/llvm/llvm-project/commit/8043beb8901cb95fce4266b498262acf08494510.diff

[PATCH] D116169: [JSONNodeDumper] Do not print mangled names for local variables (PR49111)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8043beb8901c: [JSONNodeDumper] Do not print mangled names for local variables (PR49111) (authored by nikic). Herald added a project: clang. Herald ad

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

sgatev marked an inline comment as done. sgatev added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 ___ cfe-commits mailing

<    1   2