[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395807. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D115923: [RISCV][Don't Commit] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu abandoned this revision. zixuan-wu added a comment. Only need review D115921 . Just abandon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115923/new/ https://reviews.llvm.org/D115923

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102669#3205889 , @OikawaKirie wrote: > In D102669#3199270 , @steakhal > wrote: > >> We shouldn't sk

[PATCH] D116110: Introduce the AttributeMask class

nikic added a comment. Looking at some of the changes here, I landed a couple of cleanup commits: - https://github.com/llvm/llvm-project/commit/3b0f5a4856fce76a6535feddd1692747b81b60cd (this should fix the build failure) - https://github.com/llvm/llvm-project/commit/e8e8bfeeb7233bde17d0a811b87

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[clang] b55ea2f - [Clang] Add __builtin_reduce_xor

Author: Jun Zhan Date: 2021-12-22T10:00:27Z New Revision: b55ea2fbc0a0564eece1e58fc5624057d5d05639 URL: https://github.com/llvm/llvm-project/commit/b55ea2fbc0a0564eece1e58fc5624057d5d05639 DIFF: https://github.com/llvm/llvm-project/commit/b55ea2fbc0a0564eece1e58fc5624057d5d05639.diff LOG: [Cla

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb55ea2fbc0a0: [Clang] Add __builtin_reduce_xor (authored by junaire, committed by fhahn). Changed prior to commit: https://reviews.llvm.org/D11523

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This mechanism is used almost

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. In D102669#3206089 , @steakhal wrote: > Prior to this patch, it worked on M1 ; after > landing it broke something, so we clearly shouldn't land this. I do not think it is this patch that breaks t

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall planned changes to this revision. sammccall added a comment. Actually we should probably handle `-Wno-` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116147/new/ https://reviews.llvm.org/D116147 _

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116153 Files: clang/lib/Basic/Targets/A

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by Ranjeet Singh and Son Tuan Vu. Change-Id: Ic18ffda35760587673b30c166ac145b0df038973 Repository:

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

melver accepted this revision. melver added inline comments. Comment at: clang/test/Driver/x86-outline-atomics.c:1-7 +// RUN: %clang -target x86_64 -moutline-atomics -S %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OUTLINE-ATOMICS +// CHECK-OUTLINE-ATOMICS: warning: 'x86_64' d

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At impo

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces support for targetting the Armv9.3-A architecture, which should map to the existing A

[clang] 0af6281 - [CodeGen] Make lifetime marker test more robust (NFC)

Author: Nikita Popov Date: 2021-12-22T12:28:10+01:00 New Revision: 0af628152a0547ad02856a880830ec33aa79e21c URL: https://github.com/llvm/llvm-project/commit/0af628152a0547ad02856a880830ec33aa79e21c DIFF: https://github.com/llvm/llvm-project/commit/0af628152a0547ad02856a880830ec33aa79e21c.diff

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces the new `__ARM_FEATURE_MOPS` ACLE feature test macro, which signals the a

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395837. ChuanqiXu added a comment. Format codes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

labath added a comment. Seems fairly straight-forward (and definitely useful). Just a couple of quick comments. Comment at: clang/utils/ClangDataFormat.py:28-35 +debugger.HandleCommand("type summary add -F ClangDataFormat.Optional_summary -x 'llvm::Optional<.*>'") +de

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev updated this revision to Diff 395841. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files: clang/in

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev marked 3 inline comments as done. sgatev added a comment. I also agree that the current approach isn't robust. I think that a proper solution would involve patching the CFG because in some cases it seems to be incorrect. For example, the call to `qux` is incorrectly deemed to be unreacha

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire created this revision. junaire added reviewers: fhahn, arsenm. junaire requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch adds an overload for emitUnaryBuiltin, which is addressed in D115429

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire added a comment. > Sounds good! Might be good to split the emitUnaryBuiltin changes off into a > separate change? Thanks for your suggestion! I just sent another patch: D116161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. Can you also update the existing places that could use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits mailing list c

[PATCH] D116022: [clang][dataflow] Add support for terminating noreturn destructors

sgatev updated this revision to Diff 395845. sgatev marked 3 inline comments as done. sgatev added a comment. Change commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files: clang/include/

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

ktkachov added a comment. I think the most important use of the __ARM_FEATURE_MOPS is to check whether it's safe to use the new intrinsics, so it should only be defined by the compiler once it supports the intrinsics proposed in https://github.com/ARM-software/acle/pull/38/files Repository:

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added reviewers: dmgreen, SjoerdMeijer. SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:937 case llvm::ARM::ArchKind::ARMV9_2A: getTargetDefinesARMV83A(Opts, Builder); break; Perhaps unrelated to this patc

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395852. junaire added a comment. Update the existing place that can use `emitUnaryBuiltin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/include/cla

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395853. junaire added a comment. Sorry, It seems that the base branch is wrong, reupdate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGe

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3206442 , @junaire wrote: > Update the existing place that can use `emitUnaryBuiltin`. I meant just update the existing uses *without* adding `floor`, `roundeven`, `trunc`, so this change should be NFC (non-functional c

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. In D116161#3206447 , @fhahn wrote: > In D116161#3206442 , @junaire wrote: > >> Update the existing place that can use `emitUnaryBuiltin`. > > I meant just update the existing uses *without

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg created this revision. reyg added a reviewer: cfe-commits. Herald added subscribers: carlosgalvezp, xazax.hun. reyg requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116163 Files: clang-tools-extra

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. Could you summarize what problem this is solving? There's multiple ways to "ignore diagnostics from specific checks", I think it would be confusing to add yet another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg added a comment. I actually couldn't find a way to black-list specific checks. Is there a way to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116163/new/ https://reviews.llvm.org/D116163

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 395856. momo5502 edited the summary of this revision. momo5502 added a comment. Herald added a subscriber: dexonsmith. A call to `isCompatibleWithMSVC` was added with the proper version that introduced the change (1925) and comments describing the intention

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall updated this revision to Diff 395858. sammccall added a comment. Also handle -Wno- flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116147/new/ https://reviews.llvm.org/D116147 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-t

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. In D116163#3206473 , @reyg wrote: > I actually couldn't find a way to black-list specific checks. Is there a way > to do that? Just prepend a dash to the check name that you want to disable: `checks=cppcoreguidelines-*,-c

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg abandoned this revision. reyg added a comment. Well now I feel stupid for not realizing that, thanks for pointing it out :) At least I learned how to hack around in clang-tidy 😄 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116163/new/ https:

[clang] 5eb2718 - [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

Author: Alok Kumar Sharma Date: 2021-12-22T20:04:21+05:30 New Revision: 5eb271880c8fc59835797806ac44f736eaf3ddbd URL: https://github.com/llvm/llvm-project/commit/5eb271880c8fc59835797806ac44f736eaf3ddbd DIFF: https://github.com/llvm/llvm-project/commit/5eb271880c8fc59835797806ac44f736eaf3ddbd.d

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb271880c8f: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of… (authored by alok). Changed prior to commit: https://reviews.llvm.org/D115510?vs=393447&id=395860#toc Repositor

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

chill added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:125 ARM::AEK_DOTPROD| ARM::AEK_BF16 | ARM::AEK_I8MM)) +ARM_ARCH("armv8.8-a", ARMV8_8A, "8.8-A", "v8.8a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8,

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok marked an inline comment as done. alok added a comment. Thanks @djtodoro . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115510/new/ https://reviews.llvm.org/D115510 ___ cfe-commits mailing list cfe

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666 + HasMOPS |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || + ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; So, this is enabled by default (as in "is mandatory part

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. bump, review requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. No worries, it's indeed good practice! Feel free to take a look at the docs, where this (and many more features) is described :) https://clang.llvm.org/extra/clang-tidy/ > will disable all default checks (-*) and enable all clang-analyzer-* checks > except for cl

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395863. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGen/C

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395864. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGen/C

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I have confirmed that this problem is not due to this patch. Besides, on Mac, both m1 and intel, the on-demand-parsing as well as loading an AST file generated via driver argument `-emit-ast` will also trigger this problem. However, when loading an AST file generated

[clang-tools-extra] fd8fc5e - [clang-tidy] abseil-string-find-startswith: detect `s.rfind(z, 0) == 0`

Author: Ivan Gerasimov Date: 2021-12-22T16:45:51+01:00 New Revision: fd8fc5e8d93849f4a2c8dea087690b1a0e6ea7df URL: https://github.com/llvm/llvm-project/commit/fd8fc5e8d93849f4a2c8dea087690b1a0e6ea7df DIFF: https://github.com/llvm/llvm-project/commit/fd8fc5e8d93849f4a2c8dea087690b1a0e6ea7df.diff

[clang] da007a3 - [JSONNodeDumper] Regenerate test checks (NFC)

Author: Nikita Popov Date: 2021-12-22T16:56:52+01:00 New Revision: da007a33c95a37c1331a14bc4f377982598fe68a URL: https://github.com/llvm/llvm-project/commit/da007a33c95a37c1331a14bc4f377982598fe68a DIFF: https://github.com/llvm/llvm-project/commit/da007a33c95a37c1331a14bc4f377982598fe68a.diff

[PATCH] D116167: [clangd] Adjust compile flags so they work when applied to other file(type)s.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It's reasonable to want to us

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery created this revision. GPery requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116170 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Abandon the change because of the trade off between the amount of changes and benefit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115573/new/ https://reviews.llvm.org/D1155

[clang] a364e8f - [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

Author: Shilei Tian Date: 2021-12-22T11:24:15-05:00 New Revision: a364e8f6adeb4b42296413b6112a8bdfbd2ea116 URL: https://github.com/llvm/llvm-project/commit/a364e8f6adeb4b42296413b6112a8bdfbd2ea116 DIFF: https://github.com/llvm/llvm-project/commit/a364e8f6adeb4b42296413b6112a8bdfbd2ea116.diff L

[PATCH] D116068: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa364e8f6adeb: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into… (authored by tianshilei1992). Repository: rG LLVM Git

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added a comment. You need some unit tests to show it working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-co

[clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

Author: Jeremy Morse Date: 2021-12-22T16:30:05Z New Revision: ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f URL: https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f DIFF: https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f.diff LOG:

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

Is there a way to turn this off now, if it's broken for some user/use case? I guess using an -mllvm flag, instead of an -Xclang flag? Generally I think for a significant change like this the process would be to add it under a flag, off by default, encourage people to test it by opting in via the f

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 __

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nathanchance updated this revision to Diff 395879. nathanchance added a comment. Herald added subscribers: luke957, s.egerton, simoncook. - Move test from x86-outline-atomics.c to unsupported-outline-atomics.c (Marco). - Add a test for riscv64 to ensure it works with multiple architectures (Marco

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

On Wed, Dec 22, 2021 at 4:34 PM David Blaikie via cfe-commits wrote: > Is there a way to turn this off now, if it's broken for some user/use case? I > guess using an -mllvm flag, instead of an -Xclang flag? Yup, that should be achieved by "-mllvm -experimental-debug-variable-locations=false", th

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the Response and configuration fil

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

On Wed, Dec 22, 2021 at 11:47 AM Jeremy Morse wrote: > On Wed, Dec 22, 2021 at 4:34 PM David Blaikie via cfe-commits > wrote: > > Is there a way to turn this off now, if it's broken for some user/use > case? I guess using an -mllvm flag, instead of an -Xclang flag? > > Yup, that should be achiev

[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196 + +class VirtualDestructorTest : public ::testing::Test { +protected: DYM "Noreturn" instead of "Virtual"? Repository: rG LLVM Github

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz created this revision. Herald added subscribers: dexonsmith, hiraditya. rmaz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This diff adds support for relative roots to VFS overlays. The directory root will be made a

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395893. rmaz added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clang/test/VFS/vfsoverl

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the sepavloff wrote: > Response an

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395896. rmaz added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clang/t

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_in

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet added a comment. some drive-by comments, i'll be AFK for a while though. so please don't block this on my approval if people disagree. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:197 + SourceLocation Loc = FileStartLoc.getLocWithOffset( +

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

MaskRay added a comment. Some test nits:) I don't know CodeView :( Comment at: clang/test/CodeGenCXX/debug-info-objname.cpp:1 +// RUN: cp %s %T/debug-info-objname.cpp +// RUN: cd %T The whole file appears to be CRLF where almost all other tests use LF in llvm-

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. @ronlieb do you have any more information? The patch says remove /opt/rocm but the discussion seems to be going another way. What's the actual req here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ htt

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb requested changes to this revision. ronlieb added a comment. This needs to be revisited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ https://reviews.llvm.org/D109885 ___ cfe-commits

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb added a comment. Our conclusion is that the /opt/rocm weak default needs to stay in place. Thus this patch should be abandoned in my opinion. MarkS and I are requesting the folks that requestedt his change within AMD, revisit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. Sounds good to me. > CMAKE_INSTALL_PREFIX should be removed. I think we have consensus on that ^, orthogonal to the /opt/rocm presence or absence. As long as there's some way to tell cmake to use a given HSA, and it seems there are several, deleting that string

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added a comment. In D43002#3205190 , @MaskRay wrote: > Some test nits:) I don't know CodeView :( Fixed, thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llv

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu updated this revision to Diff 395803. zixuan-wu edited the summary of this revision. zixuan-wu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

jrtc27 added a comment. Do not bring back V draft 0.7. It is gone, it will never be supported again by LLVM under that name. The standard extension namespace is reserved for ratified extensions and development snapshots only, not old drafts vendors decided to ship. For those, non-standard exten

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu updated this revision to Diff 395835. ChuanqiXu retitled this revision from "[Coroutines] Set presplit attribute in Clang" to "[Coroutines] Set presplit attribute in Clang and mlir". ChuanqiXu edited the summary of this revision. ChuanqiXu added a reviewer: mehdi_amini. ChuanqiXu added a

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu added a comment. @ezhulenev I finally made it! Thanks for your help! @mehdi_amini @ftynse hi, might you help to look if the change in mlir part is good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 ___

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

luismarques added a comment. I think this would benefit from increased test coverage, namely to show that the mattr command-line options are properly handled. Some possible ideas: - Tests with the correct extension versions (maybe add a test file that exercises the version for all extensions).

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse added a comment. Hmmm. I thought this was quiet after landing -- and it turns out the reason why is there's still a sneek-circuit in clang that's turning instruction referencing off by default. Woe is me; should have done more end-to-end testing :|. On the upside, in the last few weeks L

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395904. Jake-Egan added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/codegen-body/test.c clang/test/ClangSc

[PATCH] D116174: [clang] support relative roots to vfs overlays

keith added a comment. This LGTM but I'm interested to hear from folks with more knowledge about the VFS' desired behavior to comment on if this will have any unexpected side effects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Do we still need thi

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This will allow linking in the callbacks directly instead of using PLT. Repository: rG

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 395914. kstoimenov added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52834. Before this patch, cla

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. Thanks for taking a look. I will update the diff to address your comments. Have a good new years break. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:197 + SourceLocation Loc = FileStartLoc.getLocWithOffset( + s

[clang-tools-extra] 86618e3 - Resolve lint warning about converting unsigned to signed (NFC)

Author: Salman Javed Date: 2021-12-23T09:46:14+13:00 New Revision: 86618e37bded924d0a7a06ef0818bb9b2311532d URL: https://github.com/llvm/llvm-project/commit/86618e37bded924d0a7a06ef0818bb9b2311532d DIFF: https://github.com/llvm/llvm-project/commit/86618e37bded924d0a7a06ef0818bb9b2311532d.diff

[PATCH] D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inspection of the first character can just be handled by the loop as well, it does exactly the same

[clang-tools-extra] d840f3e - Resolve -Wdocumentation warning in ClangTidyDiagnosticConsumer (NFC)

Author: Salman Javed Date: 2021-12-23T10:25:05+13:00 New Revision: d840f3edf0297699e750413e629543c2a9271b90 URL: https://github.com/llvm/llvm-project/commit/d840f3edf0297699e750413e629543c2a9271b90 DIFF: https://github.com/llvm/llvm-project/commit/d840f3edf0297699e750413e629543c2a9271b90.diff

[PATCH] D116137: [clang-tidy] Remove dead plugin code

thakis added a comment. If this code is truly dead, this looks fine to me. But IIRC D97693 was about no longer linking clang-tidy into libclang, while clang-tidy/plugin/ClangTidyPlugin.cpp (if I read the comments therein right) is for using clang-tidy as a clan

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I really need to get my requires patch done... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116183/new/ https://reviews

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. And initialize the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo updated this revision to Diff 395926. chrisdangelo added a comment. "I think it makes sense to simply copy that file and replace function attributes with parameter attributes and see if it still passes." - @NoQ (Tue, Dec 21, 12:28 PM) Sounds good. This newest change adds malloc-ann

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395929. tianshilei1992 added a comment. just emit the error but not return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/Ope

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Single-variant enums were still getting placed on a single l

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is consistent with the behavior of Doxygen, and allows users to write strings with C escapes or

  1   2   >