[PATCH] D115968: [clang-format] Refactor common handling of attributes. NFC.

2021-12-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius created this revision. curdeius added a reviewer: MyDeveloperDay. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115968 Files: clang/lib/Format/Unwrapped

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

2021-12-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1641 case tok::equal: - // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType - // TT_FatArrow. They always start an expression or a child block if - // followed by a

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

2021-12-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. P.S. `bugprone-branch-clone` seems to have attempted to use `CloneDetector` in the past but now it's no more than a dead #include. I wonder what happened there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 ___

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

2021-12-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 __

[PATCH] D115103: Leak Sanitizer port to Windows

2021-12-17 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 395219. clemenswasser added a comment. Simplify Architecture checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt/cmake/config-ix.cmake

[PATCH] D115968: [clang-format] Refactor common handling of attributes. NFC.

2021-12-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115968/new/ https://reviews.llvm.org/D115968 ___

[clang] 9cf4b72 - [clang-format] Refactor common handling of attributes. NFC.

2021-12-17 Thread Marek Kurdej via cfe-commits
Author: Marek Kurdej Date: 2021-12-17T23:02:45+01:00 New Revision: 9cf4b7266bbf238e4a5bd85c8d0011aac2f9181b URL: https://github.com/llvm/llvm-project/commit/9cf4b7266bbf238e4a5bd85c8d0011aac2f9181b DIFF: https://github.com/llvm/llvm-project/commit/9cf4b7266bbf238e4a5bd85c8d0011aac2f9181b.diff

[PATCH] D115968: [clang-format] Refactor common handling of attributes. NFC.

2021-12-17 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cf4b7266bbf: [clang-format] Refactor common handling of attributes. NFC. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

2021-12-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52772. This patch fixes the f

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

2021-12-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115972/new/ https://reviews.llvm.org/D115972 ___

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

2021-12-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius planned changes to this revision. curdeius added a comment. Actually, I've just run it on a larger codebase and found that this patch misbehaves. Need to rework and add faulty test cases. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D115976: [clang] Fix a crash case when reporting an uninitialized field.

2021-12-17 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added a reviewer: rsmith. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - As the initializer list's getSyntacticForm() may return NULL, need to consider the current semantic initalizer list itself

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

2021-12-17 Thread Ellis Hoag via Phabricator via cfe-commits
ellis created this revision. Herald added a subscriber: ormris. ellis added reviewers: kyulee, MaskRay, alanphipps. ellis published this revision for review. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Profile merging is not supported when using deb

[clang] 713ee23 - [clang] Use llvm::reverse (NFC)

2021-12-17 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-12-17T16:51:42-08:00 New Revision: 713ee230f884651afd17ab7b910e85a992ce406b URL: https://github.com/llvm/llvm-project/commit/713ee230f884651afd17ab7b910e85a992ce406b DIFF: https://github.com/llvm/llvm-project/commit/713ee230f884651afd17ab7b910e85a992ce406b.diff L

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

2021-12-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. What's the plan for constrained intrinsics versions of these intrinsics? The IRBuilder calls for CreateFPToSI and CreateFPToUI are strict FP aware, but this new code isn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

LLVM buildmaster will be restarted tonight

2021-12-17 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted after 6 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115976: [clang] Fix a crash case when reporting an uninitialized field.

2021-12-17 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 395248. hliao added a comment. Revise the formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115976/new/ https://reviews.llvm.org/D115976 Files: clang/include/clang/AST/Expr.h clang/lib/Sema/SemaInit.

[clang] fee5771 - Use DenseMap::lookup (NFC)

2021-12-17 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-12-17T18:19:25-08:00 New Revision: fee57711fe4a5578adc65bf9ebfe664905ff5309 URL: https://github.com/llvm/llvm-project/commit/fee57711fe4a5578adc65bf9ebfe664905ff5309 DIFF: https://github.com/llvm/llvm-project/commit/fee57711fe4a5578adc65bf9ebfe664905ff5309.diff L

[clang] 212e6c9 - [doc] Fix regex in ClangFormatStyleOptions for IncludeCategories

2021-12-17 Thread Owen Pan via cfe-commits
Author: Joshua Huels Date: 2021-12-17T18:46:12-08:00 New Revision: 212e6c99776f393e0af368ca2086eb8bae2ee1ed URL: https://github.com/llvm/llvm-project/commit/212e6c99776f393e0af368ca2086eb8bae2ee1ed DIFF: https://github.com/llvm/llvm-project/commit/212e6c99776f393e0af368ca2086eb8bae2ee1ed.diff

[PATCH] D115910: [doc] Fix regex in ClangFormatStyleOptions for IncludeCategories

2021-12-17 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG212e6c99776f: [doc] Fix regex in ClangFormatStyleOptions for IncludeCategories (authored by jhuels, committed by owenpan). Herald added a subscriber:

[clang] 4e310d8 - [clang] Strip redundant lambda (NFC)

2021-12-17 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-12-17T20:55:10-08:00 New Revision: 4e310d89f22303873c952a9ca5ca91c921407336 URL: https://github.com/llvm/llvm-project/commit/4e310d89f22303873c952a9ca5ca91c921407336 DIFF: https://github.com/llvm/llvm-project/commit/4e310d89f22303873c952a9ca5ca91c921407336.diff L

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

2021-12-17 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11598

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

2021-12-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D115503#3199489 , @shchenz wrote: > In D115503#3199459 , @Esme wrote: > >> In D115503#3195171 , @dblaikie >> wrote: >> >>> Ah, cool - could y

<    1   2